200557 2019-08-08 18:13:28 -0700 REGRESSION (52279987): Most of the WKUIDelegate contextMenu delegate methods are not being called 2019-08-09 08:17:00 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino darin wenson_hsieh oldest_to_newest 1559763 0 dino 2019-08-08 18:13:28 -0700 REGRESSION (52279987): Most of the WKUIDelegate contextMenu delegate methods are not being called 1559764 1 dino 2019-08-08 18:13:54 -0700 <rdar://problem/54099201> 1559765 2 375876 dino 2019-08-08 18:17:00 -0700 Created attachment 375876 Patch 1559768 3 dino 2019-08-08 18:51:21 -0700 Actually <rdar://problem/53717962> now. 1559776 4 dino 2019-08-08 19:11:52 -0700 Committed r248456: <https://trac.webkit.org/changeset/248456> 1559884 5 darin 2019-08-09 08:07:28 -0700 Does this break compatible with the one-version-back iOS? Don’t we normally keep that working for test purposes? 1559887 6 wenson_hsieh 2019-08-09 08:08:54 -0700 (In reply to Darin Adler from comment #5) > Does this break compatible with the one-version-back iOS? Don’t we normally > keep that working for test purposes? UIContextMenuInteraction is new in iOS 13, so this should only break compatibility with older versions of iOS 13. 1559892 7 darin 2019-08-09 08:17:00 -0700 (In reply to Wenson Hsieh from comment #6) > (In reply to Darin Adler from comment #5) > > Does this break compatible with the one-version-back iOS? Don’t we normally > > keep that working for test purposes? > > UIContextMenuInteraction is new in iOS 13, so this should only break > compatibility with older versions of iOS 13. OK, great. 375876 2019-08-08 18:17:00 -0700 2019-08-08 18:58:23 -0700 Patch bug-200557-20190809111658.patch text/plain 3711 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBhNzg5MDg0ZDRiZjZiYzZl NmFkMDdkMWI3ODc2NjA5Mjk4MmYyY2MuLmQwMDVjMWQwZmRlZTZhNTA3NmUwZjkwZjc3Njk3ODA5 MDIyOWU4ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTktMDgtMDggIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKDUyMjc5OTg3KTog TW9zdCBvZiB0aGUgV0tVSURlbGVnYXRlIGNvbnRleHRNZW51IGRlbGVnYXRlIG1ldGhvZHMgYXJl IG5vdCBiZWluZyBjYWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMDU1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTQwOTkyMDE+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVUlLaXQgY2hhbmdl ZCB0aGUgbmFtZSBvZiBkZWxlZ2F0ZXMgcmVjZW50bHkuIFdlIGlnbm9yZWQgdGhlIHdhcm5pbmcg YmVjYXVzZQorICAgICAgICBpdCB3YXMgc3RpbGwgY2FsbGluZyB0aGUgb2xkIG1ldGhvZHMuIEhv d2V2ZXIsIGl0IHdpbGwgb25seSBkbyBzbyBmb3IgYXBwbGljYXRpb25zCisgICAgICAgIGF1dGhv cmVkIGJ5IEFwcGxlLCBicmVha2luZyAzcmQgcGFydGllcy4KKworICAgICAgICBUaGUgY2hhbmdl IGhlcmUgaXMganVzdCBhZG9wdGluZyB0aGUgbmV3IG1ldGhvZHMgaW4gcGxhY2Ugb2YgdGhlIG9s ZCBvbmVzLgorICAgICAgICBJdCBkb2VzIG5vdCBjaGFuZ2UgdGhlIEFQSSB0aGF0IFdlYktpdCB2 ZW5kcyAodGhleSBzdGlsbCB1c2UgdGhlIG9sZGVyIG5hbWVzKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRl bnRWaWV3IGNvbnRleHRNZW51SW50ZXJhY3Rpb246d2lsbERpc3BsYXlNZW51Rm9yQ29uZmlndXJh dGlvbjphbmltYXRvcjpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBjb250ZXh0TWVudUlu dGVyYWN0aW9uOndpbGxQZXJmb3JtUHJldmlld0FjdGlvbkZvck1lbnVXaXRoQ29uZmlndXJhdGlv bjphbmltYXRvcjpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBjb250ZXh0TWVudUludGVy YWN0aW9uOndpbGxFbmRGb3JDb25maWd1cmF0aW9uOmFuaW1hdG9yOl0pOgorICAgICAgICAoLVtX S0NvbnRlbnRWaWV3IGNvbnRleHRNZW51SW50ZXJhY3Rpb25XaWxsUHJlc2VudDpdKTogRGVsZXRl ZC4KKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBjb250ZXh0TWVudUludGVyYWN0aW9uOndpbGxD b21taXRXaXRoQW5pbWF0b3I6XSk6IERlbGV0ZWQuCisgICAgICAgICgtW1dLQ29udGVudFZpZXcg Y29udGV4dE1lbnVJbnRlcmFjdGlvbkRpZEVuZDpdKTogRGVsZXRlZC4KKwogMjAxOS0wOC0wOCAg UGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gVXNl IHRoZSBQSUQgb2YgdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyB3aGVuIGlzc3VpbmcgbG9jYWwgZmls ZSByZWFkIHNhbmRib3ggZXh0ZW5zaW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggMjEyOTliMTQyNDhl ZjVmZDQ2ZjVmYzNjYWU4MmIyMjQ4NTIzMzFhNS4uYWU5ZDM2NmFkZTEwODY5ZTVlZTkyNzhjNjgz Njg0N2RmNzFmNDI2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC04MTk1LDkgKzgxOTUsNyBAQCBzdGF0 aWMgUmV0YWluUHRyPFVJVGFyZ2V0ZWRQcmV2aWV3PiBjcmVhdGVGYWxsYmFja1RhcmdldGVkUHJl dmlldyhVSVZpZXcgKnJvb3RWaQogICAgIHJldHVybiBbc2VsZiBfY3JlYXRlVGFyZ2V0ZWRQcmV2 aWV3SWZQb3NzaWJsZV07CiB9CiAKLUFMTE9XX0RFUFJFQ0FURURfSU1QTEVNRU5UQVRJT05TX0JF R0lOCi0tICh2b2lkKWNvbnRleHRNZW51SW50ZXJhY3Rpb25XaWxsUHJlc2VudDooVUlDb250ZXh0 TWVudUludGVyYWN0aW9uICopaW50ZXJhY3Rpb24KLUFMTE9XX0RFUFJFQ0FURURfSU1QTEVNRU5U QVRJT05TX0VORAorLSAodm9pZCljb250ZXh0TWVudUludGVyYWN0aW9uOihVSUNvbnRleHRNZW51 SW50ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiB3aWxsRGlzcGxheU1lbnVGb3JDb25maWd1cmF0aW9u OihVSUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24gYW5pbWF0b3I6KGlk PFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbkFuaW1hdGluZz4pYW5pbWF0b3IKIHsKICAgICBpZiAo IV93ZWJWaWV3KQogICAgICAgICByZXR1cm47CkBAIC04MjE4LDkgKzgyMTYsNyBAQCBBTExPV19E RVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19FTkQKICAgICByZXR1cm4gc3RkOjpleGNoYW5nZShf Y29udGV4dE1lbnVJbnRlcmFjdGlvblRhcmdldGVkUHJldmlldywgbmlsKS5hdXRvcmVsZWFzZSgp OwogfQogCi1BTExPV19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19CRUdJTgotLSAodm9pZClj b250ZXh0TWVudUludGVyYWN0aW9uOihVSUNvbnRleHRNZW51SW50ZXJhY3Rpb24gKilpbnRlcmFj dGlvbiB3aWxsQ29tbWl0V2l0aEFuaW1hdG9yOihpZDxVSUNvbnRleHRNZW51SW50ZXJhY3Rpb25D b21taXRBbmltYXRpbmc+KWFuaW1hdG9yCi1BTExPV19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9O U19FTkQKKy0gKHZvaWQpY29udGV4dE1lbnVJbnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVy YWN0aW9uICopaW50ZXJhY3Rpb24gd2lsbFBlcmZvcm1QcmV2aWV3QWN0aW9uRm9yTWVudVdpdGhD b25maWd1cmF0aW9uOihVSUNvbnRleHRNZW51Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24g YW5pbWF0b3I6KGlkPFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbkNvbW1pdEFuaW1hdGluZz4pYW5p bWF0b3IKIHsKICAgICBpZiAoIV93ZWJWaWV3KQogICAgICAgICByZXR1cm47CkBAIC04MjczLDkg KzgyNjksNyBAQCBBTExPV19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19FTkQKICAgICB9CiB9 CiAKLUFMTE9XX0RFUFJFQ0FURURfSU1QTEVNRU5UQVRJT05TX0JFR0lOCi0tICh2b2lkKWNvbnRl eHRNZW51SW50ZXJhY3Rpb25EaWRFbmQ6KFVJQ29udGV4dE1lbnVJbnRlcmFjdGlvbiAqKWludGVy YWN0aW9uCi1BTExPV19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19FTkQKKy0gKHZvaWQpY29u dGV4dE1lbnVJbnRlcmFjdGlvbjooVUlDb250ZXh0TWVudUludGVyYWN0aW9uICopaW50ZXJhY3Rp b24gd2lsbEVuZEZvckNvbmZpZ3VyYXRpb246KFVJQ29udGV4dE1lbnVDb25maWd1cmF0aW9uICop Y29uZmlndXJhdGlvbiBhbmltYXRvcjoobnVsbGFibGUgaWQ8VUlDb250ZXh0TWVudUludGVyYWN0 aW9uQW5pbWF0aW5nPilhbmltYXRvcgogewogICAgIGlmICghX3dlYlZpZXcpCiAgICAgICAgIHJl dHVybjsK