200547 2019-08-08 15:10:19 -0700 Fix thread safety issue in AudioSampleDataSource() constructor 2019-08-08 15:58:20 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 200507 1 cdumez cdumez achristensen benjamin cmarcelo commit-queue dbates eric.carlson ews-watchlist ggaren jer.noble rniwa webkit-bug-importer youennf oldest_to_newest 1559675 0 cdumez 2019-08-08 15:10:19 -0700 Fix thread safety issue in AudioSampleDataSource() constructor: Thread 9 Crashed:: WebKitWebRTCAudioModule 0 com.apple.WebCore 0x000000010850ef83 WTFCrashWithInfo(int, char const*, char const*, int) + 19 1 com.apple.WebCore 0x0000000108758b21 WebCore::AudioSampleDataSource::AudioSampleDataSource(unsigned long, WebCore::MediaStreamTrackPrivate&) + 289 2 com.apple.WebCore 0x00000001087589cf WebCore::AudioSampleDataSource::create(unsigned long, WebCore::MediaStreamTrackPrivate&) + 47 3 com.apple.WebCore 0x0000000108931557 WebCore::WebAudioSourceProviderAVFObjC::prepare(AudioStreamBasicDescription const&) + 855 4 com.apple.WebCore 0x0000000108931a1c WebCore::WebAudioSourceProviderAVFObjC::audioSamplesAvailable(WebCore::MediaStreamTrackPrivate&, WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long) + 92 5 com.apple.WebCore 0x0000000109a85cec WebCore::MediaStreamTrackPrivate::forEachObserver(WTF::Function<void (WebCore::MediaStreamTrackPrivate::Observer&)> const&) const + 732 6 com.apple.WebCore 0x0000000109a86926 WebCore::MediaStreamTrackPrivate::audioSamplesAvailable(WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long) + 102 7 com.apple.WebCore 0x0000000109a887cc WebCore::RealtimeMediaSource::forEachObserver(WTF::Function<void (WebCore::RealtimeMediaSource::Observer&)> const&) const + 748 8 com.apple.WebCore 0x0000000109a88b5c WebCore::RealtimeMediaSource::audioSamplesAvailable(WTF::MediaTime const&, WebCore::PlatformAudioData const&, WebCore::AudioStreamDescription const&, unsigned long) + 92 9 com.apple.WebCore 0x0000000109aa775e WebCore::RealtimeIncomingAudioSourceCocoa::OnData(void const*, int, int, unsigned long, unsigned long) + 558 10 libwebrtc.dylib 0x000000010650287d webrtc::RemoteAudioSource::AudioDataProxy::OnData(webrtc::AudioSinkInterface::Data const&) + 77 11 libwebrtc.dylib 0x0000000106395726 webrtc::voe::(anonymous namespace)::ChannelReceive::GetAudioFrameWithInfo(int, webrtc::AudioFrame*) + 246 12 libwebrtc.dylib 0x0000000106358574 webrtc::AudioMixerImpl::GetAudioFromSources() + 164 13 libwebrtc.dylib 0x00000001063582a7 webrtc::AudioMixerImpl::Mix(unsigned long, webrtc::AudioFrame*) + 71 14 libwebrtc.dylib 0x000000010636a79a webrtc::AudioTransportImpl::PullRenderData(int, int, unsigned long, unsigned long, void*, long long*, long long*) + 58 15 com.apple.WebCore 0x00000001085d1e4d WebCore::LibWebRTCAudioModule::PollFromSource() + 189 16 com.apple.WebCore 0x00000001085d1cb8 non-virtual thunk to WebCore::LibWebRTCAudioModule::OnMessage(rtc::Message*) + 40 17 libwebrtc.dylib 0x0000000106442154 rtc::MessageQueue::Dispatch(rtc::Message*) + 212 18 libwebrtc.dylib 0x00000001065bcfdc rtc::Thread::ProcessMessages(int) + 284 19 libwebrtc.dylib 0x00000001065bce2d rtc::Thread::PreRun(void*) + 173 20 libsystem_pthread.dylib 0x00000001045682eb _pthread_body + 126 21 libsystem_pthread.dylib 0x000000010456b249 _pthread_start + 66 22 libsystem_pthread.dylib 0x000000010456740d thread_start + 13 I think the Logger is getting ref'd / deref'd from several thread and is not ThreadSafeRefCounted. I am in the process of confirming. 1559681 1 375845 cdumez 2019-08-08 15:18:08 -0700 Created attachment 375845 Patch 1559691 2 375845 cdumez 2019-08-08 15:57:14 -0700 Comment on attachment 375845 Patch Clearing flags on attachment: 375845 Committed r248446: <https://trac.webkit.org/changeset/248446> 1559692 3 cdumez 2019-08-08 15:57:16 -0700 All reviewed patches have been landed. Closing bug. 1559694 4 webkit-bug-importer 2019-08-08 15:58:20 -0700 <rdar://problem/54100643> 375845 2019-08-08 15:18:08 -0700 2019-08-08 15:57:14 -0700 Patch bug-200547-20190808151808.patch text/plain 1369 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4NDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGUwODMyZWZkMzJiNjBkMGU5NWMzZThl MmU3YWY0OTE3YzA5YTU1MDcuLmQ5NTI4YmZjNzg1YjEzNmY1MmU5NzQ1NGZjNzg1ZmI0NjExODE3 MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDgtMDggIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggdGhyZWFkIHNhZmV0eSBpc3N1ZSBpbiBBdWRpb1Nh bXBsZURhdGFTb3VyY2UoKSBjb25zdHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFrZSBMb2dnZXIgVGhyZWFkU2FmZVJlZkNvdW50ZWQgYXMg aXQgaXMgcmVmJ2QgLyBkZXJlZidkIGZyb20gdmFyaW91cworICAgICAgICB0aHJlYWRzIChpbmNs dWRpbmcgdGhlIG1haW4gdGhyZWFkIGFuZCB0aGUgV2ViS2l0V2ViUlRDQXVkaW9Nb2R1bGUgdGhy ZWFkKS4KKworICAgICAgICAqIHd0Zi9Mb2dnZXIuaDoKKwogMjAxOS0wOC0wOCAgTWljaGFlbCBT YWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBPcGVuU291cmNlIE1lbW9yeUZv b3RwcmludCBBUEkgZm9yIEpTQyBjb21tYW5kIGxpbmUgdG9vbApkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvTG9nZ2VyLmggYi9Tb3VyY2UvV1RGL3d0Zi9Mb2dnZXIuaAppbmRleCBiODFiMGY5 OGNmN2QyYjBiMzViYmQ2OTFjOWNiODJkYThkNWJhYzRmLi45ODRjOGZlMjY5OTgwMWIwNDg4ODJh MDQ0NmUzOTQwY2ZkMjAxZmZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Mb2dnZXIuaAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9Mb2dnZXIuaApAQCAtMjYsNiArMjYsNyBAQAogI3ByYWdtYSBv bmNlCiAKICNpbmNsdWRlIDx3dGYvTG9jay5oPgorI2luY2x1ZGUgPHd0Zi9UaHJlYWRTYWZlUmVm Q291bnRlZC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KIAogbmFtZXNw YWNlIFdURiB7CkBAIC0xMDYsNyArMTA3LDcgQEAgc3RydWN0IENvbnNvbGVMb2dWYWx1ZTxBcmd1 bWVudCwgZmFsc2U+IHsKICAgICB9CiB9OwogCi1jbGFzcyBMb2dnZXIgOiBwdWJsaWMgUmVmQ291 bnRlZDxMb2dnZXI+IHsKK2NsYXNzIExvZ2dlciA6IHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRl ZDxMb2dnZXI+IHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShMb2dnZXIpOwogcHVibGljOgog Cg==