200521 2019-08-07 16:22:48 -0700 Turn some ITP threading ASSERTs into RELEASE_ASSERTs 2019-08-07 20:32:21 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez bfulgham commit-queue ggaren rniwa webkit-bug-importer wilander oldest_to_newest 1559365 0 cdumez 2019-08-07 16:22:48 -0700 Turn some ITP threading ASSERTs into RELEASE_ASSERTs to help catch more bugs. 1559366 1 375764 cdumez 2019-08-07 16:23:31 -0700 Created attachment 375764 Patch 1559431 2 375764 commit-queue 2019-08-07 20:31:46 -0700 Comment on attachment 375764 Patch Clearing flags on attachment: 375764 Committed r248401: <https://trac.webkit.org/changeset/248401> 1559432 3 commit-queue 2019-08-07 20:31:48 -0700 All reviewed patches have been landed. Closing bug. 1559433 4 webkit-bug-importer 2019-08-07 20:32:21 -0700 <rdar://problem/54063791> 375764 2019-08-07 16:23:31 -0700 2019-08-07 20:31:46 -0700 Patch bug-200521-20190807162330.patch text/plain 5909 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDljMDdjOWM2NGNhNDRjMTU1 ODYwZjNlZTNkM2RlYWI3MGIwOWNkMDYuLjA5NGU2YzQxNzRjOWVhODc4NjU0N2EzNTVmYjMzNTRj NWU1MGVlYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTktMDgtMDcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBUdXJuIHNvbWUgSVRQIHRocmVhZGlu ZyBBU1NFUlRzIGludG8gUkVMRUFTRV9BU1NFUlRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA1MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUdXJuIHNvbWUgSVRQIHRocmVhZGluZyBBU1NFUlRzIGlu dG8gUkVMRUFTRV9BU1NFUlRzIHRvIGhlbHAgY2F0Y2ggbW9yZSBidWdzLgorCisgICAgICAgICog TmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWVtb3J5U3Rv cmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWVtb3J5U3Rv cmU6OlJlc291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9yZSk6CisgICAgICAgIChXZWJLaXQ6 OlJlc291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9yZTo6aXNFbXB0eSBjb25zdCk6CisgICAg ICAgICogTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzUGVy c2lzdGVudFN0b3JhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzUGVyc2lzdGVudFN0b3JhZ2U6OlJlc291cmNlTG9hZFN0YXRpc3RpY3NQZXJzaXN0ZW50U3Rv cmFnZSk6CisgICAgICAgIChXZWJLaXQ6OlJlc291cmNlTG9hZFN0YXRpc3RpY3NQZXJzaXN0ZW50 U3RvcmFnZTo6flJlc291cmNlTG9hZFN0YXRpc3RpY3NQZXJzaXN0ZW50U3RvcmFnZSk6CisgICAg ICAgICogTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNz U3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3Rv cmU6OldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZSk6CisgICAgICAgIChXZWJLaXQ6Oldl YlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6fldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NT dG9yZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6 Zmx1c2hBbmREZXN0cm95UGVyc2lzdGVudFN0b3JlKToKKwogMjAxOS0wOC0wNyAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjI0Nzc4NCkgUmVz b3VyY2VMb2FkU3RhdGlzdGljc01lbW9yeVN0b3JlIC8gUmVzb3VyY2VMb2FkU3RhdGlzdGljc1Bl cnNpc3RlbnRTdG9yYWdlIG1heSBnZXQgZGVzdHJveWVkIG9uIHRoZSB3cm9uZyB0aHJlYWQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJj ZUxvYWRTdGF0aXN0aWNzTWVtb3J5U3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9yZS5jcHAKaW5k ZXggOTAzZDc1ODAwMGEyMGJmYTY5YWNjNzg3MTkzNTc4OWM4Nzc2OWJkZi4uMDc3MGU4ZGViM2Rh ZGMzM2Q1NGZkZWQ2Mjc5Y2FhMTE3NTBiZWMyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9y ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291 cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9yZS5jcHAKQEAgLTcyLDcgKzcyLDcgQEAgc3RhdGlj IHZvaWQgcHJ1bmVSZXNvdXJjZXMoSGFzaE1hcDxSZWdpc3RyYWJsZURvbWFpbiwgUmVzb3VyY2VM b2FkU3RhdGlzdGljcz4mIHMKIFJlc291cmNlTG9hZFN0YXRpc3RpY3NNZW1vcnlTdG9yZTo6UmVz b3VyY2VMb2FkU3RhdGlzdGljc01lbW9yeVN0b3JlKFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NT dG9yZSYgc3RvcmUsIFdvcmtRdWV1ZSYgd29ya1F1ZXVlLCBTaG91bGRJbmNsdWRlTG9jYWxob3N0 IHNob3VsZEluY2x1ZGVMb2NhbGhvc3QpCiAgICAgOiBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3Rv cmUoc3RvcmUsIHdvcmtRdWV1ZSwgc2hvdWxkSW5jbHVkZUxvY2FsaG9zdCkKIHsKLSAgICBBU1NF UlQoIVJ1bkxvb3A6OmlzTWFpbigpKTsKKyAgICBSRUxFQVNFX0FTU0VSVCghUnVuTG9vcDo6aXNN YWluKCkpOwogCiAgICAgd29ya1F1ZXVlLmRpc3BhdGNoQWZ0ZXIoNV9zLCBbd2Vha1RoaXMgPSBt YWtlV2Vha1B0cigqdGhpcyldIHsKICAgICAgICAgaWYgKHdlYWtUaGlzKQpAQCAtODIsNyArODIs NyBAQCBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzTWVtb3J5U3RvcmU6OlJlc291cmNlTG9hZFN0YXRp c3RpY3NNZW1vcnlTdG9yZShXZWJSZXNvdXJjZQogCiBib29sIFJlc291cmNlTG9hZFN0YXRpc3Rp Y3NNZW1vcnlTdG9yZTo6aXNFbXB0eSgpIGNvbnN0CiB7Ci0gICAgQVNTRVJUKCFSdW5Mb29wOjpp c01haW4oKSk7CisgICAgUkVMRUFTRV9BU1NFUlQoIVJ1bkxvb3A6OmlzTWFpbigpKTsKIAogICAg IHJldHVybiBtX3Jlc291cmNlU3RhdGlzdGljc01hcC5pc0VtcHR5KCk7CiB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2FkU3Rh dGlzdGljc1BlcnNpc3RlbnRTdG9yYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzUGVyc2lzdGVudFN0b3JhZ2UuY3Bw CmluZGV4IDEwNWRkMDI4ODYwNzUwNzA5NzdjYWU4N2QyYzRhNGY0MGJiZmVmYjcuLjJlMjk2YjI5 ZjQzYTRmYzg4ZTcwMDkzMjRhNWUyM2IwYmU5Y2Q1MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzUGVyc2lz dGVudFN0b3JhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3Np Zmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzUGVyc2lzdGVudFN0b3JhZ2UuY3BwCkBAIC02MCw3 ICs2MCw3IEBAIFJlc291cmNlTG9hZFN0YXRpc3RpY3NQZXJzaXN0ZW50U3RvcmFnZTo6UmVzb3Vy Y2VMb2FkU3RhdGlzdGljc1BlcnNpc3RlbnRTdG9yYWdlCiAgICAgLCBtX3dvcmtRdWV1ZSh3b3Jr UXVldWUpCiAgICAgLCBtX3N0b3JhZ2VEaXJlY3RvcnlQYXRoKHN0b3JhZ2VEaXJlY3RvcnlQYXRo KQogewotICAgIEFTU0VSVCghUnVuTG9vcDo6aXNNYWluKCkpOworICAgIFJFTEVBU0VfQVNTRVJU KCFSdW5Mb29wOjppc01haW4oKSk7CiAKICAgICBtX21lbW9yeVN0b3JlLnNldFBlcnNpc3RlbnRT dG9yYWdlKCp0aGlzKTsKIApAQCAtNzAsNyArNzAsNyBAQCBSZXNvdXJjZUxvYWRTdGF0aXN0aWNz UGVyc2lzdGVudFN0b3JhZ2U6OlJlc291cmNlTG9hZFN0YXRpc3RpY3NQZXJzaXN0ZW50U3RvcmFn ZQogCiBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzUGVyc2lzdGVudFN0b3JhZ2U6On5SZXNvdXJjZUxv YWRTdGF0aXN0aWNzUGVyc2lzdGVudFN0b3JhZ2UoKQogewotICAgIEFTU0VSVCghUnVuTG9vcDo6 aXNNYWluKCkpOworICAgIFJFTEVBU0VfQVNTRVJUKCFSdW5Mb29wOjppc01haW4oKSk7CiAKICAg ICBpZiAobV9oYXNQZW5kaW5nV3JpdGUpCiAgICAgICAgIHdyaXRlTWVtb3J5U3RvcmVUb0Rpc2so KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9X ZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9DbGFzc2lmaWVyL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKaW5k ZXggMmE4ZGI5N2EzYmE3MTVkZjM2NmNiODdlZWVmYWQ2YmY5MjE2M2YyNi4uZGE4ODY2YjYxYzhi MDU3MmNkZDUwOGViNjlhOWQ4YTk4OWU3NWQyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1dlYlJlc291 cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAKQEAgLTE1NSw3ICsxNTUsNyBAQCBXZWJSZXNvdXJj ZUxvYWRTdGF0aXN0aWNzU3RvcmU6OldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZShOZXR3 b3JrU2Vzc2lvbiYgbgogICAgICwgbV9zdGF0aXN0aWNzUXVldWUoV29ya1F1ZXVlOjpjcmVhdGUo IldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZSBQcm9jZXNzIERhdGEgUXVldWUiLCBXb3Jr UXVldWU6OlR5cGU6OlNlcmlhbCwgV29ya1F1ZXVlOjpRT1M6OlV0aWxpdHkpKQogICAgICwgbV9k YWlseVRhc2tzVGltZXIoUnVuTG9vcDo6bWFpbigpLCB0aGlzLCAmV2ViUmVzb3VyY2VMb2FkU3Rh dGlzdGljc1N0b3JlOjpwZXJmb3JtRGFpbHlUYXNrcykKIHsKLSAgICBBU1NFUlQoUnVuTG9vcDo6 aXNNYWluKCkpOworICAgIFJFTEVBU0VfQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKICAgICAK ICAgICBwb3N0VGFzayhbdGhpcywgcmVzb3VyY2VMb2FkU3RhdGlzdGljc0RpcmVjdG9yeSA9IHJl c291cmNlTG9hZFN0YXRpc3RpY3NEaXJlY3RvcnkuaXNvbGF0ZWRDb3B5KCksIHNob3VsZEluY2x1 ZGVMb2NhbGhvc3RdIHsKICAgICAgICAgaWYgKFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJl ZEZlYXR1cmVzKCkuaXNJVFBEYXRhYmFzZUVuYWJsZWQoKSkgewpAQCAtMTc5LDkgKzE3OSw5IEBA IFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6V2ViUmVzb3VyY2VMb2FkU3RhdGlzdGlj c1N0b3JlKE5ldHdvcmtTZXNzaW9uJiBuCiAKIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9y ZTo6fldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZSgpCiB7Ci0gICAgQVNTRVJUKFJ1bkxv b3A6OmlzTWFpbigpKTsKLSAgICBBU1NFUlQoIW1fc3RhdGlzdGljc1N0b3JlKTsKLSAgICBBU1NF UlQoIW1fcGVyc2lzdGVudFN0b3JhZ2UpOworICAgIFJFTEVBU0VfQVNTRVJUKFJ1bkxvb3A6Omlz TWFpbigpKTsKKyAgICBSRUxFQVNFX0FTU0VSVCghbV9zdGF0aXN0aWNzU3RvcmUpOworICAgIFJF TEVBU0VfQVNTRVJUKCFtX3BlcnNpc3RlbnRTdG9yYWdlKTsKIH0KIAogdm9pZCBXZWJSZXNvdXJj ZUxvYWRTdGF0aXN0aWNzU3RvcmU6OmRpZERlc3Ryb3lOZXR3b3JrU2Vzc2lvbigpCkBAIC0yMDgs NyArMjA4LDcgQEAgaW5saW5lIHZvaWQgV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpw b3N0VGFza1JlcGx5KFdURjo6RnVuY3Rpb248dm9pZCgpPiYKIAogdm9pZCBXZWJSZXNvdXJjZUxv YWRTdGF0aXN0aWNzU3RvcmU6OmZsdXNoQW5kRGVzdHJveVBlcnNpc3RlbnRTdG9yZSgpCiB7Ci0g ICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKKyAgICBSRUxFQVNFX0FTU0VSVChSdW5Mb29w Ojppc01haW4oKSk7CiAKICAgICAvLyBNYWtlIHN1cmUgd2UgZGVzdHJveSB0aGUgcGVyc2lzdGVu dCBzdG9yZSBvbiB0aGUgYmFja2dyb3VuZCBxdWV1ZSBhbmQgd2FpdCBmb3IgaXQgdG8gZGllCiAg ICAgLy8gc3luY2hyb25vdXNseSBzaW5jZSBpdCBoYXMgYSBDKysgcmVmZXJlbmNlIHRvIHVzLiBC bG9ja2luZyBuYXR1cmUgb2YgdGhpcyB0YXNrIGFsbG93cyB1cwo=