20052 2008-07-16 05:25:11 -0700 Export tag & attribute names as string literals within SVGNames 2008-07-16 17:43:44 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 20051 1 zimmermann zimmermann eric koivisto oliver oldest_to_newest 86047 0 zimmermann 2008-07-16 05:25:11 -0700 The summary says it. I need this functionality for the new SVGAnimatedProperty concept. See master bug 20051 for details. 86048 1 22305 zimmermann 2008-07-16 05:25:40 -0700 Created attachment 22305 Initial patch 86123 2 22305 sam 2008-07-16 16:16:06 -0700 Comment on attachment 22305 Initial patch r=me with the one change we discussed in irc. + Allow to export the tag & attribute names as string literals. SVGAnimatedProperty contains two string literal should read as: Export the tag & attribute names string literals. 86129 3 zimmermann 2008-07-16 17:43:44 -0700 Landed in r35205. "extern" declaration in the .cpp file removed, as discussed. 22305 2008-07-16 05:25:40 -0700 2008-07-16 16:16:06 -0700 Initial patch ExposeString.diff text/plain 6796 zimmermann SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM1MTk4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMDct MTYgIE5pa29sYXMgWmltbWVybWFubiAgPHppbW1lcm1hbm5Aa2RlLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcmVwYXJlIFNWR0FuaW1hdGVk UHJvcGVydHkgaW50cm9kdWN0aW9uLgorICAgICAgICBBbGxvdyB0byBleHBvcnQgdGhlIHRhZyAm IGF0dHJpYnV0ZSBuYW1lcyBhcyBzdHJpbmcgbGl0ZXJhbHMuIFNWR0FuaW1hdGVkUHJvcGVydHkg Y29udGFpbnMgdHdvIHN0cmluZyBsaXRlcmFsCisgICAgICAgIHRlbXBsYXRlIHBhcmFtZXRlcnMs IGFuZCB3ZSdyZSB1c2luZyB0aGVzZSBleHBvcnRlZCBzdHJpbmcgbGl0ZXJhbHMgZnJvbSBTVkdO YW1lcyBhcyBpbnB1dCBwYXJhbXRlcnMuCisgICAgICAgIFNlZSBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNTEgZm9yIGRldGFpbHMuCisKKyAgICAgICAgKiBkb20v bWFrZV9uYW1lcy5wbDogSGFuZGxlIG5ldyBwYXJhbXMgImV4cG9ydFN0cmluZyIgLyAiZXhwb3J0 U3RyaW5ncyIuCisgICAgICAgICogaHRtbC9IVE1MQXR0cmlidXRlTmFtZXMuaW46IEV4cG9zZSBq dXN0IHRoZSBzaW5nbGUgImNsYXNzIiBhdHRyaWJ1dGUsIGFzIHN0cmluZy4KKyAgICAgICAgKiBz dmcvc3ZnYXR0cnMuaW46IEV4cG9ydCBhbGwgU1ZHIGF0dHJpYnV0ZXMgYXMgc3RyaW5ncy4KKyAg ICAgICAgKiBzdmcvc3ZndGFncy5pbjogRXhwb3J0IGFsbCBTVkcgdGFncyBhcyBzdHJpbmdzLgor ICAgICAgICAqIHN2Zy94bGlua2F0dHJzLmluOiBFeHBvc2UgYWxsIFhMaW5rIGF0dHJpYnV0ZXMg YXMgc3RyaW5ncy4KKwogMjAwOC0wNy0xNSAgTWF4aW1lIEJyaXR0byAgPGJyaXR0b0BhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYy4KSW5kZXg6IGRvbS9tYWtlX25hbWVzLnBs Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIGRvbS9tYWtlX25hbWVzLnBsCShyZXZpc2lvbiAzNTE5OCkKKysrIGRv bS9tYWtlX25hbWVzLnBsCSh3b3JraW5nIGNvcHkpCkBAIC04NiwxMiArODYsMTQgQEAgaWYgKCRw YXJhbWV0ZXJzeydnZW5lcmF0ZVdyYXBwZXJGYWN0b3J5Jwogc3ViIGluaXRpYWxpemVUYWdQcm9w ZXJ0eUhhc2gKIHsKICAgICByZXR1cm4gKCd1cHBlckNhc2UnID0+IHVwcGVyQ2FzZU5hbWUoJF9b MF0pLAotICAgICAgICAgICAgJ2FwcGx5QXVkaW9IYWNrJyA9PiAwKTsKKyAgICAgICAgICAgICdh cHBseUF1ZGlvSGFjaycgPT4gMCwKKyAgICAgICAgICAgICdleHBvcnRTdHJpbmcnID0+IDApOwog fQogCiBzdWIgaW5pdGlhbGl6ZUF0dHJQcm9wZXJ0eUhhc2gKIHsKLSAgICByZXR1cm4gKCd1cHBl ckNhc2UnID0+IHVwcGVyQ2FzZU5hbWUoJF9bMF0pKTsKKyAgICByZXR1cm4gKCd1cHBlckNhc2Un ID0+IHVwcGVyQ2FzZU5hbWUoJF9bMF0pLAorICAgICAgICAgICAgJ2V4cG9ydFN0cmluZycgPT4g MCk7CiB9CiAKIHN1YiBpbml0aWFsaXplUGFyYW1ldGVyc0hhc2gKQEAgLTEwNSw3ICsxMDcsOCBA QCBzdWIgaW5pdGlhbGl6ZVBhcmFtZXRlcnNIYXNoCiAgICAgICAgICAgICAnZ2VuZXJhdGVXcmFw cGVyRmFjdG9yeScgPT4gMCwKICAgICAgICAgICAgICMgVGhlIDIgbnVsbE5hbWVzcGFjZSBwcm9w ZXJ0aWVzIGFyZSBnZW5lcmF0ZWQgZnJvbSB0aGUgIm51bGxOYW1lc3BhY2UiIGF0dHJpYnV0ZSB3 aXRoIHJlc3BlY3QgdG8gdGhlIGZpbGUgcGFyc2VkIChhdHRycyBvciB0YWdzKS4KICAgICAgICAg ICAgICd0YWdzTnVsbE5hbWVzcGFjZScgPT4gMCwKLSAgICAgICAgICAgICdhdHRyc051bGxOYW1l c3BhY2UnID0+IDApOworICAgICAgICAgICAgJ2F0dHJzTnVsbE5hbWVzcGFjZScgPT4gMCwKKyAg ICAgICAgICAgICdleHBvcnRTdHJpbmdzJyA9PiAwKTsKIH0KIAogIyMjIFBhcnNpbmcgaGFuZGxl cnMKQEAgLTIyNCw4ICsyMjcsMTQgQEAgc3ViIHJlYWROYW1lcwogc3ViIHByaW50TWFjcm9zCiB7 CiAgICAgbXkgKCRGLCAkbWFjcm8sICRzdWZmaXgsICRuYW1lc1JlZikgPSBAXzsKKyAgICBteSAl bmFtZXMgPSAlJG5hbWVzUmVmOworCiAgICAgZm9yIG15ICRuYW1lIChzb3J0IGtleXMgJSRuYW1l c1JlZikgewotICAgICAgICBwcmludCBGICIgICAgJG1hY3JvICRuYW1lIiwiJHN1ZmZpeDtcbiI7 CisgICAgICAgIHByaW50IEYgIiRtYWNybyAkbmFtZSIsIiRzdWZmaXg7XG4iOworCisgICAgICAg IGlmICgkcGFyYW1ldGVyc3snZXhwb3J0U3RyaW5ncyd9IG9yICRuYW1lc3skbmFtZX17ImV4cG9y dFN0cmluZyJ9KSB7IAorICAgICAgICAgICAgcHJpbnQgRiAiZXh0ZXJuIGNvbnN0IGNoYXIgJG5h bWUiLCAiJHtzdWZmaXh9U3RyaW5nW107XG4iOworICAgICAgICB9CiAgICAgfQogfQogCkBAIC0z OTQsNyArNDAzLDYgQEAgREVGSU5FX0dMT0JBTChBdG9taWNTdHJpbmcsICR7bG93ZXJOYW1lcwog ICAgICAgICBwcmludCBGICIgICAgKnNpemUgPSAiLCBzY2FsYXIoa2V5cyAldGFncyksICI7XG4i OwogICAgICAgICBwcmludCBGICIgICAgcmV0dXJuICRwYXJhbWV0ZXJzeyduYW1lc3BhY2UnfVRh Z3M7XG4iOwogICAgICAgICBwcmludCBGICJ9XG4iOwotICAgICAgICAKICAgICB9CiAKICAgICBp ZiAoa2V5cyAlYXR0cnMpIHsKQEAgLTQxMyw2ICs0MjEsMTQgQEAgREVGSU5FX0dMT0JBTChBdG9t aWNTdHJpbmcsICR7bG93ZXJOYW1lcwogICAgICAgICBwcmludCBGICJ9XG4iOwogICAgIH0KIAor ICAgIGlmIChrZXlzICV0YWdzKSB7CisgICAgICAgIHByaW50RGVmaW5pdGlvblN0cmluZ3MoJEYs IFwldGFncywgInRhZ3MiKTsKKyAgICB9CisKKyAgICBpZiAoa2V5cyAlYXR0cnMpIHsKKyAgICAg ICAgcHJpbnREZWZpbml0aW9uU3RyaW5ncygkRiwgXCVhdHRycywgImF0dHJpYnV0ZXMiKTsKKyAg ICB9CisKIHByaW50IEYgIlxudm9pZCBpbml0KCkKIHsKICAgICBzdGF0aWMgYm9vbCBpbml0aWFs aXplZCA9IGZhbHNlOwpAQCAtNDY2LDYgKzQ4MiwyNSBAQCBzdWIgcHJpbnRFbGVtZW50SW5jbHVk ZXMKICAgICB9CiB9CiAKK3N1YiBwcmludERlZmluaXRpb25TdHJpbmdzCit7CisgICAgbXkgKCRG LCAkbmFtZXNSZWYsICR0eXBlKSA9IEBfOworICAgIG15ICRzaW5ndWxhclR5cGUgPSBzdWJzdHIo JHR5cGUsIDAsIC0xKTsKKyAgICBteSAkc2hvcnRUeXBlID0gc3Vic3RyKCRzaW5ndWxhclR5cGUs IDAsIDQpOworICAgIG15ICRzaG9ydENhbWVsVHlwZSA9IHVjZmlyc3QoJHNob3J0VHlwZSk7Cisg ICAgcHJpbnQgRiAiXG4vLyAiIC4gdWNmaXJzdCgkdHlwZSkgLiAiIGFzIHN0cmluZ3NcbiI7CisK KyAgICBteSAlbmFtZXMgPSAlJG5hbWVzUmVmOworICAgIGZvciBteSAkbmFtZSAoc29ydCBrZXlz ICUkbmFtZXNSZWYpIHsKKyAgICAgICAgbmV4dCBpZiAoISRwYXJhbWV0ZXJzeydleHBvcnRTdHJp bmdzJ30gYW5kICEkbmFtZXN7JG5hbWV9eyJleHBvcnRTdHJpbmcifSk7CisKKyAgICAgICAgbXkg JHJlYWxOYW1lID0gJG5hbWU7CisgICAgICAgICRyZWFsTmFtZSA9fiBzL18vLS9nOworCisgICAg ICAgIHByaW50IEYgImV4dGVybiBjb25zdCBjaGFyICRuYW1lIiwiJHtzaG9ydENhbWVsVHlwZX1T dHJpbmdbXSA9IFwiJHJlYWxOYW1lXCI7XG4iOworICAgIH0KK30gCisKIHN1YiBwcmludERlZmlu aXRpb25zCiB7CiAgICAgbXkgKCRGLCAkbmFtZXNSZWYsICR0eXBlLCAkbmFtZXNwYWNlVVJJKSA9 IEBfOwpAQCAtNDc2LDIzICs1MTEsMTggQEAgc3ViIHByaW50RGVmaW5pdGlvbnMKICAgICAKICAg ICBwcmludCBGICIgICAgLy8gIiAuIHVjZmlyc3QoJHR5cGUpIC4gIlxuIjsKIAorICAgIG15ICVu YW1lcyA9ICUkbmFtZXNSZWY7CiAgICAgZm9yIG15ICRuYW1lIChzb3J0IGtleXMgJSRuYW1lc1Jl ZikgewotICAgICAgICBwcmludCBGICIgICAgY29uc3QgY2hhciAqJG5hbWUiLCIke3Nob3J0Q2Ft ZWxUeXBlfVN0cmluZyA9IFwiJG5hbWVcIjtcbiI7Ci0gICAgfQotICAgICAgICAKLSAgICBmb3Ig bXkgJG5hbWUgKHNvcnQga2V5cyAlJG5hbWVzUmVmKSB7Ci0gICAgICAgIGlmICgkbmFtZSA9fiAv Xy8pIHsKLSAgICAgICAgICAgIG15ICRyZWFsTmFtZSA9ICRuYW1lOwotICAgICAgICAgICAgJHJl YWxOYW1lID1+IHMvXy8tL2c7Ci0gICAgICAgICAgICBwcmludCBGICIgICAgJHtuYW1lfSR7c2hv cnRDYW1lbFR5cGV9U3RyaW5nID0gXCIkcmVhbE5hbWVcIjtcbiI7Ci0gICAgICAgIH0KKyAgICAg ICAgbmV4dCBpZiAoJHBhcmFtZXRlcnN7J2V4cG9ydFN0cmluZ3MnfSBvciAkbmFtZXN7JG5hbWV9 eyJleHBvcnRTdHJpbmcifSk7CisKKyAgICAgICAgbXkgJHJlYWxOYW1lID0gJG5hbWU7CisgICAg ICAgICRyZWFsTmFtZSA9fiBzL18vLS9nOworICAgICAgICBwcmludCBGICIgICAgY29uc3QgY2hh ciAqJG5hbWUiLCIke3Nob3J0Q2FtZWxUeXBlfVN0cmluZyA9IFwiJHJlYWxOYW1lXCI7XG5cbiI7 CiAgICAgfQotICAgIHByaW50IEYgIlxuIjsKIAogICAgIGZvciBteSAkbmFtZSAoc29ydCBrZXlz ICUkbmFtZXNSZWYpIHsKICAgICAgICAgcHJpbnQgRiAiICAgIG5ldyAoKHZvaWQqKSYkbmFtZSIs IiR7c2hvcnRDYW1lbFR5cGV9KSBRdWFsaWZpZWROYW1lKG51bGxBdG9tLCAkbmFtZSIsIiR7c2hv cnRDYW1lbFR5cGV9U3RyaW5nLCAkbmFtZXNwYWNlVVJJKTtcbiI7CiAgICAgfQotCiB9CiAKICMj IEVsZW1lbnRGYWN0b3J5IHJvdXRpbmVzCkluZGV4OiBodG1sL0hUTUxBdHRyaWJ1dGVOYW1lcy5p bgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBodG1sL0hUTUxBdHRyaWJ1dGVOYW1lcy5pbgkocmV2aXNpb24gMzUx OTgpCisrKyBodG1sL0hUTUxBdHRyaWJ1dGVOYW1lcy5pbgkod29ya2luZyBjb3B5KQpAQCAtMzgs NyArMzgsNyBAQAogPGNoZWNrZWQvPgogPGNlbGxib3JkZXIvPgogPGNpdGUvPgotPGNsYXNzLz4K KzxjbGFzcyBleHBvcnRTdHJpbmc9IjEiLz4KIDxjbGFzc2lkLz4KIDxjbGVhci8+CiA8Y29kZS8+ CkluZGV4OiBzdmcvc3ZnYXR0cnMuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3ZnL3N2Z2F0dHJzLmluCShy ZXZpc2lvbiAzNTE5OCkKKysrIHN2Zy9zdmdhdHRycy5pbgkod29ya2luZyBjb3B5KQpAQCAtMSw0 ICsxLDQgQEAKLTxhdHRycyBuYW1lc3BhY2U9IlNWRyIgY3BwTmFtZXNwYWNlPSJXZWJDb3JlIiBu YW1lc3BhY2VVUkk9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiBnZW5lcmF0ZUZhY3Rvcnk9 IjEiIGdlbmVyYXRlV3JhcHBlckZhY3Rvcnk9IjEiIGd1YXJkRmFjdG9yeVdpdGg9IkVOQUJMRShT VkcpIiBudWxsTmFtZXNwYWNlPSIxIj4KKzxhdHRycyBuYW1lc3BhY2U9IlNWRyIgY3BwTmFtZXNw YWNlPSJXZWJDb3JlIiBuYW1lc3BhY2VVUkk9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiBn ZW5lcmF0ZUZhY3Rvcnk9IjEiIGdlbmVyYXRlV3JhcHBlckZhY3Rvcnk9IjEiIGd1YXJkRmFjdG9y eVdpdGg9IkVOQUJMRShTVkcpIiBudWxsTmFtZXNwYWNlPSIxIiBleHBvcnRTdHJpbmdzPSIxIj4K IDxhY2NlbnQtaGVpZ2h0Lz4KIDxhY2N1bXVsYXRlLz4KIDxhZGRpdGl2ZS8+CkluZGV4OiBzdmcv c3ZndGFncy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzdmcvc3ZndGFncy5pbgkocmV2aXNpb24gMzUxOTgp CisrKyBzdmcvc3ZndGFncy5pbgkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLTx0YWdz IG5hbWVzcGFjZT0iU1ZHIiBjcHBOYW1lc3BhY2U9IldlYkNvcmUiIG5hbWVzcGFjZVVSST0iaHR0 cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGdlbmVyYXRlRmFjdG9yeT0iMSIgZ2VuZXJhdGVXcmFw cGVyRmFjdG9yeT0iMSIgZ3VhcmRGYWN0b3J5V2l0aD0iRU5BQkxFKFNWRykiPgorPHRhZ3MgbmFt ZXNwYWNlPSJTVkciIGNwcE5hbWVzcGFjZT0iV2ViQ29yZSIgbmFtZXNwYWNlVVJJPSJodHRwOi8v d3d3LnczLm9yZy8yMDAwL3N2ZyIgZ2VuZXJhdGVGYWN0b3J5PSIxIiBnZW5lcmF0ZVdyYXBwZXJG YWN0b3J5PSIxIiBndWFyZEZhY3RvcnlXaXRoPSJFTkFCTEUoU1ZHKSIgZXhwb3J0U3RyaW5ncz0i MSI+CiA8YS8+CiAjaWYgRU5BQkxFX1NWR19GT05UUwogPGFsdEdseXBoLz4KSW5kZXg6IHN2Zy94 bGlua2F0dHJzLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN2Zy94bGlua2F0dHJzLmluCShyZXZpc2lvbiAz NTE5OCkKKysrIHN2Zy94bGlua2F0dHJzLmluCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBA QAotPGF0dHJzIG5hbWVzcGFjZT0iWExpbmsiIGNwcE5hbWVzcGFjZT0iV2ViQ29yZSIgbmFtZXNw YWNlVVJJPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KKzxhdHRycyBuYW1lc3BhY2U9 IlhMaW5rIiBjcHBOYW1lc3BhY2U9IldlYkNvcmUiIG5hbWVzcGFjZVVSST0iaHR0cDovL3d3dy53 My5vcmcvMTk5OS94bGluayIgZXhwb3J0U3RyaW5ncz0iMSI+CiA8YWN0dWF0ZS8+CiA8YXJjcm9s ZS8+CiA8aHJlZi8+Cg==