200510 2019-08-07 11:26:42 -0700 [WHLSL] checkRecursion, checkTextureReferences, and EscapedVariableCollector should skip stdlib functions 2019-08-07 12:49:17 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam commit-queue dino fpizlo jonlee justin_fan mmaxfield rmorisset sam webkit-bug-importer oldest_to_newest 1559209 0 saam 2019-08-07 11:26:42 -0700 they don't recurse. 1559234 1 375729 saam 2019-08-07 12:07:39 -0700 Created attachment 375729 patch 1559251 2 375729 commit-queue 2019-08-07 12:48:36 -0700 Comment on attachment 375729 patch Clearing flags on attachment: 375729 Committed r248382: <https://trac.webkit.org/changeset/248382> 1559252 3 commit-queue 2019-08-07 12:48:37 -0700 All reviewed patches have been landed. Closing bug. 1559253 4 webkit-bug-importer 2019-08-07 12:49:17 -0700 <rdar://problem/54046117> 375729 2019-08-07 12:07:39 -0700 2019-08-07 12:48:36 -0700 patch c-backup.diff text/plain 5443 saam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0ODM3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE5LTA4LTA3ICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFtXSExTTF0gY2hlY2tSZWN1cnNp b24sIGNoZWNrVGV4dHVyZVJlZmVyZW5jZXMsIGFuZCBFc2NhcGVkVmFyaWFibGVDb2xsZWN0b3Ig c2hvdWxkIHNraXAgc3RkbGliIGZ1bmN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNTEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2UgY2FuIHNraXAgd2Fsa2luZyB0aGUgc3RkbGliIHBhcnQg b2YgdGhlIEFTVCBpbiB2YXJpb3VzIHNlbWFudGljIGNoZWNraW5nIHBoYXNlczoKKyAgICAgICAg LSBjaGVja1JlY3Vyc2lvbjogdGhlIHN0ZGxpYiBkb2VzIG5vdCBoYXZlIHJlY3Vyc2lvbgorICAg ICAgICAtIGNoZWNrVGV4dHVyZVJlZmVyZW5jZXM6IHRoZSBzdGRsaWIgZG9lcyBub3QgaGF2ZSBy ZWZlcmVuY2VzIHRvIHRleHR1cmVzCisgICAgICAgIC0gRXNjYXBlZFZhcmlhYmxlQ29sbGVjdG9y OiB0aGlzIGlzIHVzZWQgaW5zaWRlIHByZXNlcnZlVmFyaWFibGVMaWZldGltZXMsIGFuZAorICAg ICAgICAgIHRoZSBzdGRsaWIgbmV2ZXIgZXNjYXBlcyBhbnkgdmFyaWFibGVzLgorICAgICAgICAK KyAgICAgICAgVGhpcyBwYXRjaCBzcGVlZHMgdXAgY2hlY2tSZWN1cnNpb24sIGNoZWNrVGV4dHVy ZVJlZmVyZW5jZXMsIGFuZCBwcmVzZXJ2ZVZhcmlhYmxlTGlmZXRpbWVzCisgICAgICAgIGJ5IGFi b3V0IDFtcyBlYWNoLCBsZWFkaW5nIHRvIGEgM21zIGNvbXBpbGUgdGltZSBzcGVlZHVwIGluIGNv bXB1dGVfYm9pZHMuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTENoZWNr VGV4dHVyZVJlZmVyZW5jZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V0hMU0w6OlRleHR1cmVS ZWZlcmVuY2VzQ2hlY2tlcjo6dmlzaXQpOgorICAgICAgICAqIE1vZHVsZXMvd2ViZ3B1L1dITFNM L1dITFNMUHJlc2VydmVWYXJpYWJsZUxpZmV0aW1lcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpX SExTTDo6cHJlc2VydmVWYXJpYWJsZUxpZmV0aW1lcyk6CisgICAgICAgIChXZWJDb3JlOjpXSExT TDo6RXNjYXBlZFZhcmlhYmxlQ29sbGVjdG9yOjplc2NhcGVWYXJpYWJsZVVzZSk6IERlbGV0ZWQu CisgICAgICAgIChXZWJDb3JlOjpXSExTTDo6RXNjYXBlZFZhcmlhYmxlQ29sbGVjdG9yOjp0YWtl RXNjYXBlZFZhcmlhYmxlcyk6IERlbGV0ZWQuCisgICAgICAgICogTW9kdWxlcy93ZWJncHUvV0hM U0wvV0hMU0xSZWN1cnNpb25DaGVja2VyLmNwcDoKKwogMjAxOS0wOC0wNyAgU2FhbSBCYXJhdGkg IDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIGNhY2hlIHJlc3VsdHMgb2Yg YXJndW1lbnRUeXBlRm9yQW5kT3ZlcmxvYWQgaW5zaWRlIENoZWNrZXIKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMQ2hlY2tUZXh0dXJlUmVmZXJlbmNlcy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hM U0xDaGVja1RleHR1cmVSZWZlcmVuY2VzLmNwcAkocmV2aXNpb24gMjQ4Mzc5KQorKysgU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xDaGVja1RleHR1cmVSZWZlcmVuY2Vz LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzksNyArMzksNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIG5hbWVzcGFjZSBXSExTTCB7CiAKLWNsYXNzIFRleHR1cmVSZWZlcmVuY2VzQ2hlY2tlciA6 IHB1YmxpYyBWaXNpdG9yIHsKK2NsYXNzIFRleHR1cmVSZWZlcmVuY2VzQ2hlY2tlciBmaW5hbCA6 IHB1YmxpYyBWaXNpdG9yIHsKIHB1YmxpYzoKICAgICBUZXh0dXJlUmVmZXJlbmNlc0NoZWNrZXIo KSA9IGRlZmF1bHQ7CiAKQEAgLTUwLDYgKzUwLDggQEAgcHJpdmF0ZToKICAgICB2b2lkIHZpc2l0 KEFTVDo6QXJyYXlSZWZlcmVuY2VUeXBlJikgb3ZlcnJpZGU7CiAgICAgdm9pZCB2aXNpdChBU1Q6 OkFycmF5VHlwZSYpIG92ZXJyaWRlOwogICAgIHZvaWQgdmlzaXQoQVNUOjpFeHByZXNzaW9uJikg b3ZlcnJpZGU7CisgICAgdm9pZCB2aXNpdChBU1Q6OkZ1bmN0aW9uRGVmaW5pdGlvbiYpIG92ZXJy aWRlOworICAgIHZvaWQgdmlzaXQoQVNUOjpOYXRpdmVGdW5jdGlvbkRlY2xhcmF0aW9uJikgb3Zl cnJpZGU7CiAKICAgICBib29sIGNvbnRhaW5zVGV4dHVyZU9yU2FtcGxlcihBU1Q6OlVubmFtZWRU eXBlJik7CiB9OwpAQCAtMTE0LDYgKzExNiwxNiBAQCB2b2lkIFRleHR1cmVSZWZlcmVuY2VzQ2hl Y2tlcjo6dmlzaXQoQVNUCiAgICAgY2hlY2tFcnJvckFuZFZpc2l0KGV4cHJlc3Npb24ucmVzb2x2 ZWRUeXBlKCkpOwogfQogCit2b2lkIFRleHR1cmVSZWZlcmVuY2VzQ2hlY2tlcjo6dmlzaXQoQVNU OjpGdW5jdGlvbkRlZmluaXRpb24mIGZ1bmN0aW9uRGVmaW5pdGlvbikKK3sKKyAgICBpZiAoZnVu Y3Rpb25EZWZpbml0aW9uLnBhcnNpbmdNb2RlKCkgIT0gUGFyc2luZ01vZGU6OlN0YW5kYXJkTGli cmFyeSkKKyAgICAgICAgVmlzaXRvcjo6dmlzaXQoZnVuY3Rpb25EZWZpbml0aW9uKTsKK30KKwor dm9pZCBUZXh0dXJlUmVmZXJlbmNlc0NoZWNrZXI6OnZpc2l0KEFTVDo6TmF0aXZlRnVuY3Rpb25E ZWNsYXJhdGlvbiYpCit7Cit9CisKIEV4cGVjdGVkPHZvaWQsIEVycm9yPiBjaGVja1RleHR1cmVS ZWZlcmVuY2VzKFByb2dyYW0mIHByb2dyYW0pCiB7CiAgICAgVGV4dHVyZVJlZmVyZW5jZXNDaGVj a2VyIHRleHR1cmVSZWZlcmVuY2VzQ2hlY2tlcjsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViZ3B1L1dITFNML1dITFNMUHJlc2VydmVWYXJpYWJsZUxpZmV0aW1lcy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xQcmVzZXJ2 ZVZhcmlhYmxlTGlmZXRpbWVzLmNwcAkocmV2aXNpb24gMjQ4Mzc5KQorKysgU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xQcmVzZXJ2ZVZhcmlhYmxlTGlmZXRpbWVzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNTQsNyArNTQsNyBAQCBuYW1lc3BhY2UgV0hMU0wgewogLy8g ICAieCIuIElmICJ4IiBpcyBhIGZ1bmN0aW9uIHBhcmFtZXRlciwgd2Ugc3RvcmUgdG8gInN0cnVj dC0+eCIgYXMgdGhlIGZpcnN0CiAvLyAgIHRoaW5nIHdlIGRvIGluIHRoZSBmdW5jdGlvbiBib2R5 LgogCi1jbGFzcyBFc2NhcGVkVmFyaWFibGVDb2xsZWN0b3IgOiBwdWJsaWMgVmlzaXRvciB7Citj bGFzcyBFc2NhcGVkVmFyaWFibGVDb2xsZWN0b3IgZmluYWwgOiBwdWJsaWMgVmlzaXRvciB7CiAg ICAgdXNpbmcgQmFzZSA9IFZpc2l0b3I7CiBwdWJsaWM6CiAKQEAgLTg3LDYgKzg3LDEyIEBAIHB1 YmxpYzoKICAgICAgICAgICAgIGVzY2FwZVZhcmlhYmxlVXNlKG1ha2VBcnJheVJlZmVyZW5jZUV4 cHJlc3Npb24ubGVmdFZhbHVlKCkpOwogICAgIH0KIAorICAgIHZvaWQgdmlzaXQoQVNUOjpGdW5j dGlvbkRlZmluaXRpb24mIGZ1bmN0aW9uRGVmaW5pdGlvbikgb3ZlcnJpZGUKKyAgICB7CisgICAg ICAgIGlmIChmdW5jdGlvbkRlZmluaXRpb24ucGFyc2luZ01vZGUoKSAhPSBQYXJzaW5nTW9kZTo6 U3RhbmRhcmRMaWJyYXJ5KQorICAgICAgICAgICAgQmFzZTo6dmlzaXQoZnVuY3Rpb25EZWZpbml0 aW9uKTsKKyAgICB9CisKICAgICBIYXNoTWFwPEFTVDo6VmFyaWFibGVEZWNsYXJhdGlvbiosIFN0 cmluZz4gdGFrZUVzY2FwZWRWYXJpYWJsZXMoKSB7IHJldHVybiBXVEZNb3ZlKG1fZXNjYXBlZFZh cmlhYmxlcyk7IH0KIAogcHJpdmF0ZToKQEAgLTI1Myw3ICsyNTksOCBAQCB2b2lkIHByZXNlcnZl VmFyaWFibGVMaWZldGltZXMoUHJvZ3JhbSYgCiAgICAgSGFzaE1hcDxBU1Q6OlZhcmlhYmxlRGVj bGFyYXRpb24qLCBTdHJpbmc+IGVzY2FwZWRWYXJpYWJsZXM7CiAgICAgewogICAgICAgICBFc2Nh cGVkVmFyaWFibGVDb2xsZWN0b3IgY29sbGVjdG9yOwotICAgICAgICBjb2xsZWN0b3IuVmlzaXRv cjo6dmlzaXQocHJvZ3JhbSk7CisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcHJvZ3Jh bS5mdW5jdGlvbkRlZmluaXRpb25zKCkuc2l6ZSgpOyArK2kpCisgICAgICAgICAgICBjb2xsZWN0 b3IudmlzaXQocHJvZ3JhbS5mdW5jdGlvbkRlZmluaXRpb25zKClbaV0pOwogICAgICAgICBlc2Nh cGVkVmFyaWFibGVzID0gY29sbGVjdG9yLnRha2VFc2NhcGVkVmFyaWFibGVzKCk7CiAgICAgfQog CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTFJlY3Vyc2lv bkNoZWNrZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1 L1dITFNML1dITFNMUmVjdXJzaW9uQ2hlY2tlci5jcHAJKHJldmlzaW9uIDI0ODM3OSkKKysrIFNv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMUmVjdXJzaW9uQ2hlY2tlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDcgKzM5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog bmFtZXNwYWNlIFdITFNMIHsKIAogLy8gTWFrZXMgc3VyZSB0aGVyZSBpcyBubyBmdW5jdGlvbiBy ZWN1cnNpb24uCi1jbGFzcyBSZWN1cnNpb25DaGVja2VyIDogcHVibGljIFZpc2l0b3IgeworY2xh c3MgUmVjdXJzaW9uQ2hlY2tlciBmaW5hbCA6IHB1YmxpYyBWaXNpdG9yIHsKIHByaXZhdGU6CiAg ICAgdm9pZCB2aXNpdChQcm9ncmFtJiBwcm9ncmFtKSBvdmVycmlkZQogICAgIHsKQEAgLTU4LDcg KzU4LDggQEAgcHJpdmF0ZToKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCi0gICAg ICAgIFZpc2l0b3I6OnZpc2l0KGZ1bmN0aW9uRGVmaW5pdGlvbik7CisgICAgICAgIGlmIChmdW5j dGlvbkRlZmluaXRpb24ucGFyc2luZ01vZGUoKSAhPSBQYXJzaW5nTW9kZTo6U3RhbmRhcmRMaWJy YXJ5KQorICAgICAgICAgICAgVmlzaXRvcjo6dmlzaXQoZnVuY3Rpb25EZWZpbml0aW9uKTsKIAog ICAgICAgICB7CiAgICAgICAgICAgICBhdXRvIGFkZFJlc3VsdCA9IG1fZmluaXNoZWRWaXNpdGlu Zy5hZGQoJmZ1bmN0aW9uRGVmaW5pdGlvbik7Cg==