<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>200499</bug_id>
          
          <creation_ts>2019-08-07 02:46:21 -0700</creation_ts>
          <short_desc>Short-cut WebGLRenderingContext::getParameter() for ALPHA_BITS when alpha channel is disabled</short_desc>
          <delta_ts>2019-08-14 09:25:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Lord">clord</reporter>
          <assigned_to name="Chris Lord">clord</assigned_to>
          <cc>ap</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dino</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>graouts</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>justin_fan</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>rego</cc>
    
    <cc>saam</cc>
    
    <cc>sam</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1559080</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-07 02:46:21 -0700</bug_when>
    <thetext>After bug #200434, retrieving ALPHA_BITS can return an incorrect value. Add a shortcut, similar to the retrieval of DEPTH and STENCIL bits.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559084</commentid>
    <comment_count>1</comment_count>
      <attachid>375692</attachid>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-07 03:01:54 -0700</bug_when>
    <thetext>Created attachment 375692
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559085</commentid>
    <comment_count>2</comment_count>
      <attachid>375693</attachid>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-07 03:18:37 -0700</bug_when>
    <thetext>Created attachment 375693
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559097</commentid>
    <comment_count>3</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-07 05:31:16 -0700</bug_when>
    <thetext>This fixes the ALPHA_BITS failure in context-attributes-alpha-depth-stencil-antialias.html on wpe and ios, as expected.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559157</commentid>
    <comment_count>4</comment_count>
      <attachid>375693</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-08-07 10:20:12 -0700</bug_when>
    <thetext>Comment on attachment 375693
Patch

Failing test is:

webgl/2.0.0/conformance/context/context-attributes-alpha-depth-stencil-antialias.html

This makes me think the failure is indeed related to this patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559158</commentid>
    <comment_count>5</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-08-07 10:20:44 -0700</bug_when>
    <thetext>Just incorrectly rebased perhaps?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559355</commentid>
    <comment_count>6</comment_count>
      <attachid>375759</attachid>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-07 15:52:57 -0700</bug_when>
    <thetext>Created attachment 375759
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559356</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-07 15:53:47 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #4)
&gt; Comment on attachment 375693 [details]
&gt; Patch
&gt; 
&gt; Failing test is:
&gt; 
&gt; webgl/2.0.0/conformance/context/context-attributes-alpha-depth-stencil-
&gt; antialias.html
&gt; 
&gt; This makes me think the failure is indeed related to this patch.

The test is actually passing now and was failing before - I&apos;ve updated the patch to mark it as passing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559447</commentid>
    <comment_count>8</comment_count>
      <attachid>375787</attachid>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-08 00:49:52 -0700</bug_when>
    <thetext>Created attachment 375787
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559699</commentid>
    <comment_count>9</comment_count>
      <attachid>375787</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-08-08 16:04:11 -0700</bug_when>
    <thetext>Comment on attachment 375787
Patch

Would be better to have test coverage for both changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559710</commentid>
    <comment_count>10</comment_count>
      <attachid>375787</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-08 16:25:15 -0700</bug_when>
    <thetext>Comment on attachment 375787
Patch

Clearing flags on attachment: 375787

Committed r248448: &lt;https://trac.webkit.org/changeset/248448&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559711</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-08-08 16:25:17 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559829</commentid>
    <comment_count>12</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-09 01:27:41 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #9)
&gt; Comment on attachment 375787 [details]
&gt; Patch
&gt; 
&gt; Would be better to have test coverage for both changes.

Thanks for the review!

I&apos;m a little stumped as to what further tests could be added to test this - it was test failures that let me identify it initially and it seems pretty well-tested in context-attributes-alpha-depth-stencil-
&gt; antialias.html in both WebGL conformance test suites (and it&apos;s replicated in the fast webgl test suite too).

Do you have any suggestions?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559882</commentid>
    <comment_count>13</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-08-09 08:04:57 -0700</bug_when>
    <thetext>Not sure my understanding is correct, but I believe that the test covers either WebGL2RenderingContext. I am suggesting adding a second test that covers WebGLRenderingContext. Otherwise we have one tested change and one untested change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559888</commentid>
    <comment_count>14</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-09 08:09:52 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #13)
&gt; Not sure my understanding is correct, but I believe that the test covers
&gt; either WebGL2RenderingContext. I am suggesting adding a second test that
&gt; covers WebGLRenderingContext. Otherwise we have one tested change and one
&gt; untested change.

The same test exists for WebGLRenderingContext (https://github.com/WebKit/webkit/blob/master/LayoutTests/webgl/1.0.2/conformance/context/context-attributes-alpha-depth-stencil-antialias.html), both tests were failing for wpe (and both contexts required the fix) - I&apos;m not what&apos;s happening with this test for ios.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1559893</commentid>
    <comment_count>15</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2019-08-09 08:18:16 -0700</bug_when>
    <thetext>OK. Here’s what confused me. Typically if tests are failing, the patch needs to update expected results for those tests. So I would have expected 4 different updates to expected results in the patch.

Glad to hear there’s no new test required. Puzzled about the status of these tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560182</commentid>
    <comment_count>16</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2019-08-09 22:55:30 -0700</bug_when>
    <thetext>The WebGL 1.0.2 test was fixed for WPE earlier in bug 200434, but it still fails on iOS and on Gtk. There was no change to its pass/fail status when this patch landed. So as Darin observed, this test does not cover your change in WebGLRenderingContext.cpp.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=webgl%2F1.0.2%2Fconformance%2Fcontext%2Fcontext-attributes-alpha-depth-stencil-antialias.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560365</commentid>
    <comment_count>17</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-12 00:56:24 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #16)
&gt; The WebGL 1.0.2 test was fixed for WPE earlier in bug 200434, but it still
&gt; fails on iOS and on Gtk. There was no change to its pass/fail status when
&gt; this patch landed. So as Darin observed, this test does not cover your
&gt; change in WebGLRenderingContext.cpp.
&gt; 
&gt; https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
&gt; html#tests=webgl%2F1.0.2%2Fconformance%2Fcontext%2Fcontext-attributes-alpha-
&gt; depth-stencil-antialias.html

I&apos;m having some trouble understanding how to read this page, could you give me some pointers? How do I access the test log for this test, for example?

context-attributes-alpha-depth-stencil-antialias has many tests underneath it and this patch only affects one of them, in case you hadn&apos;t already considered that - I&apos;d need to see the pass/fail log to see if this patch isn&apos;t tested. Note that it did pass fine on several platforms before, the outcome depended on the behaviour of the GL backend.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560543</commentid>
    <comment_count>18</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2019-08-12 13:50:10 -0700</bug_when>
    <thetext>The UI is not great indeed, haven&apos;t updated it in years.

Short story: This test is written in a way that explicitly prevents seeing those individual results, for whatever reason. But maybe fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html is similar enough that you can investigate it instead.

Here is the diff for iOS: &lt;https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r248526%20(5016)/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-pretty-diff.html&gt;

Here is one for Gtk:
&lt;https://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug%20(Tests)/r248521%20(5144)/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-pretty-diff.html&gt;

Long version:

You should see that the bottom line of rectangles (corresponding to WPE Linux) is green at the left, and red at the right. This means that this test is passing on newer builds, but failing on older builds. GTK and Mac results remain red, meaning that it&apos;s still failing.

If you click on any of the rectangles, there will be a &quot;build log&quot; link. Click on it, that sends you to a buildbot page for the test run. Then click on &quot;view layout test results&quot; link. On the results page, there will be an &quot;options&quot; link at the top right - you need to uncheck &quot;Only show unexpected results&quot;, because this failure is marked as expected.

Then you will see the test in the list, with links like &quot;diff&quot; and &quot;pretty diff&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1560815</commentid>
    <comment_count>19</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-13 09:26:38 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #18)
&gt; You should see that the bottom line of rectangles (corresponding to WPE
&gt; Linux) is green at the left, and red at the right. This means that this test
&gt; is passing on newer builds, but failing on older builds. GTK and Mac results
&gt; remain red, meaning that it&apos;s still failing.
&gt; 
&gt; If you click on any of the rectangles, there will be a &quot;build log&quot; link.
&gt; Click on it, that sends you to a buildbot page for the test run. Then click
&gt; on &quot;view layout test results&quot; link. On the results page, there will be an
&gt; &quot;options&quot; link at the top right - you need to uncheck &quot;Only show unexpected
&gt; results&quot;, because this failure is marked as expected.
&gt; 
&gt; Then you will see the test in the list, with links like &quot;diff&quot; and &quot;pretty
&gt; diff&quot;.

Thanks for this - so it seems this may have introduced new failures in this test. Given that it affects the gtk backend too, this should be easy for me to reproduce and debug. I&apos;ll set a build going now and look into this tomorrow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1561138</commentid>
    <comment_count>20</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-14 06:06:23 -0700</bug_when>
    <thetext>Testing locally, the Gtk test failures happen with or without this patch, so I guess those failures are unrelated and I misread the log. It seems the wpe results have disappeared from the logs in the link above now so I&apos;m having a tough time determining much.

The sub-test that this affects can still pass even without this patch, it seems to depend on the behaviour of the backend (which is why this patch was only needed on wpe and ios). Gtk isn&apos;t failing on the test that this patch affects. I note that there&apos;s only an expected results file for the 2.0.0 conformance tests, so I suppose this was already passing on iOS on the 1.x WebGL context?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1561177</commentid>
    <comment_count>21</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2019-08-14 09:11:11 -0700</bug_when>
    <thetext>I am not entirely sure which test you are asking about at this point. The flakiness dashboard has authoritative information on whether tests were matching expected results on each platform.

There are multiple issues being discussed here at this point.

1. This patch changes cross-platforms code, but there is no WebGL 1 test on macOS or iOS that went from failing to passing as a result. This means that we don&apos;t have a layer of defense against this functionality breaking again in the future.

2. There are various (and different) failures on tests that were discussed above, affecting most platforms.

#2 should probably be discussed in a separate bugzilla bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1561184</commentid>
    <comment_count>22</comment_count>
    <who name="Chris Lord">clord</who>
    <bug_when>2019-08-14 09:25:19 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #21)
&gt; I am not entirely sure which test you are asking about at this point. The
&gt; flakiness dashboard has authoritative information on whether tests were
&gt; matching expected results on each platform.
&gt; 
&gt; There are multiple issues being discussed here at this point.
&gt; 
&gt; 1. This patch changes cross-platforms code, but there is no WebGL 1 test on
&gt; macOS or iOS that went from failing to passing as a result. This means that
&gt; we don&apos;t have a layer of defense against this functionality breaking again
&gt; in the future.
&gt; 
&gt; 2. There are various (and different) failures on tests that were discussed
&gt; above, affecting most platforms.
&gt; 
&gt; #2 should probably be discussed in a separate bugzilla bug.

Re. 1, this patch effects the &apos;Testing alpha = false&apos; part of context-attributes-alpha-depth-stencil-antialias, more specifically, the part that tests that ALPHA_BITS == 0 on a GL context that has no alpha component. This only has an effect if this test was failing previously, which was happening on WPE in all cases, and on iOS (only on the WebGL2 context it seems). The reason other cases were unaffected is because their GraphicsContext implementations returned the expected result without needing any circumvention.

Re. 2, I assume there are bugs filed for failing WebGL tests that are failing unexpectedly - I&apos;m new to WebKit, so I don&apos;t know what the expectations are around this yet. Important/supported platforms seem to be covered by automatic regression testing, my patches are focusing on WPE which isn&apos;t covered.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375692</attachid>
            <date>2019-08-07 03:01:54 -0700</date>
            <delta_ts>2019-08-07 03:18:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200499-20190807110153.patch</filename>
            <type>text/plain</type>
            <size>2666</size>
            <attacher name="Chris Lord">clord</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTBkNzIzY2E4MzA1OGUx
MWZhZjEwMDU2YTJmN2M5YTZmMGExY2Q2Ni4uZmEzYThmYmViY2M2YTMzZWYzZTE5MjM2MGQxZDhm
ZjEzNzNlMGVjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA4LTA3ICBDaHJp
cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBTaG9ydC1jdXQgV2ViR0xSZW5k
ZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIoKSBmb3IgQUxQSEFfQklUUyB3aGVuIGFscGhhIGNo
YW5uZWwgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMDQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIHNob3J0Y3V0IHdoZW4gYSBmcmFtZWJ1ZmZlciBp
c24ndCBib3VuZCBvbiBXZWJHTAorICAgICAgICBjYW52YXNlcyB3aGVuIHJldHJpZXZpbmcgQUxQ
SEFfQklUUy4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5j
cHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFBhcmFtZXRl
cik6CisgICAgICAgIFJldHVybiAwIGZvciBBTFBIQV9CSVRTIGlmIGNhbnZhcyBoYXMgbm8gYWxw
aGEgY29tcG9uZW50LgorICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMMlJlbmRlcmluZ0NvbnRl
eHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRQYXJh
bWV0ZXIpOgorICAgICAgICBSZXR1cm4gMCBmb3IgQUxQSEFfQklUUyBpZiBjYW52YXMgaGFzIG5v
IGFscGhhIGNvbXBvbmVudC4KKwogMjAxOS0wOC0wNyAgQ2hyaXMgTG9yZCAgPGNsb3JkQGlnYWxp
YS5jb20+CiAKICAgICAgICAgY29udGV4dC1hdHRyaWJ1dGVzLWFscGhhLWRlcHRoLXN0ZW5jaWwt
YW50aWFsaWFzIGZhaWxzIG9uIFdQRSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L2h0bWwvY2FudmFzL1dlYkdMMlJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv
aHRtbC9jYW52YXMvV2ViR0wyUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggYTY2ZjdlODU2ODlm
YzVjM2I0NzdlYWRjNmQyNjMwYThkNGFlZTczMy4uNjMxMTkxNzU3MGYyZGIyODU5NGNiYjM0OTAy
NDY5OTdiNTgzZmJlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2Vi
R0wyUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv
V2ViR0wyUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTE3NzEsNiArMTc3MSw4IEBAIFdlYkdMQW55
IFdlYkdMMlJlbmRlcmluZ0NvbnRleHQ6OmdldFBhcmFtZXRlcihHQzNEZW51bSBwbmFtZSkKICAg
ICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpBTElBU0VEX1BPSU5UX1NJWkVfUkFOR0U6CiAgICAg
ICAgIHJldHVybiBnZXRXZWJHTEZsb2F0QXJyYXlQYXJhbWV0ZXIocG5hbWUpOwogICAgIGNhc2Ug
R3JhcGhpY3NDb250ZXh0M0Q6OkFMUEhBX0JJVFM6CisgICAgICAgIGlmICghbV9mcmFtZWJ1ZmZl
ckJpbmRpbmcgJiYgIW1fYXR0cmlidXRlcy5hbHBoYSkKKyAgICAgICAgICAgIHJldHVybiAwOwog
ICAgICAgICByZXR1cm4gZ2V0SW50UGFyYW1ldGVyKHBuYW1lKTsKICAgICBjYXNlIEdyYXBoaWNz
Q29udGV4dDNEOjpBUlJBWV9CVUZGRVJfQklORElORzoKICAgICAgICAgcmV0dXJuIG1fYm91bmRB
cnJheUJ1ZmZlcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM
UmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJl
bmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IGQ2MjlmYmZiNTVlMDYyYzkyN2NmZWU4MzBhMDhmNGU5
NGZjMDBhZmQuLmUwNmJmOTlkNTkxNTk2Mzk4MGE2MTFjMzJhODM5ZTI5N2YxMjgwNDUgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5j
cHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0
LmNwcApAQCAtNDIxLDYgKzQyMSw4IEBAIFdlYkdMQW55IFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6
Z2V0UGFyYW1ldGVyKEdDM0RlbnVtIHBuYW1lKQogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6
OkFMSUFTRURfUE9JTlRfU0laRV9SQU5HRToKICAgICAgICAgcmV0dXJuIGdldFdlYkdMRmxvYXRB
cnJheVBhcmFtZXRlcihwbmFtZSk7CiAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6QUxQSEFf
QklUUzoKKyAgICAgICAgaWYgKCFtX2ZyYW1lYnVmZmVyQmluZGluZyAmJiAhbV9hdHRyaWJ1dGVz
LmFscGhhKQorICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIHJldHVybiBnZXRJbnRQYXJh
bWV0ZXIocG5hbWUpOwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OkFSUkFZX0JVRkZFUl9C
SU5ESU5HOgogICAgICAgICByZXR1cm4gbV9ib3VuZEFycmF5QnVmZmVyOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375693</attachid>
            <date>2019-08-07 03:18:37 -0700</date>
            <delta_ts>2019-08-07 15:52:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200499-20190807111836.patch</filename>
            <type>text/plain</type>
            <size>2718</size>
            <attacher name="Chris Lord">clord</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTBkNzIzY2E4MzA1OGUx
MWZhZjEwMDU2YTJmN2M5YTZmMGExY2Q2Ni4uYThlMjYzZTMyM2FlYjBhNmRkYzYxOGYzMjkzZTQ2
NTcxZGZlYmUxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA4LTA3ICBDaHJp
cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBTaG9ydC1jdXQgV2ViR0xSZW5k
ZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIoKSBmb3IgQUxQSEFfQklUUyB3aGVuIGFscGhhIGNo
YW5uZWwgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMDQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIHNob3J0Y3V0IHdoZW4gYSBmcmFtZWJ1ZmZlciBp
c24ndCBib3VuZCBvbiBXZWJHTAorICAgICAgICBjYW52YXNlcyB3aGVuIHJldHJpZXZpbmcgQUxQ
SEFfQklUUy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVz
dHMuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIpOgor
ICAgICAgICBSZXR1cm4gMCBmb3IgQUxQSEFfQklUUyBpZiBjYW52YXMgaGFzIG5vIGFscGhhIGNv
bXBvbmVudC4KKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNw
cDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0UGFyYW1ldGVy
KToKKyAgICAgICAgUmV0dXJuIDAgZm9yIEFMUEhBX0JJVFMgaWYgY2FudmFzIGhhcyBubyBhbHBo
YSBjb21wb25lbnQuCisKIDIwMTktMDgtMDcgIENocmlzIExvcmQgIDxjbG9yZEBpZ2FsaWEuY29t
PgogCiAgICAgICAgIGNvbnRleHQtYXR0cmlidXRlcy1hbHBoYS1kZXB0aC1zdGVuY2lsLWFudGlh
bGlhcyBmYWlscyBvbiBXUEUgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s
L2NhbnZhcy9XZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv
Y2FudmFzL1dlYkdMMlJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IGE2NmY3ZTg1Njg5ZmM1YzNi
NDc3ZWFkYzZkMjYzMGE4ZDRhZWU3MzMuLjYzMTE5MTc1NzBmMmRiMjg1OTRjYmIzNDkwMjQ2OTk3
YjU4M2ZiZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMMlJl
bmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM
MlJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC0xNzcxLDYgKzE3NzEsOCBAQCBXZWJHTEFueSBXZWJH
TDJSZW5kZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIoR0MzRGVudW0gcG5hbWUpCiAgICAgY2Fz
ZSBHcmFwaGljc0NvbnRleHQzRDo6QUxJQVNFRF9QT0lOVF9TSVpFX1JBTkdFOgogICAgICAgICBy
ZXR1cm4gZ2V0V2ViR0xGbG9hdEFycmF5UGFyYW1ldGVyKHBuYW1lKTsKICAgICBjYXNlIEdyYXBo
aWNzQ29udGV4dDNEOjpBTFBIQV9CSVRTOgorICAgICAgICBpZiAoIW1fZnJhbWVidWZmZXJCaW5k
aW5nICYmICFtX2F0dHJpYnV0ZXMuYWxwaGEpCisgICAgICAgICAgICByZXR1cm4gMDsKICAgICAg
ICAgcmV0dXJuIGdldEludFBhcmFtZXRlcihwbmFtZSk7CiAgICAgY2FzZSBHcmFwaGljc0NvbnRl
eHQzRDo6QVJSQVlfQlVGRkVSX0JJTkRJTkc6CiAgICAgICAgIHJldHVybiBtX2JvdW5kQXJyYXlC
dWZmZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRl
cmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJp
bmdDb250ZXh0LmNwcAppbmRleCBkNjI5ZmJmYjU1ZTA2MmM5MjdjZmVlODMwYTA4ZjRlOTRmYzAw
YWZkLi5lMDZiZjk5ZDU5MTU5NjM5ODBhNjExYzMyYTgzOWUyOTdmMTI4MDQ1IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAK
QEAgLTQyMSw2ICs0MjEsOCBAQCBXZWJHTEFueSBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFBh
cmFtZXRlcihHQzNEZW51bSBwbmFtZSkKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpBTElB
U0VEX1BPSU5UX1NJWkVfUkFOR0U6CiAgICAgICAgIHJldHVybiBnZXRXZWJHTEZsb2F0QXJyYXlQ
YXJhbWV0ZXIocG5hbWUpOwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OkFMUEhBX0JJVFM6
CisgICAgICAgIGlmICghbV9mcmFtZWJ1ZmZlckJpbmRpbmcgJiYgIW1fYXR0cmlidXRlcy5hbHBo
YSkKKyAgICAgICAgICAgIHJldHVybiAwOwogICAgICAgICByZXR1cm4gZ2V0SW50UGFyYW1ldGVy
KHBuYW1lKTsKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpBUlJBWV9CVUZGRVJfQklORElO
RzoKICAgICAgICAgcmV0dXJuIG1fYm91bmRBcnJheUJ1ZmZlcjsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375759</attachid>
            <date>2019-08-07 15:52:57 -0700</date>
            <delta_ts>2019-08-08 00:49:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200499-20190807235256.patch</filename>
            <type>text/plain</type>
            <size>4372</size>
            <attacher name="Chris Lord">clord</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTBkNzIzY2E4MzA1OGUx
MWZhZjEwMDU2YTJmN2M5YTZmMGExY2Q2Ni4uYThlMjYzZTMyM2FlYjBhNmRkYzYxOGYzMjkzZTQ2
NTcxZGZlYmUxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA4LTA3ICBDaHJp
cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBTaG9ydC1jdXQgV2ViR0xSZW5k
ZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIoKSBmb3IgQUxQSEFfQklUUyB3aGVuIGFscGhhIGNo
YW5uZWwgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMDQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIHNob3J0Y3V0IHdoZW4gYSBmcmFtZWJ1ZmZlciBp
c24ndCBib3VuZCBvbiBXZWJHTAorICAgICAgICBjYW52YXNlcyB3aGVuIHJldHJpZXZpbmcgQUxQ
SEFfQklUUy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVz
dHMuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIpOgor
ICAgICAgICBSZXR1cm4gMCBmb3IgQUxQSEFfQklUUyBpZiBjYW52YXMgaGFzIG5vIGFscGhhIGNv
bXBvbmVudC4KKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNw
cDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0UGFyYW1ldGVy
KToKKyAgICAgICAgUmV0dXJuIDAgZm9yIEFMUEhBX0JJVFMgaWYgY2FudmFzIGhhcyBubyBhbHBo
YSBjb21wb25lbnQuCisKIDIwMTktMDgtMDcgIENocmlzIExvcmQgIDxjbG9yZEBpZ2FsaWEuY29t
PgogCiAgICAgICAgIGNvbnRleHQtYXR0cmlidXRlcy1hbHBoYS1kZXB0aC1zdGVuY2lsLWFudGlh
bGlhcyBmYWlscyBvbiBXUEUgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s
L2NhbnZhcy9XZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv
Y2FudmFzL1dlYkdMMlJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IGE2NmY3ZTg1Njg5ZmM1YzNi
NDc3ZWFkYzZkMjYzMGE4ZDRhZWU3MzMuLjYzMTE5MTc1NzBmMmRiMjg1OTRjYmIzNDkwMjQ2OTk3
YjU4M2ZiZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMMlJl
bmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM
MlJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC0xNzcxLDYgKzE3NzEsOCBAQCBXZWJHTEFueSBXZWJH
TDJSZW5kZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIoR0MzRGVudW0gcG5hbWUpCiAgICAgY2Fz
ZSBHcmFwaGljc0NvbnRleHQzRDo6QUxJQVNFRF9QT0lOVF9TSVpFX1JBTkdFOgogICAgICAgICBy
ZXR1cm4gZ2V0V2ViR0xGbG9hdEFycmF5UGFyYW1ldGVyKHBuYW1lKTsKICAgICBjYXNlIEdyYXBo
aWNzQ29udGV4dDNEOjpBTFBIQV9CSVRTOgorICAgICAgICBpZiAoIW1fZnJhbWVidWZmZXJCaW5k
aW5nICYmICFtX2F0dHJpYnV0ZXMuYWxwaGEpCisgICAgICAgICAgICByZXR1cm4gMDsKICAgICAg
ICAgcmV0dXJuIGdldEludFBhcmFtZXRlcihwbmFtZSk7CiAgICAgY2FzZSBHcmFwaGljc0NvbnRl
eHQzRDo6QVJSQVlfQlVGRkVSX0JJTkRJTkc6CiAgICAgICAgIHJldHVybiBtX2JvdW5kQXJyYXlC
dWZmZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRl
cmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJp
bmdDb250ZXh0LmNwcAppbmRleCBkNjI5ZmJmYjU1ZTA2MmM5MjdjZmVlODMwYTA4ZjRlOTRmYzAw
YWZkLi5lMDZiZjk5ZDU5MTU5NjM5ODBhNjExYzMyYTgzOWUyOTdmMTI4MDQ1IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAK
QEAgLTQyMSw2ICs0MjEsOCBAQCBXZWJHTEFueSBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFBh
cmFtZXRlcihHQzNEZW51bSBwbmFtZSkKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpBTElB
U0VEX1BPSU5UX1NJWkVfUkFOR0U6CiAgICAgICAgIHJldHVybiBnZXRXZWJHTEZsb2F0QXJyYXlQ
YXJhbWV0ZXIocG5hbWUpOwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OkFMUEhBX0JJVFM6
CisgICAgICAgIGlmICghbV9mcmFtZWJ1ZmZlckJpbmRpbmcgJiYgIW1fYXR0cmlidXRlcy5hbHBo
YSkKKyAgICAgICAgICAgIHJldHVybiAwOwogICAgICAgICByZXR1cm4gZ2V0SW50UGFyYW1ldGVy
KHBuYW1lKTsKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpBUlJBWV9CVUZGRVJfQklORElO
RzoKICAgICAgICAgcmV0dXJuIG1fYm91bmRBcnJheUJ1ZmZlcjsKZGlmZiAtLWdpdCBhL0xheW91
dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3Ivd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UvY29u
dGV4dC9jb250ZXh0LWF0dHJpYnV0ZXMtYWxwaGEtZGVwdGgtc3RlbmNpbC1hbnRpYWxpYXMtZXhw
ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXNpbXVsYXRvci93ZWJnbC8yLjAu
MC9jb25mb3JtYW5jZS9jb250ZXh0L2NvbnRleHQtYXR0cmlidXRlcy1hbHBoYS1kZXB0aC1zdGVu
Y2lsLWFudGlhbGlhcy1leHBlY3RlZC50eHQKaW5kZXggYWE2N2QyOGZjY2M3ZTdlNTBkNzgwNjU5
M2QxM2QzNzM4NWUyZWUwYi4uNzY1ZDdmZjgzZjkxNzI1NWFmNGEzYWY1YzZhNjY1NTE2NTI3NjE0
OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXNpbXVsYXRvci93ZWJnbC8y
LjAuMC9jb25mb3JtYW5jZS9jb250ZXh0L2NvbnRleHQtYXR0cmlidXRlcy1hbHBoYS1kZXB0aC1z
dGVuY2lsLWFudGlhbGlhcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v
aW9zLXNpbXVsYXRvci93ZWJnbC8yLjAuMC9jb25mb3JtYW5jZS9jb250ZXh0L2NvbnRleHQtYXR0
cmlidXRlcy1hbHBoYS1kZXB0aC1zdGVuY2lsLWFudGlhbGlhcy1leHBlY3RlZC50eHQKQEAgLTE5
LDcgKzE5LDcgQEAgVGVzdDogLi4vLi4vcmVzb3VyY2VzL3dlYmdsX3Rlc3RfZmlsZXMvY29uZm9y
bWFuY2UvY29udGV4dC9jb250ZXh0LWF0dHJpYnV0ZXMtYWwKIFsgMTY6IFBBU1MgXSBzaG91bGQg
YmUgMTI3LDEyNywxMjcsMTI3CiBbIDE3OiBQQVNTIF0gZ2V0RXJyb3Igd2FzIGV4cGVjdGVkIHZh
bHVlOiBOT19FUlJPUiA6IHNob3VsZCBiZSBubyBlcnJvcnMKIFsgMTg6IFBBU1MgXSBnbCA9IGdl
dFdlYkdMKDEsIDEsIHsgYWxwaGE6IGZhbHNlLCBkZXB0aDogZmFsc2UsIHN0ZW5jaWw6IGZhbHNl
LCBhbnRpYWxpYXM6IGZhbHNlIH0sIFsgMCwgMCwgMCwgMCBdLCAxLCAwKSBpcyBub24tbnVsbC4K
LVsgMTk6IEZBSUwgXSBnbC5nZXRQYXJhbWV0ZXIoZ2wuQUxQSEFfQklUUykgPT0gMCBzaG91bGQg
YmUgdHJ1ZS4gV2FzIGZhbHNlLgorWyAxOTogUEFTUyBdIGdsLmdldFBhcmFtZXRlcihnbC5BTFBI
QV9CSVRTKSA9PSAwIGlzIHRydWUKIFsgMjA6IFBBU1MgXSBnbC5nZXRQYXJhbWV0ZXIoZ2wuUkVE
X0JJVFMpID49IDggaXMgdHJ1ZQogWyAyMTogUEFTUyBdIGdsLmdldFBhcmFtZXRlcihnbC5HUkVF
Tl9CSVRTKSA+PSA4IGlzIHRydWUKIFsgMjI6IFBBU1MgXSBnbC5nZXRQYXJhbWV0ZXIoZ2wuQkxV
RV9CSVRTKSA+PSA4IGlzIHRydWUKQEAgLTEwNCw1ICsxMDQsNSBAQCBUZXN0OiAuLi8uLi9yZXNv
dXJjZXMvd2ViZ2xfdGVzdF9maWxlcy9jb25mb3JtYW5jZS9jb250ZXh0L2NvbnRleHQtYXR0cmli
dXRlcy1hbAogWyAxMDE6IFBBU1MgXSByZWRDaGFubmVsc1sxXSA9PSAyNTUgJiYgcmVkQ2hhbm5l
bHNbMl0gPT0gMCBpcyB0cnVlCiBbIDEwMjogUEFTUyBdIHJlZENoYW5uZWxzWzBdICE9IDI1NSAm
JiByZWRDaGFubmVsc1swXSAhPSAwIGlzIGNvbnRleHRBdHRyaWJzLmFudGlhbGlhcwogWyAxMDM6
IFBBU1MgXSBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQotWyBGQUlMIF0gMiBmYWlsdXJlcyBy
ZXBvcnRlZAorWyBGQUlMIF0gMSBmYWlsdXJlcyByZXBvcnRlZAogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>375787</attachid>
            <date>2019-08-08 00:49:52 -0700</date>
            <delta_ts>2019-08-08 16:25:15 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-200499-20190808084950.patch</filename>
            <type>text/plain</type>
            <size>5126</size>
            <attacher name="Chris Lord">clord</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTBkNzIzY2E4MzA1OGUx
MWZhZjEwMDU2YTJmN2M5YTZmMGExY2Q2Ni4uN2RkMTY3Y2YyNTk4OGU3N2M1YTEyMWE5ZDgwYmY4
ODI4MDVjNWJkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA4LTA4ICBDaHJp
cyBMb3JkICA8Y2xvcmRAaWdhbGlhLmNvbT4KKworICAgICAgICBTaG9ydC1jdXQgV2ViR0xSZW5k
ZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIoKSBmb3IgQUxQSEFfQklUUyB3aGVuIGFscGhhIGNo
YW5uZWwgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIwMDQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIHNob3J0Y3V0IHdoZW4gYSBmcmFtZWJ1ZmZlciBp
c24ndCBib3VuZCBvbiBXZWJHTAorICAgICAgICBjYW52YXNlcyB3aGVuIHJldHJpZXZpbmcgQUxQ
SEFfQklUUy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVz
dHMuCisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIpOgor
ICAgICAgICBSZXR1cm4gMCBmb3IgQUxQSEFfQklUUyBpZiBjYW52YXMgaGFzIG5vIGFscGhhIGNv
bXBvbmVudC4KKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNw
cDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0UGFyYW1ldGVy
KToKKyAgICAgICAgUmV0dXJuIDAgZm9yIEFMUEhBX0JJVFMgaWYgY2FudmFzIGhhcyBubyBhbHBo
YSBjb21wb25lbnQuCisKIDIwMTktMDgtMDcgIENocmlzIExvcmQgIDxjbG9yZEBpZ2FsaWEuY29t
PgogCiAgICAgICAgIGNvbnRleHQtYXR0cmlidXRlcy1hbHBoYS1kZXB0aC1zdGVuY2lsLWFudGlh
bGlhcyBmYWlscyBvbiBXUEUgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s
L2NhbnZhcy9XZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv
Y2FudmFzL1dlYkdMMlJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IGE2NmY3ZTg1Njg5ZmM1YzNi
NDc3ZWFkYzZkMjYzMGE4ZDRhZWU3MzMuLjYzMTE5MTc1NzBmMmRiMjg1OTRjYmIzNDkwMjQ2OTk3
YjU4M2ZiZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMMlJl
bmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM
MlJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC0xNzcxLDYgKzE3NzEsOCBAQCBXZWJHTEFueSBXZWJH
TDJSZW5kZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIoR0MzRGVudW0gcG5hbWUpCiAgICAgY2Fz
ZSBHcmFwaGljc0NvbnRleHQzRDo6QUxJQVNFRF9QT0lOVF9TSVpFX1JBTkdFOgogICAgICAgICBy
ZXR1cm4gZ2V0V2ViR0xGbG9hdEFycmF5UGFyYW1ldGVyKHBuYW1lKTsKICAgICBjYXNlIEdyYXBo
aWNzQ29udGV4dDNEOjpBTFBIQV9CSVRTOgorICAgICAgICBpZiAoIW1fZnJhbWVidWZmZXJCaW5k
aW5nICYmICFtX2F0dHJpYnV0ZXMuYWxwaGEpCisgICAgICAgICAgICByZXR1cm4gMDsKICAgICAg
ICAgcmV0dXJuIGdldEludFBhcmFtZXRlcihwbmFtZSk7CiAgICAgY2FzZSBHcmFwaGljc0NvbnRl
eHQzRDo6QVJSQVlfQlVGRkVSX0JJTkRJTkc6CiAgICAgICAgIHJldHVybiBtX2JvdW5kQXJyYXlC
dWZmZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRl
cmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJp
bmdDb250ZXh0LmNwcAppbmRleCBkNjI5ZmJmYjU1ZTA2MmM5MjdjZmVlODMwYTA4ZjRlOTRmYzAw
YWZkLi5lMDZiZjk5ZDU5MTU5NjM5ODBhNjExYzMyYTgzOWUyOTdmMTI4MDQ1IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAK
QEAgLTQyMSw2ICs0MjEsOCBAQCBXZWJHTEFueSBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFBh
cmFtZXRlcihHQzNEZW51bSBwbmFtZSkKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpBTElB
U0VEX1BPSU5UX1NJWkVfUkFOR0U6CiAgICAgICAgIHJldHVybiBnZXRXZWJHTEZsb2F0QXJyYXlQ
YXJhbWV0ZXIocG5hbWUpOwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OkFMUEhBX0JJVFM6
CisgICAgICAgIGlmICghbV9mcmFtZWJ1ZmZlckJpbmRpbmcgJiYgIW1fYXR0cmlidXRlcy5hbHBo
YSkKKyAgICAgICAgICAgIHJldHVybiAwOwogICAgICAgICByZXR1cm4gZ2V0SW50UGFyYW1ldGVy
KHBuYW1lKTsKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpBUlJBWV9CVUZGRVJfQklORElO
RzoKICAgICAgICAgcmV0dXJuIG1fYm91bmRBcnJheUJ1ZmZlcjsKZGlmZiAtLWdpdCBhL0xheW91
dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2NGE0ZTQxOGIy
MjkwOTE1NDMwOWMzNmFmZjlmZWE3OWM4NmExNTBjLi44M2IwMzNkMjNlM2YxY2JjZjc2NWM0Yzkx
N2IwNDRiYWRkODgwYjI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv
TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDgtMDggIENocmlz
IExvcmQgIDxjaHJpc2xvcmQubmV0QGdtYWlsLmNvbT4KKworICAgICAgICBTaG9ydC1jdXQgV2Vi
R0xSZW5kZXJpbmdDb250ZXh0OjpnZXRQYXJhbWV0ZXIoKSBmb3IgQUxQSEFfQklUUyB3aGVuIGFs
cGhhIGNoYW5uZWwgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIwMDQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zLXNpbXVsYXRvci93ZWJnbC8yLjAuMC9jb25m
b3JtYW5jZS9jb250ZXh0L2NvbnRleHQtYXR0cmlidXRlcy1hbHBoYS1kZXB0aC1zdGVuY2lsLWFu
dGlhbGlhcy1leHBlY3RlZC50eHQ6CisgICAgICAgIDEgbW9yZSBwYXNzaW5nIHRlc3QuCisKIDIw
MTktMDgtMDUgIFRha2FzaGkgS29tb3JpICA8VGFrYXNoaS5Lb21vcmlAc29ueS5jb20+CiAKICAg
ICAgICAgW0N1cmxdIGltcGxlbWVudCBDZXJ0aWZpY2F0ZUluZm86OnN1bW1hcnlJbmZvCmRpZmYg
LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yL3dlYmdsLzIuMC4wL2Nv
bmZvcm1hbmNlL2NvbnRleHQvY29udGV4dC1hdHRyaWJ1dGVzLWFscGhhLWRlcHRoLXN0ZW5jaWwt
YW50aWFsaWFzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0
b3Ivd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UvY29udGV4dC9jb250ZXh0LWF0dHJpYnV0ZXMtYWxw
aGEtZGVwdGgtc3RlbmNpbC1hbnRpYWxpYXMtZXhwZWN0ZWQudHh0CmluZGV4IGFhNjdkMjhmY2Nj
N2U3ZTUwZDc4MDY1OTNkMTNkMzczODVlMmVlMGIuLjc2NWQ3ZmY4M2Y5MTcyNTVhZjRhM2FmNWM2
YTY2NTUxNjUyNzYxNDggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11
bGF0b3Ivd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UvY29udGV4dC9jb250ZXh0LWF0dHJpYnV0ZXMt
YWxwaGEtZGVwdGgtc3RlbmNpbC1hbnRpYWxpYXMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRl
c3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3Ivd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UvY29udGV4
dC9jb250ZXh0LWF0dHJpYnV0ZXMtYWxwaGEtZGVwdGgtc3RlbmNpbC1hbnRpYWxpYXMtZXhwZWN0
ZWQudHh0CkBAIC0xOSw3ICsxOSw3IEBAIFRlc3Q6IC4uLy4uL3Jlc291cmNlcy93ZWJnbF90ZXN0
X2ZpbGVzL2NvbmZvcm1hbmNlL2NvbnRleHQvY29udGV4dC1hdHRyaWJ1dGVzLWFsCiBbIDE2OiBQ
QVNTIF0gc2hvdWxkIGJlIDEyNywxMjcsMTI3LDEyNwogWyAxNzogUEFTUyBdIGdldEVycm9yIHdh
cyBleHBlY3RlZCB2YWx1ZTogTk9fRVJST1IgOiBzaG91bGQgYmUgbm8gZXJyb3JzCiBbIDE4OiBQ
QVNTIF0gZ2wgPSBnZXRXZWJHTCgxLCAxLCB7IGFscGhhOiBmYWxzZSwgZGVwdGg6IGZhbHNlLCBz
dGVuY2lsOiBmYWxzZSwgYW50aWFsaWFzOiBmYWxzZSB9LCBbIDAsIDAsIDAsIDAgXSwgMSwgMCkg
aXMgbm9uLW51bGwuCi1bIDE5OiBGQUlMIF0gZ2wuZ2V0UGFyYW1ldGVyKGdsLkFMUEhBX0JJVFMp
ID09IDAgc2hvdWxkIGJlIHRydWUuIFdhcyBmYWxzZS4KK1sgMTk6IFBBU1MgXSBnbC5nZXRQYXJh
bWV0ZXIoZ2wuQUxQSEFfQklUUykgPT0gMCBpcyB0cnVlCiBbIDIwOiBQQVNTIF0gZ2wuZ2V0UGFy
YW1ldGVyKGdsLlJFRF9CSVRTKSA+PSA4IGlzIHRydWUKIFsgMjE6IFBBU1MgXSBnbC5nZXRQYXJh
bWV0ZXIoZ2wuR1JFRU5fQklUUykgPj0gOCBpcyB0cnVlCiBbIDIyOiBQQVNTIF0gZ2wuZ2V0UGFy
YW1ldGVyKGdsLkJMVUVfQklUUykgPj0gOCBpcyB0cnVlCkBAIC0xMDQsNSArMTA0LDUgQEAgVGVz
dDogLi4vLi4vcmVzb3VyY2VzL3dlYmdsX3Rlc3RfZmlsZXMvY29uZm9ybWFuY2UvY29udGV4dC9j
b250ZXh0LWF0dHJpYnV0ZXMtYWwKIFsgMTAxOiBQQVNTIF0gcmVkQ2hhbm5lbHNbMV0gPT0gMjU1
ICYmIHJlZENoYW5uZWxzWzJdID09IDAgaXMgdHJ1ZQogWyAxMDI6IFBBU1MgXSByZWRDaGFubmVs
c1swXSAhPSAyNTUgJiYgcmVkQ2hhbm5lbHNbMF0gIT0gMCBpcyBjb250ZXh0QXR0cmlicy5hbnRp
YWxpYXMKIFsgMTAzOiBQQVNTIF0gc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKLVsgRkFJTCBd
IDIgZmFpbHVyZXMgcmVwb3J0ZWQKK1sgRkFJTCBdIDEgZmFpbHVyZXMgcmVwb3J0ZWQKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>