20049 2008-07-16 01:26:38 -0700 testapi failure: MyObject - 0 should be NaN but instead is 1. 2009-03-21 20:04:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P1 Normal --- 1 ap zwarich sam zwarich oldest_to_newest 86013 0 ap 2008-07-16 01:26:38 -0700 Testapi is reporting a failure with r35197: __FAIL__: MyObject - 0 should be NaN but instead is 1. 86014 1 ap 2008-07-16 01:27:41 -0700 <rdar://problem/6079127> 98189 2 zwarich 2008-11-10 12:16:04 -0800 *** Bug 18037 has been marked as a duplicate of this bug. *** 111125 3 zwarich 2009-02-25 23:48:42 -0800 I think the test result here is correct. In the ECMA spec, subtraction uses ToNumber, not ToPrimitive, but the test file says this, where the second test is the failing test: shouldBe("+MyObject", 1); // toNumber ... shouldBe("MyObject - 0", NaN); // toPrimitive Addition uses ToPrimitive, and the result of the equivalent addition test may be wrong, but that's a different question. 111128 4 28007 zwarich 2009-02-25 23:56:03 -0800 Created attachment 28007 Proposed patch 114673 5 28007 oliver 2009-03-21 19:24:05 -0700 Comment on attachment 28007 Proposed patch r=me, but i'd really like it if we could come up with something that would attempt a toPrimitive conversion -- possibly another custom object? 114676 6 zwarich 2009-03-21 20:04:38 -0700 Fixed in r41896. I agree with your comment, Oliver. 28007 2009-02-25 23:56:03 -0800 2009-03-21 19:24:05 -0700 Proposed patch testapi.diff text/plain 1331 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQxMjQz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDIt MjUgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIwMDQ5OiB0ZXN0YXBp IGZhaWx1cmU6IE15T2JqZWN0IC0gMCBzaG91bGQgYmUgTmFOIGJ1dCBpbnN0ZWFkIGlzIDEuCisg ICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNDk+Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MDc5MTI3PgorCisgICAgICAgIEluIHRoaXMgY2FzZSwg dGhlIHRlc3QgaXMgd3JvbmcuIEFjY29yZGluZyB0byB0aGUgRUNNQSBzcGVjLCBzdWJ0cmFjdGlv bgorICAgICAgICB1c2VzIFRvTnVtYmVyLCBub3QgVG9QcmltaXRpdmUuIENoYW5nZSB0aGUgdGVz dCB0byBtYXRjaCB0aGUgc3BlYy4KKworICAgICAgICAqIEFQSS90ZXN0cy90ZXN0YXBpLmpzOgor CiAyMDA5LTAyLTI1ICBDYW1lcm9uIFp3YXJpY2ggIDxjd3p3YXJpY2hAdXdhdGVybG9vLmNhPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJbmRleDogQVBJL3Rlc3Rz L3Rlc3RhcGkuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gQVBJL3Rlc3RzL3Rlc3RhcGkuanMJKHJldmlzaW9u IDQxMjMzKQorKysgQVBJL3Rlc3RzL3Rlc3RhcGkuanMJKHdvcmtpbmcgY29weSkKQEAgLTEwMCw3 ICsxMDAsNyBAQCBzaG91bGRCZSgiTXlPYmplY3QgPyAxIDogMCIsIHRydWUpOyAvLyB0CiBzaG91 bGRCZSgiK015T2JqZWN0IiwgMSk7IC8vIHRvTnVtYmVyCiBzaG91bGRCZSgiKE15T2JqZWN0LnRv U3RyaW5nKCkpIiwgIltvYmplY3QgTXlPYmplY3RdIik7IC8vIHRvU3RyaW5nCiBzaG91bGRCZSgi U3RyaW5nKE15T2JqZWN0KSIsICJNeU9iamVjdEFzU3RyaW5nIik7IC8vIHR5cGUgY29udmVyc2lv biB0byBzdHJpbmcKLXNob3VsZEJlKCJNeU9iamVjdCAtIDAiLCBOYU4pOyAvLyB0b1ByaW1pdGl2 ZQorc2hvdWxkQmUoIk15T2JqZWN0IC0gMCIsIDEpOyAvLyB0b051bWJlcgogCiBzaG91bGRCZSgi dHlwZW9mIE15Q29uc3RydWN0b3IiLCAib2JqZWN0Iik7CiBjb25zdHJ1Y3RlZE9iamVjdCA9IG5l dyBNeUNvbnN0cnVjdG9yKDEpOwo=