200476 2019-08-06 12:51:36 -0700 Enable XCBuild for `make` builds 2019-08-06 14:58:00 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin ap bfulgham commit-queue jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1558879 0 krollin 2019-08-06 12:51:36 -0700 All projects have now been tested under XCBuild and successfully build. Enable the use of XCBuild when performing builds with `make` and when using a sufficient version of Xcode. We set this version to Xcode 11 since Xcode 10 -- even though it supports XCBuild -- does not support a build facility needed to build WebKit (Bug 197072, Bug 197116, Bug 197340). Do not enable XCBuild in the Xcode projects themselves since these projects may need to be used under older versions of Xcode and there's no way to make those project changes sensitive to the version of Xcode being used. This means that builds performed in the Xcode IDE will not use XCBuild. <rdar://problem/50771065> 1558881 1 375644 krollin 2019-08-06 12:54:22 -0700 Created attachment 375644 Patch 1558885 2 krollin 2019-08-06 12:56:19 -0700 This change also supports XCBuild with build-webkit. I'll update the patch to note that. 1558888 3 375645 krollin 2019-08-06 12:57:29 -0700 Created attachment 375645 Patch 1558890 4 jbedard 2019-08-06 13:00:01 -0700 (In reply to Keith Rollin from comment #0) > All projects have now been tested under XCBuild and successfully build. > Enable the use of XCBuild when performing builds with `make` and when using > a sufficient version of Xcode. We set this version to Xcode 11 since Xcode > 10 -- even though it supports XCBuild -- does not support a build facility > needed to build WebKit (Bug 197072, Bug 197116, Bug 197340). > > Do not enable XCBuild in the Xcode projects themselves since these projects > may need to be used under older versions of Xcode and there's no way to make > those project changes sensitive to the version of Xcode being used. This > means that builds performed in the Xcode IDE will not use XCBuild. > > <rdar://problem/50771065> Which versions of Xcode don't have XCBuild, at this point? 1558893 5 krollin 2019-08-06 13:06:54 -0700 Xcode 8 does not support XCBuild. Xcode 9 supports XCBuild, but there were some bugs. Xcode 10 supports XCBuild, but doesn't have the new feature we require. 1558936 6 375645 commit-queue 2019-08-06 14:57:59 -0700 Comment on attachment 375645 Patch Clearing flags on attachment: 375645 Committed r248317: <https://trac.webkit.org/changeset/248317> 1558937 7 commit-queue 2019-08-06 14:58:00 -0700 All reviewed patches have been landed. Closing bug. 375644 2019-08-06 12:54:22 -0700 2019-08-06 12:57:28 -0700 Patch bug-200476-20190806125421.patch text/plain 1875 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MjcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTcxMDA2MjZjNWY0MGQzOTdmNjg3OWNlODlmZjc5MmQz ZTcyOTFhNC4uNmVkNzA1ZmFlYjU0OGJjZjE1ZGZlOTMxYzM4OTdmYzljYWNkZmJkOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDE5LTA4LTA2ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAg ICAgICBFbmFibGUgWENCdWlsZCBmb3IgYG1ha2VgIGJ1aWxkcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwNDc2CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81MDc3MTA2NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBbGwgcHJvamVjdHMgaGF2ZSBub3cgYmVlbiB0ZXN0ZWQgdW5kZXIgWENCdWlsZCBh bmQgc3VjY2Vzc2Z1bGx5CisgICAgICAgIGJ1aWxkLiBFbmFibGUgdGhlIHVzZSBvZiBYQ0J1aWxk IHdoZW4gcGVyZm9ybWluZyBidWlsZHMgd2l0aCBgbWFrZWAKKyAgICAgICAgYW5kIHdoZW4gdXNp bmcgYSBzdWZmaWNpZW50IHZlcnNpb24gb2YgWGNvZGUuIFdlIHNldCB0aGlzIHZlcnNpb24gdG8K KyAgICAgICAgWGNvZGUgMTEgc2luY2UgWGNvZGUgMTAgLS0gZXZlbiB0aG91Z2ggaXQgc3VwcG9y dHMgWENCdWlsZCAtLSBkb2VzIG5vdAorICAgICAgICBzdXBwb3J0IGEgYnVpbGQgZmFjaWxpdHkg bmVlZGVkIHRvIGJ1aWxkIFdlYktpdCAoQnVnIDE5NzA3MiwgQnVnCisgICAgICAgIDE5NzExNiwg QnVnIDE5NzM0MCkuCisKKyAgICAgICAgRG8gbm90IGVuYWJsZSBYQ0J1aWxkIGluIHRoZSBYY29k ZSBwcm9qZWN0cyB0aGVtc2VsdmVzIHNpbmNlIHRoZXNlCisgICAgICAgIHByb2plY3RzIG1heSBu ZWVkIHRvIGJlIHVzZWQgdW5kZXIgb2xkZXIgdmVyc2lvbnMgb2YgWGNvZGUgYW5kIHRoZXJlJ3MK KyAgICAgICAgbm8gd2F5IHRvIG1ha2UgdGhvc2UgcHJvamVjdCBjaGFuZ2VzIHNlbnNpdGl2ZSB0 byB0aGUgdmVyc2lvbiBvZiBYY29kZQorICAgICAgICBiZWluZyB1c2VkLiBUaGlzIG1lYW5zIHRo YXQgYnVpbGRzIHBlcmZvcm1lZCBpbiB0aGUgWGNvZGUgSURFIHdpbGwgbm90CisgICAgICAgIHVz ZSBYQ0J1aWxkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAo Y2FuVXNlWENCdWlsZCk6CisKIDIwMTktMDgtMDUgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRA YXBwbGUuY29tPgogCiAgICAgICAgIHJ1bi13ZWJraXQtdGVzdHMgYXNzZXJ0cyB3aGVuIHRoZSBp UGhvbmUgWFIgc2ltdWxhdG9yIGlzIHJ1bm5pbmcKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBkY2ZhODFm NzJlYWUzMjJjZGM5YTBhOTI4MjJmMzI0YzA4NjljMWFiLi5hZDRmZmYyYWVhODcyODM2Y2UxOTUy NjNmODczNmZiYjY0YWI0MThhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC05MDMsNiArOTAzLDEwIEBA IHN1YiBYY29kZVN0YXRpY0FuYWx5emVyT3B0aW9uKCkKIAogc3ViIGNhblVzZVhDQnVpbGQoKQog eworICAgIGlmIChgeGNvZGVidWlsZCAtdmVyc2lvbiB8IGdyZXAgIkJ1aWxkIHZlcnNpb24iYCA9 fiAvQnVpbGQgdmVyc2lvbiAoXGQrKShbYS16QS1aXSkoXGQrKShbYS16QS1aXT8pLykgeworICAg ICAgICByZXR1cm4gJDEgPj0gMTE7CisgICAgfQorCiAgICAgcmV0dXJuIDA7CiB9CiAK 375645 2019-08-06 12:57:29 -0700 2019-08-06 14:57:59 -0700 Patch bug-200476-20190806125728.patch text/plain 1912 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MjcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTcxMDA2MjZjNWY0MGQzOTdmNjg3OWNlODlmZjc5MmQz ZTcyOTFhNC4uMmZhMmYxNWFkNmQxNjBlYTE5N2EzZTg4NjJhMDcwODczYjVmNTYwZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDE5LTA4LTA2ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAg ICAgICBFbmFibGUgWENCdWlsZCBmb3IgYG1ha2VgIGFuZCBgYnVpbGQtd2Via2l0YCBidWlsZHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDQ3Ngor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTA3NzEwNjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsIHByb2plY3RzIGhhdmUgbm93IGJlZW4gdGVz dGVkIHVuZGVyIFhDQnVpbGQgYW5kIHN1Y2Nlc3NmdWxseQorICAgICAgICBidWlsZC4gRW5hYmxl IHRoZSB1c2Ugb2YgWENCdWlsZCB3aGVuIHBlcmZvcm1pbmcgYnVpbGRzIHdpdGggYG1ha2VgIG9y CisgICAgICAgIGBidWlsZC13ZWJraXRgIGFuZCB3aGVuIHVzaW5nIGEgc3VmZmljaWVudCB2ZXJz aW9uIG9mIFhjb2RlLiBXZSBzZXQKKyAgICAgICAgdGhpcyB2ZXJzaW9uIHRvIFhjb2RlIDExIHNp bmNlIFhjb2RlIDEwIC0tIGV2ZW4gdGhvdWdoIGl0IHN1cHBvcnRzCisgICAgICAgIFhDQnVpbGQg LS0gZG9lcyBub3Qgc3VwcG9ydCBhIGJ1aWxkIGZhY2lsaXR5IG5lZWRlZCB0byBidWlsZCBXZWJL aXQKKyAgICAgICAgKEJ1ZyAxOTcwNzIsIEJ1ZyAxOTcxMTYsIEJ1ZyAxOTczNDApLgorCisgICAg ICAgIERvIG5vdCBlbmFibGUgWENCdWlsZCBpbiB0aGUgWGNvZGUgcHJvamVjdHMgdGhlbXNlbHZl cyBzaW5jZSB0aGVzZQorICAgICAgICBwcm9qZWN0cyBtYXkgbmVlZCB0byBiZSB1c2VkIHVuZGVy IG9sZGVyIHZlcnNpb25zIG9mIFhjb2RlIGFuZCB0aGVyZSdzCisgICAgICAgIG5vIHdheSB0byBt YWtlIHRob3NlIHByb2plY3QgY2hhbmdlcyBzZW5zaXRpdmUgdG8gdGhlIHZlcnNpb24gb2YgWGNv ZGUKKyAgICAgICAgYmVpbmcgdXNlZC4gVGhpcyBtZWFucyB0aGF0IGJ1aWxkcyBwZXJmb3JtZWQg aW4gdGhlIFhjb2RlIElERSB3aWxsIG5vdAorICAgICAgICB1c2UgWENCdWlsZC4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGNhblVzZVhDQnVpbGQpOgorCiAy MDE5LTA4LTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAg ICBydW4td2Via2l0LXRlc3RzIGFzc2VydHMgd2hlbiB0aGUgaVBob25lIFhSIHNpbXVsYXRvciBp cyBydW5uaW5nCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZGNmYTgxZjcyZWFlMzIyY2RjOWEwYTkyODIy ZjMyNGMwODY5YzFhYi4uYWQ0ZmZmMmFlYTg3MjgzNmNlMTk1MjYzZjg3MzZmYmI2NGFiNDE4YSAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQpAQCAtOTAzLDYgKzkwMywxMCBAQCBzdWIgWGNvZGVTdGF0aWNBbmFs eXplck9wdGlvbigpCiAKIHN1YiBjYW5Vc2VYQ0J1aWxkKCkKIHsKKyAgICBpZiAoYHhjb2RlYnVp bGQgLXZlcnNpb24gfCBncmVwICJCdWlsZCB2ZXJzaW9uImAgPX4gL0J1aWxkIHZlcnNpb24gKFxk KykoW2EtekEtWl0pKFxkKykoW2EtekEtWl0/KS8pIHsKKyAgICAgICAgcmV0dXJuICQxID49IDEx OworICAgIH0KKwogICAgIHJldHVybiAwOwogfQogCg==