200467 2019-08-06 05:18:33 -0700 Add release assert against InvalidationRuleSet mutation during invalidation 2019-08-06 09:19:24 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned cdumez commit-queue webkit-bug-importer oldest_to_newest 1558758 0 koivisto 2019-08-06 05:18:33 -0700 There have been some rare nullptr crashes here. 1558759 1 375619 koivisto 2019-08-06 05:26:25 -0700 Created attachment 375619 patch 1558769 2 375619 cdumez 2019-08-06 08:11:52 -0700 Comment on attachment 375619 patch View in context: https://bugs.webkit.org/attachment.cgi?id=375619&action=review > Source/WebCore/css/DocumentRuleSets.h:79 > + static bool s_isInvalidatingStyleWithRuleSets; I am unclear why it is OK for this to be a static. I do not think DocumentRuleSets are process-global, are they? 1558771 3 koivisto 2019-08-06 08:22:22 -0700 > I am unclear why it is OK for this to be a static. I do not think > DocumentRuleSets are process-global, are they? Invalidation affecting some other random DocumentRuleSets would be equally bad, this covers that case too. 1558772 4 375619 cdumez 2019-08-06 08:27:49 -0700 Comment on attachment 375619 patch Ok then. 1558784 5 375619 commit-queue 2019-08-06 09:18:11 -0700 Comment on attachment 375619 patch Clearing flags on attachment: 375619 Committed r248297: <https://trac.webkit.org/changeset/248297> 1558785 6 commit-queue 2019-08-06 09:18:13 -0700 All reviewed patches have been landed. Closing bug. 1558786 7 webkit-bug-importer 2019-08-06 09:19:24 -0700 <rdar://problem/53988679> 375619 2019-08-06 05:26:25 -0700 2019-08-06 09:18:11 -0700 patch class-invalidation-crash-assert.patch text/plain 4660 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0ODI5MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA4LTA2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgcmVsZWFzZSBhc3NlcnQg YWdhaW5zdCBJbnZhbGlkYXRpb25SdWxlU2V0IG11dGF0aW9uIGR1cmluZyBpbnZhbGlkYXRpb24K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDQ2Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRyeSB0byBn ZXQgYSBtb3JlIGluZm9ybWF0aXZlIHN0YWNrIGZvciByZGFyOi8vcHJvYmxlbS81MzQxMzAxMwor CisgICAgICAgICogY3NzL0RvY3VtZW50UnVsZVNldHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RG9jdW1lbnRSdWxlU2V0czo6fkRvY3VtZW50UnVsZVNldHMpOgorICAgICAgICAoV2ViQ29yZTo6 RG9jdW1lbnRSdWxlU2V0czo6Y29sbGVjdEZlYXR1cmVzIGNvbnN0KToKKyAgICAgICAgKiBjc3Mv RG9jdW1lbnRSdWxlU2V0cy5oOgorICAgICAgICAqIHN0eWxlL0F0dHJpYnV0ZUNoYW5nZUludmFs aWRhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZTo6QXR0cmlidXRlQ2hhbmdlSW52 YWxpZGF0aW9uOjppbnZhbGlkYXRlU3R5bGVXaXRoUnVsZVNldHMpOgorICAgICAgICAqIHN0eWxl L0NsYXNzQ2hhbmdlSW52YWxpZGF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlOjpD bGFzc0NoYW5nZUludmFsaWRhdGlvbjo6aW52YWxpZGF0ZVN0eWxlV2l0aFJ1bGVTZXRzKToKKwog MjAxOS0wOC0wNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtM RkNdIFJlbW92ZSBvdXQtb2YtZmxvdyBkZXNjZW5kYW50cyBmcm9tIENvbnRhaW5lcgpJbmRleDog U291cmNlL1dlYkNvcmUvY3NzL0RvY3VtZW50UnVsZVNldHMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2Nzcy9Eb2N1bWVudFJ1bGVTZXRzLmNwcAkocmV2aXNpb24gMjQ4MjcwKQor KysgU291cmNlL1dlYkNvcmUvY3NzL0RvY3VtZW50UnVsZVNldHMuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNyw2ICszNyw5IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorLy8gRm9yIGNhdGNo aW5nIDxyZGFyOi8vcHJvYmxlbS81MzQxMzAxMz4KK2Jvb2wgRG9jdW1lbnRSdWxlU2V0czo6c19p c0ludmFsaWRhdGluZ1N0eWxlV2l0aFJ1bGVTZXRzIHsgZmFsc2UgfTsKKwogRG9jdW1lbnRSdWxl U2V0czo6RG9jdW1lbnRSdWxlU2V0cyhTdHlsZVJlc29sdmVyJiBzdHlsZVJlc29sdmVyKQogICAg IDogbV9zdHlsZVJlc29sdmVyKHN0eWxlUmVzb2x2ZXIpCiB7CkBAIC00NCw3ICs0NywxMCBAQCBE b2N1bWVudFJ1bGVTZXRzOjpEb2N1bWVudFJ1bGVTZXRzKFN0eWxlCiAgICAgbV9hdXRob3JTdHls ZS0+ZGlzYWJsZUF1dG9TaHJpbmtUb0ZpdCgpOwogfQogCi1Eb2N1bWVudFJ1bGVTZXRzOjp+RG9j dW1lbnRSdWxlU2V0cygpID0gZGVmYXVsdDsKK0RvY3VtZW50UnVsZVNldHM6On5Eb2N1bWVudFJ1 bGVTZXRzKCkKK3sKKyAgICBSRUxFQVNFX0FTU0VSVCghc19pc0ludmFsaWRhdGluZ1N0eWxlV2l0 aFJ1bGVTZXRzKTsKK30KIAogUnVsZVNldCogRG9jdW1lbnRSdWxlU2V0czo6dXNlckFnZW50TWVk aWFRdWVyeVN0eWxlKCkgY29uc3QKIHsKQEAgLTE0OCw2ICsxNTQsOCBAQCB2b2lkIERvY3VtZW50 UnVsZVNldHM6OmFwcGVuZEF1dGhvclN0eWxlCiAKIHZvaWQgRG9jdW1lbnRSdWxlU2V0czo6Y29s bGVjdEZlYXR1cmVzKCkgY29uc3QKIHsKKyAgICBSRUxFQVNFX0FTU0VSVCghc19pc0ludmFsaWRh dGluZ1N0eWxlV2l0aFJ1bGVTZXRzKTsKKwogICAgIG1fZmVhdHVyZXMuY2xlYXIoKTsKICAgICAv LyBDb2xsZWN0IGFsbCBpZHMgYW5kIHJ1bGVzIHVzaW5nIHNpYmxpbmcgc2VsZWN0b3JzICg6Zmly c3QtY2hpbGQgYW5kIHNpbWlsYXIpCiAgICAgLy8gaW4gdGhlIGN1cnJlbnQgc2V0IG9mIHN0eWxl c2hlZXRzLiBTdHlsZSBzaGFyaW5nIGNvZGUgdXNlcyB0aGlzIGluZm9ybWF0aW9uIHRvIHJlamVj dApJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0RvY3VtZW50UnVsZVNldHMuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvRG9jdW1lbnRSdWxlU2V0cy5oCShyZXZpc2lvbiAyNDgy NzApCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvRG9jdW1lbnRSdWxlU2V0cy5oCSh3b3JraW5nIGNv cHkpCkBAIC03Niw2ICs3Niw4IEBAIHB1YmxpYzoKIAogICAgIFJ1bGVGZWF0dXJlU2V0JiBtdXRh YmxlRmVhdHVyZXMoKTsKIAorICAgIHN0YXRpYyBib29sIHNfaXNJbnZhbGlkYXRpbmdTdHlsZVdp dGhSdWxlU2V0czsKKwogcHJpdmF0ZToKICAgICB2b2lkIGNvbGxlY3RGZWF0dXJlcygpIGNvbnN0 OwogICAgIHZvaWQgY29sbGVjdFJ1bGVzRnJvbVVzZXJTdHlsZVNoZWV0cyhjb25zdCBWZWN0b3I8 UmVmUHRyPENTU1N0eWxlU2hlZXQ+PiYsIFJ1bGVTZXQmIHVzZXJTdHlsZSwgY29uc3QgTWVkaWFR dWVyeUV2YWx1YXRvciYsIFN0eWxlUmVzb2x2ZXImKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N0 eWxlL0F0dHJpYnV0ZUNoYW5nZUludmFsaWRhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvc3R5bGUvQXR0cmlidXRlQ2hhbmdlSW52YWxpZGF0aW9uLmNwcAkocmV2aXNpb24g MjQ4MjcwKQorKysgU291cmNlL1dlYkNvcmUvc3R5bGUvQXR0cmlidXRlQ2hhbmdlSW52YWxpZGF0 aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksNyBAQAogI2luY2x1ZGUgIkVsZW1l bnRJdGVyYXRvci5oIgogI2luY2x1ZGUgIlN0eWxlSW52YWxpZGF0aW9uRnVuY3Rpb25zLmgiCiAj aW5jbHVkZSAiU3R5bGVJbnZhbGlkYXRvci5oIgorI2luY2x1ZGUgPHd0Zi9TZXRGb3JTY29wZS5o PgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiBuYW1lc3BhY2UgU3R5bGUgewpAQCAtODgsNiArODks OCBAQCB2b2lkIEF0dHJpYnV0ZUNoYW5nZUludmFsaWRhdGlvbjo6aW52YWxpCiAKIHZvaWQgQXR0 cmlidXRlQ2hhbmdlSW52YWxpZGF0aW9uOjppbnZhbGlkYXRlU3R5bGVXaXRoUnVsZVNldHMoKQog eworICAgIFNldEZvclNjb3BlPGJvb2w+IGlzSW52YWxpZGF0aW5nKERvY3VtZW50UnVsZVNldHM6 OnNfaXNJbnZhbGlkYXRpbmdTdHlsZVdpdGhSdWxlU2V0cywgdHJ1ZSk7CisKICAgICBmb3IgKGF1 dG8qIGludmFsaWRhdGlvblJ1bGVTZXQgOiBtX2ludmFsaWRhdGlvblJ1bGVTZXRzKSB7CiAgICAg ICAgIEludmFsaWRhdG9yIGludmFsaWRhdG9yKCppbnZhbGlkYXRpb25SdWxlU2V0LT5ydWxlU2V0 KTsKICAgICAgICAgaW52YWxpZGF0b3IuaW52YWxpZGF0ZVN0eWxlV2l0aE1hdGNoRWxlbWVudCht X2VsZW1lbnQsIGludmFsaWRhdGlvblJ1bGVTZXQtPm1hdGNoRWxlbWVudCk7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9zdHlsZS9DbGFzc0NoYW5nZUludmFsaWRhdGlvbi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvc3R5bGUvQ2xhc3NDaGFuZ2VJbnZhbGlkYXRpb24uY3BwCShyZXZp c2lvbiAyNDgyNzApCisrKyBTb3VyY2UvV2ViQ29yZS9zdHlsZS9DbGFzc0NoYW5nZUludmFsaWRh dGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJTdHls ZUludmFsaWRhdGlvbkZ1bmN0aW9ucy5oIgogI2luY2x1ZGUgIlN0eWxlSW52YWxpZGF0b3IuaCIK ICNpbmNsdWRlIDx3dGYvQml0VmVjdG9yLmg+CisjaW5jbHVkZSA8d3RmL1NldEZvclNjb3BlLmg+ CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIG5hbWVzcGFjZSBTdHlsZSB7CkBAIC0xMTksNiArMTIw LDggQEAgdm9pZCBDbGFzc0NoYW5nZUludmFsaWRhdGlvbjo6Y29tcHV0ZUludgogCiB2b2lkIENs YXNzQ2hhbmdlSW52YWxpZGF0aW9uOjppbnZhbGlkYXRlU3R5bGVXaXRoUnVsZVNldHMoKQogewor ICAgIFNldEZvclNjb3BlPGJvb2w+IGlzSW52YWxpZGF0aW5nKERvY3VtZW50UnVsZVNldHM6OnNf aXNJbnZhbGlkYXRpbmdTdHlsZVdpdGhSdWxlU2V0cywgdHJ1ZSk7CisKICAgICBmb3IgKGF1dG8q IGludmFsaWRhdGlvblJ1bGVTZXQgOiBtX2ludmFsaWRhdGlvblJ1bGVTZXRzKSB7CiAgICAgICAg IEludmFsaWRhdG9yIGludmFsaWRhdG9yKCppbnZhbGlkYXRpb25SdWxlU2V0LT5ydWxlU2V0KTsK ICAgICAgICAgaW52YWxpZGF0b3IuaW52YWxpZGF0ZVN0eWxlV2l0aE1hdGNoRWxlbWVudChtX2Vs ZW1lbnQsIGludmFsaWRhdGlvblJ1bGVTZXQtPm1hdGNoRWxlbWVudCk7Cg==