200466 2019-08-06 03:33:59 -0700 REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad 2019-08-06 14:46:00 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue ggaren zalan oldest_to_newest 1558753 0 koivisto 2019-08-06 03:33:59 -0700 The page calls preventDefault() for a mouse event generated by site specific quirk. 1558754 1 koivisto 2019-08-06 03:42:06 -0700 <rdar://problem/52571754> 1558755 2 375616 koivisto 2019-08-06 03:43:41 -0700 Created attachment 375616 patch 1558776 3 375616 commit-queue 2019-08-06 08:37:34 -0700 Comment on attachment 375616 patch Clearing flags on attachment: 375616 Committed r248295: <https://trac.webkit.org/changeset/248295> 1558777 4 commit-queue 2019-08-06 08:37:36 -0700 All reviewed patches have been landed. Closing bug. 1558838 5 375616 zalan 2019-08-06 11:07:33 -0700 Comment on attachment 375616 patch View in context: https://bugs.webkit.org/attachment.cgi?id=375616&action=review > Source/WebCore/page/Quirks.cpp:303 > + // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events. SimulatedMouseEventsDispatchPolicy should definitely be Deny on mobile pages for example when the user explicitly asks for the mobile version. 1558839 6 375616 ggaren 2019-08-06 11:13:16 -0700 Comment on attachment 375616 patch View in context: https://bugs.webkit.org/attachment.cgi?id=375616&action=review >> Source/WebCore/page/Quirks.cpp:303 >> + // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events. > > SimulatedMouseEventsDispatchPolicy should definitely be Deny on mobile pages for example when the user explicitly asks for the mobile version. My understanding is that we only set WebsiteSimulatedMouseEventsDispatchPolicy::Allow when in desktop mode. (See WebPageProxy::effectiveContentModeAfterAdjustingPolicies.) I wonder how we ended up in desktop mode at all on an m. site. 1558892 7 koivisto 2019-08-06 13:04:02 -0700 If you go to m.naver.com (or any URL) on iPad it will be loaded by default in desktop mode. Or do we have heuristics somewhere that should figure out it is a mobile site? 1558894 8 koivisto 2019-08-06 13:13:11 -0700 If you go to the top naver.com you get redirected to the m. subdomain only in mobile mode. However there is no automatic redirect back to the main site in desktop mode. If you for example have an existing bookmark it will probably point to the m. site. 1558931 9 ggaren 2019-08-06 14:45:40 -0700 (In reply to Antti Koivisto from comment #7) > If you go to m.naver.com (or any URL) on iPad it will be loaded by default > in desktop mode. Or do we have heuristics somewhere that should figure out > it is a mobile site? Always desktop mode, modulo a short list of exceptions. 1558933 10 ggaren 2019-08-06 14:46:00 -0700 (In reply to Antti Koivisto from comment #8) > If you go to the top naver.com you get redirected to the m. subdomain only > in mobile mode. However there is no automatic redirect back to the main site > in desktop mode. If you for example have an existing bookmark it will > probably point to the m. site. Makes sense. 375616 2019-08-06 03:43:41 -0700 2019-08-06 08:37:34 -0700 patch mobile-quirk-disable-naver.patch text/plain 2034 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0ODI5MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA4LTA2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBDYW5ub3Qg dGFwIG9uIGFueSBidXR0b25zIG9uIG0ubmF2ZXIuY29tIGhvbWUgc2NyZWVuIG9uIGlQYWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDQ2NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwYWdlIGNh bGxzIHByZXZlbnREZWZhdWx0KCkgZm9yIGEgbW91c2UgZXZlbnQgZ2VuZXJhdGVkIGJ5IGEgc2l0 ZSBzcGVjaWZpYyBxdWlyay4KKworICAgICAgICAqIHBhZ2UvUXVpcmtzLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlF1aXJrczo6c2hvdWxkRGlzcGF0Y2hTaW11bGF0ZWRNb3VzZUV2ZW50cyBjb25z dCk6CisKKyAgICAgICAgRGlzYWJsZSB0aGUgcXVpcmsgZm9yIHRoZSAibS4iIHN1YmRvbWFpbi4g VGhpcyBpcyBhIG1vYmlsZSBzaXRlIHRoYXQgZG9uJ3QgbmVlZCBvciBleHBlY3QgdGhlbS4KKwog MjAxOS0wOC0wNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtM RkNdIFJlbW92ZSBvdXQtb2YtZmxvdyBkZXNjZW5kYW50cyBmcm9tIENvbnRhaW5lcgpJbmRleDog U291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BhZ2UvUXVpcmtzLmNwcAkocmV2aXNpb24gMjQ4MjcwKQorKysgU291cmNlL1dlYkNvcmUv cGFnZS9RdWlya3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTUsOSArMjk1LDE2IEBAIGJvb2wg UXVpcmtzOjpzaG91bGREaXNwYXRjaFNpbXVsYXRlZE1vdXMKICAgICAgICAgcmV0dXJuIHRydWU7 CiAgICAgaWYgKGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJuYXZlci5jb20i KSkKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgLy8gRGlzYWJsZSB0aGUgcXVpcmsgZm9yIHR2 Lm5hdmVyLmNvbSBzdWJkb21haW4gdG8gYmUgYWJsZSB0byBzaW11bGF0ZSBob3ZlciBvbiB2aWRl b3MuCi0gICAgaWYgKGhvc3QuZW5kc1dpdGhJZ25vcmluZ0FTQ0lJQ2FzZSgiLm5hdmVyLmNvbSIp KQotICAgICAgICByZXR1cm4gIWVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKGhvc3QsICJ0 di5uYXZlci5jb20iKTsKKyAgICBpZiAoaG9zdC5lbmRzV2l0aElnbm9yaW5nQVNDSUlDYXNlKCIu bmF2ZXIuY29tIikpIHsKKyAgICAgICAgLy8gRGlzYWJsZSB0aGUgcXVpcmsgZm9yIHR2Lm5hdmVy LmNvbSBzdWJkb21haW4gdG8gYmUgYWJsZSB0byBzaW11bGF0ZSBob3ZlciBvbiB2aWRlb3MuCisg ICAgICAgIGlmIChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShob3N0LCAidHYubmF2ZXIu Y29tIikpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIC8vIERpc2FibGUgdGhl IHF1aXJrIG9uIHRoZSBtb2JpbGUgc2l0ZS4KKyAgICAgICAgLy8gRklYTUU6IE1heWJlIHRoaXMg cXVpcmsgc2hvdWxkIGJlIGRpc2FibGVkIGZvciAibS4iIHN1YmRvbWFpbnMgb24gYWxsIHNpdGVz PyBUaGVzZSBhcmUgZ2VuZXJhbGx5IG1vYmlsZSBzaXRlcyB0aGF0IGRvbid0IG5lZWQgbW91c2Ug ZXZlbnRzLgorICAgICAgICBpZiAoZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwg Im0ubmF2ZXIuY29tIikpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIHJldHVy biB0cnVlOworICAgIH0KICAgICByZXR1cm4gZmFsc2U7CiB9CiAK