200465 2019-08-05 23:25:53 -0700 ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used 2019-08-06 18:48:45 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199848 InRadar P2 Normal --- 1 fujii fujii achristensen don.olmstead ross.kirsling webkit-bug-importer oldest_to_newest 1558728 0 fujii 2019-08-05 23:25:53 -0700 [WebKit] ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used After Bug 199848, An assertion always fails when terminating WebView if WKPageSetPageStateClient is used. ASSERTION FAILED: m_observers.isEmpty() ..\..\Source\WebKit\UIProcess/PageLoadState.cpp(45) : ~PageLoadState > WTF.dll!WTFCrash() Line 305 C++ > WebKit2.dll!WTFCrashWithInfo(int, const char *, const char *, int) Line 568 C++ > WebKit2.dll!WebKit::PageLoadState::~PageLoadState() Line 45 C++ > WebKit2.dll!WebKit::WebPageProxy::~WebPageProxy() Line 517 C++ > WebKit2.dll!WebKit::WebPageProxy::~WebPageProxy() Line 494 C++ > WebKit2.dll!WTF::ThreadSafeRefCounted<API::Object,WTF::DestructionThread::Any>::deref::<unnamed-tag>::operator()() Line 77 C++ > WebKit2.dll!WTF::ThreadSafeRefCounted<API::Object,WTF::DestructionThread::Any>::deref() Line 96 C++ > WebKit2.dll!WTF::derefIfNotNull<WebKit::WebPageProxy>(WebKit::WebPageProxy * ptr) Line 45 C++ > WebKit2.dll!WTF::RefPtr<WebKit::WebPageProxy,WTF::DumbPtrTraits<WebKit::WebPageProxy> >::~RefPtr() Line 69 C++ > WebKit2.dll!WebKit::WebView::~WebView() Line 257 C++ > WebKit2.dll!WebKit::WebView::~WebView() Line 253 C++ > WebKit2.dll!WTF::ThreadSafeRefCounted<API::Object,WTF::DestructionThread::Any>::deref::<unnamed-tag>::operator()() Line 77 C++ > WebKit2.dll!WTF::ThreadSafeRefCounted<API::Object,WTF::DestructionThread::Any>::deref() Line 96 C++ > WebKit2.dll!WKRelease(const void * typeRef) Line 47 C++ > MiniBrowserLib.dll!WebKit::WKRetainPtr<const OpaqueWKView *>::~WKRetainPtr() Line 82 C++ > MiniBrowserLib.dll!WebKitBrowserWindow::~WebKitBrowserWindow() Line 34 C++ > MiniBrowserLib.dll!WebKitBrowserWindow::~WebKitBrowserWindow() Line 34 C++ > MiniBrowserLib.dll!WTF::RefCounted<BrowserWindow>::deref() Line 145 C++ > MiniBrowserLib.dll!WTF::derefIfNotNull<BrowserWindow>(BrowserWindow * ptr) Line 45 C++ > MiniBrowserLib.dll!WTF::RefPtr<BrowserWindow,WTF::DumbPtrTraits<BrowserWindow> >::~RefPtr() Line 69 C++ > MiniBrowserLib.dll!MainWindow::~MainWindow() Line 95 C++ > MiniBrowserLib.dll!WTF::RefCounted<MainWindow>::deref() Line 145 C++ > MiniBrowserLib.dll!WTF::derefIfNotNull<MainWindow>(MainWindow * ptr) Line 45 C++ > MiniBrowserLib.dll!WTF::RefPtr<MainWindow,WTF::DumbPtrTraits<MainWindow> >::~RefPtr() Line 69 C++ > MiniBrowserLib.dll!MainWindow::WndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 270 C++ > [External Code] > WebKit2.dll!WebCore::WindowMessageBroadcaster::SubclassedWndProc(HWND__ * hwnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 123 C++ > [External Code] > WebKit.dll!WebKitMessageLoop::run(HACCEL__ * hAccelTable) Line 94 C++ > MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 97 C++ > MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 115 C++ > MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpstrCmdLine, int nCmdShow) Line 232 C++ > [External Code] 1558743 1 375611 fujii 2019-08-06 00:22:35 -0700 Created attachment 375611 Patch 1559030 2 375611 fujii 2019-08-06 18:45:29 -0700 Comment on attachment 375611 Patch Clearing flags on attachment: 375611 Committed r248336: <https://trac.webkit.org/changeset/248336> 1559031 3 fujii 2019-08-06 18:45:32 -0700 All reviewed patches have been landed. Closing bug. 1559032 4 webkit-bug-importer 2019-08-06 18:48:45 -0700 <rdar://problem/54014523> 375611 2019-08-06 00:22:35 -0700 2019-08-06 18:45:29 -0700 Patch bug-200465-20190806162234.patch text/plain 3275 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4Mjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZmZmM0NzcyOTAxNjUxMDZh MGVhMzkzNjllYjdiOGVjNjI1NGI5YTIuLmRhMDk0YWRjODU5NzMyYjVhMGIzMTUwMGQ1ZmExNWJj MDMyODdhN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDgtMDYgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZB SUxFRDogbV9vYnNlcnZlcnMuaXNFbXB0eSgpIGlmIFdLUGFnZVNldFBhZ2VTdGF0ZUNsaWVudCBp cyB1c2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDA0NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ YWdlTG9hZFN0YXRlOjpPYnNlcnZlciBzaG91bGQgYmUgcmVtb3ZlZCBiZWZvcmUgZGVzdHJ1Y3Rp bmcKKyAgICAgICAgV2ViUGFnZVByb3h5LgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6fldlYlBhZ2VQcm94eSk6 IENhbGwKKyAgICAgICAgc2V0UGFnZUxvYWRTdGF0ZU9ic2VydmVyIHdpdGggbnVsbHB0ciB0byBy ZW1vdmUKKyAgICAgICAgUGFnZUxvYWRTdGF0ZTo6T2JzZXJ2ZXIuCisKIDIwMTktMDgtMDUgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQgUlRDUnRw U2VuZGVyLmR0bWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4 IDY2MDlhZTFlZDgxNDhlNDA3OWM5N2ZmZWIwNTkyZDc5MWZmNzFhZTkuLjgyZWIyYWM1NjUxMTRl YjYxZmQ5NTI0ZmQ2NmM0NzNlYzRiMGVmZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcApAQCAtNTAwLDYgKzUwMCw4IEBAIFdlYlBhZ2VQcm94eTo6fldlYlBhZ2VQ cm94eSgpCiAgICAgICAgIEFTU0VSVChwYWdlICE9IHRoaXMpOwogI2VuZGlmCiAKKyAgICBzZXRQ YWdlTG9hZFN0YXRlT2JzZXJ2ZXIobnVsbHB0cik7CisKICAgICBpZiAoIW1faXNDbG9zZWQpCiAg ICAgICAgIGNsb3NlKCk7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0No YW5nZUxvZwppbmRleCAwNzA3ZTE2M2MwNmNkNTBkZmQ0MGUyYTY2OTM0Nzc3OTk1OTdhZGIwLi42 MzMxOWUxNzY1YmI3N2I4ZmJkNGE2NjM4ZjZmNDlmOTlhMDQ3OTkzIDEwMDY0NAotLS0gYS9Ub29s cy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTkt MDgtMDYgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAg ICAgQVNTRVJUSU9OIEZBSUxFRDogbV9vYnNlcnZlcnMuaXNFbXB0eSgpIGlmIFdLUGFnZVNldFBh Z2VTdGF0ZUNsaWVudCBpcyB1c2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDA0NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L1BhZ2VMb2FkU3RhdGUu Y3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6V2ViS2l0LlBhZ2VMb2FkU3RhdGUpOiBTZXQg UGFnZVN0YXRlQ2xpZW50IGJlZm9yZQorICAgICAgICBmaW5pc2hpbmcgdGhlIHRlc3QuCisgICAg ICAgICogVGVzdFdlYktpdEFQSS93aW4vUGxhdGZvcm1XZWJWaWV3V2luLmNwcDoKKyAgICAgICAg KFRlc3RXZWJLaXRBUEk6OlBsYXRmb3JtV2ViVmlldzo6flBsYXRmb3JtV2ViVmlldyk6IFJlbGVh c2UgbV92aWV3LgorCiAyMDE5LTA4LTA1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIGlPUyAxMzogT3ZlcmZsb3c6aGlkZGVuIG9uIGJvZHkgcHJldmVu dHMgUERGIHNjcm9sbApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQvUGFnZUxvYWRTdGF0ZS5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9Q YWdlTG9hZFN0YXRlLmNwcAppbmRleCBlNjUxNGMyYzBjMTQzY2MxY2M1M2YyNGRhMjQ3NTViZDJl ZGQxZDk0Li4xMmU5ODcyY2NmNjIxOTc3MjQyYzEzMDk0OGE0M2ZmYmU3ZTMzYjc3IDEwMDY0NAot LS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9QYWdlTG9hZFN0YXRlLmNwcAor KysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9QYWdlTG9hZFN0YXRlLmNwcApA QCAtMjk1LDYgKzI5NSw4IEBAIFRFU1QoV2ViS2l0LCBQYWdlTG9hZFN0YXRlKQogICAgIFV0aWw6 OnJ1bigmdGVzdDFEb25lKTsKIAogICAgIEVYUEVDVF9FUShzdGF0ZS5kaWRDaGFuZ2VBY3RpdmVV UkwsIDQpOworCisgICAgV0tQYWdlU2V0UGFnZVN0YXRlQ2xpZW50KHdlYlZpZXcucGFnZSgpLCAm c3RhdGVDbGllbnQuYmFzZSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkKZGlm ZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvd2luL1BsYXRmb3JtV2ViVmlld1dpbi5jcHAg Yi9Ub29scy9UZXN0V2ViS2l0QVBJL3dpbi9QbGF0Zm9ybVdlYlZpZXdXaW4uY3BwCmluZGV4IDNl YjZkNWM4MzY2NTI5ZTg2ZWM5M2U0OTU4NjNkMmVkN2RjOTliNGIuLmZiZDdjMDkzYmExNTMwNDM2 NDNkZGYzNDhhNGRiYTM3YzdmYTUzYjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv d2luL1BsYXRmb3JtV2ViVmlld1dpbi5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS93aW4v UGxhdGZvcm1XZWJWaWV3V2luLmNwcApAQCAtOTMsNiArOTMsNyBAQCB2b2lkIFBsYXRmb3JtV2Vi Vmlldzo6aW5pdGlhbGl6ZShXS1BhZ2VDb25maWd1cmF0aW9uUmVmIGNvbmZpZ3VyYXRpb24pCiBQ bGF0Zm9ybVdlYlZpZXc6On5QbGF0Zm9ybVdlYlZpZXcoKQogewogICAgIDo6RGVzdHJveVdpbmRv dyhtX3dpbmRvdyk7CisgICAgV0tSZWxlYXNlKG1fdmlldyk7CiB9CiAKIFdLUGFnZVJlZiBQbGF0 Zm9ybVdlYlZpZXc6OnBhZ2UoKSBjb25zdAo=