20042 2008-07-15 10:22:32 -0700 UI frozen when the debugger is paused 2008-08-24 15:29:20 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 rik timothy aroben timothy oldest_to_newest 85944 0 rik 2008-07-15 10:22:32 -0700 In certain cases, the inspector UI can be frozen while the debugger is paused. I've found one way to reproduce this, there might be others. The test uses /loaded|complete/.test(document.readyState) to simulate DOMContentLoaded. It's a test widely used for earlier versions of WebKit. Steps to reproduce: 1) Open the testcase 2) Open the inspector 3) Try to show/hide the console. Actual behaviour: The console panel doesn't open Expected behaviour: The console panel should open 85945 1 22280 rik 2008-07-15 10:27:09 -0700 Created attachment 22280 Testcase 85946 2 22281 rik 2008-07-15 10:29:20 -0700 Created attachment 22281 Real testcase 85947 3 rik 2008-07-15 10:34:00 -0700 (In reply to comment #0) > In certain cases, the inspector UI can be frozen while the debugger is paused. > I've found one way to reproduce this, there might be others. > > The test uses /loaded|complete/.test(document.readyState) to simulate > DOMContentLoaded. It's a test widely used for earlier versions of WebKit. > > Steps to reproduce: > 1) Open the testcase > 2) Open the inspector > 3) Try to show/hide the console. > > Actual behaviour: > The console panel doesn't open > > Expected behaviour: > The console panel should open > Sorry for the wrong steps. New ones : 1) Open the testcase 2) Open the inspector 3) Enable the script debugger (the page reloads) 4) Try to show/hide the console. 89142 4 22945 timothy 2008-08-22 14:05:54 -0700 Created attachment 22945 Proposed patch 89209 5 22945 darin 2008-08-24 15:08:24 -0700 Comment on attachment 22945 Proposed patch r=me This seems like the right fix unless we can change the design so fireTimersInNestedEventLoop is no longer needed. I'm still hoping we can do that some day. 89212 6 timothy 2008-08-24 15:29:20 -0700 Landed in r35908. 22280 2008-07-15 10:27:09 -0700 2008-07-15 10:29:20 -0700 Testcase testcase.html text/html 845 rik PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIj4KPGh0bWw+ CiAgICA8aGVhZD4KICAgICAgICA8dGl0bGU+PC90aXRsZT4KICAgICAgICA8c2NyaXB0IHR5cGU9 InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPgogICAgICAgIGZ1bmN0aW9uIGZvbygp IHsKICAgICAgICAgICAgZGVidWdnZXI7CiAgICAgICAgfQogICAgICAgIGZ1bmN0aW9uIF9fb25s b2FkX2hhbmRsZXIgKCkgewogICAgICAgICAgICBpZiAoL1dlYktpdC9pLnRlc3QobmF2aWdhdG9y LnVzZXJBZ2VudCkpIHsKICAgICAgICAgICAgICAgIHZhciBfdGltZXIgPSBzZXRJbnRlcnZhbChm dW5jdGlvbigpIHsKICAgICAgICAgICAgICAgICAgICBpZiAoL2xvYWRlZHxjb21wbGV0ZS8udGVz dChkb2N1bWVudC5yZWFkeVN0YXRlKSkgewogICAgICAgICAgICAgICAgICAgICAgICBjbGVhcklu dGVydmFsKF90aW1lcik7CiAgICAgICAgICAgICAgICAgICAgICAgIGRlbGV0ZSBfdGltZXI7CiAg ICAgICAgICAgICAgICAgICAgICAgIGZvbygpOyAvLyBjYWxsIHRoZSBvbmxvYWQgaGFuZGxlcgog ICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgIH0sIDEwKTsKICAgICAgICAgICAg fQogICAgICAgIH0KICAgICAgICA8L3NjcmlwdD4KICAgIDwvaGVhZD4KICAgIDxib2R5PgogICAg ICAgIDxhIGhyZWY9IiMiIG9uY2xpY2s9ImNsb2NrKCkiPkNsaWNrIG1lPC9hPgogICAgPC9ib2R5 PgogICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KICAg ICAgICBfX29ubG9hZF9oYW5kbGVyKCk7CiAgICA8L3NjcmlwdD4KPC9odG1sPgo= 22281 2008-07-15 10:29:20 -0700 2008-07-15 10:29:20 -0700 Real testcase testcase.html text/html 828 rik PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIj4KPGh0bWw+ CiAgICA8aGVhZD4KICAgICAgICA8dGl0bGU+PC90aXRsZT4KICAgICAgICA8c2NyaXB0IHR5cGU9 InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPgogICAgICAgIGZ1bmN0aW9uIGZvbygp IHsKICAgICAgICAgICAgZGVidWdnZXI7CiAgICAgICAgfQogICAgICAgIGZ1bmN0aW9uIF9fb25s b2FkX2hhbmRsZXIgKCkgewogICAgICAgICAgICBpZiAoL1dlYktpdC9pLnRlc3QobmF2aWdhdG9y LnVzZXJBZ2VudCkpIHsKICAgICAgICAgICAgICAgIHZhciBfdGltZXIgPSBzZXRJbnRlcnZhbChm dW5jdGlvbigpIHsKICAgICAgICAgICAgICAgICAgICBpZiAoL2xvYWRlZHxjb21wbGV0ZS8udGVz dChkb2N1bWVudC5yZWFkeVN0YXRlKSkgewogICAgICAgICAgICAgICAgICAgICAgICBjbGVhcklu dGVydmFsKF90aW1lcik7CiAgICAgICAgICAgICAgICAgICAgICAgIGRlbGV0ZSBfdGltZXI7CiAg ICAgICAgICAgICAgICAgICAgICAgIGZvbygpOyAvLyBjYWxsIHRoZSBvbmxvYWQgaGFuZGxlcgog ICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgIH0sIDEwKTsKICAgICAgICAgICAg fQogICAgICAgIH0KICAgICAgICA8L3NjcmlwdD4KICAgIDwvaGVhZD4KICAgIDxib2R5PgogICAg ICAgIDxwPk9wZW4gdGhlIGluc3BlY3RvcjwvcD4KICAgIDwvYm9keT4KICAgIDxzY3JpcHQgdHlw ZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCI+CiAgICAgICAgX19vbmxvYWRfaGFu ZGxlcigpOwogICAgPC9zY3JpcHQ+CjwvaHRtbD4K 22945 2008-08-22 14:05:54 -0700 2008-08-24 15:08:24 -0700 Proposed patch 0001--Fixes-a-bug-where-the-Inspector-s-UI-would-n.patch text/plain 4173 timothy RnJvbSA5MGIwNzM1NTNlYzAzMDFjN2Q1MWEwMzU1ZmE1ODNkYzBhYzY5NGI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBGcmksIDIyIEF1ZyAyMDA4IDE0OjA1OjA1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBGaXhlcyBhIGJ1ZyB3aGVyZSB0aGUgSW5zcGVjdG9yJ3MgVUkgd291bGQgbm90IGFuaW1h dGUgb3IKICAgICAgICAgZnVsbHkgZnVuY3Rpb24gYmVjYXVzZSBKYXZhU2NyaXB0IHRpbWVvdXRz LCBpbnRlcnZhbHMgYW5kCiAgICAgICAgIENTUyBhbmltYXRpb24gdGltZXJzIHdoZXJlIG5vdCBm aXJpbmcgd2hpbGUgcGF1c2VkIGF0IGEKICAgICAgICAgYSBicmVha3BvaW50IGluIHRoZSBpbnNw ZWN0ZWQgcGFnZS4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwMDQyCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBU ZXN0OiBtYW51YWwtdGVzdHMvaW5zcGVjdG9yL2Zvcnplbi11aS13aGlsZS1wYXVzZWQuaHRtbAoK ICAgICAgICAqIHBhZ2UvSmF2YVNjcmlwdERlYnVnU2VydmVyLmNwcDoKICAgICAgICAoV2ViQ29y ZTo6SmF2YVNjcmlwdERlYnVnU2VydmVyOjpwYXVzZUlmTmVlZGVkKToKICAgICAgICBBZGQgYSBj YWxsIHRvIFRpbWVyQmFzZTo6ZmlyZVRpbWVyc0luTmVzdGVkRXZlbnRMb29wIGJlZm9yZQogICAg ICAgIHNwaW5uaW5nIHRoZSBFdmVudExvb3AuCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE4ICsrKysrKysrKysrCiAuLi4vaW5zcGVj dG9yL2Zvcnplbi11aS13aGlsZS1wYXVzZWQuaHRtbCAgICAgICAgICB8ICAgMzEgKysrKysrKysr KysrKysrKysrKysKIFdlYkNvcmUvcGFnZS9KYXZhU2NyaXB0RGVidWdTZXJ2ZXIuY3BwICAgICAg ICAgICAgIHwgICAgMiArCiAzIGZpbGVzIGNoYW5nZWQsIDUxIGluc2VydGlvbnMoKyksIDAgZGVs ZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgV2ViQ29yZS9tYW51YWwtdGVzdHMvaW5zcGVj dG9yL2Zvcnplbi11aS13aGlsZS1wYXVzZWQuaHRtbAoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hh bmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGRiZWUzMi4uMWEwODFlOSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSAr MSwyMyBAQAogMjAwOC0wOC0yMiAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+ CiAKKyAgICAgICAgRml4ZXMgYSBidWcgd2hlcmUgdGhlIEluc3BlY3RvcidzIFVJIHdvdWxkIG5v dCBhbmltYXRlIG9yCisgICAgICAgIGZ1bGx5IGZ1bmN0aW9uIGJlY2F1c2UgSmF2YVNjcmlwdCB0 aW1lb3V0cywgaW50ZXJ2YWxzIGFuZAorICAgICAgICBDU1MgYW5pbWF0aW9uIHRpbWVycyB3aGVy ZSBub3QgZmlyaW5nIHdoaWxlIHBhdXNlZCBhdCBhCisgICAgICAgIGEgYnJlYWtwb2ludCBpbiB0 aGUgaW5zcGVjdGVkIHBhZ2UuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwMDQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGVzdDogbWFudWFsLXRlc3RzL2luc3BlY3Rvci9mb3J6ZW4tdWktd2hpbGUt cGF1c2VkLmh0bWwKKworICAgICAgICAqIHBhZ2UvSmF2YVNjcmlwdERlYnVnU2VydmVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkphdmFTY3JpcHREZWJ1Z1NlcnZlcjo6cGF1c2VJZk5lZWRlZCk6 CisgICAgICAgIEFkZCBhIGNhbGwgdG8gVGltZXJCYXNlOjpmaXJlVGltZXJzSW5OZXN0ZWRFdmVu dExvb3AgYmVmb3JlCisgICAgICAgIHNwaW5uaW5nIHRoZSBFdmVudExvb3AuCisKKzIwMDgtMDgt MjIgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAgIFJvbGxz IG91dCByMzU4MzQgYmVjYXVzZSBpdCBjYXVzZWQgYSByZWdyZXNzaW9uIGluIHRoZSBJbnNwZWN0 b3IncwogICAgICAgICBDb25zb2xlIHdoZXJlIHNvbWUgZXhwcmVzc2lvbnMgYWx3YXlzIHRocmV3 IGEgc3ludGF4IGVycm9yLgogCmRpZmYgLS1naXQgYS9XZWJDb3JlL21hbnVhbC10ZXN0cy9pbnNw ZWN0b3IvZm9yemVuLXVpLXdoaWxlLXBhdXNlZC5odG1sIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMv aW5zcGVjdG9yL2Zvcnplbi11aS13aGlsZS1wYXVzZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwLi5hOGNmMjU1Ci0tLSAvZGV2L251bGwKKysrIGIvV2ViQ29yZS9tYW51 YWwtdGVzdHMvaW5zcGVjdG9yL2Zvcnplbi11aS13aGlsZS1wYXVzZWQuaHRtbApAQCAtMCwwICsx LDMxIEBACis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHRpdGxlPjwvdGl0bGU+CisgICAg ICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCI+IAorICAg ICAgICBmdW5jdGlvbiBmb28oKSB7CisgICAgICAgICAgICB2YXIgdGltZW91dCA9IHNldFRpbWVv dXQoZnVuY3Rpb24oKSB7IGFsZXJ0KCJUaGlzIHNob3VsZCBub3QgaGFwcGVuLiBJZiB5b3UgZG8g dGhlbiB0aW1lcnMgb24gdGhlIHBhZ2UgYXJlIGZpcmluZyB3aGlsZSBwYXVzZWQuIikgfSwgMCk7 CisgICAgICAgICAgICBkZWJ1Z2dlcjsKKyAgICAgICAgICAgIGNsZWFyVGltZW91dCh0aW1lb3V0 KTsKKyAgICAgICAgfQorCisgICAgICAgIGZ1bmN0aW9uIF9fb25sb2FkX2hhbmRsZXIgKCkgewor ICAgICAgICAgICAgaWYgKC9XZWJLaXQvaS50ZXN0KG5hdmlnYXRvci51c2VyQWdlbnQpKSB7Cisg ICAgICAgICAgICAgICAgdmFyIF90aW1lciA9IHNldEludGVydmFsKGZ1bmN0aW9uKCkgeworICAg ICAgICAgICAgICAgICAgICBpZiAoL2xvYWRlZHxjb21wbGV0ZS8udGVzdChkb2N1bWVudC5yZWFk eVN0YXRlKSkgeworICAgICAgICAgICAgICAgICAgICAgICAgY2xlYXJJbnRlcnZhbChfdGltZXIp OworICAgICAgICAgICAgICAgICAgICAgICAgZGVsZXRlIF90aW1lcjsKKyAgICAgICAgICAgICAg ICAgICAgICAgIGZvbygpOyAvLyBjYWxsIHRoZSBvbmxvYWQgaGFuZGxlcgorICAgICAgICAgICAg ICAgICAgICB9CisgICAgICAgICAgICAgICAgfSwgMTApOworICAgICAgICAgICAgfQorICAgICAg ICB9CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4KKwkJPHA+VGVz dCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw MDQyIj5CdWcgMjAwNDI6IFVJIGZyb3plbiB3aGVuIHRoZSBkZWJ1Z2dlciBpcyBwYXVzZWQ8L2E+ LjwvcD4KKyAgICAgICAgPHA+T3BlbiB0aGUgaW5zcGVjdG9yIGFuZCBzdGFydCBkZWJ1Z2dpbmcg aW4gdGhlIFNjcmlwdHMgcGFuZWwuIFdoaWxlIHBhdXNlZCwgdHJ5IHRvIG9wZW4gdGhlIENvbnNv bGUuIFRoZSBDb25zb2xlIHNob3VsZCBhbmltYXRlIG9wZW4gZnVsbHkuPC9wPgorICAgIDwvYm9k eT4KKyAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRmLTgiPgor ICAgICAgICBfX29ubG9hZF9oYW5kbGVyKCk7CisgICAgPC9zY3JpcHQ+Cis8L2h0bWw+CmRpZmYg LS1naXQgYS9XZWJDb3JlL3BhZ2UvSmF2YVNjcmlwdERlYnVnU2VydmVyLmNwcCBiL1dlYkNvcmUv cGFnZS9KYXZhU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCmluZGV4IDM0NzBiYmEuLjVmYmUxYjggMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9KYXZhU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCisrKyBiL1dl YkNvcmUvcGFnZS9KYXZhU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCkBAIC00MDYsNiArNDA2LDggQEAg dm9pZCBKYXZhU2NyaXB0RGVidWdTZXJ2ZXI6OnBhdXNlSWZOZWVkZWQoUGFnZSogcGFnZSkKIAog ICAgIHNldEphdmFTY3JpcHRQYXVzZWQocGFnZS0+Z3JvdXAoKSwgdHJ1ZSk7CiAKKyAgICBUaW1l ckJhc2U6OmZpcmVUaW1lcnNJbk5lc3RlZEV2ZW50TG9vcCgpOworCiAgICAgRXZlbnRMb29wIGxv b3A7CiAgICAgbV9kb25lUHJvY2Vzc2luZ0RlYnVnZ2VyRXZlbnRzID0gZmFsc2U7CiAgICAgd2hp bGUgKCFtX2RvbmVQcm9jZXNzaW5nRGVidWdnZXJFdmVudHMgJiYgIWxvb3AuZW5kZWQoKSkKLS0g CjEuNi4wLnJjMwoK