200409 2019-08-02 16:38:29 -0700 Deploy Ref and RefPtr in DOMWindow::screen* and DOMWindow::inner* functions 2019-08-02 17:50:20 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa bfulgham cdumez jiewen_tan simon.fraser webkit-bug-importer zalan oldest_to_newest 1558200 0 rniwa 2019-08-02 16:38:29 -0700 Following up on my review comments on webkit.org/b/197999. 1558208 1 375467 rniwa 2019-08-02 16:52:12 -0700 Created attachment 375467 Patch 1558216 2 zalan 2019-08-02 17:06:23 -0700 v.nice 1558227 3 rniwa 2019-08-02 17:49:43 -0700 Committed r248193: <https://trac.webkit.org/changeset/248193> 1558228 4 webkit-bug-importer 2019-08-02 17:50:20 -0700 <rdar://problem/53887408> 375467 2019-08-02 16:52:12 -0700 2019-08-02 16:58:56 -0700 Patch bug-200409-20190802165212.patch text/plain 4850 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0ODE4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA4LTAyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlZiBGcmFtZSBpbiBET01XaW5k b3c6OnNjcmVlbiogZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDA0MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZWYgRnJhbWUgaW4gdGhlIGZvbGxvd2luZyBmdW5jdGlvbnMuCisKKyAg ICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6 OmlubmVySGVpZ2h0IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6aW5uZXJX aWR0aCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OnNjcmVlblggY29uc3Qp OgorICAgICAgICAoV2ViQ29yZTo6RE9NV2luZG93OjpzY3JlZW5ZIGNvbnN0KToKKyAgICAgICAg KFdlYkNvcmU6OkRPTVdpbmRvdzo6c2Nyb2xsWCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpE T01XaW5kb3c6OnNjcm9sbFkgY29uc3QpOgorCiAyMDE5LTA4LTAyICBBbmRyZXMgR29uemFsZXog IDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYWNjZXNzaWJpbGl0eSBvYmpl Y3QgbWV0aG9kIHRvIGRldGVybWluZSB3aGV0aGVyIGFuIGVsZW1lbnQgaXMgaW5zaWRlIGEgdGFi bGUgY2VsbC4gTmVlZGVkIGZvciBpT1MgYWNjZXNzaWJpbGl0eSBjbGllbnQuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3cuY3BwCShyZXZpc2lvbiAyNDgxODUpCisrKyBTb3VyY2UvV2ViQ29y ZS9wYWdlL0RPTVdpbmRvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNTYsMTQgKzEyNTYsMTQg QEAgaW50IERPTVdpbmRvdzo6aW5uZXJIZWlnaHQoKSBjb25zdAogICAgICAgICByZXR1cm4gMDsK ICAgICAKICAgICAvLyBGb3JjZSBlbm91Z2ggbGF5b3V0IGluIHRoZSBwYXJlbnQgZG9jdW1lbnQg dG8gZW5zdXJlIHRoYXQgdGhlIEZyYW1lVmlldyBoYXMgYmVlbiByZXNpemVkLgotICAgIGlmIChh dXRvKiBmcmFtZUVsZW1lbnQgPSB0aGlzLT5mcmFtZUVsZW1lbnQoKSkKLSAgICAgICAgZnJhbWVF bGVtZW50LT5kb2N1bWVudCgpLnVwZGF0ZUxheW91dElmRGltZW5zaW9uc091dE9mRGF0ZSgqZnJh bWVFbGVtZW50LCBIZWlnaHREaW1lbnNpb25zQ2hlY2spOworICAgIGlmIChhdXRvIG93bmVyRWxl bWVudCA9IG1ha2VSZWZQdHIoZnJhbWVFbGVtZW50KCkpKQorICAgICAgICBvd25lckVsZW1lbnQt PmRvY3VtZW50KCkudXBkYXRlTGF5b3V0SWZEaW1lbnNpb25zT3V0T2ZEYXRlKCpvd25lckVsZW1l bnQsIEhlaWdodERpbWVuc2lvbnNDaGVjayk7CiAKLSAgICBhdXRvKiBmcmFtZSA9IHRoaXMtPmZy YW1lKCk7CisgICAgYXV0byBmcmFtZSA9IG1ha2VSZWZQdHIodGhpcy0+ZnJhbWUoKSk7CiAgICAg aWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuIDA7CiAgICAgCi0gICAgRnJhbWVWaWV3KiB2aWV3 ID0gZnJhbWUtPnZpZXcoKTsKKyAgICBhdXRvIHZpZXcgPSBtYWtlUmVmUHRyKGZyYW1lLT52aWV3 KCkpOwogICAgIGlmICghdmlldykKICAgICAgICAgcmV0dXJuIDA7CiAKQEAgLTEyNzYsMTQgKzEy NzYsMTQgQEAgaW50IERPTVdpbmRvdzo6aW5uZXJXaWR0aCgpIGNvbnN0CiAgICAgICAgIHJldHVy biAwOwogCiAgICAgLy8gRm9yY2UgZW5vdWdoIGxheW91dCBpbiB0aGUgcGFyZW50IGRvY3VtZW50 IHRvIGVuc3VyZSB0aGF0IHRoZSBGcmFtZVZpZXcgaGFzIGJlZW4gcmVzaXplZC4KLSAgICBpZiAo YXV0byogZnJhbWVFbGVtZW50ID0gdGhpcy0+ZnJhbWVFbGVtZW50KCkpCi0gICAgICAgIGZyYW1l RWxlbWVudC0+ZG9jdW1lbnQoKS51cGRhdGVMYXlvdXRJZkRpbWVuc2lvbnNPdXRPZkRhdGUoKmZy YW1lRWxlbWVudCwgV2lkdGhEaW1lbnNpb25zQ2hlY2spOworICAgIGlmIChhdXRvIG93bmVyRWxl bWVudCA9IG1ha2VSZWZQdHIoZnJhbWVFbGVtZW50KCkpKQorICAgICAgICBvd25lckVsZW1lbnQt PmRvY3VtZW50KCkudXBkYXRlTGF5b3V0SWZEaW1lbnNpb25zT3V0T2ZEYXRlKCpvd25lckVsZW1l bnQsIFdpZHRoRGltZW5zaW9uc0NoZWNrKTsKIAotICAgIGF1dG8qIGZyYW1lID0gdGhpcy0+ZnJh bWUoKTsKKyAgICBhdXRvIGZyYW1lID0gbWFrZVJlZlB0cih0aGlzLT5mcmFtZSgpKTsKICAgICBp ZiAoIWZyYW1lKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIEZyYW1lVmlldyogdmlldyA9IGZy YW1lLT52aWV3KCk7CisgICAgYXV0byB2aWV3ID0gbWFrZVJlZlB0cihmcmFtZS0+dmlldygpKTsK ICAgICBpZiAoIXZpZXcpCiAgICAgICAgIHJldHVybiAwOwogCkBAIC0xMjkyLDcgKzEyOTIsNyBA QCBpbnQgRE9NV2luZG93Ojppbm5lcldpZHRoKCkgY29uc3QKIAogaW50IERPTVdpbmRvdzo6c2Ny ZWVuWCgpIGNvbnN0CiB7Ci0gICAgYXV0byogZnJhbWUgPSB0aGlzLT5mcmFtZSgpOworICAgIGF1 dG8gZnJhbWUgPSBtYWtlUmVmUHRyKHRoaXMtPmZyYW1lKCkpOwogICAgIGlmICghZnJhbWUpCiAg ICAgICAgIHJldHVybiAwOwogCkBAIC0xMzA1LDcgKzEzMDUsNyBAQCBpbnQgRE9NV2luZG93Ojpz Y3JlZW5YKCkgY29uc3QKIAogaW50IERPTVdpbmRvdzo6c2NyZWVuWSgpIGNvbnN0CiB7Ci0gICAg YXV0byogZnJhbWUgPSB0aGlzLT5mcmFtZSgpOworICAgIGF1dG8gZnJhbWUgPSBtYWtlUmVmUHRy KHRoaXMtPmZyYW1lKCkpOwogICAgIGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybiAwOwogCkBA IC0xMzE4LDExICsxMzE4LDExIEBAIGludCBET01XaW5kb3c6OnNjcmVlblkoKSBjb25zdAogCiBp bnQgRE9NV2luZG93OjpzY3JvbGxYKCkgY29uc3QKIHsKLSAgICBhdXRvKiBmcmFtZSA9IHRoaXMt PmZyYW1lKCk7CisgICAgYXV0byBmcmFtZSA9IG1ha2VSZWZQdHIodGhpcy0+ZnJhbWUoKSk7CiAg ICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBGcmFtZVZpZXcqIHZpZXcg PSBmcmFtZS0+dmlldygpOworICAgIGF1dG8gdmlldyA9IG1ha2VSZWZQdHIoZnJhbWUtPnZpZXco KSk7CiAgICAgaWYgKCF2aWV3KQogICAgICAgICByZXR1cm4gMDsKIApAQCAtMTMzMywxMSArMTMz MywxMSBAQCBpbnQgRE9NV2luZG93OjpzY3JvbGxYKCkgY29uc3QKICAgICBmcmFtZS0+ZG9jdW1l bnQoKS0+dXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7CiAKICAgICAvLyBM YXlvdXQgbWF5IGhhdmUgYWZmZWN0ZWQgdGhlIGN1cnJlbnQgZnJhbWU6Ci0gICAgYXV0byogZnJh bWVBZnRlckxheW91dCA9IHRoaXMtPmZyYW1lKCk7CisgICAgYXV0byBmcmFtZUFmdGVyTGF5b3V0 ID0gbWFrZVJlZlB0cih0aGlzLT5mcmFtZSgpKTsKICAgICBpZiAoIWZyYW1lQWZ0ZXJMYXlvdXQp CiAgICAgICAgIHJldHVybiAwOwotICAgIAotICAgIEZyYW1lVmlldyogdmlld0FmdGVyTGF5b3V0 ID0gZnJhbWVBZnRlckxheW91dC0+dmlldygpOworCisgICAgYXV0byB2aWV3QWZ0ZXJMYXlvdXQg PSBtYWtlUmVmUHRyKGZyYW1lQWZ0ZXJMYXlvdXQtPnZpZXcoKSk7CiAgICAgaWYgKCF2aWV3QWZ0 ZXJMYXlvdXQpCiAgICAgICAgIHJldHVybiAwOwogCkBAIC0xMzQ2LDExICsxMzQ2LDExIEBAIGlu dCBET01XaW5kb3c6OnNjcm9sbFgoKSBjb25zdAogCiBpbnQgRE9NV2luZG93OjpzY3JvbGxZKCkg Y29uc3QKIHsKLSAgICBhdXRvKiBmcmFtZSA9IHRoaXMtPmZyYW1lKCk7CisgICAgYXV0byBmcmFt ZSA9IG1ha2VSZWZQdHIodGhpcy0+ZnJhbWUoKSk7CiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAg cmV0dXJuIDA7CiAKLSAgICBGcmFtZVZpZXcqIHZpZXcgPSBmcmFtZS0+dmlldygpOworICAgIGF1 dG8gdmlldyA9IG1ha2VSZWZQdHIoZnJhbWUtPnZpZXcoKSk7CiAgICAgaWYgKCF2aWV3KQogICAg ICAgICByZXR1cm4gMDsKIApAQCAtMTM2MSwxNCArMTM2MSwxNCBAQCBpbnQgRE9NV2luZG93Ojpz Y3JvbGxZKCkgY29uc3QKICAgICBmcmFtZS0+ZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0SWdub3Jl UGVuZGluZ1N0eWxlc2hlZXRzKCk7CiAKICAgICAvLyBMYXlvdXQgbWF5IGhhdmUgYWZmZWN0ZWQg dGhlIGN1cnJlbnQgZnJhbWU6Ci0gICAgYXV0byogZnJhbWVBZnRlckxheW91dCA9IHRoaXMtPmZy YW1lKCk7CisgICAgYXV0byBmcmFtZUFmdGVyTGF5b3V0ID0gbWFrZVJlZlB0cih0aGlzLT5mcmFt ZSgpKTsKICAgICBpZiAoIWZyYW1lQWZ0ZXJMYXlvdXQpCiAgICAgICAgIHJldHVybiAwOwotICAg IAotICAgIEZyYW1lVmlldyogdmlld0FmdGVyTGF5b3V0ID0gZnJhbWVBZnRlckxheW91dC0+dmll dygpOworCisgICAgYXV0byB2aWV3QWZ0ZXJMYXlvdXQgPSBtYWtlUmVmUHRyKGZyYW1lQWZ0ZXJM YXlvdXQtPnZpZXcoKSk7CiAgICAgaWYgKCF2aWV3QWZ0ZXJMYXlvdXQpCiAgICAgICAgIHJldHVy biAwOwotICAgIAorCiAgICAgcmV0dXJuIHZpZXdBZnRlckxheW91dC0+bWFwRnJvbUxheW91dFRv Q1NTVW5pdHModmlld0FmdGVyTGF5b3V0LT5jb250ZW50c1Njcm9sbFBvc2l0aW9uKCkueSgpKTsK IH0KIAo=