200403 2019-08-02 14:00:34 -0700 uniqueLogIdentifier() should generate a 64-bit identifier 2020-01-22 17:43:25 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206612 1 eric.carlson eric.carlson benjamin cdumez cmarcelo commit-queue dbates ews-watchlist webkit-bug-importer youennf oldest_to_newest 1558101 0 eric.carlson 2019-08-02 14:00:34 -0700 uniqueLogIdentifier() should generate a 64-bit identifier 1558103 1 webkit-bug-importer 2019-08-02 14:00:50 -0700 <rdar://problem/53878447> 1558119 2 375452 eric.carlson 2019-08-02 14:08:53 -0700 Created attachment 375452 Patch 1558124 3 375452 youennf 2019-08-02 14:18:50 -0700 Comment on attachment 375452 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375452&action=review > Source/WTF/ChangeLog:12 > + uint32_t so use two to generate a 64-bit identifier. Maybe we should have a way to print parent id as ABCD and child log identifier as ABCD-EFGH so that it is easier to spot the relationship between parent and child. 32 bits is probably enough for parent ids so that any id above 2^32 would be printed as a child identifier. 1558128 4 eric.carlson 2019-08-02 14:22:00 -0700 (In reply to youenn fablet from comment #3) > Comment on attachment 375452 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375452&action=review > > > Source/WTF/ChangeLog:12 > > + uint32_t so use two to generate a 64-bit identifier. > > Maybe we should have a way to print parent id as ABCD and child log > identifier as ABCD-EFGH so that it is easier to spot the relationship > between parent and child. > 32 bits is probably enough for parent ids so that any id above 2^32 would be > printed as a child identifier. Good idea, I'll think about the best way to do that. 1558150 5 375452 commit-queue 2019-08-02 14:54:32 -0700 Comment on attachment 375452 Patch Clearing flags on attachment: 375452 Committed r248183: <https://trac.webkit.org/changeset/248183> 1558151 6 commit-queue 2019-08-02 14:54:34 -0700 All reviewed patches have been landed. Closing bug. 375452 2019-08-02 14:08:53 -0700 2019-08-02 14:54:32 -0700 Patch bug-200403-20190802140852.patch text/plain 2103 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJlY2RlMTYyM2YxOGZiYTRkZDE0NTg0 OTJlMmY3NTJkYWIyODlkY2YuLjNkOTRhYzEyMjkzNzhkZjRhMTA2OTFiMjBmNTgzM2E4YTA0YTlh NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDgtMDIgIEVyaWMgQ2FybHNvbiAgPGVyaWMu Y2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgdW5pcXVlTG9nSWRlbnRpZmllcigpIHNob3Vs ZCBnZW5lcmF0ZSBhIDY0LWJpdCBpZGVudGlmaWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDA0MDMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUz ODc4NDQ3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogd3RmL0xvZ2dlckhlbHBlci5oOgorICAgICAgICAoV1RGOjpMb2dnZXJIZWxwZXI6OmNoaWxk TG9nSWRlbnRpZmllciBjb25zdCk6IFVzZSB1aW50NjRfdCBtYXNrcy4KKyAgICAgICAgKFdURjo6 TG9nZ2VySGVscGVyOjp1bmlxdWVMb2dJZGVudGlmaWVyKTogY3J5cHRvZ3JhcGhpY2FsbHlSYW5k b21OdW1iZXIgcmV0dXJucyBhCisgICAgICAgIHVpbnQzMl90IHNvIHVzZSB0d28gdG8gZ2VuZXJh dGUgYSA2NC1iaXQgaWRlbnRpZmllci4KKwogMjAxOS0wOC0wMSAgQWxleCBDaHJpc3RlbnNlbiAg PGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgRm9ybURhdGEgemlwIGZp bGUgZ2VuZXJhdGlvbiB0byBOZXR3b3JrUHJvY2VzcyBhbmQgZW5hYmxlIGl0IGZvciBhbGwgV2Vi S2l0IGNsaWVudHMgZm9yIHVwbG9hZGluZyBkaXJlY3RvcmllcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvTG9nZ2VySGVscGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9Mb2dnZXJIZWxwZXIuaApp bmRleCA3NWEyMGJkZGNlZWU1ZDEwOGQzYTAzMjk0NmQyMzRmMmRjM2NlMjNiLi5lMzdmMWVhNTBk ODY4NTZlYmUzOTFiNmI5ZjFkMmExODQ0OGFmYzU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9Mb2dnZXJIZWxwZXIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Mb2dnZXJIZWxwZXIuaApAQCAt NTgsMTUgKzU4LDE2IEBAIHB1YmxpYzoKIAogICAgIGNvbnN0IHZvaWQqIGNoaWxkTG9nSWRlbnRp Zmllcih1aW50NjRfdCBpZGVudGlmaWVyKSBjb25zdAogICAgIHsKLSAgICAgICAgc3RhdGljIGNv bnN0IGludDY0X3QgcGFyZW50TWFzayA9IDB4ZmZmZmZmZmZmZmZmMDAwMGw7Ci0gICAgICAgIHN0 YXRpYyBjb25zdCBpbnQ2NF90IG1hc2tMb3dlcldvcmQgPSAweGZmZmZsOworICAgICAgICBzdGF0 aWMgY29uc3QgdWludDY0X3QgcGFyZW50TWFzayA9IDB4ZmZmZmZmZmZmZmZmMDAwMHVsbDsKKyAg ICAgICAgc3RhdGljIGNvbnN0IHVpbnQ2NF90IG1hc2tMb3dlcldvcmQgPSAweGZmZmZ1bGw7CiAg ICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PGNvbnN0IHZvaWQqPigocmVpbnRlcnByZXRf Y2FzdDx1aW50NjRfdD4obG9nSWRlbnRpZmllcigpKSAmIHBhcmVudE1hc2spIHwgKGlkZW50aWZp ZXIgJiBtYXNrTG93ZXJXb3JkKSk7CiAgICAgfQogCiAgICAgc3RhdGljIGNvbnN0IHZvaWQqIHVu aXF1ZUxvZ0lkZW50aWZpZXIoKQogICAgIHsKLSAgICAgICAgc3RhdGljIHVpbnQ2NF90IGxvZ0lk ZW50aWZpZXIgPSBjcnlwdG9ncmFwaGljYWxseVJhbmRvbU51bWJlcigpOwotICAgICAgICByZXR1 cm4gcmVpbnRlcnByZXRfY2FzdDxjb25zdCB2b2lkKj4oKytsb2dJZGVudGlmaWVyKTsKKyAgICAg ICAgc3RhdGljIHVpbnQ2NF90IGhpZ2hXb3JkID0gY3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1i ZXIoKTsKKyAgICAgICAgc3RhdGljIHVpbnQ2NF90IGxvd1dvcmQgPSBjcnlwdG9ncmFwaGljYWxs eVJhbmRvbU51bWJlcigpOworICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxjb25zdCB2 b2lkKj4oKGhpZ2hXb3JkIDw8IDMyKSArIGxvd1dvcmQpOwogICAgIH0KICNlbHNlCiAK