<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>20038</bug_id>
          
          <creation_ts>2008-07-14 21:51:50 -0700</creation_ts>
          <short_desc>REGRESSION (r35151): Can&apos;t post comments on flickr.com</short_desc>
          <delta_ts>2009-01-04 08:44:11 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Forms</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://www.flickr.com/</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, Regression, YahooBug</keywords>
          <priority>P2</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matias Canelson">canelson</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>beidson</cc>
    
    <cc>dantearmok</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>desamo</cc>
    
    <cc>henrycavillones</cc>
    
    <cc>hyatt</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>85925</commentid>
    <comment_count>0</comment_count>
    <who name="Matias Canelson">canelson</who>
    <bug_when>2008-07-14 21:51:50 -0700</bug_when>
    <thetext>While using flickr website, I tried to add a comment to a photo and it can&apos;t be done. After pressing the POST COMMENT button nothing happens. I tried using Safari 3.1 and Firefox on the same computer and it works fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86216</commentid>
    <comment_count>1</comment_count>
    <who name="Dave Bullock / eecue">eecue</who>
    <bug_when>2008-07-17 07:06:59 -0700</bug_when>
    <thetext>I am having this same problem, I just downloaded the latest release of WK and the problem still exists.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86412</commentid>
    <comment_count>2</comment_count>
    <who name="Robert Brook">mail</who>
    <bug_when>2008-07-19 00:31:10 -0700</bug_when>
    <thetext>I&apos;m seeing this behaviour on WebKit &quot;3.1.2 (5525.20.1)&quot;. Should this bug have the keyword &quot;YahooBug&quot;?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86620</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2008-07-21 21:16:43 -0700</bug_when>
    <thetext>&lt;rdar://problem/6092270&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86803</commentid>
    <comment_count>4</comment_count>
    <who name="Deirdre Saoirse Moen">desamo</who>
    <bug_when>2008-07-23 17:11:58 -0700</bug_when>
    <thetext>Just to be clear, did you mean this didn&apos;t work with the released 3.1.2, or with a WebKit build running against 3.1.2?

I just tried it on a stock 10.5.4/3.1.2 machine and had couldn&apos;t reproduce.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86804</commentid>
    <comment_count>5</comment_count>
    <who name="Matias Canelson">canelson</who>
    <bug_when>2008-07-23 17:31:22 -0700</bug_when>
    <thetext>Webkit v35289 downloaded on July 23rd doesn&apos;t work. 
Official Safari v3.1.2 (5525.20.1) does work.

I&apos;m on a Macbook CoreDuo 2Ghz with MAC OS X 10.5.4 with every Apple software up to date.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86827</commentid>
    <comment_count>6</comment_count>
    <who name="Adele Peterson">adele</who>
    <bug_when>2008-07-24 00:58:54 -0700</bug_when>
    <thetext>works in r35138
broken in r35153</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86862</commentid>
    <comment_count>7</comment_count>
    <who name="Adele Peterson">adele</who>
    <bug_when>2008-07-24 10:00:48 -0700</bug_when>
    <thetext>Regressed with http://trac.webkit.org/changeset/35151</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86896</commentid>
    <comment_count>8</comment_count>
    <who name="Adele Peterson">adele</who>
    <bug_when>2008-07-24 12:17:28 -0700</bug_when>
    <thetext>This issues occurs when your original url as a trailing slash.

Flickr adds a #preview to the url before doing another load to add the comment.  The new code added in r 35151 prevents reloading in that case where #preview is added.

I don&apos;t know how we can tell the difference between the case where the site adds a hash and intends to do more processing on a reload, and when a user adds a hash to jump somewhere in the page.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86923</commentid>
    <comment_count>9</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-07-24 16:38:57 -0700</bug_when>
    <thetext>Ugh.  Does this work on Firefox 2.0/3.0?  Perhaps we&apos;re missing a &quot;userInitiatedLoad&quot; flag to know when the change was done by JavaScript versus the user.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86941</commentid>
    <comment_count>10</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-07-25 08:48:42 -0700</bug_when>
    <thetext>I&apos;m going to look into this.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87084</commentid>
    <comment_count>11</comment_count>
    <who name="Dan C">dantearmok</who>
    <bug_when>2008-07-27 13:42:19 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; Does this work on Firefox 2.0/3.0?  

Seeing the same problem in Adium&apos;s trac system and others - they all add #preview etc.  This works from current Safari 3.1.2, and Firefox 2 and 3.0.1 but not from the latest (27 July) WebKit nightly.

I first noticed this problem in r35249 (built on 20 July 2008), fwiw.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87158</commentid>
    <comment_count>12</comment_count>
    <who name="Pierre-Luc Beaudoin">pierre-luc.beaudoin</who>
    <bug_when>2008-07-28 08:04:22 -0700</bug_when>
    <thetext>*** Bug 20195 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87720</commentid>
    <comment_count>13</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-03 06:21:52 -0700</bug_when>
    <thetext>Unfortunately r35377 just refactored many of the methods.  Not sure if this is going to help or hurt.

http://trac.webkit.org/changeset/35377</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87726</commentid>
    <comment_count>14</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-03 11:52:23 -0700</bug_when>
    <thetext>I have a fix!  The problem is that FrameLoader::m_formAboutToBeSubmitted is never set on a form that doesn&apos;t have any &quot;text fields&quot;, which causes a FormState object not be created, which causes isFormSubmission not to be set to true, which means that shouldScrollToAnchor() returns true instead of false.

Next step is to run layout tests and to write a new layout test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87727</commentid>
    <comment_count>15</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-03 11:56:08 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; Seeing the same problem in Adium&apos;s trac system and others - they all add
&gt; #preview etc.  This works from current Safari 3.1.2, and Firefox 2 and 3.0.1
&gt; but not from the latest (27 July) WebKit nightly.

Dan, what are the steps to reproduce this issue?
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87728</commentid>
    <comment_count>16</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-03 12:05:57 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; (In reply to comment #11)
&gt; &gt; Seeing the same problem in Adium&apos;s trac system and others - they all add
&gt; &gt; #preview etc.  This works from current Safari 3.1.2, and Firefox 2 and 3.0.1
&gt; &gt; but not from the latest (27 July) WebKit nightly.
&gt; 
&gt; Dan, what are the steps to reproduce this issue?

I tried creating a preview of a new ticket on macosforge.net, but the preview button still works there (even though it adds &quot;#preview&quot; to the URL).  See Comment #14.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87732</commentid>
    <comment_count>17</comment_count>
    <who name="Dan C">dantearmok</who>
    <bug_when>2008-08-03 12:59:53 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; (In reply to comment #11)
&gt; &gt; Seeing the same problem in Adium&apos;s trac system and others - they all add
&gt; &gt; #preview etc.  This works from current Safari 3.1.2, and Firefox 2 and 3.0.1
&gt; &gt; but not from the latest (27 July) WebKit nightly.
&gt; 
&gt; Dan, what are the steps to reproduce this issue?

Now using WebKit r35531, still on OS X 10.4.11.

Pick a ticket, any ticket, on AdiumX&apos;s trac.
eg: http://trac.adiumx.com/ticket/10582
Scroll to the end and login.
Put text into the comment field.
Hit &quot;Preview&quot;
The url is rewritten to have #preview on the end, but other than that, nothing happens.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87736</commentid>
    <comment_count>18</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-03 16:43:35 -0700</bug_when>
    <thetext>(In reply to comment #17)
&gt; Pick a ticket, any ticket, on AdiumX&apos;s trac.
&gt; eg: http://trac.adiumx.com/ticket/10582
&gt; Scroll to the end and login.
&gt; Put text into the comment field.
&gt; Hit &quot;Preview&quot;
&gt; The url is rewritten to have #preview on the end, but other than that, nothing
&gt; happens.

Okay, this is the same issue.  Thanks!
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87893</commentid>
    <comment_count>19</comment_count>
      <attachid>22662</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-05 15:14:06 -0700</bug_when>
    <thetext>Created attachment 22662
Patch v1

Patch with changelog and manual test.

An automated test couldn&apos;t be made since it would always succeed (used a different code path than manually clicking on the Submit button).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87894</commentid>
    <comment_count>20</comment_count>
      <attachid>22662</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-05 15:24:01 -0700</bug_when>
    <thetext>Comment on attachment 22662
Patch v1

Coming soon:  automated layout test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87913</commentid>
    <comment_count>21</comment_count>
      <attachid>22669</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-05 17:44:57 -0700</bug_when>
    <thetext>Created attachment 22669
Patch v2

Now with automated regression test.  My mistake before when creating an automated test was that I tried to submit the form before the page was finished loading, preventing the bug from reproducing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87919</commentid>
    <comment_count>22</comment_count>
      <attachid>22669</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-08-05 18:36:54 -0700</bug_when>
    <thetext>Comment on attachment 22669
Patch v2

Looks good to me!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87986</commentid>
    <comment_count>23</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-08-06 14:15:57 -0700</bug_when>
    <thetext>$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/forms/submit-to-url-fragment-expected.txt
	A	LayoutTests/fast/forms/submit-to-url-fragment.html
	M	WebCore/ChangeLog
	M	WebCore/html/HTMLFormElement.cpp
	M	WebCore/loader/FrameLoader.cpp
	M	WebCore/loader/FrameLoader.h
Committed r35611

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>104336</commentid>
    <comment_count>24</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2009-01-04 08:44:11 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; Regressed with http://trac.webkit.org/changeset/35151

See Bug 13067.

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>22662</attachid>
            <date>2008-08-05 15:14:06 -0700</date>
            <delta_ts>2008-08-05 17:44:57 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>fix-bug-20038-v1.diff</filename>
            <type>text/plain</type>
            <size>6556</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NTMyYTUxZS4uMjg3M2RiNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSw1MyBAQAorMjAwOC0wOC0wNSAgRGF2aWQgRC4gS2ls
emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEJ1ZyAyMDAzODogUkVHUkVTU0lP
TiAocjM1MTUxKTogQ2FuJ3QgcG9zdCBjb21tZW50cyBvbiBmbGlja3IuY29tCisKKyAgICAgICAg
PGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAzOD4KKyAgICAgICAg
PHJkYXI6Ly9wcm9ibGVtLzYwOTIyNzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgVGVzdDogV2ViQ29yZS9tYW51YWwtdGVzdHMvc3VibWl0LXRvLXVy
bC1oYXNoLmh0bWwKKworICAgICAgICBUaGUgcHJvYmxlbSB3YXMgdGhhdCBpc0Zvcm1TdWJtaXNz
aW9uIHdhcyBub3QgYmVpbmcgc2V0IHRvIHRydWUgaW4KKyAgICAgICAgRnJhbWVMb2FkZXI6Omxv
YWRXaXRoRG9jdW1lbnRMb2FkZXIoKSB3aGVuIHdlIHdlcmUgYWN0dWFsbHkKKyAgICAgICAgc3Vi
bWl0dGluZyBhIGZvcm0sIGNhdXNpbmcgdGhlIHBhZ2UgdG8gc2Nyb2xsIGluc3RlYWQgb2YgdGhl
IGZvcm0gdG8KKyAgICAgICAgYmUgc3VibWl0dGVkLgorCisgICAgICAgIFRoZSBpc0Zvcm1TdWJt
aXNzaW9uIHZhcmlhYmxlIHdhc24ndCBzZXQgdG8gdHJ1ZSBiZWNhdXNlIGEgRm9ybVN0YXRlCisg
ICAgICAgIG9iamVjdCB3YXMgbm90IGJlaW5nIGNyZWF0ZWQgaW4KKyAgICAgICAgRnJhbWVMb2Fk
ZXI6OmxvYWRGcmFtZVJlcXVlc3RXaXRoRm9ybUFuZFZhbHVlcygpLgorCisgICAgICAgIFRoZSBG
b3JtU3RhdGUgb2JqZWN0IHdhcyBub3QgYmVpbmcgY3JlYXRlZCBiZWNhdXNlCisgICAgICAgIEhU
TUxGb3JtRWxlbWVudDo6c3VibWl0KEV2ZW50KiwgYm9vbCBhY3RpdmF0ZVN1Ym1pdEJ1dHRvbikg
d291bGQKKyAgICAgICAgb25seSBzZXQgRnJhbWVMb2FkZXI6Om1fZm9ybUFib3V0VG9CZVN1Ym1p
dHRlZCB0byB0aGUgY3VycmVudCBmb3JtCisgICAgICAgIGlmIHRoZXJlIHdhcyBhICJ0ZXh0IGZp
ZWxkIiBlbGVtZW50IGluIHRoZSBmb3JtICh0eXBlID0gdGV4dCwKKyAgICAgICAgcGFzc3dvcmQs
IHNlYXJjaCBvciBpc2luZGV4KS4KKworICAgICAgICBUaHVzIHdoZW4gRnJhbWVMb2FkZXI6OnN1
Ym1pdEZvcm0oY29uc3QgRnJhbWVMb2FkUmVxdWVzdCYsIEV2ZW50KikKKyAgICAgICAgY2FsbGVk
IEZyYW1lTG9hZGVyOjpsb2FkRnJhbWVSZXF1ZXN0V2l0aEZvcm1BbmRWYWx1ZXMoKSwgYSBudWxs
CisgICAgICAgIEhUTUxGb3JtRWxlbWVudCBwb2ludGVyIHdvdWxkIGJlIHNlbnQgYW5kIGNhdXNl
IHRoZSBhYm92ZSBmYWlsdXJlcy4KKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1FbGVtZW50LmNw
cDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtRWxlbWVudDo6c3VibWl0KTogQ2FsbCBuZXcK
KyAgICAgICAgRnJhbWVMb2FkZXI6OnNldEZvcm1BYm91dFRvQmVTdWJtaXR0ZWQoKSBtZXRob2Qg
b3V0c2lkZSB0aGUgZm9yCisgICAgICAgIGxvb3Agc28gd2UgYWx3YXlzIHNldCBGcmFtZUxvYWRl
cjo6bV9mb3JtQWJvdXRUb0JlU3VibWl0dGVkIGV4YWN0bHkKKyAgICAgICAgb25jZSBmb3IgYW55
IGZvcm0gc3VibWlzc2lvbi4gIFRoZSBGcmFtZUxvYWRlcjo6cmVjb3JkRm9ybVZhbHVlKCkKKyAg
ICAgICAgbWV0aG9kIGlzIG9ubHkgY2FsbGVkIHdpdGggdGhlIG5hbWUvdmFsdWUgcGFpciBvZiBl
YWNoIHRleHQgZmllbGQuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAg
ICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnNldEZvcm1BYm91dFRvQmVTdWJtaXR0ZWQpOiBB
ZGRlZCBtZXRob2QgdGhhdAorICAgICAgICBvbmx5IHNldHMgbV9mb3JtQWJvdXRUb0JlU3VibWl0
dGVkLgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnJlY29yZEZvcm1WYWx1ZSk6IFJl
bW92ZWQKKyAgICAgICAgUGFzc1JlZlB0cjxIVE1MRm9ybUVsZW1lbnQ+IGFyZ3VtZW50IHNpbmNl
IHRoaXMgbWV0aG9kIG9ubHkgc2V0cworICAgICAgICBuYW1lL3ZhbHVlIHBhaXJzIG9uIG1fZm9y
bVZhbHVlc0Fib3V0VG9CZVN1Ym1pdHRlZCBub3cuCisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxv
YWRlcjo6bG9hZEZyYW1lUmVxdWVzdFdpdGhGb3JtQW5kVmFsdWVzKTogQ3JlYXRlIGEKKyAgICAg
ICAgRm9ybVN0YXRlIG9iamVjdCBhcyBsb25nIGFzIHN1Ym1pdEZvcm0gaXMgbm90IG51bGwgc28g
dGhhdCBvdGhlcgorICAgICAgICBGcmFtZUxvYWRlciBtZXRob2RzIGtub3cgd2hlbiBhIGZvcm0g
aXMgYmVpbmcgc3VibWl0dGVkLgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5oOgorCisg
ICAgICAgICogbWFudWFsLXRlc3RzL3N1Ym1pdC10by11cmwtaGFzaC5odG1sOiBBZGRlZC4KKwog
MjAwOC0wOC0wMiAgTWF4aW1lIEJyaXR0byAgPGJyaXR0b0BhcHBsZS5jb20+CiAKICAgICAgICAg
UmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTEZv
cm1FbGVtZW50LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCmluZGV4IGI0
NzhkNGQuLjFlZTk3NGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQu
Y3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCkBAIC00NDMsMTIgKzQ0
MywxMyBAQCB2b2lkIEhUTUxGb3JtRWxlbWVudDo6c3VibWl0KEV2ZW50KiBldmVudCwgYm9vbCBh
Y3RpdmF0ZVN1Ym1pdEJ1dHRvbikKICAgICBib29sIG5lZWRCdXR0b25BY3RpdmF0aW9uID0gYWN0
aXZhdGVTdWJtaXRCdXR0b247IC8vIGRvIHdlIG5lZWQgdG8gYWN0aXZhdGUgYSBzdWJtaXQgYnV0
dG9uPwogICAgIAogICAgIGZyYW1lLT5sb2FkZXIoKS0+Y2xlYXJSZWNvcmRlZEZvcm1WYWx1ZXMo
KTsKKyAgICBmcmFtZS0+bG9hZGVyKCktPnNldEZvcm1BYm91dFRvQmVTdWJtaXR0ZWQodGhpcyk7
CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGZvcm1FbGVtZW50cy5zaXplKCk7ICsraSkg
ewogICAgICAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50KiBjb250cm9sID0gZm9ybUVsZW1lbnRz
W2ldOwogICAgICAgICBpZiAoY29udHJvbC0+aGFzTG9jYWxOYW1lKGlucHV0VGFnKSkgewogICAg
ICAgICAgICAgSFRNTElucHV0RWxlbWVudCogaW5wdXQgPSBzdGF0aWNfY2FzdDxIVE1MSW5wdXRF
bGVtZW50Kj4oY29udHJvbCk7CiAgICAgICAgICAgICBpZiAoaW5wdXQtPmlzVGV4dEZpZWxkKCkp
IHsKLSAgICAgICAgICAgICAgICBmcmFtZS0+bG9hZGVyKCktPnJlY29yZEZvcm1WYWx1ZShpbnB1
dC0+bmFtZSgpLCBpbnB1dC0+dmFsdWUoKSwgdGhpcyk7CisgICAgICAgICAgICAgICAgZnJhbWUt
PmxvYWRlcigpLT5yZWNvcmRGb3JtVmFsdWUoaW5wdXQtPm5hbWUoKSwgaW5wdXQtPnZhbHVlKCkp
OwogICAgICAgICAgICAgICAgIGlmIChpbnB1dC0+aXNTZWFyY2hGaWVsZCgpKQogICAgICAgICAg
ICAgICAgICAgICBpbnB1dC0+YWRkU2VhcmNoUmVzdWx0KCk7CiAgICAgICAgICAgICB9CmRpZmYg
LS1naXQgYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9XZWJDb3JlL2xvYWRlci9G
cmFtZUxvYWRlci5jcHAKaW5kZXggYzAwYTdiYS4uY2U1NGNkOCAxMDA2NDQKLS0tIGEvV2ViQ29y
ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy
LmNwcApAQCAtMTc0OSw5ICsxNzQ5LDEzIEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNsZWFyUmVjb3Jk
ZWRGb3JtVmFsdWVzKCkKICAgICBtX2Zvcm1WYWx1ZXNBYm91dFRvQmVTdWJtaXR0ZWQuY2xlYXIo
KTsKIH0KIAotdm9pZCBGcmFtZUxvYWRlcjo6cmVjb3JkRm9ybVZhbHVlKGNvbnN0IFN0cmluZyYg
bmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSwgUGFzc1JlZlB0cjxIVE1MRm9ybUVsZW1lbnQ+IGVs
ZW1lbnQpCit2b2lkIEZyYW1lTG9hZGVyOjpzZXRGb3JtQWJvdXRUb0JlU3VibWl0dGVkKFBhc3NS
ZWZQdHI8SFRNTEZvcm1FbGVtZW50PiBlbGVtZW50KQogewogICAgIG1fZm9ybUFib3V0VG9CZVN1
Ym1pdHRlZCA9IGVsZW1lbnQ7Cit9CisKK3ZvaWQgRnJhbWVMb2FkZXI6OnJlY29yZEZvcm1WYWx1
ZShjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmFsdWUpCit7CiAgICAgbV9mb3Jt
VmFsdWVzQWJvdXRUb0JlU3VibWl0dGVkLnNldChuYW1lLCB2YWx1ZSk7CiB9CiAKQEAgLTIwODgs
MTQgKzIwOTIsMTQgQEAgdm9pZCBGcmFtZUxvYWRlcjo6bG9hZEZyYW1lUmVxdWVzdFdpdGhGb3Jt
U3RhdGUoY29uc3QgRnJhbWVMb2FkUmVxdWVzdCYgcmVxdWVzdCwKICAgICAgICAgaWYgKFBhZ2Uq
IHBhZ2UgPSB0YXJnZXRGcmFtZS0+cGFnZSgpKQogICAgICAgICAgICAgcGFnZS0+Y2hyb21lKCkt
PmZvY3VzKCk7CiB9Ci0gICAgICAgIAorCiB2b2lkIEZyYW1lTG9hZGVyOjpsb2FkRnJhbWVSZXF1
ZXN0V2l0aEZvcm1BbmRWYWx1ZXMoY29uc3QgRnJhbWVMb2FkUmVxdWVzdCYgcmVxdWVzdCwgYm9v
bCBsb2NrSGlzdG9yeSwgRXZlbnQqIGV2ZW50LAogICAgIEhUTUxGb3JtRWxlbWVudCogc3VibWl0
Rm9ybSwgY29uc3QgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4mIGZvcm1WYWx1ZXMpCiB7CiAgICAg
UmVmUHRyPEZvcm1TdGF0ZT4gZm9ybVN0YXRlOwotICAgIGlmIChzdWJtaXRGb3JtICYmICFmb3Jt
VmFsdWVzLmlzRW1wdHkoKSkKKyAgICBpZiAoc3VibWl0Rm9ybSkKICAgICAgICAgZm9ybVN0YXRl
ID0gRm9ybVN0YXRlOjpjcmVhdGUoc3VibWl0Rm9ybSwgZm9ybVZhbHVlcywgbV9mcmFtZSk7Ci0g
ICAgCisKICAgICBsb2FkRnJhbWVSZXF1ZXN0V2l0aEZvcm1TdGF0ZShyZXF1ZXN0LCBsb2NrSGlz
dG9yeSwgZXZlbnQsIGZvcm1TdGF0ZS5yZWxlYXNlKCkpOyAgICAgICAgCiB9CiAKZGlmZiAtLWdp
dCBhL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmggYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxv
YWRlci5oCmluZGV4IDRmMDRiOTcuLjc4ODZjZTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvbG9hZGVy
L0ZyYW1lTG9hZGVyLmgKKysrIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaApAQCAtMzg2
LDcgKzM4Niw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBzY2hlZHVsZUNo
ZWNrTG9hZENvbXBsZXRlKCk7CiAKICAgICAgICAgdm9pZCBjbGVhclJlY29yZGVkRm9ybVZhbHVl
cygpOwotICAgICAgICB2b2lkIHJlY29yZEZvcm1WYWx1ZShjb25zdCBTdHJpbmcmIG5hbWUsIGNv
bnN0IFN0cmluZyYgdmFsdWUsIFBhc3NSZWZQdHI8SFRNTEZvcm1FbGVtZW50Pik7CisgICAgICAg
IHZvaWQgc2V0Rm9ybUFib3V0VG9CZVN1Ym1pdHRlZChQYXNzUmVmUHRyPEhUTUxGb3JtRWxlbWVu
dD4gZWxlbWVudCk7CisgICAgICAgIHZvaWQgcmVjb3JkRm9ybVZhbHVlKGNvbnN0IFN0cmluZyYg
bmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSk7CiAKICAgICAgICAgYm9vbCBpc0NvbXBsZXRlKCkg
Y29uc3Q7CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvbWFudWFsLXRlc3RzL3N1Ym1pdC10by11cmwt
aGFzaC5odG1sIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvc3VibWl0LXRvLXVybC1oYXNoLmh0bWwK
bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uOTE2MDJiYQotLS0gL2Rldi9udWxs
CisrKyBiL1dlYkNvcmUvbWFudWFsLXRlc3RzL3N1Ym1pdC10by11cmwtaGFzaC5odG1sCkBAIC0w
LDAgKzEsMjcgQEAKKzxodG1sPgorPGhlYWQ+Cis8dGl0bGU+VGVzdCBmb3IgQnVnIDIwMDM4OiBS
RUdSRVNTSU9OIChyMzUxNTEpOiBDYW4ndCBwb3N0IGNvbW1lbnRzIG9uIGZsaWNrci5jb208L3Rp
dGxlPgorPC9oZWFkPgorPGJvZHk+Cis8cD4KK1Rlc3QgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAzOCI+QnVnIDIwMDM4OiBSRUdSRVNTSU9O
IChyMzUxNTEpOiBDYW4ndCBwb3N0IGNvbW1lbnRzIG9uIGZsaWNrci5jb208L2E+Cis8L3A+Cis8
b2w+Cis8bGk+Q2xpY2sgb24gIlN1Ym1pdCIgYnV0dG9uLjwvbGk+Cis8bGk+UGFnZSBzaG91bGQg
cmVsb2FkIChldmVuIGlmIGxvYWRlZCBsb2NhbGx5KSBhbmQgc2Nyb2xsIHRvICJQQVNTIi4KKzwv
b2w+Cis8Zm9ybSBhY3Rpb249IiNwcmV2aWV3IiBtZXRob2Q9InBvc3QiPgorPGlucHV0IGlkPSJt
eXN1Ym1pdCIgdHlwZT0ic3VibWl0IiBuYW1lPSJTdWJtaXQiIHZhbHVlPSJTdWJtaXQiPgorPC9m
b3JtPgorPGRpdiBpZD0icHJldmlldyI+Cis8c2NyaXB0PgoraWYgKGRvY3VtZW50LmxvY2F0aW9u
Lmhhc2ggIT0gIiNwcmV2aWV3IikgeworICAgIGRvY3VtZW50LndyaXRlKCJGQUlMIik7Cit9IGVs
c2UgeworICAgIGRvY3VtZW50LndyaXRlKCJQQVNTIik7Cit9Cis8L3NjcmlwdD4KKzwvZGl2Pgor
PGRpdiBzdHlsZT0ibWluLWhlaWdodDogMTAwMHB4OyI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+
Cg==
</data>
<flag name="review"
          id="10032"
          type_id="1"
          status="-"
          setter="ddkilzer"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>22669</attachid>
            <date>2008-08-05 17:44:57 -0700</date>
            <delta_ts>2008-08-05 18:36:54 -0700</delta_ts>
            <desc>Patch v2</desc>
            <filename>fix-bug-20038-v2.diff</filename>
            <type>text/plain</type>
            <size>7912</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NTMyYTUxZS4uY2YzYjcwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSw1MSBAQAorMjAwOC0wOC0wNSAgRGF2aWQgRC4gS2ls
emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEJ1ZyAyMDAzODogUkVHUkVTU0lP
TiAocjM1MTUxKTogQ2FuJ3QgcG9zdCBjb21tZW50cyBvbiBmbGlja3IuY29tCisKKyAgICAgICAg
PGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAzOD4KKyAgICAgICAg
PHJkYXI6Ly9wcm9ibGVtLzYwOTIyNzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy9zdWJtaXQtdG8tdXJsLWZyYWdtZW50
Lmh0bWwKKworICAgICAgICBUaGUgcHJvYmxlbSB3YXMgdGhhdCBpc0Zvcm1TdWJtaXNzaW9uIHdh
cyBub3QgYmVpbmcgc2V0IHRvIHRydWUgaW4KKyAgICAgICAgRnJhbWVMb2FkZXI6OmxvYWRXaXRo
RG9jdW1lbnRMb2FkZXIoKSB3aGVuIHdlIHdlcmUgYWN0dWFsbHkKKyAgICAgICAgc3VibWl0dGlu
ZyBhIGZvcm0sIGNhdXNpbmcgdGhlIHBhZ2UgdG8gc2Nyb2xsIGluc3RlYWQgb2YgdGhlIGZvcm0g
dG8KKyAgICAgICAgYmUgc3VibWl0dGVkLgorCisgICAgICAgIFRoZSBpc0Zvcm1TdWJtaXNzaW9u
IHZhcmlhYmxlIHdhc24ndCBzZXQgdG8gdHJ1ZSBiZWNhdXNlIGEgRm9ybVN0YXRlCisgICAgICAg
IG9iamVjdCB3YXMgbm90IGJlaW5nIGNyZWF0ZWQgaW4KKyAgICAgICAgRnJhbWVMb2FkZXI6Omxv
YWRGcmFtZVJlcXVlc3RXaXRoRm9ybUFuZFZhbHVlcygpLgorCisgICAgICAgIFRoZSBGb3JtU3Rh
dGUgb2JqZWN0IHdhcyBub3QgYmVpbmcgY3JlYXRlZCBiZWNhdXNlCisgICAgICAgIEhUTUxGb3Jt
RWxlbWVudDo6c3VibWl0KEV2ZW50KiwgYm9vbCBhY3RpdmF0ZVN1Ym1pdEJ1dHRvbikgd291bGQK
KyAgICAgICAgb25seSBzZXQgRnJhbWVMb2FkZXI6Om1fZm9ybUFib3V0VG9CZVN1Ym1pdHRlZCB0
byB0aGUgY3VycmVudCBmb3JtCisgICAgICAgIGlmIHRoZXJlIHdhcyBhICJ0ZXh0IGZpZWxkIiBl
bGVtZW50IGluIHRoZSBmb3JtICh0eXBlID0gdGV4dCwKKyAgICAgICAgcGFzc3dvcmQsIHNlYXJj
aCBvciBpc2luZGV4KS4KKworICAgICAgICBUaHVzIHdoZW4gRnJhbWVMb2FkZXI6OnN1Ym1pdEZv
cm0oY29uc3QgRnJhbWVMb2FkUmVxdWVzdCYsIEV2ZW50KikKKyAgICAgICAgY2FsbGVkIEZyYW1l
TG9hZGVyOjpsb2FkRnJhbWVSZXF1ZXN0V2l0aEZvcm1BbmRWYWx1ZXMoKSwgYSBudWxsCisgICAg
ICAgIEhUTUxGb3JtRWxlbWVudCBwb2ludGVyIHdvdWxkIGJlIHNlbnQgYW5kIGNhdXNlIHRoZSBh
Ym92ZSBmYWlsdXJlcy4KKworICAgICAgICAqIGh0bWwvSFRNTEZvcm1FbGVtZW50LmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtRWxlbWVudDo6c3VibWl0KTogQ2FsbCBuZXcKKyAgICAg
ICAgRnJhbWVMb2FkZXI6OnNldEZvcm1BYm91dFRvQmVTdWJtaXR0ZWQoKSBtZXRob2Qgb3V0c2lk
ZSB0aGUgZm9yCisgICAgICAgIGxvb3Agc28gd2UgYWx3YXlzIHNldCBGcmFtZUxvYWRlcjo6bV9m
b3JtQWJvdXRUb0JlU3VibWl0dGVkIGV4YWN0bHkKKyAgICAgICAgb25jZSBmb3IgYW55IGZvcm0g
c3VibWlzc2lvbi4gIFRoZSBGcmFtZUxvYWRlcjo6cmVjb3JkRm9ybVZhbHVlKCkKKyAgICAgICAg
bWV0aG9kIGlzIG9ubHkgY2FsbGVkIHdpdGggdGhlIG5hbWUvdmFsdWUgcGFpciBvZiBlYWNoIHRl
eHQgZmllbGQuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAo
V2ViQ29yZTo6RnJhbWVMb2FkZXI6OnNldEZvcm1BYm91dFRvQmVTdWJtaXR0ZWQpOiBBZGRlZCBt
ZXRob2QgdGhhdAorICAgICAgICBvbmx5IHNldHMgbV9mb3JtQWJvdXRUb0JlU3VibWl0dGVkLgor
ICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnJlY29yZEZvcm1WYWx1ZSk6IFJlbW92ZWQK
KyAgICAgICAgUGFzc1JlZlB0cjxIVE1MRm9ybUVsZW1lbnQ+IGFyZ3VtZW50IHNpbmNlIHRoaXMg
bWV0aG9kIG9ubHkgc2V0cworICAgICAgICBuYW1lL3ZhbHVlIHBhaXJzIG9uIG1fZm9ybVZhbHVl
c0Fib3V0VG9CZVN1Ym1pdHRlZCBub3cuCisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6
bG9hZEZyYW1lUmVxdWVzdFdpdGhGb3JtQW5kVmFsdWVzKTogQ3JlYXRlIGEKKyAgICAgICAgRm9y
bVN0YXRlIG9iamVjdCBhcyBsb25nIGFzIHN1Ym1pdEZvcm0gaXMgbm90IG51bGwgc28gdGhhdCBv
dGhlcgorICAgICAgICBGcmFtZUxvYWRlciBtZXRob2RzIGtub3cgd2hlbiBhIGZvcm0gaXMgYmVp
bmcgc3VibWl0dGVkLgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5oOgorCiAyMDA4LTA4
LTAyICBNYXhpbWUgQnJpdHRvICA8YnJpdHRvQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl
ZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1l
bnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAKaW5kZXggYjQ3OGQ0ZC4u
MWVlOTc0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAKKysr
IGIvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAKQEAgLTQ0MywxMiArNDQzLDEzIEBA
IHZvaWQgSFRNTEZvcm1FbGVtZW50OjpzdWJtaXQoRXZlbnQqIGV2ZW50LCBib29sIGFjdGl2YXRl
U3VibWl0QnV0dG9uKQogICAgIGJvb2wgbmVlZEJ1dHRvbkFjdGl2YXRpb24gPSBhY3RpdmF0ZVN1
Ym1pdEJ1dHRvbjsgLy8gZG8gd2UgbmVlZCB0byBhY3RpdmF0ZSBhIHN1Ym1pdCBidXR0b24/CiAg
ICAgCiAgICAgZnJhbWUtPmxvYWRlcigpLT5jbGVhclJlY29yZGVkRm9ybVZhbHVlcygpOworICAg
IGZyYW1lLT5sb2FkZXIoKS0+c2V0Rm9ybUFib3V0VG9CZVN1Ym1pdHRlZCh0aGlzKTsKICAgICBm
b3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZm9ybUVsZW1lbnRzLnNpemUoKTsgKytpKSB7CiAgICAg
ICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQqIGNvbnRyb2wgPSBmb3JtRWxlbWVudHNbaV07CiAg
ICAgICAgIGlmIChjb250cm9sLT5oYXNMb2NhbE5hbWUoaW5wdXRUYWcpKSB7CiAgICAgICAgICAg
ICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCA9IHN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQq
Pihjb250cm9sKTsKICAgICAgICAgICAgIGlmIChpbnB1dC0+aXNUZXh0RmllbGQoKSkgewotICAg
ICAgICAgICAgICAgIGZyYW1lLT5sb2FkZXIoKS0+cmVjb3JkRm9ybVZhbHVlKGlucHV0LT5uYW1l
KCksIGlucHV0LT52YWx1ZSgpLCB0aGlzKTsKKyAgICAgICAgICAgICAgICBmcmFtZS0+bG9hZGVy
KCktPnJlY29yZEZvcm1WYWx1ZShpbnB1dC0+bmFtZSgpLCBpbnB1dC0+dmFsdWUoKSk7CiAgICAg
ICAgICAgICAgICAgaWYgKGlucHV0LT5pc1NlYXJjaEZpZWxkKCkpCiAgICAgICAgICAgICAgICAg
ICAgIGlucHV0LT5hZGRTZWFyY2hSZXN1bHQoKTsKICAgICAgICAgICAgIH0KZGlmZiAtLWdpdCBh
L1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h
ZGVyLmNwcAppbmRleCBjMDBhN2JhLi5jZTU0Y2Q4IDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRl
ci9GcmFtZUxvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBA
IC0xNzQ5LDkgKzE3NDksMTMgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y2xlYXJSZWNvcmRlZEZvcm1W
YWx1ZXMoKQogICAgIG1fZm9ybVZhbHVlc0Fib3V0VG9CZVN1Ym1pdHRlZC5jbGVhcigpOwogfQog
Ci12b2lkIEZyYW1lTG9hZGVyOjpyZWNvcmRGb3JtVmFsdWUoY29uc3QgU3RyaW5nJiBuYW1lLCBj
b25zdCBTdHJpbmcmIHZhbHVlLCBQYXNzUmVmUHRyPEhUTUxGb3JtRWxlbWVudD4gZWxlbWVudCkK
K3ZvaWQgRnJhbWVMb2FkZXI6OnNldEZvcm1BYm91dFRvQmVTdWJtaXR0ZWQoUGFzc1JlZlB0cjxI
VE1MRm9ybUVsZW1lbnQ+IGVsZW1lbnQpCiB7CiAgICAgbV9mb3JtQWJvdXRUb0JlU3VibWl0dGVk
ID0gZWxlbWVudDsKK30KKwordm9pZCBGcmFtZUxvYWRlcjo6cmVjb3JkRm9ybVZhbHVlKGNvbnN0
IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSkKK3sKICAgICBtX2Zvcm1WYWx1ZXNB
Ym91dFRvQmVTdWJtaXR0ZWQuc2V0KG5hbWUsIHZhbHVlKTsKIH0KIApAQCAtMjA4OCwxNCArMjA5
MiwxNCBAQCB2b2lkIEZyYW1lTG9hZGVyOjpsb2FkRnJhbWVSZXF1ZXN0V2l0aEZvcm1TdGF0ZShj
b25zdCBGcmFtZUxvYWRSZXF1ZXN0JiByZXF1ZXN0LAogICAgICAgICBpZiAoUGFnZSogcGFnZSA9
IHRhcmdldEZyYW1lLT5wYWdlKCkpCiAgICAgICAgICAgICBwYWdlLT5jaHJvbWUoKS0+Zm9jdXMo
KTsKIH0KLSAgICAgICAgCisKIHZvaWQgRnJhbWVMb2FkZXI6OmxvYWRGcmFtZVJlcXVlc3RXaXRo
Rm9ybUFuZFZhbHVlcyhjb25zdCBGcmFtZUxvYWRSZXF1ZXN0JiByZXF1ZXN0LCBib29sIGxvY2tI
aXN0b3J5LCBFdmVudCogZXZlbnQsCiAgICAgSFRNTEZvcm1FbGVtZW50KiBzdWJtaXRGb3JtLCBj
b25zdCBIYXNoTWFwPFN0cmluZywgU3RyaW5nPiYgZm9ybVZhbHVlcykKIHsKICAgICBSZWZQdHI8
Rm9ybVN0YXRlPiBmb3JtU3RhdGU7Ci0gICAgaWYgKHN1Ym1pdEZvcm0gJiYgIWZvcm1WYWx1ZXMu
aXNFbXB0eSgpKQorICAgIGlmIChzdWJtaXRGb3JtKQogICAgICAgICBmb3JtU3RhdGUgPSBGb3Jt
U3RhdGU6OmNyZWF0ZShzdWJtaXRGb3JtLCBmb3JtVmFsdWVzLCBtX2ZyYW1lKTsKLSAgICAKKwog
ICAgIGxvYWRGcmFtZVJlcXVlc3RXaXRoRm9ybVN0YXRlKHJlcXVlc3QsIGxvY2tIaXN0b3J5LCBl
dmVudCwgZm9ybVN0YXRlLnJlbGVhc2UoKSk7ICAgICAgICAKIH0KIApkaWZmIC0tZ2l0IGEvV2Vi
Q29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaCBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgK
aW5kZXggNGYwNGI5Ny4uNzg4NmNlMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvRnJhbWVM
b2FkZXIuaAorKysgYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCkBAIC0zODYsNyArMzg2
LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2b2lkIHNjaGVkdWxlQ2hlY2tMb2Fk
Q29tcGxldGUoKTsKIAogICAgICAgICB2b2lkIGNsZWFyUmVjb3JkZWRGb3JtVmFsdWVzKCk7Ci0g
ICAgICAgIHZvaWQgcmVjb3JkRm9ybVZhbHVlKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3Ry
aW5nJiB2YWx1ZSwgUGFzc1JlZlB0cjxIVE1MRm9ybUVsZW1lbnQ+KTsKKyAgICAgICAgdm9pZCBz
ZXRGb3JtQWJvdXRUb0JlU3VibWl0dGVkKFBhc3NSZWZQdHI8SFRNTEZvcm1FbGVtZW50PiBlbGVt
ZW50KTsKKyAgICAgICAgdm9pZCByZWNvcmRGb3JtVmFsdWUoY29uc3QgU3RyaW5nJiBuYW1lLCBj
b25zdCBTdHJpbmcmIHZhbHVlKTsKIAogICAgICAgICBib29sIGlzQ29tcGxldGUoKSBjb25zdDsK
IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nCmluZGV4IDNlMjU5MTkuLmZhOWIzY2MgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n
ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOC0w
OC0wNSAgRGF2aWQgRC4gS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEJ1
ZyAyMDAzODogUkVHUkVTU0lPTiAocjM1MTUxKTogQ2FuJ3QgcG9zdCBjb21tZW50cyBvbiBmbGlj
a3IuY29tCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMDAzOD4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYwOTIyNzA+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3N1Ym1pdC10
by11cmwtZnJhZ21lbnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1z
L3N1Ym1pdC10by11cmwtZnJhZ21lbnQuaHRtbDogQWRkZWQuCisKIDIwMDgtMDgtMDMgIERhdmlk
IEQuIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGdXR1cmUtcHJvb2Yg
ZmFzdC9jb29raWVzL2xvY2FsLWZpbGUtY2FuLXNldC1jb29raWVzLmh0bWwKZGlmZiAtLWdpdCBh
L0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LXRvLXVybC1mcmFnbWVudC1leHBlY3RlZC50
eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3N1Ym1pdC10by11cmwtZnJhZ21lbnQtZXhwZWN0
ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmQyZjY5OGQKLS0tIC9k
ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3N1Ym1pdC10by11cmwtZnJhZ21l
bnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorVGVzdCBmb3IgQnVnIDIwMDM4OiBSRUdS
RVNTSU9OIChyMzUxNTEpOiBDYW4ndCBwb3N0IGNvbW1lbnRzIG9uIGZsaWNrci5jb20KKworCitQ
QVNTCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LXRvLXVybC1m
cmFnbWVudC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdWJtaXQtdG8tdXJsLWZyYWdt
ZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZTJjZDg3ZQotLS0g
L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc3VibWl0LXRvLXVybC1mcmFn
bWVudC5odG1sCkBAIC0wLDAgKzEsMzkgQEAKKzxodG1sPgorPGhlYWQ+Cis8dGl0bGU+VGVzdCBm
b3IgQnVnIDIwMDM4OiBSRUdSRVNTSU9OIChyMzUxNTEpOiBDYW4ndCBwb3N0IGNvbW1lbnRzIG9u
IGZsaWNrci5jb208L3RpdGxlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy
b2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5
b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworfQorCitmdW5jdGlvbiBydW5UZXN0
KCkgeworICAgIGlmIChkb2N1bWVudC5sb2NhdGlvbi5oYXNoICE9ICIjcHJldmlldyIpIHsKKyAg
ICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm15c3VibWl0IikuY2xpY2soKTsKKyAgICAg
ICAgc2V0VGltZW91dCgnaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeyBsYXlvdXRU
ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7IH0nLCA1MDAwKTsKKyAgICB9Cit9Cis8L3Njcmlw
dD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxwPgorVGVzdCBmb3IgPGEg
aHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDM4Ij5CdWcg
MjAwMzg6IFJFR1JFU1NJT04gKHIzNTE1MSk6IENhbid0IHBvc3QgY29tbWVudHMgb24gZmxpY2ty
LmNvbTwvYT4KKzwvcD4KKzxmb3JtIGFjdGlvbj0iI3ByZXZpZXciIG1ldGhvZD0icG9zdCI+Cis8
aW5wdXQgaWQ9Im15c3VibWl0IiB0eXBlPSJzdWJtaXQiIG5hbWU9IlN1Ym1pdCIgdmFsdWU9IlN1
Ym1pdCI+Cis8L2Zvcm0+Cis8ZGl2IGlkPSJwcmV2aWV3Ij4KKzxzY3JpcHQ+CitpZiAoZG9jdW1l
bnQubG9jYXRpb24uaGFzaCAhPSAiI3ByZXZpZXciKSB7CisgICAgZG9jdW1lbnQud3JpdGUoIkZB
SUwiKTsKK30gZWxzZSB7CisgICAgZG9jdW1lbnQud3JpdGUoIlBBU1MiKTsKKyAgICBpZiAod2lu
ZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy
Lm5vdGlmeURvbmUoKTsKKyAgICB9Cit9Cis8L3NjcmlwdD4KKzwvZGl2PgorPGRpdiBzdHlsZT0i
bWluLWhlaWdodDogMTAwMHB4OyI+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>
<flag name="review"
          id="10038"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>