200379 2019-08-01 20:40:20 -0700 Remove constructors and operators of FontPlatformData defined only for Freetype 2019-08-02 03:21:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annulen annulen cgarcia commit-queue ews-watchlist fred.wang mcatanzaro mmaxfield webkit-bug-importer oldest_to_newest 1557855 0 annulen 2019-08-01 20:40:20 -0700 These methods only make maintenance harder, as all data fields are trivially copyable. Constructors generated by compiler should be used instead. 1557857 1 375388 annulen 2019-08-01 20:41:43 -0700 Created attachment 375388 Patch 1557904 2 375388 cgarcia 2019-08-02 01:34:49 -0700 Comment on attachment 375388 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375388&action=review > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:-155 > - I think we only needed this when we had m_fallbacks and m_harfBuzzFace members that we had to reset on copy. 1557917 3 375388 commit-queue 2019-08-02 03:20:54 -0700 Comment on attachment 375388 Patch Clearing flags on attachment: 375388 Committed r248152: <https://trac.webkit.org/changeset/248152> 1557918 4 commit-queue 2019-08-02 03:20:56 -0700 All reviewed patches have been landed. Closing bug. 1557919 5 webkit-bug-importer 2019-08-02 03:21:17 -0700 <rdar://problem/53856484> 375388 2019-08-01 20:41:43 -0700 2019-08-02 03:20:54 -0700 Patch bug-200379-20190802064142.patch text/plain 3291 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGEwMDIxMTUzNmQ2ZGE3 Zjc1OTU2YTdjMzJlMThjZGI5ZDBlYWU3MS4uNDRhZjJjM2QyNzliOGY1YTE3ZGRmNWY0NzhlNjc3 NDkyNWIyZWFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA4LTAxICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBSZW1vdmUgY29u c3RydWN0b3JzIGFuZCBvcGVyYXRvcnMgb2YgRm9udFBsYXRmb3JtRGF0YSBkZWZpbmVkIG9ubHkg Zm9yIEZyZWV0eXBlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDAzNzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGVzZSBtZXRob2RzIG9ubHkgbWFrZSBtYWludGVuYW5jZSBoYXJkZXIsIGFzIGFsbCBk YXRhIGZpZWxkcyBhcmUKKyAgICAgICAgdHJpdmlhbGx5IGNvcHlhYmxlLiBDb25zdHJ1Y3RvcnMg Z2VuZXJhdGVkIGJ5IGNvbXBpbGVyIHNob3VsZCBiZSB1c2VkCisgICAgICAgIGluc3RlYWQuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250UGxhdGZvcm1EYXRhLmg6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3JtRGF0YUZyZWVUeXBlLmNw cDoKKwogMjAxOS0wOC0wMSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIGNyYXNoIGRpYWdub3N0aWNzIGZvciBkZWJ1Z2dpbmcgdW5leHBlY3RlZCB6YXBwZWQg Y2VsbHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250 UGxhdGZvcm1EYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250UGxh dGZvcm1EYXRhLmgKaW5kZXggMWNhOTc1ZTlmNzg4ZDNiMzA0OWUzMDBlZjQ4NGQzYjJiNDVjN2Jl My4uOGNmODY4MTk2YTg4YTNmYzE4OTc1OGRlMzI0ODRmMDRjMDdiMjAwNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udFBsYXRmb3JtRGF0YS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRQbGF0Zm9ybURhdGEuaApAQCAt MTEzLDExICsxMTMsNiBAQCBwdWJsaWM6CiAKICNpZiBVU0UoRlJFRVRZUEUpCiAgICAgRm9udFBs YXRmb3JtRGF0YShjYWlyb19mb250X2ZhY2VfdCosIEZjUGF0dGVybiosIGZsb2F0IHNpemUsIGJv b2wgZml4ZWRXaWR0aCwgYm9vbCBzeW50aGV0aWNCb2xkLCBib29sIHN5bnRoZXRpY09ibGlxdWUs IEZvbnRPcmllbnRhdGlvbik7Ci0gICAgRm9udFBsYXRmb3JtRGF0YShjb25zdCBGb250UGxhdGZv cm1EYXRhJik7Ci0gICAgRm9udFBsYXRmb3JtRGF0YShGb250UGxhdGZvcm1EYXRhJiYpID0gZGVm YXVsdDsKLSAgICBGb250UGxhdGZvcm1EYXRhJiBvcGVyYXRvcj0oY29uc3QgRm9udFBsYXRmb3Jt RGF0YSYpOwotICAgIEZvbnRQbGF0Zm9ybURhdGEmIG9wZXJhdG9yPShGb250UGxhdGZvcm1EYXRh JiYpID0gZGVmYXVsdDsKLSAgICB+Rm9udFBsYXRmb3JtRGF0YSgpOwogI2VuZGlmCiAKICNpZiBQ TEFURk9STShXSU4pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcApp bmRleCBiY2Y2NzU0YzRhOWVhNjgwNjM4ZDRjNmU2ZTFlMTdiNDQ2ZTdkNTIwLi43MzU3MjYzYTZm M2RkN2I1ODBmNzczY2Q1ZDA1MzM1ZmU3ZmEwZmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0 Zm9ybURhdGFGcmVlVHlwZS5jcHAKQEAgLTEyNiwzOCArMTI2LDYgQEAgRm9udFBsYXRmb3JtRGF0 YTo6Rm9udFBsYXRmb3JtRGF0YShjYWlyb19mb250X2ZhY2VfdCogZm9udEZhY2UsIEZjUGF0dGVy biogcGF0dGUKICNlbmRpZgogfQogCi1Gb250UGxhdGZvcm1EYXRhOjpGb250UGxhdGZvcm1EYXRh KGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEmIG90aGVyKQotewotICAgICp0aGlzID0gb3RoZXI7Ci19 Ci0KLUZvbnRQbGF0Zm9ybURhdGEmIEZvbnRQbGF0Zm9ybURhdGE6Om9wZXJhdG9yPShjb25zdCBG b250UGxhdGZvcm1EYXRhJiBvdGhlcikKLXsKLSAgICAvLyBDaGVjayBmb3Igc2VsZi1hc3NpZ25t ZW50LgotICAgIGlmICh0aGlzID09ICZvdGhlcikKLSAgICAgICAgcmV0dXJuICp0aGlzOwotCi0g ICAgbV9zaXplID0gb3RoZXIubV9zaXplOwotICAgIG1fb3JpZW50YXRpb24gPSBvdGhlci5tX29y aWVudGF0aW9uOwotICAgIG1fd2lkdGhWYXJpYW50ID0gb3RoZXIubV93aWR0aFZhcmlhbnQ7Ci0g ICAgbV90ZXh0UmVuZGVyaW5nTW9kZSA9IG90aGVyLm1fdGV4dFJlbmRlcmluZ01vZGU7Ci0KLSAg ICBtX3N5bnRoZXRpY0JvbGQgPSBvdGhlci5tX3N5bnRoZXRpY0JvbGQ7Ci0gICAgbV9zeW50aGV0 aWNPYmxpcXVlID0gb3RoZXIubV9zeW50aGV0aWNPYmxpcXVlOwotICAgIG1faXNDb2xvckJpdG1h cEZvbnQgPSBvdGhlci5tX2lzQ29sb3JCaXRtYXBGb250OwotICAgIG1faXNIYXNoVGFibGVEZWxl dGVkVmFsdWUgPSBvdGhlci5tX2lzSGFzaFRhYmxlRGVsZXRlZFZhbHVlOwotICAgIG1faXNTeXN0 ZW1Gb250ID0gb3RoZXIubV9pc1N5c3RlbUZvbnQ7Ci0KLSAgICBtX2ZpeGVkV2lkdGggPSBvdGhl ci5tX2ZpeGVkV2lkdGg7Ci0gICAgbV9wYXR0ZXJuID0gb3RoZXIubV9wYXR0ZXJuOwotCi0gICAg bV9zY2FsZWRGb250ID0gb3RoZXIubV9zY2FsZWRGb250OwotCi0gICAgcmV0dXJuICp0aGlzOwot fQotCi1Gb250UGxhdGZvcm1EYXRhOjp+Rm9udFBsYXRmb3JtRGF0YSgpID0gZGVmYXVsdDsKLQog Rm9udFBsYXRmb3JtRGF0YSBGb250UGxhdGZvcm1EYXRhOjpjbG9uZVdpdGhPcmllbnRhdGlvbihj b25zdCBGb250UGxhdGZvcm1EYXRhJiBzb3VyY2UsIEZvbnRPcmllbnRhdGlvbiBvcmllbnRhdGlv bikKIHsKICAgICBGb250UGxhdGZvcm1EYXRhIGNvcHkoc291cmNlKTsK