200357 2019-08-01 13:29:43 -0700 fast/forms/ios/file-upload-panel.html is flaky on iOS 13 2019-08-01 20:45:51 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez aestes simon.fraser webkit-bug-importer wenson_hsieh youennf zalan oldest_to_newest 1557724 0 cdumez 2019-08-01 13:29:43 -0700 fast/forms/ios/file-upload-panel.html is flaky on iOS 13. 1557725 1 cdumez 2019-08-01 13:30:01 -0700 <rdar://problem/53028551> 1557726 2 375340 cdumez 2019-08-01 13:31:44 -0700 Created attachment 375340 Patch 1557733 3 375340 simon.fraser 2019-08-01 14:05:56 -0700 Comment on attachment 375340 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375340&action=review > LayoutTests/fast/forms/ios/file-upload-panel.html:54 > - UIHelper.activateElement(testInput).then(() => { > + internals.withUserGesture(() => { Can we fix UIHelper to do the right thing (or add a new function to it)? UIHelper is the future. 1557746 4 cdumez 2019-08-01 14:30:01 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 375340 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375340&action=review > > > LayoutTests/fast/forms/ios/file-upload-panel.html:54 > > - UIHelper.activateElement(testInput).then(() => { > > + internals.withUserGesture(() => { > > Can we fix UIHelper to do the right thing (or add a new function to it)? > UIHelper is the future. But I have no idea why the tap is getting swallowed (and why this regressed very recently). If I sleep 1 second between taps, then they are no longer swallowed but this is not a viable fix. UIHelper may be the future but HTMLElement.click() is never going away :) 1557750 5 cdumez 2019-08-01 14:31:37 -0700 (In reply to Chris Dumez from comment #4) > (In reply to Simon Fraser (smfr) from comment #3) > > Comment on attachment 375340 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=375340&action=review > > > > > LayoutTests/fast/forms/ios/file-upload-panel.html:54 > > > - UIHelper.activateElement(testInput).then(() => { > > > + internals.withUserGesture(() => { > > > > Can we fix UIHelper to do the right thing (or add a new function to it)? > > UIHelper is the future. > > But I have no idea why the tap is getting swallowed (and why this regressed > very recently). If I sleep 1 second between taps, then they are no longer > swallowed but this is not a viable fix. UIHelper may be the future but > HTMLElement.click() is never going away :) Note that we already swizzle out all the popover presenting API, however, this is still insufficient. I suspect some kind of UIButton animation when tapping it? 1557808 6 aestes 2019-08-01 17:08:41 -0700 (In reply to Chris Dumez from comment #4) > But I have no idea why the tap is getting swallowed (and why this regressed > very recently). Could it be due to r247866? Payment Request tests were failing in a very similar way and Zalan resolved it by migrating those tests to using UIHelper.activateElementAtHumanSpeed. Would that work here too? 1557856 7 375387 cdumez 2019-08-01 20:41:08 -0700 Created attachment 375387 Patch 1557858 8 cdumez 2019-08-01 20:42:01 -0700 (In reply to Andy Estes from comment #6) > (In reply to Chris Dumez from comment #4) > > But I have no idea why the tap is getting swallowed (and why this regressed > > very recently). > > Could it be due to r247866? > > Payment Request tests were failing in a very similar way and Zalan resolved > it by migrating those tests to using UIHelper.activateElementAtHumanSpeed. > Would that work here too? It does. Slow though. 1557859 9 zalan 2019-08-01 20:42:57 -0700 (In reply to Chris Dumez from comment #8) > (In reply to Andy Estes from comment #6) > > (In reply to Chris Dumez from comment #4) > > > But I have no idea why the tap is getting swallowed (and why this regressed > > > very recently). > > > > Could it be due to r247866? > > > > Payment Request tests were failing in a very similar way and Zalan resolved > > it by migrating those tests to using UIHelper.activateElementAtHumanSpeed. > > Would that work here too? > > It does. Slow though. Human speed. 1557862 10 375387 cdumez 2019-08-01 20:45:45 -0700 Comment on attachment 375387 Patch Clearing flags on attachment: 375387 Committed r248145: <https://trac.webkit.org/changeset/248145> 1557863 11 cdumez 2019-08-01 20:45:51 -0700 All reviewed patches have been landed. Closing bug. 375340 2019-08-01 13:31:44 -0700 2019-08-01 20:41:04 -0700 Patch bug-200357-20190801133144.patch text/plain 1728 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MTEzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmQ5NGJmNDEwNDUyNTM4MTJlYzZh ZGU3NjkyNmM1NjVjMDk0NmMwOS4uMDFmNDNmNGRmZDIxNDkzNGE2MjM1ZTAyZTQ4ZTE0OWRmYjM4 YWE1ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA4LTAxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFu ZWwuaHRtbCBpcyBmbGFreSBvbiBpT1MgMTMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMDM1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTMwMjg1 NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBm YXN0L2Zvcm1zL2lvcy9maWxlLXVwbG9hZC1wYW5lbC5odG1sOgorCiAyMDE5LTA4LTAxICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtUZXh0IGF1dG9z aXppbmddIFtpUGFkT1NdIEFkZCB0YXJnZXRlZCBoYWNrcyB0byBhZGRyZXNzIHNvbWUgcmVtYWlu aW5nIHRleHQgYXV0b3NpemluZyBpc3N1ZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2lvcy9maWxlLXVwbG9hZC1wYW5lbC5odG1sCmluZGV4IGIyMmRmMjc0NThlNjk0YWI0NGNhNmI5 NjUyNzZlMWRkMWExOGFmMGIuLmFmZmUwYzZhNjQ1NGYyOWFlMzU3M2FlNjM1ZTc3YzdhMzFlNzUy ZTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBh bmVsLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFu ZWwuaHRtbApAQCAtMyw3ICszLDYgQEAKIDxoZWFkPgogPG1ldGEgbmFtZT0idmlld3BvcnQiIGNv bnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCI+CiA8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3Vy Y2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgotPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNl cy91aS1oZWxwZXIuanMiPjwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+CiA8ZGl2IGlkPSJkZXNj cmlwdGlvbiI+PC9kaXY+CkBAIC01Miw3ICs1MSw4IEBAIGZ1bmN0aW9uIHJ1bkFjY2VwdFRlc3Qo YWNjZXB0LCBleHBlY3RlZE1lbnVJdGVtcykKICAgICAgICAgZGVidWcoIiogYWNjZXB0ID0gIiAr IGFjY2VwdCk7CiAgICAgICAgIHRlc3RJbnB1dC5hY2NlcHQgPSBhY2NlcHQ7CiAKLSAgICAgICAg VUlIZWxwZXIuYWN0aXZhdGVFbGVtZW50KHRlc3RJbnB1dCkudGhlbigoKSA9PiB7CisgICAgICAg IGludGVybmFscy53aXRoVXNlckdlc3R1cmUoKCkgPT4geworICAgICAgICAgICAgdGVzdElucHV0 LmNsaWNrKCk7CiAgICAgICAgICAgICBnZXRGaWxlVXBsb2FkUGlja2VyTWVudUl0ZW1zKCkudGhl bigoX2l0ZW1zKSA9PiB7CiAgICAgICAgICAgICAgICAgaXRlbXMgPSBfaXRlbXM7CiAgICAgICAg ICAgICAgICAgc2hvdWxkQmVUcnVlKCJhcmVBcnJheXNFcXVhbChpdGVtcywgIiArIGV4cGVjdGVk TWVudUl0ZW1zICsgIikiKTsK 375387 2019-08-01 20:41:08 -0700 2019-08-01 20:45:45 -0700 Patch bug-200357-20190801204107.patch text/plain 1689 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MTQ0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmQ5NGJmNDEwNDUyNTM4MTJlYzZh ZGU3NjkyNmM1NjVjMDk0NmMwOS4uMTY0ZTQwNzJhMGQzY2FiNDUzNTZhY2I2YmE2ZmIxNDMxMTIw YmVjMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA4LTAxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFu ZWwuaHRtbCBpcyBmbGFreSBvbiBpT1MgMTMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwMDM1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTMwMjg1 NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IFVJSGVscGVyLmFjdGl2YXRlRWxlbWVudEF0SHVtYW5TcGVlZCgpIGluc3RlYWQgb2YgVUlIZWxw ZXIuYWN0aXZhdGVFbGVtZW50KCkKKyAgICAgICAgdG8gYWRkcmVzcyBmbGFraW5lc3MuIElmIHRo ZSBidXR0b24gdGFwcyBhcmUgaXNzdWVkIHRvIHF1aWNrbHksIHNvbWUgb2YgdGhlbQorICAgICAg ICBnZXQgc3dhbGxvd2VkLgorCisgICAgICAgICogZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQt cGFuZWwuaHRtbDoKKwogMjAxOS0wOC0wMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFw cGxlLmNvbT4KIAogICAgICAgICBbVGV4dCBhdXRvc2l6aW5nXSBbaVBhZE9TXSBBZGQgdGFyZ2V0 ZWQgaGFja3MgdG8gYWRkcmVzcyBzb21lIHJlbWFpbmluZyB0ZXh0IGF1dG9zaXppbmcgaXNzdWVz CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9maWxlLXVwbG9hZC1wYW5l bC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvZmlsZS11cGxvYWQtcGFuZWwuaHRt bAppbmRleCBiMjJkZjI3NDU4ZTY5NGFiNDRjYTZiOTY1Mjc2ZTFkZDFhMThhZjBiLi5kMzY5N2I4 ZWRjZWQwN2Y2MmNiZjg5ZjQ0ZTMyYmQ2MmU4MTBhOTc4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2lvcy9maWxlLXVwbG9hZC1wYW5lbC5odG1sCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvaW9zL2ZpbGUtdXBsb2FkLXBhbmVsLmh0bWwKQEAgLTUyLDcgKzUyLDcgQEAg ZnVuY3Rpb24gcnVuQWNjZXB0VGVzdChhY2NlcHQsIGV4cGVjdGVkTWVudUl0ZW1zKQogICAgICAg ICBkZWJ1ZygiKiBhY2NlcHQgPSAiICsgYWNjZXB0KTsKICAgICAgICAgdGVzdElucHV0LmFjY2Vw dCA9IGFjY2VwdDsKIAotICAgICAgICBVSUhlbHBlci5hY3RpdmF0ZUVsZW1lbnQodGVzdElucHV0 KS50aGVuKCgpID0+IHsKKyAgICAgICAgVUlIZWxwZXIuYWN0aXZhdGVFbGVtZW50QXRIdW1hblNw ZWVkKHRlc3RJbnB1dCkudGhlbigoKSA9PiB7CiAgICAgICAgICAgICBnZXRGaWxlVXBsb2FkUGlj a2VyTWVudUl0ZW1zKCkudGhlbigoX2l0ZW1zKSA9PiB7CiAgICAgICAgICAgICAgICAgaXRlbXMg PSBfaXRlbXM7CiAgICAgICAgICAgICAgICAgc2hvdWxkQmVUcnVlKCJhcmVBcnJheXNFcXVhbChp dGVtcywgIiArIGV4cGVjdGVkTWVudUl0ZW1zICsgIikiKTsK