20035 2008-07-14 16:51:58 -0700 [GTK] Fix return value for webkit_web_view_go_to_back_forward_item() 2008-08-01 22:20:24 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 uws+webkit uws+webkit oldest_to_newest 85915 0 uws+webkit 2008-07-14 16:51:58 -0700 Currently webkit_web_view_go_to_back_forward_item() always returns TRUE. There's a FIXME in the code to change this. Find attached a patch that changes this into a more suitable return value. Note that the Objective-C docs at http://developer.apple.com/documentation/Cocoa/Reference/WebKit/Classes/WebView_Class/Reference/Reference.html#//apple_ref/occ/instm/WebView/goToBackForwardItem: seem to suggest this approach as well. 85916 1 22274 uws+webkit 2008-07-14 16:54:55 -0700 Created attachment 22274 Proposed fix 85917 2 uws+webkit 2008-07-14 17:06:07 -0700 02:03:33 < bdash> uws: https://bugs.webkit.org/attachment.cgi?id=22274&action=prettypatch -- the declaration and assignment should be on the same line, and the variable name should match our coding style guidelines 85918 3 22275 uws+webkit 2008-07-14 17:12:42 -0700 Created attachment 22275 Updated patch 87653 4 22275 eric 2008-08-01 17:00:43 -0700 Comment on attachment 22275 Updated patch Looks fine. 87660 5 jmalonzo 2008-08-01 22:20:24 -0700 landed in r35522 22274 2008-07-14 16:54:55 -0700 2008-07-14 17:12:42 -0700 Proposed fix webkit-go-to-back-forward-item-return-value-bug-20035.patch text/plain 1308 uws+webkit SW5kZXg6IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCShyZXZpc2lvbiAzNTE2NykKKysr IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NTE3LDcgKzE1MTcsMTIgQEAgZ2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3X2dvX3RvX2JhY2tfZm9y dwogICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSwg RkFMU0UpOwogICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfSElTVE9SWV9J VEVNKGl0ZW0pLCBGQUxTRSk7CiAKLSAgICAvLyBGSVhNRTogVGhpcyBhbHdheXMgcmV0dXJucyBU UlVFCisgICAgV2ViS2l0V2ViQmFja0ZvcndhcmRMaXN0KiBiYWNrX2ZvcndhcmRfbGlzdDsKKwor ICAgIGJhY2tfZm9yd2FyZF9saXN0ID0gd2Via2l0X3dlYl92aWV3X2dldF9iYWNrX2ZvcndhcmRf bGlzdCh3ZWJWaWV3KTsKKyAgICBpZiAoIXdlYmtpdF93ZWJfYmFja19mb3J3YXJkX2xpc3RfY29u dGFpbnNfaXRlbShiYWNrX2ZvcndhcmRfbGlzdCwgaXRlbSkpCisgICAgICAgIHJldHVybiBGQUxT RTsKKwogICAgIGNvcmUod2ViVmlldyktPmdvVG9JdGVtKGNvcmUoaXRlbSksIEZyYW1lTG9hZFR5 cGVJbmRleGVkQmFja0ZvcndhcmQpOwogICAgIHJldHVybiBUUlVFOwogfQpJbmRleDogV2ViS2l0 L2d0ay9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlz aW9uIDM1MTc1KQorKysgV2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxMCBAQAorMjAwOC0wNy0xNSAgV291dGVyIEJvbHN0ZXJsZWUgIDx3Ym9sc3RlckBzdm4u Z25vbWUub3JnPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDAzNQorICAgICAgICBbR1RLXSBGaXggcmV0dXJuIHZhbHVlIGZvciB3ZWJraXRfd2Vi X3ZpZXdfZ29fdG9fYmFja19mb3J3YXJkX2l0ZW0oKQorCisgICAgICAgICogd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwOgorCiAyMDA4LTA3LTA4ICBKYW4gTWljaGFlbCBBbG9uem8gIDxqbWFsb256 b0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENocmlzdGlhbiBEeXdhbi4K 22275 2008-07-14 17:12:42 -0700 2008-08-01 17:00:43 -0700 Updated patch webkit-go-to-back-forward-item-return-value-bug-20035.patch text/plain 1269 uws+webkit SW5kZXg6IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCShyZXZpc2lvbiAzNTE2NykKKysr IFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NTE3LDcgKzE1MTcsMTAgQEAgZ2Jvb2xlYW4gd2Via2l0X3dlYl92aWV3X2dvX3RvX2JhY2tfZm9y dwogICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSwg RkFMU0UpOwogICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfSElTVE9SWV9J VEVNKGl0ZW0pLCBGQUxTRSk7CiAKLSAgICAvLyBGSVhNRTogVGhpcyBhbHdheXMgcmV0dXJucyBU UlVFCisgICAgV2ViS2l0V2ViQmFja0ZvcndhcmRMaXN0KiBiYWNrRm9yd2FyZExpc3QgPSB3ZWJr aXRfd2ViX3ZpZXdfZ2V0X2JhY2tfZm9yd2FyZF9saXN0KHdlYlZpZXcpOworICAgIGlmICghd2Vi a2l0X3dlYl9iYWNrX2ZvcndhcmRfbGlzdF9jb250YWluc19pdGVtKGJhY2tGb3J3YXJkTGlzdCwg aXRlbSkpCisgICAgICAgIHJldHVybiBGQUxTRTsKKwogICAgIGNvcmUod2ViVmlldyktPmdvVG9J dGVtKGNvcmUoaXRlbSksIEZyYW1lTG9hZFR5cGVJbmRleGVkQmFja0ZvcndhcmQpOwogICAgIHJl dHVybiBUUlVFOwogfQpJbmRleDogV2ViS2l0L2d0ay9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDM1MTc1KQorKysgV2ViS2l0L2d0ay9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMCBAQAorMjAwOC0wNy0xNSAgV291dGVy IEJvbHN0ZXJsZWUgIDx1d3NAeHM0YWxsLm5sPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAzNQorICAgICAgICBbR1RLXSBGaXggcmV0dXJuIHZh bHVlIGZvciB3ZWJraXRfd2ViX3ZpZXdfZ29fdG9fYmFja19mb3J3YXJkX2l0ZW0oKQorCisgICAg ICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorCiAyMDA4LTA3LTA4ICBKYW4gTWljaGFl bCBBbG9uem8gIDxqbWFsb256b0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENo cmlzdGlhbiBEeXdhbi4K