200347 2019-08-01 09:28:11 -0700 results.webkit.org: Collision detection for dots is off by 2 * dotMargin 2019-08-01 12:44:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard commit-queue webkit-bug-importer zhifei_fang oldest_to_newest 1557617 0 jbedard 2019-08-01 09:28:11 -0700 Messing around with the canvas timeline, our collision detection isn't quite right. It's definitely the dotMargin. 1557620 1 375315 jbedard 2019-08-01 09:29:46 -0700 Created attachment 375315 Patch 1557622 2 jbedard 2019-08-01 09:31:24 -0700 This patch 'fixes' the problem, but it's definitely the wrong way to do it. It feels like the actual x value of the dots is wrong. 1557637 3 375321 zhifei_fang 2019-08-01 10:17:22 -0700 Created attachment 375321 Patch 1557706 4 375321 commit-queue 2019-08-01 12:43:09 -0700 Comment on attachment 375321 Patch Clearing flags on attachment: 375321 Committed r248117: <https://trac.webkit.org/changeset/248117> 1557707 5 commit-queue 2019-08-01 12:43:10 -0700 All reviewed patches have been landed. Closing bug. 1557713 6 webkit-bug-importer 2019-08-01 12:44:17 -0700 <rdar://problem/53827885> 375315 2019-08-01 09:29:46 -0700 2019-08-01 09:30:07 -0700 Patch bug-200347-20190801092946.patch text/plain 1640 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0ODEwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE5LTA4LTAxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IENvbGxpc2lvbiBkZXRlY3Rpb24gZm9y IGRvdHMgaXMgb2ZmIGJ5IDIgKiBkb3RNYXJnaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDM0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5PVCBUTyBCRSBMQU5ERUQKKworICAgICAgICAqIHJlc3Vs dHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvY29tcG9uZW50cy9UaW1l bGluZUNvbXBvbmVudHMuanM6CisgICAgICAgIChmcm9tLnN0cmluZ19hcHBlYXJlZF9oZXJlLnBv aW50Q2lyY2xlQ29sbGlzaW9uRGV0YWN0KToKKwogMjAxOS0wOC0wMSAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RN YW5hZ2VyUHJveHkgc2hvdWxkIG5vdCB1c2UgYXVkaW8rdmlkZW8gZGVuaWVkIHJlcXVlc3RzIHRv IGRlbnkgYXVkaW8tb25seSBvciB2aWRlby1vbmx5IHJlcXVlc3RzCkluZGV4OiBUb29scy9yZXN1 bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2pzL2NvbXBvbmVudHMvVGlt ZWxpbmVDb21wb25lbnRzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3Vs dHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvY29tcG9uZW50cy9UaW1lbGluZUNvbXBvbmVu dHMuanMJKHJldmlzaW9uIDI0ODEwNCkKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5 L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvY29tcG9uZW50cy9UaW1lbGluZUNvbXBvbmVudHMuanMJ KHdvcmtpbmcgY29weSkKQEAgLTI5LDcgKzI5LDcgQEAgaW1wb3J0IHtpc0RhcmtNb2RlfSBmcm9t ICcuLi9VdGlscy5qcyc7CiBpbXBvcnQge0xpc3RDb21wb25lbnQsIExpc3RQcm92aWRlciwgTGlz dFByb3ZpZGVyUmVjZWl2ZXJ9IGZyb20gJy4vQmFzZUNvbXBvbmVudHMuanMnCiAKIGZ1bmN0aW9u IHBvaW50Q2lyY2xlQ29sbGlzaW9uRGV0YWN0KHBvaW50LCBjaXJjbGUpIHsKLSAgICByZXR1cm4g TWF0aC5wb3cocG9pbnQueCAtIGNpcmNsZS54LCAyKSArIE1hdGgucG93KHBvaW50LnkgLSBjaXJj bGUueSwgMikgPD0gY2lyY2xlLnJhZGl1cyAqIGNpcmNsZS5yYWRpdXM7CisgICAgcmV0dXJuIE1h dGgucG93KHBvaW50LnggLSBjaXJjbGUueCArIDEyLCAyKSArIE1hdGgucG93KHBvaW50LnkgLSBj aXJjbGUueSwgMikgPD0gY2lyY2xlLnJhZGl1cyAqIGNpcmNsZS5yYWRpdXM7CiB9CiAKIGZ1bmN0 aW9uIHBvaW50UmVjdENvbGxpc2lvbkRldGVjdChwb2ludCwgcmVjdCkgewo= 375321 2019-08-01 10:17:22 -0700 2019-08-01 12:43:09 -0700 Patch 200347.diff text/plain 1931 zhifei_fang ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MWU2 ZDUwYWY4NC4uMzRiMDY4NDE3MzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0wOC0wMSAgWmhpZmVpIEZhbmcg IDx6aGlmZWlfZmFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgcmVzdWx0cy53ZWJraXQub3JnOiBD b2xsaXNpb24gZGV0ZWN0aW9uIGZvciBkb3RzIGlzIG9mZiBieSAyICogZG90TWFyZ2luCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAzNDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlc3VsdHNkYnB5 L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvY29tcG9uZW50cy9UaW1lbGluZUNv bXBvbmVudHMuanM6CisgICAgICAgIChUaW1lbGluZS5DYW52YXNTZXJpZXNDb21wb25lbnQpOiBO ZWVkIHRvIGNoYW5nZSBpdCB0byBkb3RNYXJnaW4gKyByYWRpdXMgb3RoZXIgdGhhbiB1c2UgYSBm aXhlZCAzICogcmFkaXVzLCB3aGljaCBpcyBmb3IgdGhlIG9sZCB3aWRlIHRpbWVsaW5lCisKIDIw MTktMDctMzEgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAg IHJlc3VsdHMud2Via2l0Lm9nOiBUaW1lbGluZSBpbiBjYW52YXMgcGFpbnRpbmcgd2l0aCB3cm9u ZyBjb2xvcnMsIGNhbm5vdCBjdXN0b21pemUgc2NhbGUKZGlmZiAtLWdpdCBhL1Rvb2xzL3Jlc3Vs dHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvY29tcG9uZW50cy9UaW1l bGluZUNvbXBvbmVudHMuanMgYi9Ub29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0 YXRpYy9saWJyYXJ5L2pzL2NvbXBvbmVudHMvVGltZWxpbmVDb21wb25lbnRzLmpzCmluZGV4IGE1 ZjU3NmVjMjM1Li4yYjkwOTExNjI1ZiAxMDA2NDQKLS0tIGEvVG9vbHMvcmVzdWx0c2RicHkvcmVz dWx0c2RicHkvdmlldy9zdGF0aWMvbGlicmFyeS9qcy9jb21wb25lbnRzL1RpbWVsaW5lQ29tcG9u ZW50cy5qcworKysgYi9Ub29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9s aWJyYXJ5L2pzL2NvbXBvbmVudHMvVGltZWxpbmVDb21wb25lbnRzLmpzCkBAIC0zMjIsNyArMzIy LDcgQEAgVGltZWxpbmUuQ2FudmFzU2VyaWVzQ29tcG9uZW50ID0gKGRvdHMsIHNjYWxlcywgb3B0 aW9uID0ge30pID0+IHsKICAgICAgICAgICAgIGxldCB4ID0gaSAqIGRvdFdpZHRoIC0gKHNjcm9s bExlZnQgPCBwYWRkaW5nID8gc2Nyb2xsTGVmdCA6IHNjcm9sbExlZnQgLSBwYWRkaW5nKTsKICAg ICAgICAgICAgIGlmIChjdXJyZW50RG90SW5kZXggPCBkb3RzLmxlbmd0aCAmJiBjb21wKHNjYWxl c1tpXSwgZ2V0U2NhbGUoZG90c1tjdXJyZW50RG90SW5kZXhdKSkgPT09IDApIHsKICAgICAgICAg ICAgICAgICByZW5kZXIoZG90c1tjdXJyZW50RG90SW5kZXhdLCBjb250ZXh0LCB4LCByYWRpdXMp OwotICAgICAgICAgICAgICAgIGRvdHNbY3VycmVudERvdEluZGV4XS5fZG90Q2VudGVyID0ge3g6 IHggKyAzICogcmFkaXVzLCB5OiByYWRpdXN9OworICAgICAgICAgICAgICAgIGRvdHNbY3VycmVu dERvdEluZGV4XS5fZG90Q2VudGVyID0ge3g6IHggKyBkb3RNYXJnaW4gKyByYWRpdXMsIHk6IHJh ZGl1c307CiAgICAgICAgICAgICAgICAgZG90c1tjdXJyZW50RG90SW5kZXhdLl9jYWNoZWRTY3Jv bGxMZWZ0ID0gc2Nyb2xsTGVmdCA8IHBhZGRpbmcgPyBzY3JvbGxMZWZ0IDogc2Nyb2xsTGVmdCAt IHBhZGRpbmc7CiAgICAgICAgICAgICAgICAgaW5DYWNoZURvdHMucHVzaChkb3RzW2N1cnJlbnRE b3RJbmRleF0pOwogICAgICAgICAgICAgICAgIGN1cnJlbnREb3RJbmRleCArPSAxOwo=