20034 2008-07-14 16:36:26 -0700 [GTK] Invalid vim modeline in WebCore/plugins/gtk/gtk2xtbin.h (with patch) 2008-08-02 04:29:19 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 uws+webkit webkit-unassigned oldest_to_newest 85913 0 uws+webkit 2008-07-14 16:36:26 -0700 The vim modeline in WebCore/plugins/gtk/gtk2xtbin.h is malformed, causing an error when this file is opened in Vim. (I'm atrevision 35167) 85914 1 22273 uws+webkit 2008-07-14 16:40:15 -0700 Created attachment 22273 Fix malformed Vim modeline 87673 2 22273 eric 2008-08-02 01:12:15 -0700 Comment on attachment 22273 Fix malformed Vim modeline Looks sane enough. Seems we should have a script to add WebKit-style compatible mode-lines to all files if we're going to use them. It's silly to go through and fix each one by hand. 87680 3 jmalonzo 2008-08-02 02:41:21 -0700 landed in r35526 87684 4 uws+webkit 2008-08-02 04:29:19 -0700 (In reply to comment #2) > Seems we should have a script to add WebKit-style compatible mode-lines to all > files if we're going to use them. It's silly to go through and fix each one by > hand. Perhaps a sample Vim configuration file snippet can be placed somewhere in the WebKit tree. Some comments can be added to tell people how to use it, e.g. tell them to place something like this in their ~/.vimrc: autocmd BufReadPost /path/to/your/webkit/tree/* source /patch/to/your/webkit/tree/webkit.vim Anyway, nothing major, so leaving this report RESOLVED FIXED. 22273 2008-07-14 16:40:15 -0700 2008-08-02 01:12:15 -0700 Fix malformed Vim modeline webkit-fix-vim-modeline-bug-20034.patch text/plain 939 uws+webkit SW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9ndGsvZ3RrMnh0YmluLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbHVnaW5zL2d0ay9ndGsyeHRiaW4uaAkocmV2aXNpb24gMzUxNjcpCisrKyBXZWJDb3Jl L3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAog LyogLSotIE1vZGU6IEMrKzsgdGFiLXdpZHRoOiAyOyBpbmRlbnQtdGFicy1tb2RlOiBuaWw7IGMt YmFzaWMtb2Zmc2V0OiAyIC0qLQotICogdmltOmV4cGFuZHRhYjpzaGlmdHdpZHRoPTI6dGFic3Rv cD0yOiAqLworICogdmltOiBzZXQgZXhwYW5kdGFiIHNoaWZ0d2lkdGg9MiB0YWJzdG9wPTI6ICov CiAgCiAvKiAqKioqKiBCRUdJTiBMSUNFTlNFIEJMT0NLICoqKioqCiAgKiBWZXJzaW9uOiBNUEwg MS4xL0dQTCAyLjAvTEdQTCAyLjEKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAzNTE3NSkKKysrIFdlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDgtMDctMTUgIFdvdXRlciBC b2xzdGVybGVlICA8d2JvbHN0ZXJAc3ZuLmdub21lLm9yZz4KKworICAgICAgICAqIHBsdWdpbnMv Z3RrL2d0azJ4dGJpbi5oOgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDAzNAorICAgICAgICBGaXggbWFsZm9ybWVkIFZpbSBtb2RlbGluZS4KKwog MjAwOC0wNy0xNCAgY2hyaXMgZmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEJldGggRGFraW4K