200320 2019-07-31 14:51:54 -0700 Improve flakiness of SOAuthorizationRedirect tests 2019-08-01 12:33:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan achristensen bfulgham commit-queue jiewen_tan webkit-bug-importer oldest_to_newest 1557392 0 jiewen_tan 2019-07-31 14:51:54 -0700 Improve flakiness of SOAuthorizationRedirect tests. 1557394 1 jiewen_tan 2019-07-31 14:52:18 -0700 <rdar://problem/53767057> 1557402 2 375255 jiewen_tan 2019-07-31 15:00:11 -0700 Created attachment 375255 Patch 1557681 3 375255 jiewen_tan 2019-08-01 11:46:00 -0700 Comment on attachment 375255 Patch Thanks Alex for r+ this patch. 1557703 4 375255 commit-queue 2019-08-01 12:33:06 -0700 Comment on attachment 375255 Patch Clearing flags on attachment: 375255 Committed r248116: <https://trac.webkit.org/changeset/248116> 1557704 5 commit-queue 2019-08-01 12:33:08 -0700 All reviewed patches have been landed. Closing bug. 375255 2019-07-31 15:00:11 -0700 2019-08-01 12:33:06 -0700 Patch bug-200320-20190731150010.patch text/plain 4301 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MDQ3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTkwMDkxZjE4YTQwM2QxZTdjNDc2MWJmOTlhNzQ5YTQw MzQ1M2M4MS4uNDkyYTg4ZWQzODQ4MzQ0OThmY2Q3OTU2ODY4NWM0ZDJiZTQyZmI5MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE5LTA3LTMxICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAg ICAgICAgSW1wcm92ZSBmbGFraW5lc3Mgb2YgU09BdXRob3JpemF0aW9uUmVkaXJlY3QgdGVzdHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDMyMAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM3NjcwNTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZXBsYWNlcyBVdGlsOjpzbGVl cCgwLjUpIGluIHRlc3RzIHRoYXQgZXhwZWN0IGEgU09BdXRob3JpemF0aW9uIHNlc3Npb24gdG8g d2FpdCB3aGVuIHRoZSBjb3JyZXNwb25kaW5nIFdLV2ViVmlldworICAgICAgICBpcyBvdXQgb2Yg dGhlIHdpbmRvdyB3aXRoIGEgbW9yZSBwcmVjaXNlIGJvb2xlYW4gaW5kaWNhdG9yOiBuYXZpZ2F0 aW9uUG9saWN5RGVjaWRlZC4gVGhlIG5ldyBib29sZWFuIGluZGljYXRvciBpcyB3b3JraW5nIGFu ZAorICAgICAgICBiZXR0ZXIgYmVjYXVzZSB0aGUgYXV0aG9yaXphdGlvblBlcmZvcm1lZCBzaG91 bGQgYmUgc2V0IGluIHRoZSBzYW1lIHJ1bmxvb3Agd2hlbiBOYXZpZ2F0aW9uU3RhdGU6OmRlY2lk ZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24KKyAgICAgICAgaXMgZXhlY3V0ZWQuCisKKyAgICAg ICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Rlc3RTT0F1dGhvcml6YXRpb24u bW06CisgICAgICAgICgtW1Rlc3RTT0F1dGhvcml6YXRpb25EZWxlZ2F0ZSB3ZWJWaWV3OmRlY2lk ZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb246ZGVjaXNpb25IYW5kbGVyOl0pOgorICAgICAgICAo cmVzZXRTdGF0ZSk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxOS0wNy0z MSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04g KHIyNDc0ODY/KTogRmxha3kgQVBJIFRlc3QgVGVzdFdlYktpdEFQSS5XS1dlYlZpZXcuTG9jYWxT dG9yYWdlUHJvY2Vzc1N1c3BlbmRzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdENvY29hL1Rlc3RTT0F1dGhvcml6YXRpb24ubW0gYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL1Rlc3RTT0F1dGhvcml6YXRpb24ubW0KaW5kZXggZjRhYjNl ZWNiNzAwZWQwNTJiNzI4ZTFkMDE1ZjIyNDVhYzMzOTViMS4uOWJiY2JmNmYzMDA2OTExZGI5ZTFl N2MzNzQ3NDQ1MDYyNDM2YjZjMyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9UZXN0U09BdXRob3JpemF0aW9uLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVGVzdFNPQXV0aG9yaXphdGlvbi5tbQpAQCAtNTIsNiAr NTIsNyBAQCBzdGF0aWMgYm9vbCBhdXRob3JpemF0aW9uQ2FuY2VsbGVkID0gZmFsc2U7CiBzdGF0 aWMgYm9vbCB1aVNob3dlZCA9IGZhbHNlOwogc3RhdGljIGJvb2wgbmV3V2luZG93Q3JlYXRlZCA9 IGZhbHNlOwogc3RhdGljIGJvb2wgaGF2ZUh0dHBCb2R5ID0gZmFsc2U7CitzdGF0aWMgYm9vbCBu YXZpZ2F0aW9uUG9saWN5RGVjaWRlZCA9IGZhbHNlOwogc3RhdGljIFN0cmluZyBmaW5hbFVSTDsK IHN0YXRpYyBTT0F1dGhvcml6YXRpb24qIGdBdXRob3JpemF0aW9uOwogc3RhdGljIGlkPFNPQXV0 aG9yaXphdGlvbkRlbGVnYXRlPiBnRGVsZWdhdGU7CkBAIC0xNjksNiArMTcwLDcgQEAgLSAodm9p ZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZEZpbmlzaE5hdmlnYXRpb246KFdLTmF2 aWdhdGlvbiAqKW5hdmlnYXQKIAogLSAodm9pZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3 IGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb246KFdLTmF2aWdhdGlvbkFjdGlvbiAqKW5h dmlnYXRpb25BY3Rpb24gZGVjaXNpb25IYW5kbGVyOih2b2lkICheKShXS05hdmlnYXRpb25BY3Rp b25Qb2xpY3kpKWRlY2lzaW9uSGFuZGxlcgogeworICAgIG5hdmlnYXRpb25Qb2xpY3lEZWNpZGVk ID0gdHJ1ZTsKICAgICBFWFBFQ1RfRVEobmF2aWdhdGlvbkFjdGlvbi5fc2hvdWxkT3BlbkV4dGVy bmFsU2NoZW1lcywgc2VsZi5zaG91bGRPcGVuRXh0ZXJuYWxTY2hlbWVzKTsKICAgICBpZiAoc2Vs Zi5pc0RlZmF1bHRQb2xpY3kpIHsKICAgICAgICAgZGVjaXNpb25IYW5kbGVyKFdLTmF2aWdhdGlv bkFjdGlvblBvbGljeUFsbG93KTsKQEAgLTI4OSw2ICsyOTEsNyBAQCBzdGF0aWMgdm9pZCByZXNl dFN0YXRlKCkKICAgICB1aVNob3dlZCA9IGZhbHNlOwogICAgIG5ld1dpbmRvd0NyZWF0ZWQgPSBm YWxzZTsKICAgICBoYXZlSHR0cEJvZHkgPSBmYWxzZTsKKyAgICBuYXZpZ2F0aW9uUG9saWN5RGVj aWRlZCA9IGZhbHNlOwogICAgIGZpbmFsVVJMID0gZW1wdHlTdHJpbmcoKTsKICAgICBnQXV0aG9y aXphdGlvbiA9IG51bGxwdHI7CiAgICAgZ0RlbGVnYXRlID0gbnVsbHB0cjsKQEAgLTc2NCw3ICs3 NjcsNyBAQCBURVNUKFNPQXV0aG9yaXphdGlvblJlZGlyZWN0LCBJbnRlcmNlcHRpb25TdWNjZWVk V2l0aFdhaXRpbmdTZXNzaW9uKQogICAgIC8vIFRoZSBzZXNzaW9uIHdpbGwgYmUgd2FpdGluZyBz aW5jZSB0aGUgd2ViIHZpZXcgaXMgaXMgbm90IGluIHRoZSB3aW5kb3cuCiAgICAgW3dlYlZpZXcg cmVtb3ZlRnJvbVN1cGVydmlld107CiAgICAgW3dlYlZpZXcgbG9hZFJlcXVlc3Q6W05TVVJMUmVx dWVzdCByZXF1ZXN0V2l0aFVSTDp0ZXN0VVJMLmdldCgpXV07Ci0gICAgVXRpbDo6c2xlZXAoMC41 KTsKKyAgICBVdGlsOjpydW4oJm5hdmlnYXRpb25Qb2xpY3lEZWNpZGVkKTsKICAgICBFWFBFQ1Rf RkFMU0UoYXV0aG9yaXphdGlvblBlcmZvcm1lZCk7CiAKICAgICAvLyBTaG91bGQgYWN0aXZhdGUg dGhlIHNlc3Npb24uCkBAIC04MDAsNyArODAzLDcgQEAgVEVTVChTT0F1dGhvcml6YXRpb25SZWRp cmVjdCwgSW50ZXJjZXB0aW9uQWJvcnRlZFdpdGhXYWl0aW5nU2Vzc2lvbikKICAgICAvLyBUaGUg c2Vzc2lvbiB3aWxsIGJlIHdhaXRpbmcgc2luY2UgdGhlIHdlYiB2aWV3IGlzIGlzIG5vdCBpbiB0 aGUgd2luZG93LgogICAgIFt3ZWJWaWV3IHJlbW92ZUZyb21TdXBlcnZpZXddOwogICAgIFt3ZWJW aWV3IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6dGVzdFVSTDEuZ2V0 KCldXTsKLSAgICBVdGlsOjpzbGVlcCgwLjUpOworICAgIFV0aWw6OnJ1bigmbmF2aWdhdGlvblBv bGljeURlY2lkZWQpOwogICAgIEVYUEVDVF9GQUxTRShhdXRob3JpemF0aW9uUGVyZm9ybWVkKTsK IAogICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6 dGVzdFVSTDIuZ2V0KCldXTsKQEAgLTkyNywxMiArOTMwLDEzIEBAIFRFU1QoU09BdXRob3JpemF0 aW9uUmVkaXJlY3QsIEludGVyY2VwdGlvblN1Y2NlZWRTdXBwcmVzc1dhaXRpbmdTZXNzaW9uKQog ICAgIC8vIFRoZSBzZXNzaW9uIHdpbGwgYmUgd2FpdGluZyBzaW5jZSB0aGUgd2ViIHZpZXcgaXMg aXMgbm90IGludCB0aGUgd2luZG93LgogICAgIFt3ZWJWaWV3IHJlbW92ZUZyb21TdXBlcnZpZXdd OwogICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6 dGVzdFVSTC5nZXQoKV1dOwotICAgIFV0aWw6OnNsZWVwKDAuNSk7CisgICAgVXRpbDo6cnVuKCZu YXZpZ2F0aW9uUG9saWN5RGVjaWRlZCk7CiAgICAgRVhQRUNUX0ZBTFNFKGF1dGhvcml6YXRpb25Q ZXJmb3JtZWQpOwogCiAgICAgLy8gU3VwcHJlc3MgdGhlIGxhc3Qgd2FpdGluZyBzZXNzaW9uLgor ICAgIG5hdmlnYXRpb25Qb2xpY3lEZWNpZGVkID0gZmFsc2U7CiAgICAgW3dlYlZpZXcgbG9hZFJl cXVlc3Q6W05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDp0ZXN0VVJMLmdldCgpXV07Ci0gICAg VXRpbDo6c2xlZXAoMC41KTsKKyAgICBVdGlsOjpydW4oJm5hdmlnYXRpb25Qb2xpY3lEZWNpZGVk KTsKICAgICBFWFBFQ1RfRkFMU0UoYXV0aG9yaXphdGlvblBlcmZvcm1lZCk7CiAKICAgICAvLyBB Y3RpdmF0ZSB0aGUgbGFzdCBzZXNzaW9uLgo=