200291 2019-07-30 20:21:23 -0700 [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus 2019-07-31 07:41:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin cdumez commit-queue megan_gardner thorton webkit-bug-importer oldest_to_newest 1557180 0 wenson_hsieh 2019-07-30 20:21:23 -0700 <rdar://problem/53717946> 1557181 1 375205 wenson_hsieh 2019-07-30 20:26:53 -0700 Created attachment 375205 Patch 1557255 2 375205 wenson_hsieh 2019-07-31 07:20:53 -0700 Comment on attachment 375205 Patch Thanks for the review! 1557263 3 375205 commit-queue 2019-07-31 07:41:22 -0700 Comment on attachment 375205 Patch Clearing flags on attachment: 375205 Committed r248039: <https://trac.webkit.org/changeset/248039> 1557264 4 commit-queue 2019-07-31 07:41:23 -0700 All reviewed patches have been landed. Closing bug. 375205 2019-07-30 20:26:53 -0700 2019-07-31 07:41:22 -0700 Patch bug-200291-20190730202653.patch text/plain 5105 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3OTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEwYWJiYTdmZGQ2MzNlNmEx NWVkZmQ1Y2U3M2JhYzJiOGQwMjI3OTkuLjRhNmU3ZmIzZWIxMzEwNGFiMjE1ODZjOGU5NmU4MTA3 NjM4NDFlMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDctMzAgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyAxM10gU2FmYXJp IGNyYXNoZXMgd2hlbiBjbG9zaW5nIGEgdGFiIHdpdGggYSBmb2N1c2VkIGVsZW1lbnQgaWYgdGhl IHVuaWZpZWQgZmllbGQgaGFzIGZvY3VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDAyOTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUzNzE3OTQ2 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Vz IC1yZXF1ZXN0QXV0b2NvcnJlY3Rpb25Db250ZXh0V2l0aENvbXBsZXRpb25IYW5kbGVyOiByb2J1 c3QgaW4gdGhlIGNhc2Ugd2hlcmUgdGhlIHdlYiBwYWdlIGhhcyBiZWVuIGNsb3NlZCwKKyAgICAg ICAgYW5kIHRoZXJlIGlzIG5vIENvbm5lY3Rpb24gb2JqZWN0IHRvIHVzZSB3aGVuIHdhaXRpbmcg Zm9yIGEgc3luYyBJUEMgcmVzcG9uc2UuCisKKyAgICAgICAgVGVzdDogQXV0b2NvcnJlY3Rpb25U ZXN0cy5SZXF1ZXN0QXV0b2NvcnJlY3Rpb25Db250ZXh0QWZ0ZXJDbG9zaW5nUGFnZQorCisgICAg ICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgcmVxdWVzdEF1dG9jb3JyZWN0aW9uQ29udGV4dFdpdGhDb21wbGV0 aW9uSGFuZGxlcjpdKToKKwogMjAxOS0wNy0yOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVo QGFwcGxlLmNvbT4KIAogICAgICAgICBZb3VUdWJlIHNlYXJjaCBmaWVsZCBzaG93cyBSVEwgdGV4 dCBvdXRzaWRlIGl0cyBib3JkZXIgb24gaVBhZE9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCA0OGQxN2E1 ZTM1NTI1NTVjZWI1ZWVjMTVhZGIzNTExZmQ1MmViMjk1Li5lZDQyY2VjY2ZmMzIzMWE1ZmEwNzBm MjBkNDZmOWJlMThkZDE0ZjUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTM4OTAsNiArMzg5MCwxMSBA QCAtICh2b2lkKXJlcXVlc3RBdXRvY29ycmVjdGlvbkNvbnRleHRXaXRoQ29tcGxldGlvbkhhbmRs ZXI6KHZvaWQgKF4pKFVJV0tBdXRvY29ycgogICAgIH0KICNlbmRpZgogCisgICAgaWYgKCFfcGFn ZS0+aGFzUnVubmluZ1Byb2Nlc3MoKSkgeworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihXS0F1 dG9jb3JyZWN0aW9uQ29udGV4dC5lbXB0eUF1dG9jb3JyZWN0aW9uQ29udGV4dCk7CisgICAgICAg IHJldHVybjsKKyAgICB9CisKICAgICAvLyBGSVhNRTogUmVtb3ZlIHRoZSBzeW5jaHJvbm91cyBj YWxsIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzE2MjA3MDAyPiBpcyBmaXhlZC4KICAgICBjb25zdCBi b29sIHVzZVN5bmNSZXF1ZXN0ID0gdHJ1ZTsKIApAQCAtMzkwNCw3ICszOTA5LDYgQEAgLSAodm9p ZClyZXF1ZXN0QXV0b2NvcnJlY3Rpb25Db250ZXh0V2l0aENvbXBsZXRpb25IYW5kbGVyOih2b2lk ICheKShVSVdLQXV0b2NvcnIKICAgICBpZiAodXNlU3luY1JlcXVlc3QpIHsKICAgICAgICAgX3Bh Z2UtPnByb2Nlc3MoKS5jb25uZWN0aW9uKCktPndhaXRGb3JBbmREaXNwYXRjaEltbWVkaWF0ZWx5 PE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkhhbmRsZUF1dG9jb3JyZWN0aW9uQ29udGV4dD4oX3Bh Z2UtPnBhZ2VJRCgpLCAxX3MsIElQQzo6V2FpdEZvck9wdGlvbjo6SW50ZXJydXB0V2FpdGluZ0lm U3luY01lc3NhZ2VBcnJpdmVzKTsKICAgICAgICAgW3NlbGYgX2NhbmNlbFBlbmRpbmdBdXRvY29y cmVjdGlvbkNvbnRleHRIYW5kbGVyXTsKLSAgICAgICAgcmV0dXJuOwogICAgIH0KIH0KIApkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGYwZjc1ZjNh YmI3MTBhOGZlMTg2ZjUxNmZkY2M5OTc2NTM1MTEzMzEuLjlhZDAyYWZlMGU4ODc2NWM2NTQ4ZmI2 Y2FiZTJjYTRlMzdjYjhlYTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOS0wNy0zMCAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TIDEzXSBTYWZhcmkgY3Jhc2hl cyB3aGVuIGNsb3NpbmcgYSB0YWIgd2l0aCBhIGZvY3VzZWQgZWxlbWVudCBpZiB0aGUgdW5pZmll ZCBmaWVsZCBoYXMgZm9jdXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMDI5MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM3MTc5NDY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFuIEFQSSB0 ZXN0IHRvIGV4ZXJjaXNlIHRoZSBzY2VuYXJpbyBvZiBzeW5jaHJvbm91c2x5IHJlcXVlc3Rpbmcg dGhlIGF1dG9jb3JyZWN0aW9uIGNvbnRleHQgaW1tZWRpYXRlbHkKKyAgICAgICAgYWZ0ZXIgY2xv c2luZyB0aGUgd2ViIHZpZXcsIHdoaWxlIHRoZSB3ZWIgdmlldydzIGNvbnRlbnQgdmlldyBpc24n dCB0aGUgZmlyc3QgcmVzcG9uZGVyLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9p b3MvQXV0b2NvcnJlY3Rpb25UZXN0c0lPUy5tbToKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL2lv cy9VSUtpdFNQSS5oOgorCiAyMDE5LTA3LTI5ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBsYXlvdXQgdGVzdCBjb3ZlcmFnZSBmb3IgPGh0dHBz Oi8vd2Via2l0Lm9yZy9iLzIwMDIxNT4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvaW9zL0F1dG9jb3JyZWN0aW9uVGVzdHNJT1MubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL2lvcy9BdXRvY29ycmVjdGlvblRlc3RzSU9TLm1tCmluZGV4IDY5NzIwM2EwOTM0NmYy ZmMyNzEzODdjYmRkM2QwYzhkNDM1Y2RkMDEuLmYwOTI5Zjg3YzJhYzE0Nzg4YTE5ODI1YjczNTBk MmMxODE3NTRjMjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0F1 dG9jb3JyZWN0aW9uVGVzdHNJT1MubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9p b3MvQXV0b2NvcnJlY3Rpb25UZXN0c0lPUy5tbQpAQCAtOTQsNCArOTQsMjAgQEAgVEVTVChBdXRv Y29ycmVjdGlvblRlc3RzLCBGb250QXRDYXJldFdoZW5Vc2luZ1VJQ1RGb250VGV4dFN0eWxlKQog ICAgIEVYUEVDVF9FUSgzMiwgZm9udEFmdGVyU2NhbGluZy5wb2ludFNpemUpOwogfQogCitURVNU KEF1dG9jb3JyZWN0aW9uVGVzdHMsIFJlcXVlc3RBdXRvY29ycmVjdGlvbkNvbnRleHRBZnRlckNs b3NpbmdQYWdlKQoreworICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3 IGFsbG9jXSBpbml0XSk7CisgICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5h bWVkOkAiYXV0b2ZvY3VzZWQtdGV4dC1pbnB1dCJdOworCisgICAgYXV0byBjb250ZW50VmlldyA9 IFt3ZWJWaWV3IHRleHRJbnB1dENvbnRlbnRWaWV3XTsKKyAgICBbY29udGVudFZpZXcgcmVzaWdu Rmlyc3RSZXNwb25kZXJdOworICAgIFt3ZWJWaWV3IF9jbG9zZV07CisKKyAgICBib29sIGRvbmUg PSBmYWxzZTsKKyAgICBbY29udGVudFZpZXcgcmVxdWVzdEF1dG9jb3JyZWN0aW9uQ29udGV4dFdp dGhDb21wbGV0aW9uSGFuZGxlcjpbJl0gKFVJV0tBdXRvY29ycmVjdGlvbkNvbnRleHQgKikgewor ICAgICAgICBkb25lID0gdHJ1ZTsKKyAgICB9XTsKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpy dW4oJmRvbmUpOworfQorCiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TX0ZBTUlMWSkKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvaW9zL1VJS2l0U1BJLmggYi9Ub29scy9UZXN0V2ViS2l0 QVBJL2lvcy9VSUtpdFNQSS5oCmluZGV4IDU2MTI1YzIyMTA4YzAzOTc2NzNmNzAyNTBkYjFiMTIy MTllOTRkZmYuLjk5OTM0OWYyMzVkZTc4YzZjMzQzYjM0NGYxMTk3ODJjZmY0ODQzZTkgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvaW9zL1VJS2l0U1BJLmgKKysrIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9pb3MvVUlLaXRTUEkuaApAQCAtMTU2LDggKzE1NiwxMiBAQCB0eXBlZGVmIE5T X09QVElPTlMoTlNJbnRlZ2VyLCBVSVdLRG9jdW1lbnRSZXF1ZXN0RmxhZ3MpIHsKIEBwcm9wZXJ0 eSAobm9uYXRvbWljKSBDR1JlY3QgbGFzdFJlY3Q7CiBAZW5kCiAKK0BpbnRlcmZhY2UgVUlXS0F1 dG9jb3JyZWN0aW9uQ29udGV4dCA6IE5TT2JqZWN0CitAZW5kCisKIEBwcm90b2NvbCBVSVdLSW50 ZXJhY3Rpb25WaWV3UHJvdG9jb2wKIC0gKHZvaWQpcmVxdWVzdEF1dG9jb3JyZWN0aW9uUmVjdHNG b3JTdHJpbmc6KE5TU3RyaW5nICopaW5wdXQgd2l0aENvbXBsZXRpb25IYW5kbGVyOih2b2lkIChe KShVSVdLQXV0b2NvcnJlY3Rpb25SZWN0cyAqcmVjdHNGb3JJbnB1dCkpY29tcGxldGlvbkhhbmRs ZXI7CistICh2b2lkKXJlcXVlc3RBdXRvY29ycmVjdGlvbkNvbnRleHRXaXRoQ29tcGxldGlvbkhh bmRsZXI6KHZvaWQgKF4pKFVJV0tBdXRvY29ycmVjdGlvbkNvbnRleHQgKmF1dG9jb3JyZWN0aW9u Q29udGV4dCkpY29tcGxldGlvbkhhbmRsZXI7CiBAZW5kCiAKIElHTk9SRV9XQVJOSU5HU19CRUdJ TigiZGVwcmVjYXRlZC1pbXBsZW1lbnRhdGlvbnMiKQo=