200289 2019-07-30 17:17:16 -0700 ObjC RTCCVPixelBuffer should be prefixed to not conflict with other apps 2019-08-01 15:51:49 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200365 InRadar P2 Normal --- 1 youennf youennf commit-queue darin ddkilzer eric.carlson webkit-bug-importer youennf oldest_to_newest 1557142 0 youennf 2019-07-30 17:17:16 -0700 ObjC RTCCVPixelBuffer should be prefixed to not conflict with other apps 1557143 1 youennf 2019-07-30 17:17:42 -0700 <rdar://problem/49554670> 1557314 2 375231 youennf 2019-07-31 11:38:41 -0700 Created attachment 375231 Patch 1557395 3 375231 darin 2019-07-31 14:52:23 -0700 Comment on attachment 375231 Patch Why only this class? What about all the other classes defined in libwebrtc? 1557399 4 youennf 2019-07-31 14:57:05 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 375231 [details] > Patch > > Why only this class? What about all the other classes defined in libwebrtc? The other classes are prefixed. I missed that one when switching the implementation to use the ObjC libwebrtc factories. It would be nice to have some kind of build checks that enforces that libwebrtc does not define any ObjC RTCXX interface. 1557417 5 375231 commit-queue 2019-07-31 15:26:49 -0700 Comment on attachment 375231 Patch Clearing flags on attachment: 375231 Committed r248077: <https://trac.webkit.org/changeset/248077> 1557418 6 commit-queue 2019-07-31 15:26:50 -0700 All reviewed patches have been landed. Closing bug. 1557436 7 darin 2019-07-31 16:01:00 -0700 (In reply to youenn fablet from comment #4) > It would be nice to have some kind of build checks that enforces that > libwebrtc does not define any ObjC RTCXX interface. Should be easy to add that. 1557493 8 ddkilzer 2019-07-31 19:08:53 -0700 (In reply to Darin Adler from comment #7) > (In reply to youenn fablet from comment #4) > > It would be nice to have some kind of build checks that enforces that > > libwebrtc does not define any ObjC RTCXX interface. > > Should be easy to add that. You should be able to do something like this in a build phase script that only runs for Engineering builds (other build phase scripts do this in WebCore): $ xcrun nm -U /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks/libwebrtc.dylib | grep _OBJC_CLASS_ | grep -v '_OBJC_CLASS_$_WK_' 000000000063b360 s _OBJC_CLASS_$_RTCCVPixelBuffer 000000000063b748 s _OBJC_CLASS_$_RTCVideoDecoderVP8 000000000063b9f0 s _OBJC_CLASS_$_RTCWrappedNativeVideoDecoder 000000000063ba40 s _OBJC_CLASS_$_RTCWrappedNativeVideoEncoder That was from macOS 10.4.4 Mojave. Looks like we missed four classes there. If the output from that shell command is empty, we're good. 1557495 9 youennf 2019-07-31 19:27:21 -0700 > You should be able to do something like this in a build phase script that > only runs for Engineering builds (other build phase scripts do this in > WebCore): Thanks > $ xcrun nm -U > /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore. > framework/Versions/A/Frameworks/libwebrtc.dylib | grep _OBJC_CLASS_ | grep > -v '_OBJC_CLASS_$_WK_' > 000000000063b360 s _OBJC_CLASS_$_RTCCVPixelBuffer > 000000000063b748 s _OBJC_CLASS_$_RTCVideoDecoderVP8 > 000000000063b9f0 s _OBJC_CLASS_$_RTCWrappedNativeVideoDecoder > 000000000063ba40 s _OBJC_CLASS_$_RTCWrappedNativeVideoEncoder > > That was from macOS 10.4.4 Mojave. Looks like we missed four classes there. > > If the output from that shell command is empty, we're good. It only includes RTCCVPixelBuffer in recent builds so we should be good. 375231 2019-07-31 11:38:41 -0700 2019-07-31 15:26:49 -0700 Patch bug-200289-20190731113841.patch text/plain 1639 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBkZWYxMDIxM2IwZDY0MjBiNjIwNzNkYTJiMDNlOTcxNTliZTM1ZGE1Li5kMTM2 N2JlODQ4MGE1NWQ5MmVhYTUzMTNkNzE5MzZkOWU5MzQ2NjU2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0wNy0zMSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgT2JqQyBSVENDVlBpeGVsQnVmZmVy IHNob3VsZCBiZSBwcmVmaXhlZCB0byBub3QgY29uZmxpY3Qgd2l0aCBvdGhlciBhcHBzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAyODkKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzQ5NTU0NjcwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9jb21wb25lbnRz L3ZpZGVvX2ZyYW1lX2J1ZmZlci9SVENDVlBpeGVsQnVmZmVyLmg6CisKIDIwMTktMDctMTcgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBWQ1AgU1BJIGlu IGNhc2UgY3JlYXRpb24gb2YgYSBjb21wcmVzc2lvbiBzZXNzaW9uIHdpdGggVlRCIGZvciAnaDI2 NC5ydHZjJyBmYWlscwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1Nv dXJjZS93ZWJydGMvc2RrL29iamMvY29tcG9uZW50cy92aWRlb19mcmFtZV9idWZmZXIvUlRDQ1ZQ aXhlbEJ1ZmZlci5oIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMv c2RrL29iamMvY29tcG9uZW50cy92aWRlb19mcmFtZV9idWZmZXIvUlRDQ1ZQaXhlbEJ1ZmZlci5o CmluZGV4IDQzMmEzODI1NzQ2NGIyNmNiNTMyMzRjOGEzN2FmNjdkNThlZjgwYjEuLmFiZTlkZmNh OTNiMDRiZjU1MmVjMDMwMmI4MDc1OTdkZjI2MWVkYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGly ZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpjL2NvbXBvbmVudHMvdmlkZW9f ZnJhbWVfYnVmZmVyL1JUQ0NWUGl4ZWxCdWZmZXIuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9s aWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9jb21wb25lbnRzL3ZpZGVvX2ZyYW1lX2J1 ZmZlci9SVENDVlBpeGVsQnVmZmVyLmgKQEAgLTE3LDYgKzE3LDcgQEAgTlNfQVNTVU1FX05PTk5V TExfQkVHSU4KIAogLyoqIFJUQ1ZpZGVvRnJhbWVCdWZmZXIgY29udGFpbmluZyBhIENWUGl4ZWxC dWZmZXJSZWYgKi8KIFJUQ19PQkpDX0VYUE9SVAorX19hdHRyaWJ1dGVfXygob2JqY19ydW50aW1l X25hbWUoIldLX1JUQ0NWUGl4ZWxCdWZmZXIiKSkpCiBAaW50ZXJmYWNlIFJUQ0NWUGl4ZWxCdWZm ZXIgOiBOU09iamVjdCA8UlRDVmlkZW9GcmFtZUJ1ZmZlcj4KIAogQHByb3BlcnR5KG5vbmF0b21p YywgcmVhZG9ubHkpIENWUGl4ZWxCdWZmZXJSZWYgcGl4ZWxCdWZmZXI7Cg==