200288 2019-07-30 16:33:06 -0700 Fix 64-bit vs 32-bit mismatch in PersistentCoders.h 2019-07-31 09:27:04 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin benjamin cdumez cmarcelo commit-queue dbates ews-watchlist webkit-bug-importer oldest_to_newest 1557124 0 krollin 2019-07-30 16:33:06 -0700 hashMapSize is declared as a uint64_t. It is passed to HashMapType::reserveInitialCapacity, which takes an unsigned int. This is a 32-bit value on 32-bit platforms, leading to a compile time error. Fix his by casting hashMapSize to the expected type. 1557125 1 webkit-bug-importer 2019-07-30 16:33:18 -0700 <rdar://problem/53734203> 1557127 2 375195 krollin 2019-07-30 16:34:32 -0700 Created attachment 375195 Patch 1557286 3 375195 commit-queue 2019-07-31 09:27:02 -0700 Comment on attachment 375195 Patch Clearing flags on attachment: 375195 Committed r248044: <https://trac.webkit.org/changeset/248044> 1557287 4 commit-queue 2019-07-31 09:27:04 -0700 All reviewed patches have been landed. Closing bug. 375195 2019-07-30 16:34:32 -0700 2019-07-31 09:27:02 -0700 Patch bug-200288-20190730163431.patch text/plain 1654 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUzNmUwMjcxODAzMTBkNjMzYjMxMzFj ODZkYjQzODJjYTljMWQ4OWMuLjZhMzkzMzQ1NTc1OGQ1MzI3YmUzNzgyN2Q3YjYwZjUxY2FkOTM5 NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDctMzAgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCA2NC1iaXQgdnMgMzItYml0IG1pc21hdGNoIGlu IFBlcnNpc3RlbnRDb2RlcnMuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAwMjg4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MzczNDIwMz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBoYXNoTWFwU2l6 ZSBpcyBkZWNsYXJlZCBhcyBhIHVpbnQ2NF90LiBJdCBpcyBwYXNzZWQgdG8KKyAgICAgICAgSGFz aE1hcFR5cGU6OnJlc2VydmVJbml0aWFsQ2FwYWNpdHksIHdoaWNoIHRha2VzIGFuIHVuc2lnbmVk IGludC4gVGhpcworICAgICAgICBpcyBhIDMyLWJpdCB2YWx1ZSBvbiAzMi1iaXQgcGxhdGZvcm1z LCBsZWFkaW5nIHRvIGEgY29tcGlsZSB0aW1lCisgICAgICAgIGVycm9yLiBGaXggaGlzIGJ5IGNh c3RpbmcgaGFzaE1hcFNpemUgdG8gdGhlIGV4cGVjdGVkIHR5cGUuCisKKyAgICAgICAgKiB3dGYv cGVyc2lzdGVuY2UvUGVyc2lzdGVudENvZGVycy5oOgorCiAyMDE5LTA3LTMwICBLZWl0aCBSb2xs aW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggNjQtYml0IHZzIDMyLWJpdCBt aXNtYXRjaCBpbiBMb2dBcmd1bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvcGVyc2lz dGVuY2UvUGVyc2lzdGVudENvZGVycy5oIGIvU291cmNlL1dURi93dGYvcGVyc2lzdGVuY2UvUGVy c2lzdGVudENvZGVycy5oCmluZGV4IGI0MTZhZDg0YjkyM2JlZTgwNjE3OTQ1NjY2MzNlNzViYjEw MDViZjMuLjkwOTUzMmRmYmZhZTE3ZTQ4ZjEwY2E2ODdlN2E4MTIyOTg5NmRjMDMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL3BlcnNpc3RlbmNlL1BlcnNpc3RlbnRDb2RlcnMuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9wZXJzaXN0ZW5jZS9QZXJzaXN0ZW50Q29kZXJzLmgKQEAgLTE5Niw3ICsx OTYsNyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBLZXlBcmcsIHR5cGVuYW1lIE1hcHBlZEFyZywgdHlw ZW5hbWUgSGFzaEFyZywgdHlwZW5hbWUgS2V5VHJhaQogICAgICAgICAgICAgcmV0dXJuIGZhbHNl OwogCiAgICAgICAgIEhhc2hNYXBUeXBlIHRlbXBIYXNoTWFwOwotICAgICAgICB0ZW1wSGFzaE1h cC5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KGhhc2hNYXBTaXplKTsKKyAgICAgICAgdGVtcEhhc2hN YXAucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShzdGF0aWNfY2FzdDx1bnNpZ25lZD4oaGFzaE1hcFNp emUpKTsKICAgICAgICAgZm9yICh1aW50NjRfdCBpID0gMDsgaSA8IGhhc2hNYXBTaXplOyArK2kp IHsKICAgICAgICAgICAgIEtleUFyZyBrZXk7CiAgICAgICAgICAgICBNYXBwZWRBcmcgdmFsdWU7 Cg==