200279 2019-07-30 13:26:50 -0700 Web Inspector: Console: execution context picker doesn't update when switching to the inferred context from auto 2019-08-03 00:38:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195805 InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1557051 0 hi 2019-07-30 13:26:50 -0700 # STEPS TO REPRODUCE: 1. inspect any page with multiple execution contexts (e.g. <iframe>) 2. make sure the "auto" execution context is selected in the Console 3. try to switch execution contexts to the one that is shown after the "auto - XXX" => UI doesn't change ("auto" is still shown) 1557072 1 375177 hi 2019-07-30 14:20:53 -0700 Created attachment 375177 Patch 1558268 2 375177 joepeck 2019-08-03 00:07:06 -0700 Comment on attachment 375177 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375177&action=review r=me > Source/WebInspectorUI/ChangeLog:11 > + and therfore the `RuntimeManager.Event.ActiveExecutionContextChanged` wouldn't fire. In this Typo "therfore" => "therefore" 1558269 3 375177 commit-queue 2019-08-03 00:37:06 -0700 Comment on attachment 375177 Patch Clearing flags on attachment: 375177 Committed r248196: <https://trac.webkit.org/changeset/248196> 1558270 4 commit-queue 2019-08-03 00:37:08 -0700 All reviewed patches have been landed. Closing bug. 1558271 5 webkit-bug-importer 2019-08-03 00:38:17 -0700 <rdar://problem/53894836> 375177 2019-07-30 14:20:53 -0700 2019-08-03 00:37:06 -0700 Patch bug-200279-20190730142053.patch text/plain 2990 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFkODUzMmJmMDlhN2FhYmQ1Yjk5NWNjOGNlM2Jh YjE1OTM1NWFlMmMuLjgzNTIxZGJjZjc3MDUzMGQ5NDRlYzgwY2VhZGRkMzIyYTQ4MjgzYmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA3LTMwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD b25zb2xlOiBleGVjdXRpb24gY29udGV4dCBwaWNrZXIgZG9lc24ndCB1cGRhdGUgd2hlbiBzd2l0 Y2hpbmcgdG8gdGhlIGluZmVycmVkIGNvbnRleHQgZnJvbSBhdXRvCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAyNzkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYHJlcHJlc2VudGVkT2JqZWN0YCBv ZiB0aGUgImF1dG8iIGV4ZWN1dGlvbiBjb250ZXh0IHBhdGggY29tcG9uZW50IGlzIHNoYXJlZCB3 aXRoIHRoYXQKKyAgICAgICAgZXhlY3V0aW9uIGNvbnRleHQncyBhY3R1YWwgcGF0aCBjb21wb25l bnQsIG1lYW5pbmcgdGhhdCBpZiB0aGUgdXNlciBzd2l0Y2hlcyBmcm9tICJhdXRvIiB0bworICAg ICAgICB0aGF0IGV4ZWN1dGlvbiBjb250ZXh0J3MgcGF0aCBjb21wb25lbnQsIHRoZSB1bmRlcmx5 aW5nIGByZXByZXNlbnRlZE9iamVjdGAgd291bGRuJ3QgY2hhbmdlLAorICAgICAgICBhbmQgdGhl cmZvcmUgdGhlIGBSdW50aW1lTWFuYWdlci5FdmVudC5BY3RpdmVFeGVjdXRpb25Db250ZXh0Q2hh bmdlZGAgd291bGRuJ3QgZmlyZS4gSW4gdGhpcworICAgICAgICBjYXNlLCB1cGRhdGUgdGhlIHZp c2libGUgKCJzZWxlY3RlZCIpIGV4ZWN1dGlvbiBjb250ZXh0IHBhdGggY29tcG9uZW50IG1hbnVh bGx5LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9RdWlja0NvbnNvbGUuanM6Cisg ICAgICAgIChXSS5RdWlja0NvbnNvbGUucHJvdG90eXBlLl9zZWxlY3RFeGVjdXRpb25Db250ZXh0 KToKKyAgICAgICAgKFdJLlF1aWNrQ29uc29sZS5wcm90b3R5cGUuX3BhdGhDb21wb25lbnRTZWxl Y3RlZCk6CisKIDIwMTktMDctMjYgIEdyZWcgRG9vbGl0dGxlICA8Z3IzZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogQVhJOiBBdWRpdDogVHlwbyBvZiAic29tZSIgYXMgInNv bWVlIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvUXVpY2tDb25zb2xlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvUXVpY2tDb25zb2xlLmpzCmluZGV4IDAxZWVhM2Q4MjhiMGE2MTI0MDgxNTg4MjZhNDIw MGI3MGUzOWU1NTEuLjY3MmRlYWFjM2M1NzQzYjdjZGJhM2FjOWVmYTY5M2NiZmRlMTljNWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1F1aWNr Q29uc29sZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9RdWlja0NvbnNvbGUuanMKQEAgLTE1OSw5ICsxNTksMTIgQEAgV0kuUXVpY2tDb25zb2xlID0g Y2xhc3MgUXVpY2tDb25zb2xlIGV4dGVuZHMgV0kuVmlldwogICAgICAgICBpZiAoIWV4ZWN1dGlv bkNvbnRleHQpCiAgICAgICAgICAgICBleGVjdXRpb25Db250ZXh0ID0gV0kubWFpblRhcmdldC5l eGVjdXRpb25Db250ZXh0OwogCi0gICAgICAgIFdJLnJ1bnRpbWVNYW5hZ2VyLmFjdGl2ZUV4ZWN1 dGlvbkNvbnRleHQgPSBleGVjdXRpb25Db250ZXh0OwotCiAgICAgICAgIHRoaXMuX2F1dG9tYXRp Y0V4ZWN1dGlvbkNvbnRleHRQYXRoQ29tcG9uZW50LmRpc3BsYXlOYW1lID0gV0kuVUlTdHJpbmco IkF1dG8gLSAlcyIpLmZvcm1hdChwcmVmZXJyZWROYW1lIHx8IGV4ZWN1dGlvbkNvbnRleHQubmFt ZSk7CisKKyAgICAgICAgbGV0IGNoYW5nZWQgPSBXSS5ydW50aW1lTWFuYWdlci5hY3RpdmVFeGVj dXRpb25Db250ZXh0ICE9PSBleGVjdXRpb25Db250ZXh0OworICAgICAgICBpZiAoY2hhbmdlZCkK KyAgICAgICAgICAgIFdJLnJ1bnRpbWVNYW5hZ2VyLmFjdGl2ZUV4ZWN1dGlvbkNvbnRleHQgPSBl eGVjdXRpb25Db250ZXh0OworICAgICAgICByZXR1cm4gY2hhbmdlZDsKICAgICB9CiAKICAgICBf aGFuZGxlTW91c2VEb3duKGV2ZW50KQpAQCAtNDA1LDcgKzQwOCwxMSBAQCBXSS5RdWlja0NvbnNv bGUgPSBjbGFzcyBRdWlja0NvbnNvbGUgZXh0ZW5kcyBXSS5WaWV3CiAgICAgX3BhdGhDb21wb25l bnRTZWxlY3RlZChldmVudCkKICAgICB7CiAgICAgICAgIHRoaXMuX3Nob3VsZEF1dG9tYXRpY2Fs bHlTZWxlY3RFeGVjdXRpb25Db250ZXh0ID0gZXZlbnQuZGF0YS5wYXRoQ29tcG9uZW50ID09PSB0 aGlzLl9hdXRvbWF0aWNFeGVjdXRpb25Db250ZXh0UGF0aENvbXBvbmVudDsKLSAgICAgICAgdGhp cy5fc2VsZWN0RXhlY3V0aW9uQ29udGV4dChldmVudC5kYXRhLnBhdGhDb21wb25lbnQucmVwcmVz ZW50ZWRPYmplY3QpOworCisgICAgICAgIC8vIE9ubHkgbWFudWFsbHkgcmVidWlsZCB0aGUgZXhl Y3V0aW9uIGNvbnRleHQgcGF0aCBjb21wb25lbnRzIGlmIHRoZSBuZXdseSBzZWxlY3RlZAorICAg ICAgICAvLyBleGVjdXRpb24gY29udGV4dCBtYXRjaGVzIHRoZSBwcmV2aW91c2x5IHNlbGVjdGVk IG9uZS4KKyAgICAgICAgaWYgKCF0aGlzLl9zZWxlY3RFeGVjdXRpb25Db250ZXh0KGV2ZW50LmRh dGEucGF0aENvbXBvbmVudC5yZXByZXNlbnRlZE9iamVjdCkpCisgICAgICAgICAgICB0aGlzLl9y ZWJ1aWxkRXhlY3V0aW9uQ29udGV4dFBhdGhDb21wb25lbnRzKCk7CiAgICAgfQogCiAgICAgX3Bh dGhDb21wb25lbnRDbGlja2VkKGV2ZW50KQo=