200274 2019-07-30 11:14:52 -0700 Analysis task page should show build request author and creation time. 2019-07-31 09:28:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dewei_zhu dewei_zhu dewei_zhu rniwa oldest_to_newest 1557024 0 dewei_zhu 2019-07-30 11:14:52 -0700 Analysis task page should show build request author and creation time. 1557025 1 375164 dewei_zhu 2019-07-30 11:18:01 -0700 Created attachment 375164 Patch 1557026 2 dewei_zhu 2019-07-30 11:18:27 -0700 rdar://43339731 1557209 3 375164 rniwa 2019-07-31 00:12:45 -0700 Comment on attachment 375164 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375164&action=review > Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:376 > + const requestSummary = `Scheduled${currentGroup.author() ? 'by "' + currentGroup.author() + '"': ''} at ${currentGroup.createdAt()}` Need a space between scheduled & by. Embedding conditions inside a literal expression like this makes impossible to decipher. Please split that into a separate statement as in: const authoredBy = currentGroup.author() ? ' by ' + currentGroup.author() : ''; this.content('request-summary').innerHTML = `Scheduled ${authoredBy} at ${currentGroup.createdAt()}` Multiple whitespaces are automatically collapsed into one by CSS. 1557289 4 dewei_zhu 2019-07-31 09:28:26 -0700 Landed in r248045. 375164 2019-07-30 11:18:01 -0700 2019-07-31 00:12:45 -0700 Patch bug-200274-20190730111801.patch text/plain 3582 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ4MDEwCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAxMTBlNDYzZjY1ZmY1NTU2ODYzY2ViMjc2MzY4MmQ0ZDQ2YWQxOWEyLi5iYmIxNWU2ZDMy M2MwOTVlOTFjOTc0OTI3OWExNDJkZDQ4YjMwOWEzIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wNy0zMCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBBbmFseXNpcyB0YXNrIHBhZ2Ugc2hvdWxkIHNob3cgYnVp bGQgcmVxdWVzdCBhdXRob3IgYW5kIGNyZWF0aW9uIHRpbWUuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAyNzQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdXRob3IgYW5kIGNyZWF0aW9uIHRpbWUgb2Yg YSBidWlsZCByZXF1ZXN0IHNob3VsZCBiZSB2aXNpYmxlIGluIGFuYWx5c2lzIHRhc2sgcGFnZS4K KworICAgICAgICAqIHB1YmxpYy92My9wYWdlcy9hbmFseXNpcy10YXNrLXBhZ2UuanM6IEFkZGVk IFVJIHRvIHNob3cgYnVpbGQgcmVxdWVzdCBjcmVhdGlvbiB0aW1lIGFuZCBhdXRob3IuCisgICAg ICAgIChBbmFseXNpc1Rhc2tUZXN0R3JvdXBQYW5lLnByb3RvdHlwZS5fcmVuZGVyQ3VycmVudFRl c3RHcm91cCk6CisKIDIwMTktMDctMjkgIERld2VpIFpodSAgPGRld2VpX3podUBhcHBsZS5jb20+ CiAKICAgICAgICAgU2hvdWxkIG5vdCByZW5kZXIgbGF0ZXN0IGJ1aWxkIGluZm9ybWF0aW9uIGlm IHRoZXJlIGlzIG5vIGRhdGEgcG9pbnRzIGZvciBhIGNvbmZpZy4KZGlmZiAtLWdpdCBhL1dlYnNp dGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcGFnZXMvYW5hbHlzaXMtdGFzay1wYWdlLmpz IGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9wYWdlcy9hbmFseXNpcy10YXNr LXBhZ2UuanMKaW5kZXggODI4MGRhYTRiMGNjZDM4ZmIyODJhMjQ3MmVmNjk4ZWJiMDAzYzVkNy4u Y2RkNzljNjUyNzc5ZDlhMGE4NzkzYzg5MTlmOWJiMzEzNjZiYTE5MCAxMDA2NDQKLS0tIGEvV2Vi c2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9wYWdlcy9hbmFseXNpcy10YXNrLXBhZ2Uu anMKKysrIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9wYWdlcy9hbmFseXNp cy10YXNrLXBhZ2UuanMKQEAgLTM3MSwxMiArMzcxLDE1IEBAIGNsYXNzIEFuYWx5c2lzVGFza1Rl c3RHcm91cFBhbmUgZXh0ZW5kcyBDb21wb25lbnRCYXNlIHsKICAgICAgICAgaWYgKGN1cnJlbnRH cm91cCkgewogICAgICAgICAgICAgdGhpcy5wYXJ0KCdyZXRyeS1mb3JtJykuc2V0UmVwZXRpdGlv bkNvdW50KGN1cnJlbnRHcm91cC5pbml0aWFsUmVwZXRpdGlvbkNvdW50KCkpOwogICAgICAgICAg ICAgdGhpcy5wYXJ0KCdiaXNlY3QtZm9ybScpLnNldFJlcGV0aXRpb25Db3VudChjdXJyZW50R3Jv dXAuaW5pdGlhbFJlcGV0aXRpb25Db3VudCgpKTsKLSAgICAgICAgICAgIGNvbnN0IHN1bW1hcnkg PSBgJHtjdXJyZW50R3JvdXAuaW5pdGlhbFJlcGV0aXRpb25Db3VudCgpfSByZXF1ZXN0ZWQsICR7 Y3VycmVudEdyb3VwLnJlcGV0aXRpb25Db3VudCgpIC0gY3VycmVudEdyb3VwLmluaXRpYWxSZXBl dGl0aW9uQ291bnQoKX0gYWRkZWQgZHVlIHRvIGZhaWx1cmVzLmA7Ci0gICAgICAgICAgICB0aGlz LmNvbnRlbnQoJ3N0YXR1cy1zdW1tYXJ5JykuaW5uZXJIVE1MID0gc3VtbWFyeTsKKyAgICAgICAg ICAgIGNvbnN0IHN0YXR1c1N1bW1hcnkgPSBgJHtjdXJyZW50R3JvdXAuaW5pdGlhbFJlcGV0aXRp b25Db3VudCgpfSByZXF1ZXN0ZWQsICR7Y3VycmVudEdyb3VwLnJlcGV0aXRpb25Db3VudCgpIC0g Y3VycmVudEdyb3VwLmluaXRpYWxSZXBldGl0aW9uQ291bnQoKX0gYWRkZWQgZHVlIHRvIGZhaWx1 cmVzLmA7CisgICAgICAgICAgICB0aGlzLmNvbnRlbnQoJ3N0YXR1cy1zdW1tYXJ5JykuaW5uZXJI VE1MID0gc3RhdHVzU3VtbWFyeTsKKyAgICAgICAgICAgIGNvbnN0IHJlcXVlc3RTdW1tYXJ5ID0g YFNjaGVkdWxlZCR7Y3VycmVudEdyb3VwLmF1dGhvcigpID8gJ2J5ICInICsgY3VycmVudEdyb3Vw LmF1dGhvcigpICsgJyInOiAnJ30gYXQgJHtjdXJyZW50R3JvdXAuY3JlYXRlZEF0KCl9YAorICAg ICAgICAgICAgdGhpcy5jb250ZW50KCdyZXF1ZXN0LXN1bW1hcnknKS5pbm5lckhUTUwgPSByZXF1 ZXN0U3VtbWFyeTsKICAgICAgICAgfQogICAgICAgICB0aGlzLmNvbnRlbnQoJ3JldHJ5LWZvcm0n KS5zdHlsZS5kaXNwbGF5ID0gY3VycmVudEdyb3VwID8gbnVsbCA6ICdub25lJzsKICAgICAgICAg dGhpcy5jb250ZW50KCdiaXNlY3QtZm9ybScpLnN0eWxlLmRpc3BsYXkgPSBjdXJyZW50R3JvdXAg JiYgdGhpcy5fYmlzZWN0aW5nQ29tbWl0U2V0QnlUZXN0R3JvdXAuZ2V0KGN1cnJlbnRHcm91cCkg PyBudWxsIDogJ25vbmUnOwogICAgICAgICB0aGlzLmNvbnRlbnQoJ3N0YXR1cy1zdW1tYXJ5Jyku c3R5bGUuZGlzcGxheSA9IGN1cnJlbnRHcm91cCAmJiBjdXJyZW50R3JvdXAucmVwZXRpdGlvbkNv dW50KCkgPiBjdXJyZW50R3JvdXAuaW5pdGlhbFJlcGV0aXRpb25Db3VudCgpID8gbnVsbCA6ICdu b25lJzsKKyAgICAgICAgdGhpcy5jb250ZW50KCdyZXF1ZXN0LXN1bW1hcnknKS5zdHlsZS5kaXNw bGF5ID0gY3VycmVudEdyb3VwID8gbnVsbCA6ICdub25lJzsKIAogICAgICAgICBjb25zdCBoaWRl QnV0dG9uID0gdGhpcy5jb250ZW50KCdoaWRlLWJ1dHRvbicpOwogICAgICAgICBoaWRlQnV0dG9u LnRleHRDb250ZW50ID0gY3VycmVudEdyb3VwICYmIGN1cnJlbnRHcm91cC5pc0hpZGRlbigpID8g J1VuaGlkZScgOiAnSGlkZSc7CkBAIC0zOTMsNiArMzk2LDcgQEAgY2xhc3MgQW5hbHlzaXNUYXNr VGVzdEdyb3VwUGFuZSBleHRlbmRzIENvbXBvbmVudEJhc2UgewogICAgICAgICAgICAgICAgIDx0 ZXN0LWdyb3VwLXJlc3VsdHMtdmlld2VyIGlkPSJyZXN1bHRzLXZpZXdlciI+PC90ZXN0LWdyb3Vw LXJlc3VsdHMtdmlld2VyPgogICAgICAgICAgICAgICAgIDx0ZXN0LWdyb3VwLXJldmlzaW9uLXRh YmxlIGlkPSJyZXZpc2lvbi10YWJsZSI+PC90ZXN0LWdyb3VwLXJldmlzaW9uLXRhYmxlPgogICAg ICAgICAgICAgICAgIDxkaXYgaWQ9InN0YXR1cy1zdW1tYXJ5IiBjbGFzcz0ic3VtbWFyeSI+PC9k aXY+CisgICAgICAgICAgICAgICAgPGRpdiBpZD0icmVxdWVzdC1zdW1tYXJ5IiBjbGFzcz0ic3Vt bWFyeSI+PC9kaXY+CiAgICAgICAgICAgICAgICAgPHRlc3QtZ3JvdXAtZm9ybSBpZD0icmV0cnkt Zm9ybSI+UmV0cnk8L3Rlc3QtZ3JvdXAtZm9ybT4KICAgICAgICAgICAgICAgICA8dGVzdC1ncm91 cC1mb3JtIGlkPSJiaXNlY3QtZm9ybSI+QmlzZWN0PC90ZXN0LWdyb3VwLWZvcm0+CiAgICAgICAg ICAgICAgICAgPGJ1dHRvbiBpZD0iaGlkZS1idXR0b24iPkhpZGU8L2J1dHRvbj4K