200260 2019-07-29 17:11:01 -0700 Web Inspector: Resources: add a "Show Grid" navigation item for the Images collection 2019-07-29 22:31:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200212 InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1556833 0 hi 2019-07-29 17:11:01 -0700 From <https://webkit.org/b/200212#c5>: > While we're at it, I think it would be awesome to add a `WI.NavigationItem` for toggling the image transparent background style (the checkerboard icon). We already show it for individual image resources (and canvas rendering contexts). 1556845 1 375130 hi 2019-07-29 17:26:26 -0700 Created attachment 375130 Patch 1556872 2 375130 joepeck 2019-07-29 18:59:25 -0700 Comment on attachment 375130 Patch r=me 1556901 3 375130 commit-queue 2019-07-29 22:30:06 -0700 Comment on attachment 375130 Patch Clearing flags on attachment: 375130 Committed r248004: <https://trac.webkit.org/changeset/248004> 1556902 4 commit-queue 2019-07-29 22:30:07 -0700 All reviewed patches have been landed. Closing bug. 1556903 5 webkit-bug-importer 2019-07-29 22:31:17 -0700 <rdar://problem/53695374> 375130 2019-07-29 17:26:26 -0700 2019-07-29 22:30:06 -0700 Patch bug-200260-20190729172625.patch text/plain 5396 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFkODUzMmJmMDlhN2FhYmQ1Yjk5NWNjOGNlM2Jh YjE1OTM1NWFlMmMuLmY0Yzg4NmNhZjg1MWNiYjNlNjcyYTM5YTVhYjA0OGQwNjIzYTllOTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTA3LTI5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS ZXNvdXJjZXM6IGFkZCBhICJTaG93IEdyaWQiIG5hdmlnYXRpb24gaXRlbSBmb3IgdGhlIEltYWdl cyBjb2xsZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDAyNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBFYWNoIHN1YnZpZXcgYFdJLkltYWdlUmVzb3VyY2VDb250ZW50Vmlld2AgYWxyZWFkeSBs aXN0ZW5zIGZvciBjaGFuZ2VzIHRvIHRoZSB1bmRlcmx5aW5nCisgICAgICAgIGBXSS5zZXR0aW5n cy5zaG93SW1hZ2VHcmlkYCBhbmQgYWRkcyB0aGUgYC5zaG93LWdyaWRgIGNsYXNzIGlmIGVuYWJs ZWQuIEFzIHN1Y2gsIHRoaXMgY2hhbmdlCisgICAgICAgIGp1c3QgYWRkcyBhIGBXSS5CdXR0b25O YXZpZ2F0aW9uSXRlbWAgZm9yIHRvZ2dsaW5nIGBXSS5zZXR0aW5ncy5zaG93SW1hZ2VHcmlkYCBm cm9tIHRoZQorICAgICAgICBJbWFnZXMgImZvbGRlciIuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL1Jlc291cmNlQ29sbGVjdGlvbkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0ku UmVzb3VyY2VDb2xsZWN0aW9uQ29udGVudFZpZXcpOgorICAgICAgICAoV0kuUmVzb3VyY2VDb2xs ZWN0aW9uQ29udGVudFZpZXcucHJvdG90eXBlLmdldCBuYXZpZ2F0aW9uSXRlbXMpOgorICAgICAg ICAoV0kuUmVzb3VyY2VDb2xsZWN0aW9uQ29udGVudFZpZXcucHJvdG90eXBlLmF0dGFjaGVkKTog QWRkZWQuCisgICAgICAgIChXSS5SZXNvdXJjZUNvbGxlY3Rpb25Db250ZW50Vmlldy5wcm90b3R5 cGUuZGV0YWNoZWQpOiBBZGRlZC4KKyAgICAgICAgKFdJLlJlc291cmNlQ29sbGVjdGlvbkNvbnRl bnRWaWV3LnByb3RvdHlwZS5fdXBkYXRlSW1hZ2VUeXBlU2NvcGVCYXIpOgorICAgICAgICBEcml2 ZS1ieTogaGlkZSB0aGUgaW1hZ2UgdHlwZSBgV0kuU2NvcGVCYXJgIGlmIHRoZXJlJ3Mgb25seSBv bmUgdHlwZSBvZiBpbWFnZS4KKyAgICAgICAgKFdJLlJlc291cmNlQ29sbGVjdGlvbkNvbnRlbnRW aWV3LnByb3RvdHlwZS5faGFuZGxlU2hvd0dyaWRCdXR0b25DbGlja2VkKTogQWRkZWQuCisgICAg ICAgIChXSS5SZXNvdXJjZUNvbGxlY3Rpb25Db250ZW50Vmlldy5wcm90b3R5cGUuX2hhbmRsZVNo b3dJbWFnZUdyaWRTZXR0aW5nQ2hhbmdlZCk6IEFkZGVkLgorCiAyMDE5LTA3LTI2ICBHcmVnIERv b2xpdHRsZSAgPGdyM2dAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFYSTog QXVkaXQ6IFR5cG8gb2YgInNvbWUiIGFzICJzb21lZSIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlQ29sbGVjdGlvbkNvbnRlbnRW aWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3Vy Y2VDb2xsZWN0aW9uQ29udGVudFZpZXcuanMKaW5kZXggNGM1NDZhZTY5MDI2NjNlNWRjZDgwNzk4 NjdiZmE1MmY0NTNiZTgzZS4uNTY5NmFiZjljNGNiNjYxN2Y4NzA3ZTIxYjU5ZTE2ODJhNDQ3MTM3 MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv UmVzb3VyY2VDb2xsZWN0aW9uQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VDb2xsZWN0aW9uQ29udGVudFZpZXcuanMK QEAgLTM2LDYgKzM2LDExIEBAIFdJLlJlc291cmNlQ29sbGVjdGlvbkNvbnRlbnRWaWV3ID0gY2xh c3MgUmVzb3VyY2VDb2xsZWN0aW9uQ29udGVudFZpZXcgZXh0ZW5kcyBXCiAgICAgICAgIHN1cGVy KGNvbGxlY3Rpb24sIGNvbnRlbnRWaWV3Q29uc3RydWN0b3IpOwogCiAgICAgICAgIGlmIChjb2xs ZWN0aW9uLnJlc291cmNlVHlwZSA9PT0gV0kuUmVzb3VyY2UuVHlwZS5JbWFnZSkgeworICAgICAg ICAgICAgdGhpcy5fc2hvd0dyaWRCdXR0b25OYXZpZ2F0aW9uSXRlbSA9IG5ldyBXSS5BY3RpdmF0 ZUJ1dHRvbk5hdmlnYXRpb25JdGVtKCJzaG93LWdyaWQiLCBXSS5VSVN0cmluZygiU2hvdyBHcmlk IiksIFdJLlVJU3RyaW5nKCJIaWRlIEdyaWQiKSwgIkltYWdlcy9OYXZpZ2F0aW9uSXRlbUNoZWNr ZXJzLnN2ZyIsIDEzLCAxMyk7CisgICAgICAgICAgICB0aGlzLl9zaG93R3JpZEJ1dHRvbk5hdmln YXRpb25JdGVtLmFkZEV2ZW50TGlzdGVuZXIoV0kuQnV0dG9uTmF2aWdhdGlvbkl0ZW0uRXZlbnQu Q2xpY2tlZCwgdGhpcy5faGFuZGxlU2hvd0dyaWRCdXR0b25DbGlja2VkLCB0aGlzKTsKKyAgICAg ICAgICAgIHRoaXMuX3Nob3dHcmlkQnV0dG9uTmF2aWdhdGlvbkl0ZW0udmlzaWJpbGl0eVByaW9y aXR5ID0gV0kuTmF2aWdhdGlvbkl0ZW0uVmlzaWJpbGl0eVByaW9yaXR5LkxvdzsKKyAgICAgICAg ICAgIHRoaXMuX3Nob3dHcmlkQnV0dG9uTmF2aWdhdGlvbkl0ZW0uYWN0aXZhdGVkID0gISFXSS5z ZXR0aW5ncy5zaG93SW1hZ2VHcmlkLnZhbHVlOworCiAgICAgICAgICAgICBsZXQgYWxsSXRlbSA9 IG5ldyBXSS5TY29wZUJhckl0ZW0oImFsbCIsIFdJLlVJU3RyaW5nKCJBbGwiKSk7CiAKICAgICAg ICAgICAgIGxldCBpdGVtcyA9IFthbGxJdGVtXTsKQEAgLTY4LDE0ICs3MywzMSBAQCBXSS5SZXNv dXJjZUNvbGxlY3Rpb25Db250ZW50VmlldyA9IGNsYXNzIFJlc291cmNlQ29sbGVjdGlvbkNvbnRl bnRWaWV3IGV4dGVuZHMgVwogCiAgICAgZ2V0IG5hdmlnYXRpb25JdGVtcygpCiAgICAgewotICAg ICAgICBsZXQgbmF2aWdhdGlvbkl0ZW1zID0gc3VwZXIubmF2aWdhdGlvbkl0ZW1zOworICAgICAg ICBsZXQgbmF2aWdhdGlvbkl0ZW1zID0gW107CiAgICAgICAgIGlmICh0aGlzLl9pbWFnZVR5cGVT Y29wZUJhcikKLSAgICAgICAgICAgIG5hdmlnYXRpb25JdGVtcy51bnNoaWZ0KHRoaXMuX2ltYWdl VHlwZVNjb3BlQmFyKTsKKyAgICAgICAgICAgIG5hdmlnYXRpb25JdGVtcy5wdXNoKHRoaXMuX2lt YWdlVHlwZVNjb3BlQmFyKTsKKyAgICAgICAgaWYgKHRoaXMuX3Nob3dHcmlkQnV0dG9uTmF2aWdh dGlvbkl0ZW0pCisgICAgICAgICAgICBuYXZpZ2F0aW9uSXRlbXMucHVzaCh0aGlzLl9zaG93R3Jp ZEJ1dHRvbk5hdmlnYXRpb25JdGVtKTsKKyAgICAgICAgbmF2aWdhdGlvbkl0ZW1zID0gbmF2aWdh dGlvbkl0ZW1zLmNvbmNhdChzdXBlci5uYXZpZ2F0aW9uSXRlbXMpOwogICAgICAgICByZXR1cm4g bmF2aWdhdGlvbkl0ZW1zOwogICAgIH0KIAogICAgIC8vIFByb3RlY3RlZAogCisgICAgYXR0YWNo ZWQoKQorICAgIHsKKyAgICAgICAgc3VwZXIuYXR0YWNoZWQoKTsKKworICAgICAgICBXSS5zZXR0 aW5ncy5zaG93SW1hZ2VHcmlkLmFkZEV2ZW50TGlzdGVuZXIoV0kuU2V0dGluZy5FdmVudC5DaGFu Z2VkLCB0aGlzLl9oYW5kbGVTaG93SW1hZ2VHcmlkU2V0dGluZ0NoYW5nZWQsIHRoaXMpOworICAg IH0KKworICAgIGRldGFjaGVkKCkKKyAgICB7CisgICAgICAgIFdJLnNldHRpbmdzLnNob3dJbWFn ZUdyaWQucmVtb3ZlRXZlbnRMaXN0ZW5lcihudWxsLCBudWxsLCB0aGlzKTsKKworICAgICAgICBz dXBlci5kZXRhY2hlZCgpOworICAgIH0KKwogICAgIGNvbnRlbnRWaWV3QWRkZWQoY29udGVudFZp ZXcpCiAgICAgewogICAgICAgICBjb25zb2xlLmFzc2VydChjb250ZW50VmlldyBpbnN0YW5jZW9m IFdJLlJlc291cmNlQ29udGVudFZpZXcpOwpAQCAtOTksNiArMTIxLDcgQEAgV0kuUmVzb3VyY2VD b2xsZWN0aW9uQ29udGVudFZpZXcgPSBjbGFzcyBSZXNvdXJjZUNvbGxlY3Rpb25Db250ZW50Vmll dyBleHRlbmRzIFcKICAgICBfdXBkYXRlSW1hZ2VUeXBlU2NvcGVCYXIoKQogICAgIHsKICAgICAg ICAgbGV0IGV4dGVuc2lvbnMgPSBuZXcgU2V0OworICAgICAgICBsZXQgdmlzaWJsZUV4dGVuc2lv bnMgPSAwOwogCiAgICAgICAgIGZvciAobGV0IHJlc291cmNlIG9mIHRoaXMucmVwcmVzZW50ZWRP YmplY3QpCiAgICAgICAgICAgICBleHRlbnNpb25zLmFkZChXSS5maWxlRXh0ZW5zaW9uRm9yTUlN RVR5cGUocmVzb3VyY2UubWltZVR5cGUpKTsKQEAgLTEwOCw3ICsxMzEsMTggQEAgV0kuUmVzb3Vy Y2VDb2xsZWN0aW9uQ29udGVudFZpZXcgPSBjbGFzcyBSZXNvdXJjZUNvbGxlY3Rpb25Db250ZW50 VmlldyBleHRlbmRzIFcKICAgICAgICAgICAgIGl0ZW0uaGlkZGVuID0gaGlkZGVuOwogICAgICAg ICAgICAgaWYgKGhpZGRlbiAmJiBpdGVtLnNlbGVjdGVkKQogICAgICAgICAgICAgICAgIGl0ZW0u c2VsZWN0ZWQgPSBmYWxzZTsKKworICAgICAgICAgICAgaWYgKCFpdGVtLmhpZGRlbikKKyAgICAg ICAgICAgICAgICArK3Zpc2libGVFeHRlbnNpb25zOwogICAgICAgICB9CisKKyAgICAgICAgdGhp cy5faW1hZ2VUeXBlU2NvcGVCYXIuaGlkZGVuID0gdmlzaWJsZUV4dGVuc2lvbnMgPD0gMTsKKyAg ICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV0kuQ29udGVudFZpZXcuRXZlbnQu TmF2aWdhdGlvbkl0ZW1zRGlkQ2hhbmdlKTsKKyAgICB9CisKKyAgICBfaGFuZGxlU2hvd0dyaWRC dXR0b25DbGlja2VkKGV2ZW50KQorICAgIHsKKyAgICAgICAgV0kuc2V0dGluZ3Muc2hvd0ltYWdl R3JpZC52YWx1ZSA9ICF0aGlzLl9zaG93R3JpZEJ1dHRvbk5hdmlnYXRpb25JdGVtLmFjdGl2YXRl ZDsKICAgICB9CiAKICAgICBfaGFuZGxlSW1hZ2VUeXBlU2VsZWN0aW9uQ2hhbmdlZCgpCkBAIC0x MjMsNiArMTU3LDEyIEBAIFdJLlJlc291cmNlQ29sbGVjdGlvbkNvbnRlbnRWaWV3ID0gY2xhc3Mg UmVzb3VyY2VDb2xsZWN0aW9uQ29udGVudFZpZXcgZXh0ZW5kcyBXCiAgICAgICAgIH0KICAgICB9 CiAKKyAgICBfaGFuZGxlU2hvd0ltYWdlR3JpZFNldHRpbmdDaGFuZ2VkKGV2ZW50KQorICAgIHsK KyAgICAgICAgbGV0IGFjdGl2YXRlZCA9IFdJLnNldHRpbmdzLnNob3dJbWFnZUdyaWQudmFsdWU7 CisgICAgICAgIHRoaXMuX3Nob3dHcmlkQnV0dG9uTmF2aWdhdGlvbkl0ZW0uYWN0aXZhdGVkID0g YWN0aXZhdGVkOworICAgIH0KKwogICAgIF9oYW5kbGVDb250ZW50RXJyb3IoZXZlbnQpCiAgICAg ewogICAgICAgICBpZiAoZXZlbnQgJiYgZXZlbnQudGFyZ2V0KQo=