200258 2019-07-29 16:52:54 -0700 imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker.html is a flakey failure, WebAssembly.Global is not implemented 2019-12-04 12:28:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell ysuzuki ap commit-queue saam webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1556816 0 tsavell 2019-07-29 16:52:54 -0700 It looks like the imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker.html added in https://trac.webkit.org/changeset/247457/webkit is flaky on Mac Debug. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fwasm%2Fjsapi%2Finterface.any.worker.html Diff: --- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker-expected.txt +++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/wasm/jsapi/interface.any.worker-actual.txt @@ -1,5 +1,3 @@ -CONSOLE MESSAGE: line 1774: TypeError: null is not an object (evaluating 'this.message_target.removeEventListener') -CONSOLE MESSAGE: line 154: TypeError: undefined is not an object (evaluating 'WebAssembly.Global.prototype') Harness Error (FAIL), message = TypeError: undefined is not an object (evaluating 'WebAssembly.Global.prototype') 1556817 1 webkit-bug-importer 2019-07-29 16:53:27 -0700 <rdar://problem/53686304> 1556867 2 ysuzuki 2019-07-29 18:51:48 -0700 This is imported from wpt, and the error related to `WebAssembly.Global` thing is expected since this is not implemented yet. We can mark it as flaky. When `WebAssembly.Global` is implemented, we can make it PASS. 1556941 3 tsavell 2019-07-30 08:24:36 -0700 Marked test as flakey in https://trac.webkit.org/changeset/248005/webkit 1557100 4 ap 2019-07-30 15:28:38 -0700 Curious why an unimplemented feature causes flaky failures, not 100% failures. Is this test racy in some way? 1595397 5 ysuzuki 2019-12-04 00:06:18 -0800 Let's unmark it since I implemented WebAssembly.Global. 1595402 6 384792 ysuzuki 2019-12-04 00:12:30 -0800 Created attachment 384792 Patch 1595555 7 384792 commit-queue 2019-12-04 12:28:14 -0800 Comment on attachment 384792 Patch Clearing flags on attachment: 384792 Committed r253119: <https://trac.webkit.org/changeset/253119> 1595556 8 commit-queue 2019-12-04 12:28:16 -0800 All reviewed patches have been landed. Closing bug. 384792 2019-12-04 00:12:30 -0800 2019-12-04 12:28:14 -0800 Patch bug-200258-20191204001229.patch text/plain 1669 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzMDk1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2FlNWE4ZTk5N2RlYzI1N2Y1Mjhh NWNiMGU3YWYxMjc5ZGQyNjYwMy4uYTJmZjIyM2ZiYjdjZGUwMzk1YmY2N2Y4ZThkNTNiYjQ1ODBh ZDA5ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTEyLTA0ICBZdXN1a2UgU3V6dWtpICA8 eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy93YXNtL2pzYXBpL2ludGVyZmFjZS5hbnkud29ya2VyLmh0bWwgaXMgYSBmbGFrZXkgZmFp bHVyZSwgV2ViQXNzZW1ibHkuR2xvYmFsIGlzIG5vdCBpbXBsZW1lbnRlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMjU4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgaW1wbGVtZW50ZWQgV2ViQXNz ZW1ibHkuR2xvYmFsIG5vdy4gU28gbGV0J3MgdW5tYXJrIGl0LgorCisgICAgICAgICogcGxhdGZv cm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTktMTItMDMgIE1lZ2FuIEdhcmRuZXIgIDxt ZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgZGlzYWJsZWQgaGlnaGxpZ2h0 IEFQSSBza2VsZXRvbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RF eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpp bmRleCBiMTBhNDNmMDU5YTJkNTgwMDNiOGQ4NzQxOTcyYjBiNWRlMjg3ZWQxLi4zZjU1MzI3NGUy OGQ0ZWZkODM4YmZmYThkYzdmM2UzMGYzNWI1ZGZhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTg4Niw4ICsxODg2LDYgQEAgd2Via2l0Lm9yZy9iLzE5 NTYzNSBzY3JvbGxpbmdjb29yZGluYXRvci9tYWMvbXVsdGlwbGUtZml4ZWQuaHRtbCBbIFBhc3Mg VGltZW91dAogWyBDYXRhbGluYSsgXSBmYXN0L3RleHQvZGVzaWduLXN5c3RlbS11aS0xNS5odG1s IFsgUGFzcyBdCiBbIENhdGFsaW5hKyBdIGZhc3QvdGV4dC9kZXNpZ24tc3lzdGVtLXVpLTE2Lmh0 bWwgWyBQYXNzIF0KIAotd2Via2l0Lm9yZy9iLzIwMDI1OCBbIERlYnVnIF0gaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy93YXNtL2pzYXBpL2ludGVyZmFjZS5hbnkud29ya2VyLmh0bWwg WyBQYXNzIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMjAwMTI4IGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90aGUtdmlkZW8t ZWxlbWVudC92aWRlb190aW1ldXBkYXRlX29uX3NlZWsuaHRtbCBbIFRpbWVvdXQgUGFzcyBdCiAK IHdlYmtpdC5vcmcvYi8xODE4MzcgWyBSZWxlYXNlIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXIvcmVhZHkuaHR0cHMuaHRtbCBb IFBhc3MgRmFpbHVyZSBdCg==