200243 2019-07-29 14:29:06 -0700 Fix CRASH_WITH_INFO() so that it doesn't complain about unused parameters on non Clang / MSVC compilers. 2019-07-30 09:07:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mcatanzaro benjamin cdumez cmarcelo commit-queue dbates ews-watchlist mcatanzaro saam tzagallo webkit-bug-importer oldest_to_newest 1556711 0 mark.lam 2019-07-29 14:29:06 -0700 ... 1556721 1 375106 mark.lam 2019-07-29 14:34:41 -0700 Created attachment 375106 proposed patch. 1556724 2 375107 mark.lam 2019-07-29 14:36:05 -0700 Created attachment 375107 proposed patch. 1556735 3 mark.lam 2019-07-29 15:00:56 -0700 Sign. This is more annoying to fix than I thought. It appears that GCC does not support ##__VA_ARGS__ expansion. 1556741 4 mark.lam 2019-07-29 15:06:58 -0700 (In reply to Mark Lam from comment #3) > Sign. This is more annoying to fix than I thought. It appears that GCC > does not support ##__VA_ARGS__ expansion. Not true. I misread the build failure logs. Let me try again. 1556749 5 mcatanzaro 2019-07-29 15:15:04 -0700 Oh thanks! (And nice timing, because this was coming up next on my TODO. :) 1556751 6 mark.lam 2019-07-29 15:16:48 -0700 (In reply to Michael Catanzaro from comment #5) > Oh thanks! (And nice timing, because this was coming up next on my TODO. :) Can you take the bug? I don't have gcc and I can't reproduce the issue. 1556753 7 mcatanzaro 2019-07-29 15:19:46 -0700 Yeah I'll try. 1556763 8 mcatanzaro 2019-07-29 15:44:49 -0700 After reading https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html I was confused why your patch didn't work, but eventually I noticed: """ CPP retains the comma when conforming to a specific C standard. Otherwise the comma is dropped as an extension to the standard. """ Indeed, your patch works if I try this: diff --git a/Source/cmake/OptionsCommon.cmake b/Source/cmake/OptionsCommon.cmake index a574ef8c222..75f60ea9384 100644 --- a/Source/cmake/OptionsCommon.cmake +++ b/Source/cmake/OptionsCommon.cmake @@ -1,6 +1,6 @@ set(CMAKE_CXX_STANDARD 17) set(CMAKE_CXX_STANDARD_REQUIRED ON) -set(CMAKE_CXX_EXTENSIONS OFF) +set(CMAKE_CXX_EXTENSIONS ON) add_definitions(-DBUILDING_WITH_CMAKE=1) add_definitions(-DHAVE_CONFIG_H=1) Apple ports are compiled with GNU language extensions enabled (which clang implements for compatibility), but CMake ports are not. We could turn them on to make this work if Apple is OK with starting to use GNU extensions throughout the codebase, but it's probably better for WebKit to stick to language standards. The standard solution, according to the documentation, is to replace ##__VA_ARGS__ with format __VA_OPT__(,) __VA_ARGS__, but this requires C++20, and well, please no. Let me see if I can make it work by using the va_list in the function. It will probably mess up the stack and defeat the entire point of using the CRASH_WITH_INFO() macro, but this is just for the fallback path anyway. 1556765 9 mcatanzaro 2019-07-29 15:45:57 -0700 (In reply to Michael Catanzaro from comment #8) > We could turn them > on to make this work if Apple is OK with starting to use GNU extensions > throughout the codebase (Currently they only work in Apple-specific code. That might be ironic.) 1556786 10 mcatanzaro 2019-07-29 16:09:47 -0700 (In reply to Michael Catanzaro from comment #8) > Let me see if I can make it work by using the va_list in the function. Well that doesn't work because of course there's no way to get the vargs into the function without using __VA_ARGS__, oops. 1556844 11 mcatanzaro 2019-07-29 17:23:18 -0700 OK, solution is just to use an inline function instead of a macro and call it a day. 1556846 12 375131 mcatanzaro 2019-07-29 17:34:24 -0700 Created attachment 375131 Patch 1556849 13 375131 mark.lam 2019-07-29 17:41:54 -0700 Comment on attachment 375131 Patch r=me if the EWS bots are happy. 1556940 14 375131 mcatanzaro 2019-07-30 08:23:02 -0700 Comment on attachment 375131 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375131&action=review > Source/WTF/wtf/Assertions.h:606 > +// FIXME: When we enable C++20, we should replace ##__VA_ARGS with format __VA_OPT__(,) __VA_ARGS__ Typo here, should be ##__VA_ARGS__. Will land manually. 1556959 15 mcatanzaro 2019-07-30 09:04:53 -0700 Committed r248008: <https://trac.webkit.org/changeset/248008> 1556960 16 webkit-bug-importer 2019-07-30 09:07:02 -0700 <rdar://problem/53712058> 375106 2019-07-29 14:34:41 -0700 2019-07-29 14:35:06 -0700 proposed patch. bug-200243.patch text/plain 1678 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDc5MjEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE5LTA3LTI5ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQ1JBU0hfV0lUSF9JTkZPKCkgc28gdGhhdCBpdCBk b2Vzbid0IGNvbXBsYWluIGFib3V0IHVudXNlZCBwYXJhbWV0ZXJzIG9uIG5vbiBDbGFuZyAvIE1T VkMgY29tcGlsZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAwMjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5oOgorICAgICAgICAoV1RGQ3Jhc2hVbnVzZWQpOgorCisy MDE5LTA3LTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBOZWVk IGEgc2hvcnQgZGVzY3JpcHRpb24gKE9PUFMhKS4KKyAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAo T09QUyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogd3RmL0Fzc2VydGlvbnMuaDoKKyAgICAgICAgKFdURkNyYXNoVW51c2VkKToKKyAgICAgICAg KiB3dGYvQ29tcGlsZXIuaDoKKwogMjAxOS0wNy0yNSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIGhlbHBlciBmb3IgaWdub3JpbmcgZGVwcmVjYXRlZCBpbXBs ZW1lbnRhdGlvbiB3YXJuaW5ncwpJbmRleDogU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAkocmV2aXNpb24gMjQ3OTEy KQorKysgU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC01OTcs OSArNTk3LDEzIEBAIGlubGluZSB2b2lkIGNvbXBpbGVyRmVuY2VGb3JDcmFzaCgpCiAgICAgICAg IGNvbXBpbGVyRmVuY2VGb3JDcmFzaCgpOyBcCiAgICAgICAgIFdURkNyYXNoV2l0aEluZm8oX19M SU5FX18sIF9fRklMRV9fLCBXVEZfUFJFVFRZX0ZVTkNUSU9OLCBfX0NPVU5URVJfXywgIyNfX1ZB X0FSR1NfXyk7IFwKICAgICB9IHdoaWxlIChmYWxzZSkKLSNlbHNlCi0jZGVmaW5lIENSQVNIX1dJ VEhfSU5GTyguLi4pIENSQVNIKCkKLSNlbmRpZgorI2Vsc2UgLy8gbm90IChDT01QSUxFUihDTEFO RykgfHwgQ09NUElMRVIoTVNWQykpCitpbmxpbmUgdm9pZCBXVEZDcmFzaFVudXNlZChpbnQsIC4u LikgeyB9CisjZGVmaW5lIENSQVNIX1dJVEhfSU5GTyguLi4pIGRvIHsgXAorICAgICAgICBXVEZD cmFzaFVudXNlZCgwLCAjI19fVkFfQVJHU19fKTsgXAorICAgICAgICBDUkFTSCgpOyBcCisgICAg fSB3aGlsZShmYWxzZSkKKyNlbmRpZiAvLyBDT01QSUxFUihDTEFORykgfHwgQ09NUElMRVIoTVNW QykKICNlbmRpZiAvLyBDUkFTSF9XSVRIX0lORk8KIAogI2lmbmRlZiBDUkFTSF9XSVRIX1NFQ1VS SVRZX0lNUExJQ0FUSU9OX0FORF9JTkZPCg== 375107 2019-07-29 14:36:05 -0700 2019-07-29 15:15:59 -0700 proposed patch. bug-200243.patch text/plain 1428 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDc5MjEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA3LTI5ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggQ1JBU0hfV0lUSF9JTkZPKCkgc28gdGhhdCBpdCBk b2Vzbid0IGNvbXBsYWluIGFib3V0IHVudXNlZCBwYXJhbWV0ZXJzIG9uIG5vbiBDbGFuZyAvIE1T VkMgY29tcGlsZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjAwMjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5oOgorICAgICAgICAoV1RGQ3Jhc2hVbnVzZWQpOgorCiAy MDE5LTA3LTI1ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg aGVscGVyIGZvciBpZ25vcmluZyBkZXByZWNhdGVkIGltcGxlbWVudGF0aW9uIHdhcm5pbmdzCklu ZGV4OiBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dU Ri93dGYvQXNzZXJ0aW9ucy5oCShyZXZpc2lvbiAyNDc5MTIpCisrKyBTb3VyY2UvV1RGL3d0Zi9B c3NlcnRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTU5Nyw5ICs1OTcsMTMgQEAgaW5saW5lIHZv aWQgY29tcGlsZXJGZW5jZUZvckNyYXNoKCkKICAgICAgICAgY29tcGlsZXJGZW5jZUZvckNyYXNo KCk7IFwKICAgICAgICAgV1RGQ3Jhc2hXaXRoSW5mbyhfX0xJTkVfXywgX19GSUxFX18sIFdURl9Q UkVUVFlfRlVOQ1RJT04sIF9fQ09VTlRFUl9fLCAjI19fVkFfQVJHU19fKTsgXAogICAgIH0gd2hp bGUgKGZhbHNlKQotI2Vsc2UKLSNkZWZpbmUgQ1JBU0hfV0lUSF9JTkZPKC4uLikgQ1JBU0goKQot I2VuZGlmCisjZWxzZSAvLyBub3QgKENPTVBJTEVSKENMQU5HKSB8fCBDT01QSUxFUihNU1ZDKSkK K2lubGluZSB2b2lkIFdURkNyYXNoVW51c2VkKGludCwgLi4uKSB7IH0KKyNkZWZpbmUgQ1JBU0hf V0lUSF9JTkZPKC4uLikgZG8geyBcCisgICAgICAgIFdURkNyYXNoVW51c2VkKDAsICMjX19WQV9B UkdTX18pOyBcCisgICAgICAgIENSQVNIKCk7IFwKKyAgICB9IHdoaWxlKGZhbHNlKQorI2VuZGlm IC8vIENPTVBJTEVSKENMQU5HKSB8fCBDT01QSUxFUihNU1ZDKQogI2VuZGlmIC8vIENSQVNIX1dJ VEhfSU5GTwogCiAjaWZuZGVmIENSQVNIX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT05fQU5EX0lO Rk8K 375131 2019-07-29 17:34:24 -0700 2019-07-30 08:23:02 -0700 Patch bug-200243-20190729193423.patch text/plain 2931 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3ODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDdiY2ZjNzVjNDk5YWNiZjQxMDU5ZGM3 ZWEwYmM0Mzk4NjE0MDcwM2YuLjVkMzE1ZTE4ZjZkZTE2MGM1YzM4YTcxNGUyMDViMzg5ODRiNDIz NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDctMjkgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIEZpeCBDUkFTSF9XSVRIX0lORk8oKSBz byB0aGF0IGl0IGRvZXNuJ3QgY29tcGxhaW4gYWJvdXQgdW51c2VkIHBhcmFtZXRlcnMgb24gbm9u IENsYW5nIC8gTVNWQyBjb21waWxlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDAyNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGb3IgR0NDLCB3ZSdsbCBpbXBsZW1lbnQgV1RGQ3Jhc2hXaXRoSW5m byBhcyBhIGZ1bmN0aW9uIHJhdGhlciB0aGFuIGEgbWFjcm8uIFRvIHVzZQorICAgICAgICAjI19f VkFfQVJHUyB3ZSB3b3VsZCBuZWVkIHRvIGVuYWJsZSBHTlUgZXh0ZW5zaW9ucywgYW5kIGRvbid0 IHdhbnQgdG8gZG8gdGhhdC4gVGhlIHByb3BlcgorICAgICAgICBzb2x1dGlvbiwgZm9ybWF0IF9f VkFfT1BUX18oLCkgX19WQV9BUkdTX18sIHJlcXVpcmVzIEMrKzIwLiBTbyBqdXN0IHVzZSBhbiBp bmxpbmUgZnVuY3Rpb24KKyAgICAgICAgZm9yIG5vdyBhcyBhIHdvcmthcm91bmQuCisKKyAgICAg ICAgKiB3dGYvQXNzZXJ0aW9ucy5oOgorICAgICAgICAoQ1JBU0hfV0lUSF9JTkZPKToKKyAgICAg ICAgKENSQVNIX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT05fQU5EX0lORk8pOgorCiAyMDE5LTA3 LTI1ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgaGVscGVy IGZvciBpZ25vcmluZyBkZXByZWNhdGVkIGltcGxlbWVudGF0aW9uIHdhcm5pbmdzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmggYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRp b25zLmgKaW5kZXggNzA2MmU3Y2VjYWE1YjEzYTdjZTZkOTZhZjZmYTAxYTU1Y2VjYWViZS4uMGQy MzQ2NTIwMjM3YTM5YjNjOTFkNDc3MjMyOWM0OTkwZDJiZDE5ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvQXNzZXJ0aW9ucy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaApA QCAtNTg5LDggKzU4OSw4IEBAIGlubGluZSB2b2lkIGNvbXBpbGVyRmVuY2VGb3JDcmFzaCgpCiB9 CiAKICNpZm5kZWYgQ1JBU0hfV0lUSF9JTkZPCi0vLyBUaGlzIGlzIHVzZWZ1bCBpZiB5b3UgYXJl IGdvaW5nIHRvIHN0dWZmIGRhdGEgaW50byByZWdpc3RlcnMgYmVmb3JlIGNyYXNoaW5nLiBMaWtl IHRoZSBjcmFzaFdpdGhJbmZvIGZ1bmN0aW9ucyBiZWxvdy4uLgotLy8gR0NDIGRvZXNuJ3QgbGlr ZSB0aGUgIyNfX1ZBX0FSR1NfXyBoZXJlIHNpbmNlIHRoaXMgbWFjcm8gaXMgY2FsbGVkIGZyb20g YW5vdGhlciBtYWNybyBzbyB3ZSBqdXN0IENSQVNIIGluc3RlYWQgdGhlcmUuCisvLyBUaGlzIGlz IHVzZWZ1bCBpZiB5b3UgYXJlIGdvaW5nIHRvIHN0dWZmIGRhdGEgaW50byByZWdpc3RlcnMgYmVm b3JlIGNyYXNoaW5nLCBsaWtlIHRoZQorLy8gY3Jhc2hXaXRoSW5mbyBmdW5jdGlvbnMgYmVsb3cu CiAjaWYgQ09NUElMRVIoQ0xBTkcpIHx8IENPTVBJTEVSKE1TVkMpCiAjZGVmaW5lIENSQVNIX1dJ VEhfSU5GTyguLi4pIGRvIHsgXAogICAgICAgICBXVEY6OmlzSW50ZWdyYWxUeXBlKF9fVkFfQVJH U19fKTsgXApAQCAtNTk4LDcgKzU5OCwyNCBAQCBpbmxpbmUgdm9pZCBjb21waWxlckZlbmNlRm9y Q3Jhc2goKQogICAgICAgICBXVEZDcmFzaFdpdGhJbmZvKF9fTElORV9fLCBfX0ZJTEVfXywgV1RG X1BSRVRUWV9GVU5DVElPTiwgX19DT1VOVEVSX18sICMjX19WQV9BUkdTX18pOyBcCiAgICAgfSB3 aGlsZSAoZmFsc2UpCiAjZWxzZQotI2RlZmluZSBDUkFTSF9XSVRIX0lORk8oLi4uKSBDUkFTSCgp CisvLyBHQ0MgZG9lcyBub3QgYWxsb3cgIyNfX1ZBX0FSR1NfXyB1bmxlc3MgR05VIGV4dGVuc2lv bnMgYXJlIGVuYWJsZWQgKC0tc3RkPWdudSsrTk4gaW5zdGVhZCBvZgorLy8gLS1zdGQ9YysrTk4p IGFuZCBJIHRoaW5rIHdlIGRvbid0IHdhbnQgdGhhdCwgc28gd2UnbGwgaGF2ZSBhIGZhbGxiYWNr IHBhdGggZm9yIEdDQy4gT2J2aW91c2x5CisvLyB0aGlzIHdpbGwgbm90IGFjdHVhbGx5IHN1Y2Nl ZWQgYXQgZ2V0dGluZyB0aGUgZGVzaXJlZCBpbmZvIGludG8gcmVnaXN0ZXJzIGJlZm9yZSBjcmFz aGluZywgYnV0CisvLyBpdCdzIGp1c3QgYSBmYWxsYmFjayBhbnl3YXkuCisvLworLy8gRklYTUU6 IFdoZW4gd2UgZW5hYmxlIEMrKzIwLCB3ZSBzaG91bGQgcmVwbGFjZSAjI19fVkFfQVJHUyB3aXRo IGZvcm1hdCBfX1ZBX09QVF9fKCwpIF9fVkFfQVJHU19fCisvLyBzbyB0aGF0IHdlIGNhbiByZW1v dmUgdGhpcyBmYWxsYmFjay4KK2lubGluZSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIHZvaWQgQ1JB U0hfV0lUSF9JTkZPKC4uLikKK3sKKyAgICBDUkFTSCgpOworfQorCisvLyBXZSBtdXN0IGRlZmlu ZSB0aGlzIGhlcmUgYmVjYXVzZSBDUkFTSF9XSVRIX0lORk8oKSBpcyBub3QgZGVmaW5lZCBhcyBh IG1hY3JvLgorLy8gRklYTUU6IFJlbW92ZSB0aGlzIHdoZW4gdXBncmFkaW5nIHRvIEMrKzIwLgor aW5saW5lIE5PX1JFVFVSTl9EVUVfVE9fQ1JBU0ggdm9pZCBDUkFTSF9XSVRIX1NFQ1VSSVRZX0lN UExJQ0FUSU9OX0FORF9JTkZPKC4uLikKK3sKKyAgICBDUkFTSCgpOworfQogI2VuZGlmCiAjZW5k aWYgLy8gQ1JBU0hfV0lUSF9JTkZPCiAK