200239 2019-07-29 13:51:11 -0700 Contextual menu does not present when holding an embedded photo but works with link and attachments 2019-07-29 14:20:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino thorton webkit-bug-importer oldest_to_newest 1556685 0 dino 2019-07-29 13:51:11 -0700 Contextual menu does not present when holding an embedded photo but works with link and attachments 1556686 1 dino 2019-07-29 13:51:44 -0700 <rdar://problem/53318733> 1556687 2 375096 dino 2019-07-29 13:55:03 -0700 Created attachment 375096 Patch 1556689 3 375096 thorton 2019-07-29 13:56:42 -0700 Comment on attachment 375096 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375096&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7971 > + UIContextMenuActionProvider actionMenuProvider = [weakSelf = weakSelf, elementInfo = elementInfo] (NSArray<UIMenuElement *> *) -> UIMenu * { why the [a = a, b = b]? can't you just [a, b]? 1556690 4 375096 thorton 2019-07-29 13:56:55 -0700 Comment on attachment 375096 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375096&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7978 > + return [UIMenu menuWithTitle:@"" children:actions]; Is this not nullable? 1556702 5 375096 dino 2019-07-29 14:16:27 -0700 Comment on attachment 375096 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375096&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7971 >> + UIContextMenuActionProvider actionMenuProvider = [weakSelf = weakSelf, elementInfo = elementInfo] (NSArray<UIMenuElement *> *) -> UIMenu * { > > why the [a = a, b = b]? can't you just [a, b]? yes >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7978 >> + return [UIMenu menuWithTitle:@"" children:actions]; > > Is this not nullable? Alas, no. Very strange since they don't really want titles. 1556707 6 dino 2019-07-29 14:20:46 -0700 Committed r247920: <https://trac.webkit.org/changeset/247920> 375096 2019-07-29 13:55:03 -0700 2019-07-29 13:56:42 -0700 Patch bug-200239-20190730065502.patch text/plain 3586 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3ODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk5NGY0NWQ0YWZiNDRhMTRi ZDA2OWY4MDdlNDAyODlkMzYxODEwNjcuLmEzOGFkNzE5MGYzNzM1OWYwM2ZlYzY3NzQ5ZTgwZTI0 ZmJiZThjMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDctMjkgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIENvbnRleHR1YWwgbWVudSBkb2VzIG5v dCBwcmVzZW50IHdoZW4gaG9sZGluZyBhbiBlbWJlZGRlZCBwaG90byBidXQgd29ya3Mgd2l0aCBs aW5rIGFuZCBhdHRhY2htZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAwMjM5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MzMxODczMz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgdXNl ciBsb25nLXByZXNzZWQgb24gYW4gaW1hZ2UsIGFuZCB0aGUgY2xpZW50IGltcGxlbWVudGVkIHRo ZSBuZXcgQVBJIGJ1dCBkaWQKKyAgICAgICAgbm90IHByb3ZpZGUgYSBjb25maWd1cmF0aW9uLCB3 ZSB3ZXJlIG5vdCBmYWxsaW5nIGJhY2sgdG8gdGhlIGRlZmF1bHQgYmVoYXZpb3VyIG9mCisgICAg ICAgIGdpdmluZyBhIG1lbnUgYWxsb3dpbmcgdGhlIHVzZXIgdG8gY29weS9zaGFyZS9zYXZlIHRo ZSBpbWFnZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGNvbnRpbnVlQ29udGV4dE1lbnVJbnRl cmFjdGlvbjpdKTogSWYgd2UgZ2V0IHRocm91Z2ggdGhlIGRlbGVnYXRlcywKKyAgICAgICAgYW5k IHRoZSBlbGVtZW50IGlzIGFuIGltYWdlLCByZXR1cm4gdGhlIGRlZmF1bHQgY29uZmlndXJhdGlv bi4KKwogMjAxOS0wNy0yNSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOiBlcnJv cjogaW1wbGVtZW50aW5nIGRlcHJlY2F0ZWQgbWV0aG9kIGNvbnRleHRNZW51SW50ZXJhY3Rpb25X aWxsUHJlc2VudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0Nv bnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggYmI0OTRhMWU4Y2EyYmJmMjE3MmU4YmYyYjhh NzA2NmNmYWQ5NGRkZi4uMzMzNGM1MmMxNmRiNjBjYWU5MzE4NGRkZWMzZjMwYjM1YThkZTI1YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCkBAIC03OTYwLDYgKzc5NjAsMzUgQEAgc3RhdGljIFVJTWVudSAqbWVu dVdpdGhTaG93TGlua1ByZXZpZXdBY3Rpb24oVUlNZW51ICpvcmlnaW5hbE1lbnUpCiAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIH0KIAorICAgICAgICBpZiAoc3Ryb25nU2VsZi0+X3Bvc2l0 aW9uSW5mb3JtYXRpb24uaXNJbWFnZSkgeworICAgICAgICAgICAgQVNTRVJUKHN0cm9uZ1NlbGYt Pl9wb3NpdGlvbkluZm9ybWF0aW9uLmltYWdlKTsKKyAgICAgICAgICAgIGF1dG8gY2dJbWFnZSA9 IHN0cm9uZ1NlbGYtPl9wb3NpdGlvbkluZm9ybWF0aW9uLmltYWdlLT5tYWtlQ0dJbWFnZUNvcHko KTsKKworICAgICAgICAgICAgc3Ryb25nU2VsZi0+X2NvbnRleHRNZW51QWN0aW9uUHJvdmlkZXJE ZWxlZ2F0ZU5lZWRzT3ZlcnJpZGUgPSBOTzsKKworICAgICAgICAgICAgYXV0byBlbGVtZW50SW5m byA9IGFkb3B0TlMoW1tfV0tBY3RpdmF0ZWRFbGVtZW50SW5mbyBhbGxvY10gX2luaXRXaXRoSW50 ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb246c3Ryb25nU2VsZi0+X3Bvc2l0aW9uSW5mb3Jt YXRpb25dKTsKKworICAgICAgICAgICAgVUlDb250ZXh0TWVudUFjdGlvblByb3ZpZGVyIGFjdGlv bk1lbnVQcm92aWRlciA9IFt3ZWFrU2VsZiA9IHdlYWtTZWxmLCBlbGVtZW50SW5mbyA9IGVsZW1l bnRJbmZvXSAoTlNBcnJheTxVSU1lbnVFbGVtZW50ICo+ICopIC0+IFVJTWVudSAqIHsKKyAgICAg ICAgICAgICAgICBhdXRvIHN0cm9uZ1NlbGYgPSB3ZWFrU2VsZi5nZXQoKTsKKyAgICAgICAgICAg ICAgICBpZiAoIXN0cm9uZ1NlbGYpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBuaWw7CisK KyAgICAgICAgICAgICAgICBSZXRhaW5QdHI8TlNBcnJheTxfV0tFbGVtZW50QWN0aW9uICo+PiBk ZWZhdWx0QWN0aW9uc0Zyb21Bc3Npc3RhbnQgPSBbc3Ryb25nU2VsZi0+X2FjdGlvblNoZWV0QXNz aXN0YW50IGRlZmF1bHRBY3Rpb25zRm9ySW1hZ2VTaGVldDplbGVtZW50SW5mby5nZXQoKV07Cisg ICAgICAgICAgICAgICAgYXV0byBhY3Rpb25zID0gbWVudUVsZW1lbnRzRnJvbURlZmF1bHRBY3Rp b25zKGRlZmF1bHRBY3Rpb25zRnJvbUFzc2lzdGFudCwgZWxlbWVudEluZm8pOworICAgICAgICAg ICAgICAgIHJldHVybiBbVUlNZW51IG1lbnVXaXRoVGl0bGU6QCIiIGNoaWxkcmVuOmFjdGlvbnNd OworICAgICAgICAgICAgfTsKKworICAgICAgICAgICAgVUlDb250ZXh0TWVudUNvbnRlbnRQcmV2 aWV3UHJvdmlkZXIgY29udGVudFByZXZpZXdQcm92aWRlciA9IFt3ZWFrU2VsZiA9IHdlYWtTZWxm LCBjZ0ltYWdlID0gY2dJbWFnZSwgZWxlbWVudEluZm8gPSBlbGVtZW50SW5mb10gKCkgLT4gVUlW aWV3Q29udHJvbGxlciAqIHsKKyAgICAgICAgICAgICAgICBhdXRvIHN0cm9uZ1NlbGYgPSB3ZWFr U2VsZi5nZXQoKTsKKyAgICAgICAgICAgICAgICBpZiAoIXN0cm9uZ1NlbGYpCisgICAgICAgICAg ICAgICAgICAgIHJldHVybiBuaWw7CisKKyAgICAgICAgICAgICAgICByZXR1cm4gW1tXS0ltYWdl UHJldmlld1ZpZXdDb250cm9sbGVyIGFsbG9jXSBpbml0V2l0aENHSW1hZ2U6Y2dJbWFnZSBkZWZh dWx0QWN0aW9uczpuaWwgZWxlbWVudEluZm86ZWxlbWVudEluZm8uZ2V0KCldOworICAgICAgICAg ICAgfTsKKworICAgICAgICAgICAgcmV0dXJuIGNvbnRpbnVlV2l0aENvbnRleHRNZW51Q29uZmln dXJhdGlvbihbVUlDb250ZXh0TWVudUNvbmZpZ3VyYXRpb24gY29uZmlndXJhdGlvbldpdGhJZGVu dGlmaWVyOm5pbCBwcmV2aWV3UHJvdmlkZXI6Y29udGVudFByZXZpZXdQcm92aWRlciBhY3Rpb25Q cm92aWRlcjphY3Rpb25NZW51UHJvdmlkZXJdKTsKKyAgICAgICAgfQorCiAgICAgICAgIC8vIEF0 IHRoaXMgcG9pbnQgd2UgaGF2ZSBhbiBvYmplY3Qgd2UgbWlnaHQgd2FudCB0byBzaG93IGEgY29u dGV4dCBtZW51IGZvciwgYnV0IHRoZQogICAgICAgICAvLyBjbGllbnQgd2FzIHVuYWJsZSB0byBo YW5kbGUgaXQuIEJlZm9yZSBnaXZpbmcgdXAsIHdlIGFzayBEYXRhRGV0ZWN0b3JzLgogCg==