20023 2008-07-12 14:36:00 -0700 Failed assertion in PropertyNameArray.cpp 2008-07-16 01:21:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 1 david.hansen ap oldest_to_newest 85852 0 david.hansen 2008-07-12 14:36:00 -0700 Just run this little test: ASSERTION FAILED: identifier == &UString::Rep::null || identifier == &UString::Rep::empty || identifier->identifierTable (JavaScriptCore/kjs/PropertyNameArray.cpp:30 void KJS::PropertyNameArray::add(KJS::UString::Rep*)) #include <stdlib.h> #include <stdbool.h> #include <JavaScriptCore/JavaScript.h> static bool has_prop (JSContextRef jsCtx, JSObjectRef jsObj, JSStringRef jsName) { if (JSStringIsEqualToUTF8CString (jsName, "fourtyTwo")) return true; return false; } static JSValueRef get_prop (JSContextRef jsCtx, JSObjectRef jsObj, JSStringRef jsName, JSValueRef *jsExn) { return JSValueMakeNumber (jsCtx, 42.0); } static void get_prop_names (JSContextRef jsCtx, JSObjectRef jsObj, JSPropertyNameAccumulatorRef jsNames) { JSStringRef jsStr = JSStringCreateWithUTF8CString ("fourtyTwo"); JSPropertyNameAccumulatorAddName (jsNames, jsStr); JSStringRelease (jsStr); } int main (void) { JSClassDefinition cdef = kJSClassDefinitionEmpty; JSClassRef jsClass; JSGlobalContextRef jsCtx; JSStringRef jsScript; jsScript = JSStringCreateWithUTF8CString ("var a = [];" "for (i in this) { a.push[i]; }"); cdef.className = "Foo"; cdef.hasProperty = has_prop; cdef.getProperty = get_prop; cdef.getPropertyNames = get_prop_names; jsClass = JSClassCreate (&cdef); jsCtx = JSGlobalContextCreate (jsClass); /* Boom! */ JSEvaluateScript (jsCtx, jsScript, NULL, NULL, 0, NULL); return EXIT_SUCCESS; } /* Local Variables: compile-command: "gcc -g -ggdb -O0 -W -Wall \ `pkg-config --cflags --libs webkit-1.0` \ jsaccum.c -o jsaccum" End: */ 85970 1 22290 ap 2008-07-15 14:46:43 -0700 Created attachment 22290 proposed fix /me mutters something about the benefits of type safety 85979 2 22290 ggaren 2008-07-15 15:29:09 -0700 Comment on attachment 22290 proposed fix To unit test this, you can add some of the code above to testapi.c. 86011 3 ap 2008-07-16 01:21:43 -0700 Committed revision 35196. Turns out that testapi already exercised this code path - it's just that no one ran it in a while. 22290 2008-07-15 14:46:43 -0700 2008-07-15 15:29:09 -0700 proposed fix 20023r1_patch.txt text/plain 1146 ap SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM1MTg1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDctMTUgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDAyMworICAgICAgICBGYWlsZWQgYXNzZXJ0aW9uIGluIFByb3BlcnR5TmFtZUFycmF5 LmNwcAorCisgICAgICAgICogQVBJL0pTT2JqZWN0UmVmLmNwcDogKEpTUHJvcGVydHlOYW1lQWNj dW11bGF0b3JBZGROYW1lKTogQWRkIHRoZSBzdHJpbmcgdG8gaWRlbnRpZmllcgorICAgICAgICB0 YWJsZSB0byBhcHBlYWFzZSBQcm9wZXJ0eU5hbWVBcnJheS4KKwogMjAwOC0wNy0xNSAgS2V2aW4g TWNDdWxsb3VnaCAgPGttY2N1bGxvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBHZW9mZi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL0FQSS9KU09iamVjdFJlZi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQVBJL0pTT2JqZWN0UmVmLmNwcAkocmV2aXNpb24gMzUx NzkpCisrKyBKYXZhU2NyaXB0Q29yZS9BUEkvSlNPYmplY3RSZWYuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00MDQsNSArNDA0LDUgQEAgdm9pZCBKU1Byb3BlcnR5TmFtZUFjY3VtdWxhdG9yQWRkTmFt ZShKUwogICAgIHByb3BlcnR5TmFtZXMtPmdsb2JhbERhdGEoKS0+aGVhcC0+cmVnaXN0ZXJUaHJl YWQoKTsKICAgICBKU0xvY2sgbG9jayhwcm9wZXJ0eU5hbWVzLT5nbG9iYWxEYXRhKCktPmlzU2hh cmVkSW5zdGFuY2UpOwogCi0gICAgcHJvcGVydHlOYW1lcy0+YWRkKHJlcCk7CisgICAgcHJvcGVy dHlOYW1lcy0+YWRkKElkZW50aWZpZXIocHJvcGVydHlOYW1lcy0+Z2xvYmFsRGF0YSgpLCByZXAp KTsKIH0K