200218 2019-07-29 00:00:40 -0700 [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window 2019-07-29 18:48:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham don.olmstead pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1556503 0 fujii 2019-07-29 00:00:40 -0700 [Win][MiniBrowser][WK2] Automatically supplement "file://" or "http://" for an input URL as well as WK1 browser window * Move the logic from WebKitLegacyBrowserWindow::loadURL to MainWindow::loadURL 1556504 1 375066 fujii 2019-07-29 00:02:52 -0700 Created attachment 375066 Patch 1556609 2 375066 bfulgham 2019-07-29 10:42:04 -0700 Comment on attachment 375066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375066&action=review > Tools/MiniBrowser/win/MainWindow.cpp:442 > + url = L"http://" + url; http, or https? :-) 1556612 3 375066 achristensen 2019-07-29 10:51:42 -0700 Comment on attachment 375066 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375066&action=review >> Tools/MiniBrowser/win/MainWindow.cpp:442 >> + url = L"http://" + url; > > http, or https? :-) You could be the first browser to default to https if you want. If people want the plaintext page, they can type in the protocol themselves. 1556857 4 fujii 2019-07-29 18:36:24 -0700 Somewhat too early. After Mac port MiniBrowser will change, I'll change Windows port MiniBrowser. 1556863 5 fujii 2019-07-29 18:48:00 -0700 Committed r247935: <https://trac.webkit.org/changeset/247935> 1556864 6 webkit-bug-importer 2019-07-29 18:48:18 -0700 <rdar://problem/53690116> 375066 2019-07-29 00:02:52 -0700 2019-07-29 10:39:04 -0700 Patch bug-200218-20190729160250.patch text/plain 4302 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3ODk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGFkZDFiODYwMzg1YTllNTI2ZTJmMGIzYTk2MGFkOTAz MjQ5YTMyOC4uNDZmNWM1M2UyMTNmZWQ1NzZmNDAxMjc3NjBhZjk2NDM1OWJlNDY0MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE5LTA3LTI5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dW01pbmlCcm93c2VyXVtXSzJdIEF1dG9tYXRpY2FsbHkgc3VwcGxl bWVudCAiZmlsZTovLyIgb3IgImh0dHA6Ly8iIGZvciBhbiBpbnB1dCBVUkwgYXMgd2VsbCBhcyBX SzEgYnJvd3NlciB3aW5kb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMDIxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1vdmUgdGhlIHNjaGVtZSBzdXBwbGVtZW50aW5nIGxvZ2ljIGZyb20KKyAgICAg ICAgV2ViS2l0TGVnYWN5QnJvd3NlcldpbmRvdzo6bG9hZFVSTCB0byBNYWluV2luZG93Ojpsb2Fk VVJMLgorCisgICAgICAgICogTWluaUJyb3dzZXIvd2luL01haW5XaW5kb3cuY3BwOgorICAgICAg ICAoTWFpbldpbmRvdzo6bG9hZFVSTCk6CisgICAgICAgIChNYWluV2luZG93OjpvblVSTEJhckVu dGVyKToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci93aW4vTWFpbldpbmRvdy5oOgorICAgICAgICAq IE1pbmlCcm93c2VyL3dpbi9XZWJLaXRMZWdhY3lCcm93c2VyV2luZG93LmNwcDoKKyAgICAgICAg KFdlYktpdExlZ2FjeUJyb3dzZXJXaW5kb3c6OmxvYWRVUkwpOgorCiAyMDE5LTA3LTI4ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlb3JnYW5pemUg VUlTY3JpcHRDb250cm9sbGVyIGludG8gcGxhdGZvcm0tc3BlY2lmaWMgc3ViY2xhc3NlcwpkaWZm IC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL01haW5XaW5kb3cuY3BwIGIvVG9vbHMvTWlu aUJyb3dzZXIvd2luL01haW5XaW5kb3cuY3BwCmluZGV4IDNmN2Q3NGMwNjYwODU2MGU3NTE5MzA2 ZThlMGMxZWYyODRlYTY1Y2UuLjdkNGMxZjZhODk1M2Y5Yzc4M2FmY2YzZTBiMWZmODE3ZWQyMDFl MzIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9NYWluV2luZG93LmNwcAorKysg Yi9Ub29scy9NaW5pQnJvd3Nlci93aW4vTWFpbldpbmRvdy5jcHAKQEAgLTQyOSw5ICs0MjksMTkg QEAgSU5UX1BUUiBDQUxMQkFDSyBNYWluV2luZG93OjpjdXN0b21Vc2VyQWdlbnREaWFsb2dQcm9j KEhXTkQgaERsZywgVUlOVCBtZXNzYWdlLAogICAgIHJldHVybiAoSU5UX1BUUilGQUxTRTsKIH0K IAotdm9pZCBNYWluV2luZG93Ojpsb2FkVVJMKEJTVFIgdXJsKQordm9pZCBNYWluV2luZG93Ojps b2FkVVJMKHN0ZDo6d3N0cmluZyB1cmwpCiB7Ci0gICAgaWYgKEZBSUxFRChtX2Jyb3dzZXJXaW5k b3ctPmxvYWRVUkwodXJsKSkpCisgICAgaWYgKDo6UGF0aEZpbGVFeGlzdHModXJsLmNfc3RyKCkp IHx8IDo6UGF0aElzVU5DKHVybC5jX3N0cigpKSkgeworICAgICAgICB3Y2hhcl90IGZpbGVVUkxb SU5URVJORVRfTUFYX1VSTF9MRU5HVEhdOworICAgICAgICBEV09SRCBmaWxlVVJMTGVuZ3RoID0g X2NvdW50b2YoZmlsZVVSTCk7CisKKyAgICAgICAgaWYgKFNVQ0NFRURFRCg6OlVybENyZWF0ZUZy b21QYXRoKHVybC5jX3N0cigpLCBmaWxlVVJMLCAmZmlsZVVSTExlbmd0aCwgMCkpKQorICAgICAg ICAgICAgdXJsID0gZmlsZVVSTDsKKyAgICB9CisgICAgaWYgKHVybC5maW5kKEwiOi8vIikgPT0g dXJsLm5wb3MpCisgICAgICAgIHVybCA9IEwiaHR0cDovLyIgKyB1cmw7CisKKyAgICBpZiAoRkFJ TEVEKG1fYnJvd3NlcldpbmRvdy0+bG9hZFVSTChfYnN0cl90KHVybC5jX3N0cigpKSkpKQogICAg ICAgICByZXR1cm47CiAKICAgICBTZXRGb2N1cyhtX2Jyb3dzZXJXaW5kb3ctPmh3bmQoKSk7CkBA IC00NDIsOCArNDUyLDcgQEAgdm9pZCBNYWluV2luZG93OjpvblVSTEJhckVudGVyKCkKICAgICB3 Y2hhcl90IHN0clB0cltJTlRFUk5FVF9NQVhfVVJMX0xFTkdUSF07CiAgICAgR2V0V2luZG93VGV4 dChtX2hVUkxCYXJXbmQsIHN0clB0ciwgSU5URVJORVRfTUFYX1VSTF9MRU5HVEgpOwogICAgIHN0 clB0cltJTlRFUk5FVF9NQVhfVVJMX0xFTkdUSCAtIDFdID0gMDsKLSAgICBfYnN0cl90IGJzdHIo c3RyUHRyKTsKLSAgICBsb2FkVVJMKGJzdHIuR2V0QlNUUigpKTsKKyAgICBsb2FkVVJMKHN0clB0 cik7CiB9CiAKIHZvaWQgTWFpbldpbmRvdzo6dXBkYXRlRGV2aWNlU2NhbGVGYWN0b3IoKQpkaWZm IC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL01haW5XaW5kb3cuaCBiL1Rvb2xzL01pbmlC cm93c2VyL3dpbi9NYWluV2luZG93LmgKaW5kZXggYzU3MjA3NmE2OGM2YmJjYTRlNTE1ZTkyMzM4 YjhlZmI4OWZkMzEyMS4uZjZkZDhmNTk0OGE0ZTU2Y2NkYjAxZTUwZTI4NzEwODFhZGM1YTUxMiAx MDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL01haW5XaW5kb3cuaAorKysgYi9Ub29s cy9NaW5pQnJvd3Nlci93aW4vTWFpbldpbmRvdy5oCkBAIC00NCw3ICs0NCw3IEBAIHB1YmxpYzoK ICAgICBIV05EIGh3bmQoKSBjb25zdCB7IHJldHVybiBtX2hNYWluV25kOyB9CiAgICAgQnJvd3Nl cldpbmRvdyogYnJvd3NlcldpbmRvdygpIGNvbnN0IHsgcmV0dXJuIG1fYnJvd3NlcldpbmRvdy5n ZXQoKTsgfQogCi0gICAgdm9pZCBsb2FkVVJMKEJTVFIgdXJsKTsKKyAgICB2b2lkIGxvYWRVUkwo c3RkOjp3c3RyaW5nKTsKICAgICAKIHByaXZhdGU6CiAgICAgc3RhdGljIExSRVNVTFQgQ0FMTEJB Q0sgV25kUHJvYyhIV05ELCBVSU5ULCBXUEFSQU0sIExQQVJBTSk7CmRpZmYgLS1naXQgYS9Ub29s cy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0TGVnYWN5QnJvd3NlcldpbmRvdy5jcHAgYi9Ub29scy9N aW5pQnJvd3Nlci93aW4vV2ViS2l0TGVnYWN5QnJvd3NlcldpbmRvdy5jcHAKaW5kZXggNTE2YTc4 NWVhOTExZDE5N2M3MWQ5YWZmMDlkNmVmYThhZTQ2MWQ3Yy4uZjBjZDQ0ZTM4MTk5MTEyY2M4NWEz NjE5MmEyZWViZTJjZDY0ZWQzMSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL1dl YktpdExlZ2FjeUJyb3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9X ZWJLaXRMZWdhY3lCcm93c2VyV2luZG93LmNwcApAQCAtNDc0LDE1ICs0NzQsNiBAQCBIUkVTVUxU IFdlYktpdExlZ2FjeUJyb3dzZXJXaW5kb3c6OmxvYWRVUkwoY29uc3QgQlNUUiYgcGFzc2VkVVJM KQogICAgIGlmICghcGFzc2VkVVJMKQogICAgICAgICByZXR1cm4gRV9JTlZBTElEQVJHOwogCi0g ICAgX2JzdHJfdCB1cmxCU3RyKHBhc3NlZFVSTCk7Ci0gICAgaWYgKCEhdXJsQlN0ciAmJiAoOjpQ YXRoRmlsZUV4aXN0cyh1cmxCU3RyKSB8fCA6OlBhdGhJc1VOQyh1cmxCU3RyKSkpIHsKLSAgICAg ICAgVENIQVIgZmlsZVVSTFtJTlRFUk5FVF9NQVhfVVJMX0xFTkdUSF07Ci0gICAgICAgIERXT1JE IGZpbGVVUkxMZW5ndGggPSBzaXplb2YoZmlsZVVSTCkgLyBzaXplb2YoZmlsZVVSTFswXSk7Ci0K LSAgICAgICAgaWYgKFNVQ0NFRURFRCg6OlVybENyZWF0ZUZyb21QYXRoKHVybEJTdHIsIGZpbGVV UkwsICZmaWxlVVJMTGVuZ3RoLCAwKSkpCi0gICAgICAgICAgICB1cmxCU3RyID0gZmlsZVVSTDsK LSAgICB9Ci0KICAgICBJV2ViRnJhbWVQdHIgZnJhbWU7CiAgICAgSFJFU1VMVCBociA9IG1fd2Vi Vmlldy0+bWFpbkZyYW1lKCZmcmFtZS5HZXRJbnRlcmZhY2VQdHIoKSk7CiAgICAgaWYgKEZBSUxF RChocikpCkBAIC00OTMsNyArNDg0LDcgQEAgSFJFU1VMVCBXZWJLaXRMZWdhY3lCcm93c2VyV2lu ZG93Ojpsb2FkVVJMKGNvbnN0IEJTVFImIHBhc3NlZFVSTCkKICAgICBpZiAoRkFJTEVEKGhyKSkK ICAgICAgICAgcmV0dXJuIGhyOwogCi0gICAgaHIgPSByZXF1ZXN0LT5pbml0V2l0aFVSTCh3Y3Nz dHIoc3RhdGljX2Nhc3Q8d2NoYXJfdCo+KHVybEJTdHIpLCBMIjovLyIpID8gdXJsQlN0ciA6IF9i c3RyX3QoTCJodHRwOi8vIikgKyB1cmxCU3RyLCBXZWJVUkxSZXF1ZXN0VXNlUHJvdG9jb2xDYWNo ZVBvbGljeSwgNjApOworICAgIGhyID0gcmVxdWVzdC0+aW5pdFdpdGhVUkwocGFzc2VkVVJMLCBX ZWJVUkxSZXF1ZXN0VXNlUHJvdG9jb2xDYWNoZVBvbGljeSwgNjApOwogICAgIGlmIChGQUlMRUQo aHIpKQogICAgICAgICByZXR1cm4gaHI7CiAK