200201 2019-07-27 18:56:01 -0700 Fix static analyzer build 2019-07-28 14:29:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap aakash_jain aestes andersca commit-queue ddkilzer jbedard krollin webkit-bug-importer oldest_to_newest 1556412 0 ap 2019-07-27 18:56:01 -0700 We don't have a makefile target for analyze in ThirdParty, so the build stops there. This broke in April with r244726, when Source/Makefile started to include Source/ThirdParty/Makefile. 1556413 1 375037 ap 2019-07-27 18:58:17 -0700 Created attachment 375037 proposed fix 1556434 2 375037 commit-queue 2019-07-28 14:28:31 -0700 Comment on attachment 375037 proposed fix Clearing flags on attachment: 375037 Committed r247895: <https://trac.webkit.org/changeset/247895> 1556435 3 commit-queue 2019-07-28 14:28:32 -0700 All reviewed patches have been landed. Closing bug. 1556436 4 webkit-bug-importer 2019-07-28 14:29:17 -0700 <rdar://problem/53641031> 375037 2019-07-27 18:58:17 -0700 2019-07-28 14:28:31 -0700 proposed fix FixStaticAnalyzer.txt text/plain 1328 ap SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv VGhpcmRQYXJ0eS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0Nzg5MykKKysrIFNvdXJjZS9UaGlyZFBh cnR5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA3LTI3 ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBzdGF0 aWMgYW5hbHl6ZXIgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwMDIwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogTWFrZWZpbGU6IEFkZCBhbiBhbmFseXplIHRhcmdldCwgYXMgdGhpcyBtYWtl ZmlsZSBpcyBub3cgdXNlZCBmb3IgZnVsbCBidWlsZHMsCisgICAgICAgIGluY2x1ZGluZyBzdGF0 aWMgYW5hbHl6ZXIgb25lcy4KKwogMjAxOS0wNC0yOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDI5OTM5Nj4g Rml4IGludGVybmFsIEhpZ2ggU2llcnJhIGJ1aWxkCkluZGV4OiBTb3VyY2UvVGhpcmRQYXJ0eS9N YWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvVGhpcmRQYXJ0eS9NYWtlZmlsZQkocmV2aXNp b24gMjQ3ODY1KQorKysgU291cmNlL1RoaXJkUGFydHkvTWFrZWZpbGUJKHdvcmtpbmcgY29weSkK QEAgLTM2LDYgKzM2LDEwIEBAIHJlbGVhc2UgciBkZXBsb3ltZW50IGRlcCBkZXBsb3k6CiAJQGZv ciBkaXIgaW4gJChNT0RVTEVTKTsgZG8gJHtNQUtFfSAkQCAtQyAkJGRpcjsgZXhpdF9zdGF0dXM9 JCQ/OyBcCiAJaWYgWyAkJGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4aXRfc3Rh dHVzOyBmaTsgZG9uZQogCithbmFseXplOgorCUBmb3IgZGlyIGluICQoTU9EVUxFUyk7IGRvICR7 TUFLRX0gJEAgLUMgJCRkaXI7IGV4aXRfc3RhdHVzPSQkPzsgXAorCWlmIFsgJCRleGl0X3N0YXR1 cyAtbmUgMCBdOyB0aGVuIGV4aXQgJCRleGl0X3N0YXR1czsgZmk7IGRvbmUKKwogY2xlYW46CiAJ QGZvciBkaXIgaW4gJChNT0RVTEVTKTsgZG8gJHtNQUtFfSAkQCAtQyAkJGRpcjsgZXhpdF9zdGF0 dXM9JCQ/OyBcCiAJaWYgWyAkJGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4aXRf c3RhdHVzOyBmaTsgZG9uZQo=