200186 2019-07-26 18:03:47 -0700 Force Reveal to always lookup from menu 2019-07-29 12:21:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner commit-queue thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1556313 0 megan_gardner 2019-07-26 18:03:47 -0700 Force Reveal to always lookup from menu 1556314 1 375007 megan_gardner 2019-07-26 18:05:50 -0700 Created attachment 375007 Patch 1556629 2 thorton 2019-07-29 11:34:33 -0700 plz fix all the typos and grammaros 1556634 3 375087 megan_gardner 2019-07-29 11:41:20 -0700 Created attachment 375087 Patch 1556641 4 375087 thorton 2019-07-29 11:59:05 -0700 Comment on attachment 375087 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375087&action=review > Source/WebCore/ChangeLog:11 > + Reveal is not currenlty testable. 😲 1556642 5 375088 megan_gardner 2019-07-29 12:00:53 -0700 Created attachment 375088 Patch 1556649 6 375088 commit-queue 2019-07-29 12:20:23 -0700 Comment on attachment 375088 Patch Clearing flags on attachment: 375088 Committed r247915: <https://trac.webkit.org/changeset/247915> 1556650 7 commit-queue 2019-07-29 12:20:25 -0700 All reviewed patches have been landed. Closing bug. 1556651 8 webkit-bug-importer 2019-07-29 12:21:18 -0700 <rdar://problem/53673245> 375007 2019-07-26 18:05:50 -0700 2019-07-29 11:41:19 -0700 Patch bug-200186-20190726180550.patch text/plain 1755 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTY5MGYwMDkxZjIzNzkx MjMyMzY1NTVjYWU0YmE0OWVkYWEzMWViOS4uNWY2YmRhYTBmZDQxNTNlNzJkNjViOGFkMjYzMmNk MzQyMWRiNGExMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA3LTI2ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRm9yY2UgUmV2 ZWFsIHRvIGFsd2F5cyBsb29rdXAgZnJvbSBtZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAxODYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUy OTY3OTQwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlIGN1cnJlbnRseSBvbmx5IGhhdmUgdGhlICdsb29rdXAnIG1lbnUgaXRlbSwgc28gd2Ugc2hv dWxkIGFsd2FzeSB0byB0aGUgbG9va3VwIGFjdGlvbiBmcm9tIGl0LgorCisgICAgICAgIFJldmVh bCBpcyBub3QgY3VycmVubHR5IHRlc3RhYmxlLgorCisgICAgICAgICogZWRpdGluZy9jb2NvYS9E aWN0aW9uYXJ5TG9va3VwLm1tOgorICAgICAgICAoV2ViQ29yZTo6c2hvd1BvcHVwT3JDcmVhdGVB bmltYXRpb25Db250cm9sbGVyKToKKwogMjAxOS0wNy0yNiAgTWFyayBMYW0gIDxtYXJrLmxhbUBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIGNyYXNoIGRpYWdub3N0aWNzIGZvciBkZWJ1Z2dpbmcg dW5leHBlY3RlZCB6YXBwZWQgY2VsbHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL2NvY29hL0RpY3Rpb25hcnlMb29rdXAubW0gYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2Nv Y29hL0RpY3Rpb25hcnlMb29rdXAubW0KaW5kZXggY2I0OWY0NjM2OTQ2N2E0NWU2NzEzMjIyZWQ2 Njc0N2YxMjE1Yzk3MC4uYmUyMjUyOWNmNGUyNTEzMWEzZTNmYzBiN2EzYzgyZDBlNWViZTBjZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9EaWN0aW9uYXJ5TG9va3Vw Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGljdGlvbmFyeUxvb2t1cC5t bQpAQCAtNDkxLDcgKzQ5MSw3IEBAIHN0YXRpYyBXS1JldmVhbENvbnRyb2xsZXIgc2hvd1BvcHVw T3JDcmVhdGVBbmltYXRpb25Db250cm9sbGVyKGJvb2wgY3JlYXRlQW5pbWF0CiAgICAgCiAgICAg aWYgKGNyZWF0ZUFuaW1hdGlvbkNvbnRyb2xsZXIpCiAgICAgICAgIHJldHVybiBbcHJlc2VudGVy IGFuaW1hdGlvbkNvbnRyb2xsZXJGb3JJdGVtOml0ZW0uZ2V0KCkgZG9jdW1lbnRDb250ZXh0Om5p bCBwcmVzZW50aW5nQ29udGV4dDpjb250ZXh0LmdldCgpIG9wdGlvbnM6bmlsXTsKLSAgICBbcHJl c2VudGVyIHJldmVhbEl0ZW06aXRlbS5nZXQoKSBkb2N1bWVudENvbnRleHQ6bmlsIHByZXNlbnRp bmdDb250ZXh0OmNvbnRleHQuZ2V0KCkgb3B0aW9uczpuaWxdOworICAgIFtwcmVzZW50ZXIgcmV2 ZWFsSXRlbTppdGVtLmdldCgpIGRvY3VtZW50Q29udGV4dDpuaWwgcHJlc2VudGluZ0NvbnRleHQ6 Y29udGV4dC5nZXQoKSBvcHRpb25zOkB7IEAiZm9yY2VMb29rdXAiOiBAWUVTIH1dOwogICAgIHJl dHVybiBuaWw7CiAgICAgCiAjZWxpZiBQTEFURk9STShNQUNDQVRBTFlTVCkK 375087 2019-07-29 11:41:20 -0700 2019-07-29 12:00:52 -0700 Patch bug-200186-20190729114120.patch text/plain 1805 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE3OGQyNDE4YjVmYThj YjAzNDIxOTcyZGI5NDZlNTUzZWQ0MTRkZC4uODU0ODU5MmIwZjc5MTk2MmZjMzY5Njk2NzRiZWM3 ZGFiNWQwYjYwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA3LTI2ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRm9yY2UgUmV2 ZWFsIHRvIGFsd2F5cyBsb29rdXAgZnJvbSBtZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAxODYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUy OTY3OTQwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlIGN1cnJlbnRseSBvbmx5IGhhdmUgdGhlICdsb29rdXAnIG1lbnUgaXRlbSwgc28gd2Ugc2hv dWxkIGFsd2F5cyBmb3JjZSB0aGUgJ2xvb2t1cCcgYWN0aW9uIGZyb20gaXQuCisKKyAgICAgICAg UmV2ZWFsIGlzIG5vdCBjdXJyZW5sdHkgdGVzdGFibGUuCisKKyAgICAgICAgKiBlZGl0aW5nL2Nv Y29hL0RpY3Rpb25hcnlMb29rdXAubW06CisgICAgICAgIChXZWJDb3JlOjpzaG93UG9wdXBPckNy ZWF0ZUFuaW1hdGlvbkNvbnRyb2xsZXIpOgorCiAyMDE5LTA3LTI5ICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNDMwNTgpOiBb R1N0cmVhbWVyXSBXZWJLaXRXZWJTcmMncyBpbnRlcm5hbCBxdWV1ZSBjYW4gZXhoYXVzdCB0aGUg V2ViUHJvY2VzcyBtZW1vcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29j b2EvRGljdGlvbmFyeUxvb2t1cC5tbSBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGlj dGlvbmFyeUxvb2t1cC5tbQppbmRleCBjYjQ5ZjQ2MzY5NDY3YTQ1ZTY3MTMyMjJlZDY2NzQ3ZjEy MTVjOTcwLi5iZTIyNTI5Y2Y0ZTI1MTMxYTNlM2ZjMGI3YTNjODJkMGU1ZWJlMGNkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0RpY3Rpb25hcnlMb29rdXAubW0KKysr IGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9EaWN0aW9uYXJ5TG9va3VwLm1tCkBAIC00 OTEsNyArNDkxLDcgQEAgc3RhdGljIFdLUmV2ZWFsQ29udHJvbGxlciBzaG93UG9wdXBPckNyZWF0 ZUFuaW1hdGlvbkNvbnRyb2xsZXIoYm9vbCBjcmVhdGVBbmltYXQKICAgICAKICAgICBpZiAoY3Jl YXRlQW5pbWF0aW9uQ29udHJvbGxlcikKICAgICAgICAgcmV0dXJuIFtwcmVzZW50ZXIgYW5pbWF0 aW9uQ29udHJvbGxlckZvckl0ZW06aXRlbS5nZXQoKSBkb2N1bWVudENvbnRleHQ6bmlsIHByZXNl bnRpbmdDb250ZXh0OmNvbnRleHQuZ2V0KCkgb3B0aW9uczpuaWxdOwotICAgIFtwcmVzZW50ZXIg cmV2ZWFsSXRlbTppdGVtLmdldCgpIGRvY3VtZW50Q29udGV4dDpuaWwgcHJlc2VudGluZ0NvbnRl eHQ6Y29udGV4dC5nZXQoKSBvcHRpb25zOm5pbF07CisgICAgW3ByZXNlbnRlciByZXZlYWxJdGVt Oml0ZW0uZ2V0KCkgZG9jdW1lbnRDb250ZXh0Om5pbCBwcmVzZW50aW5nQ29udGV4dDpjb250ZXh0 LmdldCgpIG9wdGlvbnM6QHsgQCJmb3JjZUxvb2t1cCI6IEBZRVMgfV07CiAgICAgcmV0dXJuIG5p bDsKICAgICAKICNlbGlmIFBMQVRGT1JNKE1BQ0NBVEFMWVNUKQo= 375088 2019-07-29 12:00:53 -0700 2019-07-29 12:20:23 -0700 Patch bug-200186-20190729120053.patch text/plain 1805 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE3OGQyNDE4YjVmYThj YjAzNDIxOTcyZGI5NDZlNTUzZWQ0MTRkZC4uZjM3NzcxNzc0NjIwYTU2OTcxODc5N2M1NGY3ODhj ZGZlNTI0YmEyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA3LTI2ICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRm9yY2UgUmV2 ZWFsIHRvIGFsd2F5cyBsb29rdXAgZnJvbSBtZW51CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDAxODYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUy OTY3OTQwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlIGN1cnJlbnRseSBvbmx5IGhhdmUgdGhlICdsb29rdXAnIG1lbnUgaXRlbSwgc28gd2Ugc2hv dWxkIGFsd2F5cyBmb3JjZSB0aGUgJ2xvb2t1cCcgYWN0aW9uIGZyb20gaXQuCisKKyAgICAgICAg UmV2ZWFsIGlzIG5vdCBjdXJyZW50bHkgdGVzdGFibGUuCisKKyAgICAgICAgKiBlZGl0aW5nL2Nv Y29hL0RpY3Rpb25hcnlMb29rdXAubW06CisgICAgICAgIChXZWJDb3JlOjpzaG93UG9wdXBPckNy ZWF0ZUFuaW1hdGlvbkNvbnRyb2xsZXIpOgorCiAyMDE5LTA3LTI5ICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNDMwNTgpOiBb R1N0cmVhbWVyXSBXZWJLaXRXZWJTcmMncyBpbnRlcm5hbCBxdWV1ZSBjYW4gZXhoYXVzdCB0aGUg V2ViUHJvY2VzcyBtZW1vcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29j b2EvRGljdGlvbmFyeUxvb2t1cC5tbSBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvY29jb2EvRGlj dGlvbmFyeUxvb2t1cC5tbQppbmRleCBjYjQ5ZjQ2MzY5NDY3YTQ1ZTY3MTMyMjJlZDY2NzQ3ZjEy MTVjOTcwLi5iZTIyNTI5Y2Y0ZTI1MTMxYTNlM2ZjMGI3YTNjODJkMGU1ZWJlMGNkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0RpY3Rpb25hcnlMb29rdXAubW0KKysr IGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9EaWN0aW9uYXJ5TG9va3VwLm1tCkBAIC00 OTEsNyArNDkxLDcgQEAgc3RhdGljIFdLUmV2ZWFsQ29udHJvbGxlciBzaG93UG9wdXBPckNyZWF0 ZUFuaW1hdGlvbkNvbnRyb2xsZXIoYm9vbCBjcmVhdGVBbmltYXQKICAgICAKICAgICBpZiAoY3Jl YXRlQW5pbWF0aW9uQ29udHJvbGxlcikKICAgICAgICAgcmV0dXJuIFtwcmVzZW50ZXIgYW5pbWF0 aW9uQ29udHJvbGxlckZvckl0ZW06aXRlbS5nZXQoKSBkb2N1bWVudENvbnRleHQ6bmlsIHByZXNl bnRpbmdDb250ZXh0OmNvbnRleHQuZ2V0KCkgb3B0aW9uczpuaWxdOwotICAgIFtwcmVzZW50ZXIg cmV2ZWFsSXRlbTppdGVtLmdldCgpIGRvY3VtZW50Q29udGV4dDpuaWwgcHJlc2VudGluZ0NvbnRl eHQ6Y29udGV4dC5nZXQoKSBvcHRpb25zOm5pbF07CisgICAgW3ByZXNlbnRlciByZXZlYWxJdGVt Oml0ZW0uZ2V0KCkgZG9jdW1lbnRDb250ZXh0Om5pbCBwcmVzZW50aW5nQ29udGV4dDpjb250ZXh0 LmdldCgpIG9wdGlvbnM6QHsgQCJmb3JjZUxvb2t1cCI6IEBZRVMgfV07CiAgICAgcmV0dXJuIG5p bDsKICAgICAKICNlbGlmIFBMQVRGT1JNKE1BQ0NBVEFMWVNUKQo=