200177 2019-07-26 15:28:39 -0700 [Canvas Timeline] Compact canvas timeline 2019-07-29 07:41:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zhifei_fang webkit-unassigned commit-queue jbedard webkit-bug-importer zhifei_fang oldest_to_newest 1556252 0 zhifei_fang 2019-07-26 15:28:39 -0700 Make timeline dots' margin smaller, move the tag under the dot, so that we can have more room to display more dots at once. 1556253 1 374992 zhifei_fang 2019-07-26 15:30:45 -0700 Created attachment 374992 Patch 1556554 2 374992 commit-queue 2019-07-29 07:40:22 -0700 Comment on attachment 374992 Patch Clearing flags on attachment: 374992 Committed r247904: <https://trac.webkit.org/changeset/247904> 1556555 3 commit-queue 2019-07-29 07:40:23 -0700 All reviewed patches have been landed. Closing bug. 1556556 4 webkit-bug-importer 2019-07-29 07:41:18 -0700 <rdar://problem/53661495> 374992 2019-07-26 15:30:45 -0700 2019-07-29 07:40:22 -0700 Patch bug-200177-20190726153044.patch text/plain 6677 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3ODc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzE0NGZjMjgxODRiNDk1NmI3ZjdlNmE2ZGQ5NTVhNjI5 N2M0YTc4Zi4uZmMzOWQ5MGVkOGUzYTRlMzFjNjczYWJjOTM5OGU4NmI4ZWUwNmUwNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTA3LTI2ICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKwor ICAgICAgICBbQ2FudmFzIFRpbWVsaW5lXSBDb21wYWN0IGNhbnZhcyB0aW1lbGluZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMTc3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9y ZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2pzL2NvbXBvbmVudHMvQmFzZUNvbXBvbmVu dHMuanM6CisgICAgICAgICogcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGli cmFyeS9qcy9jb21wb25lbnRzL1RpbWVsaW5lQ29tcG9uZW50cy5qczoKKyAgICAgICAgKFRpbWVs aW5lLkNhbnZhc1Nlcmllc0NvbXBvbmVudCk6CisKIDIwMTktMDctMjYgIEpvbmF0aGFuIEJlZGFy ZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIHJlc3VsdHMud2Via2l0Lm9yZzogQWRk IHN3aXRjaCB0byBmaWx0ZXIgcmVzdWx0cyBieSBleHBlY3RhdGlvbgpkaWZmIC0tZ2l0IGEvVG9v bHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGlicmFyeS9qcy9jb21wb25l bnRzL0Jhc2VDb21wb25lbnRzLmpzIGIvVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmll dy9zdGF0aWMvbGlicmFyeS9qcy9jb21wb25lbnRzL0Jhc2VDb21wb25lbnRzLmpzCmluZGV4IGE2 MWYyYWU5YWQ4N2ZiMzk1NWM2OWY3MmNkNmNkNWE2MGVjZmQzN2YuLmE2OTQ4YjMxYTE3YjAyYjIx NmE0YzFjZDJmNDI5Njc4Yzk1OGI5NmQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3Jlc3VsdHNkYnB5L3Jl c3VsdHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvY29tcG9uZW50cy9CYXNlQ29tcG9uZW50 cy5qcworKysgYi9Ub29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJy YXJ5L2pzL2NvbXBvbmVudHMvQmFzZUNvbXBvbmVudHMuanMKQEAgLTIzLDcgKzIzLDcgQEAKIGlt cG9ydCB7CiAgICAgRE9NLCBSRUYsIGRpZmYsIEV2ZW50U3RyZWFtLCB1dWlkdjQKIH0KLWZyb20g Jy4uL2pzL1JlZi5qcyc7Citmcm9tICcuLi9SZWYuanMnOwogCiBmdW5jdGlvbiBBcHBseU5ld0No aWxkcmVuKGVsZW1lbnQsIG9sZEFycmF5LCBuZXdBcnJheSwgY2hpbGRUb0tleUZ1bmMsIGl0ZW1Q cm9jZXNzb3IpIHsKICAgICBjb25zdCBuZXdDaGlsZHJlbiA9IFtdOwpkaWZmIC0tZ2l0IGEvVG9v bHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGlicmFyeS9qcy9jb21wb25l bnRzL1RpbWVsaW5lQ29tcG9uZW50cy5qcyBiL1Rvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5 L3ZpZXcvc3RhdGljL2xpYnJhcnkvanMvY29tcG9uZW50cy9UaW1lbGluZUNvbXBvbmVudHMuanMK aW5kZXggZGEwMjE5ZTYxNmQ3NGJhOGU0OTdhZDM1ZmZlZTIxOGY3OTMxNjhkZS4uNGU0YjI0ODEy Yzg3Mjg3ODg2MzhkMTM2ZGU5MDgzYzVlZmJjYTcwZCAxMDA2NDQKLS0tIGEvVG9vbHMvcmVzdWx0 c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGlicmFyeS9qcy9jb21wb25lbnRzL1RpbWVs aW5lQ29tcG9uZW50cy5qcworKysgYi9Ub29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3 L3N0YXRpYy9saWJyYXJ5L2pzL2NvbXBvbmVudHMvVGltZWxpbmVDb21wb25lbnRzLmpzCkBAIC0y Myw3ICsyMyw3IEBACiBpbXBvcnQgewogICAgIERPTSwgUkVGLCBGUCwgRXZlbnRTdHJlYW0KIH0K LWZyb20gJy4uL2pzL1JlZi5qcyc7Citmcm9tICcuLi9SZWYuanMnOwogCiBpbXBvcnQge2lzRGFy a01vZGV9IGZyb20gJy4uL1V0aWxzLmpzJzsKIGltcG9ydCB7TGlzdENvbXBvbmVudCwgTGlzdFBy b3ZpZGVyLCBMaXN0UHJvdmlkZXJSZWNlaXZlcn0gZnJvbSAnLi9CYXNlQ29tcG9uZW50cy5qcycK QEAgLTE4NSwxMCArMTg1LDExIEBAIFRpbWVsaW5lLkNhbnZhc1Nlcmllc0NvbXBvbmVudCA9IChk b3RzLCBzY2FsZXMsIG9wdGlvbiA9IHt9KSA9PiB7CiAgICAgLy8gR2V0IHRoZSBjc3MgdmFsdWUs IHRoaXMgY29tcG9uZW50IGFzc3VtZSB0byB1c2Ugd2l0aCB3ZWJraXQuY3NzCiAgICAgY29uc3Qg Y29tcHV0ZWRTdHlsZSA9IGdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuYm9keSk7CiAgICAgbGV0 IHJhZGl1cyA9IHBhcnNlSW50KGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgnLS1zbWFs bFNpemUnKSkgLyAyOworICAgIGxldCBkb3RNYXJnaW4gPSBwYXJzZUludChjb21wdXRlZFN0eWxl LmdldFByb3BlcnR5VmFsdWUoJy0tdGlueVNpemUnKSkgLyAyOwogICAgIGxldCBmb250RmFtaWx5 ID0gY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdmb250LWZhbWlseScpOwogICAgIGxl dCBkZWZhdWx0RG90Q29sb3IgPSBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5VmFsdWUoJy0tZ3Jl ZW5MaWdodCcpLnRyaW0oKTsKICAgICBsZXQgZGVmYXVsdEVtcHR5TGluZUNvbG9yID0gY29tcHV0 ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCctLWdyZXknKS50cmltKCk7Ci0gICAgbGV0IGRlZmF1 bHRGb250U2l6ZSA9IGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgnLS10aW55U2l6ZScp OworICAgIGxldCBkZWZhdWx0Rm9udFNpemUgPSBwYXJzZUludChjb21wdXRlZFN0eWxlLmdldFBy b3BlcnR5VmFsdWUoJy0tdGlueVNpemUnKSk7CiAKICAgICAvLyBHZXQgY29uZmlndXJhdGlvbgog ICAgIC8vIERlZmF1bHQgb3JkZXIgaXMgbGVmdCBpcyBiaWdnZXN0CkBAIC0xOTcsNyArMTk4LDkg QEAgVGltZWxpbmUuQ2FudmFzU2VyaWVzQ29tcG9uZW50ID0gKGRvdHMsIHNjYWxlcywgb3B0aW9u ID0ge30pID0+IHsKICAgICBjb25zdCBjb21wID0gdHlwZW9mIG9wdGlvbi5jb21wYXJlRnVuYyA9 PT0gImZ1bmN0aW9uIiA/IG9wdGlvbi5jb21wYXJlRnVuYyA6IChhLCBiKSA9PiBhIC0gYjsKICAg ICBjb25zdCBvbkRvdENsaWNrID0gdHlwZW9mIG9wdGlvbi5vbkRvdENsaWNrID09PSAiZnVuY3Rp b24iID8gb3B0aW9uLm9uRG90Q2xpY2sgOiBudWxsOwogICAgIGNvbnN0IG9uRG90SG92ZXIgPSB0 eXBlb2Ygb3B0aW9uLm9uRG90SG92ZXIgPT09ICJmdW5jdGlvbiIgPyBvcHRpb24ub25Eb3RIb3Zl ciA6IG51bGw7Ci0gICAgY29uc3QgaGVpZ2h0ID0gb3B0aW9uLmhlaWdodCA/IG9wdGlvbi5oZWln aHQgOiAyICogcmFkaXVzOworICAgIGNvbnN0IHRhZ0hlaWdodCA9IGRlZmF1bHRGb250U2l6ZTsK KyAgICBjb25zdCBoZWlnaHQgPSBvcHRpb24uaGVpZ2h0ID8gb3B0aW9uLmhlaWdodCA6IDIgKiBy YWRpdXMgKyB0YWdIZWlnaHQ7CisKIAogICAgIC8vIERyYXcgZG90IGFwaSBjYW4gYmUgdXNlZCBp biB1c2VyIGRlZmluZWQgcmVuZGVyIGZ1bmN0aW9uCiAgICAgY29uc3QgZHJhd0RvdCA9IChjb250 ZXh0LCB4LCB5LCBpc0VtcHR5LCB0YWcgPSBudWxsLCB1c2VSYWRpdXMsIGNvbG9yLCBlbXB0eWxp bmVDb2xvcikgPT4gewpAQCAtMjA2LDE3ICsyMDksMTggQEAgVGltZWxpbmUuQ2FudmFzU2VyaWVz Q29tcG9uZW50ID0gKGRvdHMsIHNjYWxlcywgb3B0aW9uID0ge30pID0+IHsKICAgICAgICAgZW1w dHlsaW5lQ29sb3IgPSBlbXB0eWxpbmVDb2xvciA/IGVtcHR5bGluZUNvbG9yIDogZGVmYXVsdEVt cHR5TGluZUNvbG9yOwogICAgICAgICAgICAgaWYgKCFpc0VtcHR5KSB7CiAgICAgICAgICAgICAg ICAgLy9EcmF3IHRoZSBkb3QKLSAgICAgICAgICAgICAgICBjb250ZXh0LmFyYyh4ICsgMyAqIHJh ZGl1cywgeSwgcmFkaXVzLCAwLCAyICogTWF0aC5QSSk7CisgICAgICAgICAgICAgICAgY29udGV4 dC5hcmMoeCArIGRvdE1hcmdpbiArIHJhZGl1cywgeSwgcmFkaXVzLCAwLCAyICogTWF0aC5QSSk7 CiAgICAgICAgICAgICAgICAgY29udGV4dC5maWxsU3R5bGUgPSBjb2xvcjsKICAgICAgICAgICAg ICAgICBjb250ZXh0LmZpbGwoKTsKICAgICAgICAgICAgICAgICBpZiAodHlwZW9mIHRhZyA9PT0g Im51bWJlciIgfHwgdHlwZW9mIHRhZyA9PT0gInN0cmluZyIpIHsKICAgICAgICAgICAgICAgICAg ICAgY29udGV4dC5mb250ID0gYCR7Zm9udEZhbWlseX0gJHtkZWZhdWx0Rm9udFNpemV9cHhgOwot ICAgICAgICAgICAgICAgICAgICBjb250ZXh0LmZpbGxUZXh0KHRhZywgeCArIDQgKiByYWRpdXMs IHkgKyByYWRpdXMpOworICAgICAgICAgICAgICAgICAgICBjb25zdCB0YWdTaXplID0gY29udGV4 dC5tZWFzdXJlVGV4dCh0YWcpOworICAgICAgICAgICAgICAgICAgICBjb250ZXh0LmZpbGxUZXh0 KHRhZywgeCArIGRvdE1hcmdpbiArIHJhZGl1cyAtIHRhZ1NpemUud2lkdGggLyAyLCByYWRpdXMg KiAyICsgdGFnU2l6ZS5lbUhlaWdodEFzY2VudCk7CiAgICAgICAgICAgICAgICAgfQogICAgICAg ICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBjb250ZXh0LmJlZ2luUGF0aCgpOwotICAg ICAgICAgICAgICAgIGNvbnRleHQubW92ZVRvKHggKyAyICogcmFkaXVzLCB5KTsKLSAgICAgICAg ICAgICAgICBjb250ZXh0LmxpbmVUbyh4ICsgNCAqIHJhZGl1cywgeSk7CisgICAgICAgICAgICAg ICAgY29udGV4dC5tb3ZlVG8oeCArIGRvdE1hcmdpbiwgeSk7CisgICAgICAgICAgICAgICAgY29u dGV4dC5saW5lVG8oeCArIGRvdE1hcmdpbiArIDIgKiByYWRpdXMsIHkpOwogICAgICAgICAgICAg ICAgIGNvbnRleHQubGluZVdpZHRoID0gMTsKICAgICAgICAgICAgICAgICBjb250ZXh0LnN0cm9r ZVN0eWxlID0gZGVmYXVsdEVtcHR5TGluZUNvbG9yOwogICAgICAgICAgICAgICAgIGNvbnRleHQu c3Ryb2tlKCk7CkBAIC0yNDQsOSArMjQ4LDkgQEAgVGltZWxpbmUuQ2FudmFzU2VyaWVzQ29tcG9u ZW50ID0gKGRvdHMsIHNjYWxlcywgb3B0aW9uID0ge30pID0+IHsKICAgICAgICAgICAgIH0pKTsK ICAgICB9CiAKLSAgICBjb25zdCBkb3RXaWR0aCA9IDMgKiAyICogcmFkaXVzOworICAgIGNvbnN0 IGRvdFdpZHRoID0gMiAqIChyYWRpdXMgKyBkb3RNYXJnaW4pOwogICAgIGNvbnN0IHBhZGRpbmcg PSAxMDAgKiBkb3RXaWR0aCAvIGdldERldmljZVBpeGVsUmF0aW8oKTsKLSAgICBjb25zdCBvZmZz Y3JlZW5DYWNoZWRSZW5kZXIgPSBvZmZzY3JlZW5DYWNoZWRSZW5kZXJGYWN0b3J5KHBhZGRpbmcs IHJhZGl1cyAqIDIpOworICAgIGNvbnN0IG9mZnNjcmVlbkNhY2hlZFJlbmRlciA9IG9mZnNjcmVl bkNhY2hlZFJlbmRlckZhY3RvcnkocGFkZGluZywgaGVpZ2h0KTsKIAogICAgIC8vIEdlbmVyYXRl IHRoZSBkb3QgY2FjaGUKICAgICBjb25zdCByZWRyYXdDYWNoZSA9IChvZmZzY3JlZW5DYW52YXMs IGVsZW1lbnQsIHN0YXRlRGlmZiwgc3RhdGUsIG5vdGlmeVRvUmVuZGVyKSA9PiB7CkBAIC0zMzgs NyArMzQyLDcgQEAgVGltZWxpbmUuQ2FudmFzU2VyaWVzQ29tcG9uZW50ID0gKGRvdHMsIHNjYWxl cywgb3B0aW9uID0ge30pID0+IHsKICAgICAgICAgICAgIHdpZHRoOiAwLAogICAgICAgICB9LAog ICAgICAgICBvbkVsZW1lbnRNb3VudDogKGVsZW1lbnQpID0+IHsKLSAgICAgICAgICAgIHNldHVw Q2FudmFzSGVpZ2h0V2l0aERwcihlbGVtZW50LCByYWRpdXMgKiAyKTsKKyAgICAgICAgICAgIHNl dHVwQ2FudmFzSGVpZ2h0V2l0aERwcihlbGVtZW50LCBoZWlnaHQpOwogICAgICAgICAgICAgc2V0 dXBDYW52YXNDb250ZXh0U2NhbGUoZWxlbWVudCk7CiAgICAgICAgICAgICBpZiAob25Eb3RDbGlj aykgewogICAgICAgICAgICAgICAgIGVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcignY2xpY2snLCAo ZSkgPT4gewpAQCAtNDk5LDcgKzUwMyw3IEBAIFRpbWVsaW5lLkNhbnZhc1hBeGlzQ29tcG9uZW50 ID0gKHNjYWxlcywgb3B0aW9uID0ge30pID0+IHsKICAgICBjb25zdCBmb250Um90YXRlID0gNjAg KiBNYXRoLlBJIC8gMTgwOwogICAgIGNvbnN0IGZvbnRUb3BSb3RhdGUgPSAzMDAgKiBNYXRoLlBJ IC8gMTgwOwogICAgIGNvbnN0IGxpbmtDb2xvciA9IGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlW YWx1ZSgnLS1saW5rQ29sb3InKTsKLSAgICBjb25zdCBzY2FsZVdpZHRoID0gcGFyc2VJbnQoY29t cHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCctLXNtYWxsU2l6ZScpKSAqIDM7CisgICAgY29u c3Qgc2NhbGVXaWR0aCA9IHBhcnNlSW50KGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgn LS1zbWFsbFNpemUnKSkgKyBwYXJzZUludChjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5VmFsdWUo Jy0tdGlueVNpemUnKSk7CiAgICAgY29uc3Qgc2NhbGVUYWdMaW5lSGVpZ2h0ID0gcGFyc2VJbnQo Y29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCctLXNtYWxsU2l6ZScpKTsKICAgICBjb25z dCBzY2FsZVRhZ0xpbmVQYWRkaW5nID0gMTA7CiAgICAgY29uc3Qgc2NhbGVCcm9hZExpbmVIZWln aHQgPSBwYXJzZUludChjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5VmFsdWUoJy0tdGlueVNpemUn KSkgLyAyOwo=