200161 2019-07-26 03:41:53 -0700 WebSockets: workers never use the platform WebSockets path 2019-07-29 09:18:24 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 200162 1 cgarcia webkit-unassigned achristensen ap mcatanzaro webkit-bug-importer youennf oldest_to_newest 1556082 0 cgarcia 2019-07-26 03:41:53 -0700 A WebCore::WebSocketChannel is created unconditionally in WorkerThreadableWebSocketChannel::Peer. 1556084 1 374960 cgarcia 2019-07-26 03:44:34 -0700 Created attachment 374960 Patch 1556354 2 ap 2019-07-26 23:56:49 -0700 Related a couple bugs that this will hopefully fix. 1556529 3 cgarcia 2019-07-29 02:11:37 -0700 Committed r247902: <https://trac.webkit.org/changeset/247902> 1556531 4 webkit-bug-importer 2019-07-29 02:13:58 -0700 <rdar://problem/53653192> 1556540 5 mcatanzaro 2019-07-29 04:31:32 -0700 I don't think this is related to bug #199906 since that's a Safari bug report and Safari releases are not using the new CFNet WebSockets yet. This could only fix problems in the new codepath, not the old one. Also bug #193636 predates the new codepath by a lot. Thanks for looking for possibly-related bugs though! 1556577 6 ap 2019-07-29 09:18:24 -0700 The problem in bug 199906 is that WebSockets in service workers attempt to use in-process loading instead of Networking process. This patch doesn't fix that, but I think that the nature of the issue is similar enough for someone working on that to be aware of this too. 374960 2019-07-26 03:44:34 -0700 2019-07-26 09:07:31 -0700 Patch wk2-workers-websockets.diff text/plain 5133 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNTMxYmVlNzI2Zi4uMjhlZThkNDk3OGIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOS0wNy0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgV2ViU29ja2V0czogd29ya2VycyBuZXZlciB1c2UgdGhlIHBs YXRmb3JtIFdlYlNvY2tldHMgcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjAwMTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQSBXZWJDb3JlOjpXZWJTb2NrZXRDaGFubmVsIGlzIGNyZWF0ZWQgdW5j b25kaXRpb25hbGx5IGluIFdvcmtlclRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsOjpQZWVyLgor CisgICAgICAgICogTW9kdWxlcy93ZWJzb2NrZXRzL1RocmVhZGFibGVXZWJTb2NrZXRDaGFubmVs LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsOjpjcmVh dGUpOiBOZXcgY3JlYXRlIG1ldGhvZCB0aGF0IHJlY2VpdmVzIGEgRG9jdW1lbnQmIGFuZCBjcmVh dGVzIHRoZQorICAgICAgICBXZWJTb2NrZXQgY2hhbm5lbCBjaGVja2luZyB0aGUgcnVudGltZSBl bmFibGVkIGZlYXR1cmVzIHRvIGRlY2lkZS4KKyAgICAgICAgKiBNb2R1bGVzL3dlYnNvY2tldHMv VGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuaDoKKyAgICAgICAgKiBNb2R1bGVzL3dlYnNvY2tl dHMvV29ya2VyVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6V29ya2VyVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWw6OlBlZXI6OlBlZXIpOiBVc2UgVGhy ZWFkYWJsZVdlYlNvY2tldENoYW5uZWw6OmNyZWF0ZSgpLgorCiAyMDE5LTA3LTI2ICBSb2IgQnVp cyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgTWFrZSBzdG9yaW5nIGNyb3NzLW9yaWdp biB0b3AtbGV2ZWwgcHJlZmV0Y2hlcyBpbiBIVFRQIGNhY2hlIG9wdGlvbmFsCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENo YW5uZWwuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1RocmVhZGFibGVX ZWJTb2NrZXRDaGFubmVsLmNwcAppbmRleCA2ZTA0Y2Y0YjllNy4uYWM3MzYxYmFkMzYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9UaHJlYWRhYmxlV2ViU29j a2V0Q2hhbm5lbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1Ro cmVhZGFibGVXZWJTb2NrZXRDaGFubmVsLmNwcApAQCAtNDgsMTYgKzQ4LDggQEAKIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCi1SZWY8VGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWw+IFRocmVhZGFi bGVXZWJTb2NrZXRDaGFubmVsOjpjcmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgY29udGV4 dCwgV2ViU29ja2V0Q2hhbm5lbENsaWVudCYgY2xpZW50LCBTb2NrZXRQcm92aWRlciYgcHJvdmlk ZXIpCitSZWY8VGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWw+IFRocmVhZGFibGVXZWJTb2NrZXRD aGFubmVsOjpjcmVhdGUoRG9jdW1lbnQmIGRvY3VtZW50LCBXZWJTb2NrZXRDaGFubmVsQ2xpZW50 JiBjbGllbnQsIFNvY2tldFByb3ZpZGVyJiBwcm92aWRlcikKIHsKLSAgICBpZiAoaXM8V29ya2Vy R2xvYmFsU2NvcGU+KGNvbnRleHQpKSB7Ci0gICAgICAgIFdvcmtlckdsb2JhbFNjb3BlJiB3b3Jr ZXJHbG9iYWxTY29wZSA9IGRvd25jYXN0PFdvcmtlckdsb2JhbFNjb3BlPihjb250ZXh0KTsKLSAg ICAgICAgV29ya2VyUnVuTG9vcCYgcnVuTG9vcCA9IHdvcmtlckdsb2JhbFNjb3BlLnRocmVhZCgp LnJ1bkxvb3AoKTsKLSAgICAgICAgcmV0dXJuIFdvcmtlclRocmVhZGFibGVXZWJTb2NrZXRDaGFu bmVsOjpjcmVhdGUod29ya2VyR2xvYmFsU2NvcGUsIGNsaWVudCwgbWFrZVN0cmluZygid2ViU29j a2V0Q2hhbm5lbE1vZGUiLCBydW5Mb29wLmNyZWF0ZVVuaXF1ZUlkKCkpLCBwcm92aWRlcik7Ci0g ICAgfQotCi0gICAgYXV0byYgZG9jdW1lbnQgPSBkb3duY2FzdDxEb2N1bWVudD4oY29udGV4dCk7 Ci0KICAgICBib29sIHNob3VsZFByb3ZpZGVyQ3JlYXRlU29ja2V0Q2hhbm5lbCA9IGZhbHNlOwog I2lmIEhBVkUoTlNVUkxTRVNTSU9OX1dFQlNPQ0tFVCkKICAgICBzaG91bGRQcm92aWRlckNyZWF0 ZVNvY2tldENoYW5uZWwgPSBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygp LmlzTlNVUkxTZXNzaW9uV2ViU29ja2V0RW5hYmxlZCgpOwpAQCAtNzQsNiArNjYsMTcgQEAgUmVm PFRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsPiBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbDo6 Y3JlYXRlKFNjcmlwdEV4ZWN1dGkKICAgICByZXR1cm4gV2ViU29ja2V0Q2hhbm5lbDo6Y3JlYXRl KGRvY3VtZW50LCBjbGllbnQsIHByb3ZpZGVyKTsKIH0KIAorUmVmPFRocmVhZGFibGVXZWJTb2Nr ZXRDaGFubmVsPiBUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbDo6Y3JlYXRlKFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQmIGNvbnRleHQsIFdlYlNvY2tldENoYW5uZWxDbGllbnQmIGNsaWVudCwgU29j a2V0UHJvdmlkZXImIHByb3ZpZGVyKQoreworICAgIGlmIChpczxXb3JrZXJHbG9iYWxTY29wZT4o Y29udGV4dCkpIHsKKyAgICAgICAgV29ya2VyR2xvYmFsU2NvcGUmIHdvcmtlckdsb2JhbFNjb3Bl ID0gZG93bmNhc3Q8V29ya2VyR2xvYmFsU2NvcGU+KGNvbnRleHQpOworICAgICAgICBXb3JrZXJS dW5Mb29wJiBydW5Mb29wID0gd29ya2VyR2xvYmFsU2NvcGUudGhyZWFkKCkucnVuTG9vcCgpOwor ICAgICAgICByZXR1cm4gV29ya2VyVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWw6OmNyZWF0ZSh3 b3JrZXJHbG9iYWxTY29wZSwgY2xpZW50LCBtYWtlU3RyaW5nKCJ3ZWJTb2NrZXRDaGFubmVsTW9k ZSIsIHJ1bkxvb3AuY3JlYXRlVW5pcXVlSWQoKSksIHByb3ZpZGVyKTsKKyAgICB9CisKKyAgICBy ZXR1cm4gY3JlYXRlKGRvd25jYXN0PERvY3VtZW50Pihjb250ZXh0KSwgY2xpZW50LCBwcm92aWRl cik7Cit9CisKIE9wdGlvbmFsPFRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsOjpWYWxpZGF0ZWRV Ukw+IFRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsOjp2YWxpZGF0ZVVSTChEb2N1bWVudCYgZG9j dW1lbnQsIGNvbnN0IFVSTCYgcmVxdWVzdGVkVVJMKQogewogICAgIFZhbGlkYXRlZFVSTCB2YWxp ZGF0ZWRVUkwgeyByZXF1ZXN0ZWRVUkwsIHRydWUgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2Vic29ja2V0cy9UaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbC5oIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1RocmVhZGFibGVXZWJTb2NrZXRDaGFubmVs LmgKaW5kZXggOGU2NWY5NTJiOTUuLmZjMzcwMzViYjQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENo YW5uZWwuaApAQCAtNTAsNiArNTAsNyBAQCBjbGFzcyBXZWJTb2NrZXRDaGFubmVsQ2xpZW50Owog Y2xhc3MgVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwgewogICAgIFdURl9NQUtFX05PTkNPUFlB QkxFKFRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsKTsKIHB1YmxpYzoKKyAgICBzdGF0aWMgUmVm PFRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsPiBjcmVhdGUoRG9jdW1lbnQmLCBXZWJTb2NrZXRD aGFubmVsQ2xpZW50JiwgU29ja2V0UHJvdmlkZXImKTsKICAgICBzdGF0aWMgUmVmPFRocmVhZGFi bGVXZWJTb2NrZXRDaGFubmVsPiBjcmVhdGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYsIFdlYlNv Y2tldENoYW5uZWxDbGllbnQmLCBTb2NrZXRQcm92aWRlciYpOwogICAgIFRocmVhZGFibGVXZWJT b2NrZXRDaGFubmVsKCkgPSBkZWZhdWx0OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYnNvY2tldHMvV29ya2VyVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dvcmtlclRocmVhZGFibGVXZWJTb2Nr ZXRDaGFubmVsLmNwcAppbmRleCAxZGQzOWE5MjFkMC4uOWVjNGNhZjFjYTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy9Xb3JrZXJUaHJlYWRhYmxlV2ViU29j a2V0Q2hhbm5lbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2NrZXRzL1dv cmtlclRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsLmNwcApAQCAtMTQ0LDcgKzE0NCw3IEBAIHZv aWQgV29ya2VyVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWw6OnJlc3VtZSgpCiBXb3JrZXJUaHJl YWRhYmxlV2ViU29ja2V0Q2hhbm5lbDo6UGVlcjo6UGVlcihSZWY8VGhyZWFkYWJsZVdlYlNvY2tl dENoYW5uZWxDbGllbnRXcmFwcGVyPiYmIGNsaWVudFdyYXBwZXIsIFdvcmtlckxvYWRlclByb3h5 JiBsb2FkZXJQcm94eSwgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgY29udGV4dCwgY29uc3QgU3Ry aW5nJiB0YXNrTW9kZSwgU29ja2V0UHJvdmlkZXImIHByb3ZpZGVyKQogICAgIDogbV93b3JrZXJD bGllbnRXcmFwcGVyKFdURk1vdmUoY2xpZW50V3JhcHBlcikpCiAgICAgLCBtX2xvYWRlclByb3h5 KGxvYWRlclByb3h5KQotICAgICwgbV9tYWluV2ViU29ja2V0Q2hhbm5lbChXZWJTb2NrZXRDaGFu bmVsOjpjcmVhdGUoZG93bmNhc3Q8RG9jdW1lbnQ+KGNvbnRleHQpLCAqdGhpcywgcHJvdmlkZXIp KQorICAgICwgbV9tYWluV2ViU29ja2V0Q2hhbm5lbChUaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5l bDo6Y3JlYXRlKGRvd25jYXN0PERvY3VtZW50Pihjb250ZXh0KSwgKnRoaXMsIHByb3ZpZGVyKSkK ICAgICAsIG1fdGFza01vZGUodGFza01vZGUpCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgp KTsK