200145 2019-07-25 16:46:21 -0700 Subpixel fringes around TextIndicator snapshots at non-integral scale factors 2019-07-31 09:30:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue dino repstein ryanhaddad simon.fraser webkit-bug-importer zalan oldest_to_newest 1555962 0 thorton 2019-07-25 16:46:21 -0700 Subpixel fringes around TextIndicator snapshots at non-integral scale factors 1555963 1 374923 thorton 2019-07-25 16:46:30 -0700 Created attachment 374923 Patch 1555985 2 374923 commit-queue 2019-07-25 17:40:32 -0700 Comment on attachment 374923 Patch Clearing flags on attachment: 374923 Committed r247846: <https://trac.webkit.org/changeset/247846> 1555986 3 commit-queue 2019-07-25 17:40:33 -0700 All reviewed patches have been landed. Closing bug. 1555987 4 webkit-bug-importer 2019-07-25 17:41:20 -0700 <rdar://problem/53568050> 1557123 5 repstein 2019-07-30 16:32:08 -0700 It appears that this patch (r247846) broke the following API Test: TestWebKitAPI.DragAndDropTests.ModernWebArchiveType Error: ASSERTION FAILED: !data.contentImageWithHighlight || data.contentImageScaleFactor == snapshotScaleFactor ./page/TextIndicator.cpp(172) : bool WebCore::takeSnapshots(WebCore::TextIndicatorData &, WebCore::Frame &, WebCore::IntRect, const Vector<WebCore::FloatRect> &) 1 0x1833bdca9 WTFCrash 2 0x187f826fb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x18b0c192c WebCore::takeSnapshots(WebCore::TextIndicatorData&, WebCore::Frame&, WebCore::IntRect, WTF::Vector<WebCore::FloatRect, 0ul, WTF::CrashOnOverflow, 16ul> const&) 4 0x18b0bcd8d WebCore::initializeIndicator(WebCore::TextIndicatorData&, WebCore::Frame&, WebCore::Range const&, WebCore::FloatSize, bool) 5 0x18b0bc442 WebCore::TextIndicator::createWithRange(WebCore::Range const&, unsigned short, WebCore::TextIndicatorPresentationTransition, WebCore::FloatSize) 6 0x103c77e81 WebKit::WebPage::computeAndSendEditDragSnapshot() 7 0x103c779cf WebKit::WebPage::didConcludeEditDrag() 8 0x103bee809 WebKit::WebDragClient::didConcludeEditDrag() 9 0x18af7b424 WebCore::DragController::performDragOperation(WebCore::DragData const&) 10 0x104022aaa WebKit::WebPage::performDragControllerAction(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&) 11 0x1040f0538 void IPC::callMemberFunctionImpl<WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&), std::__1::tuple<WebKit::DragControllerAction, WebCore::DragData, WebKit::SandboxExtension::Handle, WebKit::SandboxExtension::HandleArray>, 0ul, 1ul, 2ul, 3ul>(WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&), std::__1::tuple<WebKit::DragControllerAction, WebCore::DragData, WebKit::SandboxExtension::Handle, WebKit::SandboxExtension::HandleArray>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) 12 0x1040ed730 void IPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&), std::__1::tuple<WebKit::DragControllerAction, WebCore::DragData, WebKit::SandboxExtension::Handle, WebKit::SandboxExtension::HandleArray>, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul> >(std::__1::tuple<WebKit::DragControllerAction, WebCore::DragData, WebKit::SandboxExtension::Handle, WebKit::SandboxExtension::HandleArray>&&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&)) 13 0x10408928b void IPC::handleMessage<Messages::WebPage::PerformDragControllerAction, WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&)>(IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::DragControllerAction, WebCore::DragData const&, WebKit::SandboxExtension::Handle&&, WebKit::SandboxExtension::HandleArray&&)) 14 0x10407950e WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&) 15 0x104025988 WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 16 0x102e9a7c9 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 17 0x103c0fa2d WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 18 0x102e2dcf9 IPC::Connection::dispatchMessage(IPC::Decoder&) 19 0x102e26a7b IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 20 0x102e2e803 IPC::Connection::dispatchOneIncomingMessage() 21 0x102e4cd9b IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_11::operator()() 22 0x102e4ccb9 WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_11, void>::call() 23 0x1833eaaea WTF::Function<void ()>::operator()() const 24 0x1834558e3 WTF::RunLoop::performWork() 25 0x183456cce WTF::RunLoop::performWork(void*) 26 0x10c742be1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 27 0x10c742463 __CFRunLoopDoSources0 28 0x10c73cb1f __CFRunLoopRun 29 0x10c73c302 CFRunLoopRunSpecific 30 0x102888044 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 31 0x1028881e4 -[NSRunLoop(NSRunLoop) run] ERROR: Failed to load accessibility bundle at /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Library/CoreSimulator/Profiles/Runtimes/iOS.simruntime/Contents/Resources/RuntimeRootSystem/Library/AccessibilityBundles/WebProcessLoader.axbundle: (null) /Volumes/Data/slave/ios-simulator-12-debug/build/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm(331) : void WebKit::registerWithAccessibility() TestWebKitAPI.DragAndDropTests.ModernWebArchiveType Timeout 1557290 6 ryanhaddad 2019-07-31 09:30:37 -0700 https://trac.webkit.org/changeset/248028/webkit was landed to address the test failure. 374923 2019-07-25 16:46:30 -0700 2019-07-25 17:40:32 -0700 Patch bug-200145-20190725164629.patch text/plain 3603 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3ODAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZmMTM3ZjYyNTljZjZm Y2M4ZWUxMzcxMjhkOThkZDc1MDU3MjU0Zi4uNTIwOGM1ZDY0MjQ3NjQ1NzM5YTM2ZGU1YTExYTAz NWY5OTQwZjhkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA3LTI1ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFN1YnBpeGVsIGZy aW5nZXMgYXJvdW5kIFRleHRJbmRpY2F0b3Igc25hcHNob3RzIGF0IG5vbi1pbnRlZ3JhbCBzY2Fs ZSBmYWN0b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDAxNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBhZ2UvRnJhbWVTbmFwc2hvdHRpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c25hcHNo b3RGcmFtZVJlY3RXaXRoQ2xpcCk6CisgICAgICAgICogcGFnZS9GcmFtZVNuYXBzaG90dGluZy5o OgorICAgICAgICAqIHBhZ2UvVGV4dEluZGljYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpz bmFwc2hvdE9wdGlvbnNGb3JUZXh0SW5kaWNhdG9yT3B0aW9ucyk6CisgICAgICAgIFJvdW5kIHRo ZSBzY2FsZSBmYWN0b3IgdXAsIGFuZCBzbmFwcGlseSBlbmNsb3NlIHRoZSBjbGlwIHJlY3RzLgor CisgICAgICAgIFRleHRJbmRpY2F0b3IgZG9lc24ndCByZXF1aXJlIHRoZSB1c2Ugb2YgdGhlIHBy ZWNpc2Ugc2NhbGUgZmFjdG9yIHRoYXQKKyAgICAgICAgdGhlIHBhZ2UgaXMgcGFpbnRlZCBhdCwg YnV0IHdlIHdhbnQgaXQgdG8gYmUgc2hhcnAsIHNvIHdlIG92ZXJzaG9vdCEKKwogMjAxOS0wNy0y NCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIE1l ZGlhUGxheWVyUHJpdmF0ZTo6c3VwcG9ydHNNdXRpbmcoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVNuYXBzaG90dGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lU25hcHNob3R0aW5nLmNwcAppbmRleCA3ODdiZDQ4ZGVhMzBlNjBkYzczMGU3YTFhYTk2Mzg2 NjQwZDI3Mjg0Li5lMjdjNDFhODQ0Y2M4ODI4MjI2MTVkYzUzNGRkMGY2YmQyYmFkYjkxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lU25hcHNob3R0aW5nLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lU25hcHNob3R0aW5nLmNwcApAQCAtMTA4LDYgKzEwOCw5 IEBAIHN0ZDo6dW5pcXVlX3B0cjxJbWFnZUJ1ZmZlcj4gc25hcHNob3RGcmFtZVJlY3RXaXRoQ2xp cChGcmFtZSYgZnJhbWUsIGNvbnN0IEludFJlCiAgICAgaWYgKGZyYW1lLnNldHRpbmdzKCkuZGVs ZWdhdGVzUGFnZVNjYWxpbmcoKSkKICAgICAgICAgc2NhbGVGYWN0b3IgKj0gZnJhbWUucGFnZSgp LT5wYWdlU2NhbGVGYWN0b3IoKTsKIAorICAgIGlmIChvcHRpb25zICYgU25hcHNob3RPcHRpb25z UGFpbnRXaXRoSW50ZWdyYWxTY2FsZUZhY3RvcikKKyAgICAgICAgc2NhbGVGYWN0b3IgPSBjZWls ZihzY2FsZUZhY3Rvcik7CisKICAgICBzdGQ6OnVuaXF1ZV9wdHI8SW1hZ2VCdWZmZXI+IGJ1ZmZl ciA9IEltYWdlQnVmZmVyOjpjcmVhdGUoaW1hZ2VSZWN0LnNpemUoKSwgVW5hY2NlbGVyYXRlZCwg c2NhbGVGYWN0b3IpOwogICAgIGlmICghYnVmZmVyKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsK QEAgLTExNiw3ICsxMTksNyBAQCBzdGQ6OnVuaXF1ZV9wdHI8SW1hZ2VCdWZmZXI+IHNuYXBzaG90 RnJhbWVSZWN0V2l0aENsaXAoRnJhbWUmIGZyYW1lLCBjb25zdCBJbnRSZQogICAgIGlmICghY2xp cFJlY3RzLmlzRW1wdHkoKSkgewogICAgICAgICBQYXRoIGNsaXBQYXRoOwogICAgICAgICBmb3Ig KGF1dG8mIHJlY3QgOiBjbGlwUmVjdHMpCi0gICAgICAgICAgICBjbGlwUGF0aC5hZGRSZWN0KHJl Y3QpOworICAgICAgICAgICAgY2xpcFBhdGguYWRkUmVjdChlbmNsb3NlUmVjdFRvRGV2aWNlUGl4 ZWxzKHJlY3QsIHNjYWxlRmFjdG9yKSk7CiAgICAgICAgIGJ1ZmZlci0+Y29udGV4dCgpLmNsaXBQ YXRoKGNsaXBQYXRoKTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVTbmFwc2hvdHRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVTbmFwc2hvdHRp bmcuaAppbmRleCBiZGJjN2VhOGVhMmU0NDFlYjdlMjU2YzBhMDRiMjk5NTkyZDg2ODY1Li4zNjAz YmNiMjY1Njc2NjkzODM2OGM2MGVhNjQ5Mjk4NWE4Y2UxMmY2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lU25hcHNob3R0aW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVNuYXBzaG90dGluZy5oCkBAIC00Nyw3ICs0Nyw4IEBAIGVudW0gewogICAgIFNuYXBz aG90T3B0aW9uc0luVmlld0Nvb3JkaW5hdGVzID0gMSA8PCAyLAogICAgIFNuYXBzaG90T3B0aW9u c0ZvcmNlQmxhY2tUZXh0ID0gMSA8PCAzLAogICAgIFNuYXBzaG90T3B0aW9uc1BhaW50U2VsZWN0 aW9uQW5kQmFja2dyb3VuZHNPbmx5ID0gMSA8PCA0LAotICAgIFNuYXBzaG90T3B0aW9uc1BhaW50 RXZlcnl0aGluZ0V4Y2x1ZGluZ1NlbGVjdGlvbiA9IDEgPDwgNQorICAgIFNuYXBzaG90T3B0aW9u c1BhaW50RXZlcnl0aGluZ0V4Y2x1ZGluZ1NlbGVjdGlvbiA9IDEgPDwgNSwKKyAgICBTbmFwc2hv dE9wdGlvbnNQYWludFdpdGhJbnRlZ3JhbFNjYWxlRmFjdG9yID0gMSA8PCA2LAogfTsKIHR5cGVk ZWYgdW5zaWduZWQgU25hcHNob3RPcHRpb25zOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1RleHRJbmRpY2F0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9UZXh0SW5kaWNh dG9yLmNwcAppbmRleCA0NjA4ZDU1YzVhNjkwY2U1ZGFhMTg4MDMwOTU4YTIyMWZhZDMzODlhLi43 ZTA1MDNlZGZjY2Q5N2FmZDM1NmMwMjA5NTBjYzQ2ZDlhNzJlNGMwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1RleHRJbmRpY2F0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvVGV4dEluZGljYXRvci5jcHAKQEAgLTEzMiw3ICsxMzIsNyBAQCBzdGF0aWMgYm9vbCBoYXNO b25JbmxpbmVPclJlcGxhY2VkRWxlbWVudHMoY29uc3QgUmFuZ2UmIHJhbmdlKQogCiBzdGF0aWMg U25hcHNob3RPcHRpb25zIHNuYXBzaG90T3B0aW9uc0ZvclRleHRJbmRpY2F0b3JPcHRpb25zKFRl eHRJbmRpY2F0b3JPcHRpb25zIG9wdGlvbnMpCiB7Ci0gICAgU25hcHNob3RPcHRpb25zIHNuYXBz aG90T3B0aW9ucyA9IFNuYXBzaG90T3B0aW9uc05vbmU7CisgICAgU25hcHNob3RPcHRpb25zIHNu YXBzaG90T3B0aW9ucyA9IFNuYXBzaG90T3B0aW9uc1BhaW50V2l0aEludGVncmFsU2NhbGVGYWN0 b3I7CiAKICAgICBpZiAoIShvcHRpb25zICYgVGV4dEluZGljYXRvck9wdGlvblBhaW50QWxsQ29u dGVudCkpIHsKICAgICAgICAgaWYgKG9wdGlvbnMgJiBUZXh0SW5kaWNhdG9yT3B0aW9uUGFpbnRC YWNrZ3JvdW5kcykK