200129 2019-07-25 10:08:28 -0700 Avoid some unnecessary HashMap copies 2019-07-25 11:11:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue ggaren rniwa webkit-bug-importer youennf oldest_to_newest 1555824 0 cdumez 2019-07-25 10:08:28 -0700 Avoid some unnecessary HashMap copies. 1555826 1 374895 cdumez 2019-07-25 10:09:50 -0700 Created attachment 374895 Patch 1555843 2 374895 commit-queue 2019-07-25 11:10:06 -0700 Comment on attachment 374895 Patch Clearing flags on attachment: 374895 Committed r247828: <https://trac.webkit.org/changeset/247828> 1555844 3 commit-queue 2019-07-25 11:10:07 -0700 All reviewed patches have been landed. Closing bug. 1555845 4 webkit-bug-importer 2019-07-25 11:11:17 -0700 <rdar://problem/53550282> 374895 2019-07-25 10:09:50 -0700 2019-07-25 11:10:06 -0700 Patch bug-200129-20190725100949.patch text/plain 7145 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMxY2Y2Y2Q0YTJjZmUw NzcyMDkyYjBkZDIwMGYyNTA0N2JjMTZiOC4uYTU0Mjc2ODYyN2Q2MDMwOTEyZmIwM2QyYTE1YjQz OGExOTE5NTk4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA3LTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgc29tZSB1bm5lY2Vz c2FyeSBIYXNoTWFwIGNvcGllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjAwMTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlNXU2VydmVyOjphZGRSZWdpc3RyYXRpb25Gcm9tU3RvcmUpOgorCiAyMDE5 LTA3LTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQg VUkgUHJvY2VzcyBoYW5ncyB3aGVuIHRoZSBXZWJDb250ZW50IHByb2Nlc3MgaXMgc2hvd2luZyBK UyBwcm9tcHRzIC8gYWxlcnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQxZGZkNWVkZWRiYTBhYmI3ODkyOTA1OTNh YmU2NzYyYzU5MTU5OGYuLjU4YThmMDc0ZDNkYmIwMDQ3MWZhZGE2YTU5ZTFlNzQ5ZDE5MjBiYWEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDctMjUgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCBzb21lIHVubmVjZXNzYXJ5IEhhc2hNYXAg Y29waWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDAxMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IE5ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmRpZENsb3NlKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvQXV4aWxpYXJ5UHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdl YktpdDo6QXV4aWxpYXJ5UHJvY2Vzc1Byb3h5Ojpjb25uZWN0KToKKyAgICAgICAgKiBVSVByb2Nl c3MvTGF1bmNoZXIvUHJvY2Vzc0xhdW5jaGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vz c0xhdW5jaGVyOjpQcm9jZXNzTGF1bmNoZXIpOgorICAgICAgICAqIFVJUHJvY2Vzcy9MYXVuY2hl ci9Qcm9jZXNzTGF1bmNoZXIuaDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc0xhdW5jaGVyOjpj cmVhdGUpOgorICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9XZWJQbHVnaW5JbmZvUHJvdmlk ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVnaW5JbmZvUHJvdmlkZXI6OnNldFBsdWdp bkxvYWRDbGllbnRQb2xpY3kpOgorCiAyMDE5LTA3LTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQgVUkgUHJvY2VzcyBoYW5ncyB3aGVuIHRoZSBXZWJD b250ZW50IHByb2Nlc3MgaXMgc2hvd2luZyBKUyBwcm9tcHRzIC8gYWxlcnRzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCmluZGV4IDMz OTRiZWIyMTJiNDIzMWQ5Mjg5MTA2YjdmZDk4NjY3MjA0ZGNmOTMuLmZlNWNjODU5ZTY1YTZlMzJh NzhiNTI4OTc1YTEzMmU3NGJmMTc4N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtl cnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtl cnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCkBAIC0xNDksNyArMTQ5LDcgQEAgdm9pZCBT V1NlcnZlcjo6YWRkUmVnaXN0cmF0aW9uRnJvbVN0b3JlKFNlcnZpY2VXb3JrZXJDb250ZXh0RGF0 YSYmIGRhdGEpCiAgICAgYXV0byByZWdpc3RyYXRpb25QdHIgPSByZWdpc3RyYXRpb24uZ2V0KCk7 CiAgICAgYWRkUmVnaXN0cmF0aW9uKFdURk1vdmUocmVnaXN0cmF0aW9uKSk7CiAKLSAgICBhdXRv IHdvcmtlciA9IFNXU2VydmVyV29ya2VyOjpjcmVhdGUoKnRoaXMsICpyZWdpc3RyYXRpb25QdHIs IGRhdGEuc2NyaXB0VVJMLCBkYXRhLnNjcmlwdCwgZGF0YS5jb250ZW50U2VjdXJpdHlQb2xpY3ks IFdURk1vdmUoZGF0YS5yZWZlcnJlclBvbGljeSksIGRhdGEud29ya2VyVHlwZSwgZGF0YS5zZXJ2 aWNlV29ya2VySWRlbnRpZmllciwgSGFzaE1hcDxVUkwsIFNlcnZpY2VXb3JrZXJDb250ZXh0RGF0 YTo6SW1wb3J0ZWRTY3JpcHQ+IHsgZGF0YS5zY3JpcHRSZXNvdXJjZU1hcCB9KTsKKyAgICBhdXRv IHdvcmtlciA9IFNXU2VydmVyV29ya2VyOjpjcmVhdGUoKnRoaXMsICpyZWdpc3RyYXRpb25QdHIs IGRhdGEuc2NyaXB0VVJMLCBkYXRhLnNjcmlwdCwgZGF0YS5jb250ZW50U2VjdXJpdHlQb2xpY3ks IFdURk1vdmUoZGF0YS5yZWZlcnJlclBvbGljeSksIGRhdGEud29ya2VyVHlwZSwgZGF0YS5zZXJ2 aWNlV29ya2VySWRlbnRpZmllciwgV1RGTW92ZShkYXRhLnNjcmlwdFJlc291cmNlTWFwKSk7CiAg ICAgcmVnaXN0cmF0aW9uUHRyLT51cGRhdGVSZWdpc3RyYXRpb25TdGF0ZShTZXJ2aWNlV29ya2Vy UmVnaXN0cmF0aW9uU3RhdGU6OkFjdGl2ZSwgd29ya2VyLnB0cigpKTsKICAgICB3b3JrZXItPnNl dFN0YXRlKFNlcnZpY2VXb3JrZXJTdGF0ZTo6QWN0aXZhdGVkKTsKIH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3Mu Y3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2Vi UHJvY2Vzcy5jcHAKaW5kZXggZjU1NjViOWI4ZWI5ODFiNDZlNjAzMmE5OWVmOWRkM2M5Y2ViZGZi Mi4uOTMzYzNhZWIyZTJmYzkzNGQ2YmNhOTU2NjE1OTMxYzJhMGI1MThmNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vz cy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlv blRvV2ViUHJvY2Vzcy5jcHAKQEAgLTMxMiwxMSArMzEyLDkgQEAgdm9pZCBOZXR3b3JrQ29ubmVj dGlvblRvV2ViUHJvY2Vzczo6ZGlkQ2xvc2UoSVBDOjpDb25uZWN0aW9uJiBjb25uZWN0aW9uKQog I2VuZGlmCiAKICNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkKLSAgICBhdXRvIGlkYkNvbm5l Y3Rpb25zID0gbV93ZWJJREJDb25uZWN0aW9uczsKKyAgICBhdXRvIGlkYkNvbm5lY3Rpb25zID0g c3RkOjpleGNoYW5nZShtX3dlYklEQkNvbm5lY3Rpb25zLCB7IH0pOwogICAgIGZvciAoYXV0byYg Y29ubmVjdGlvbiA6IGlkYkNvbm5lY3Rpb25zLnZhbHVlcygpKQogICAgICAgICBjb25uZWN0aW9u LT5kaXNjb25uZWN0ZWRGcm9tV2ViUHJvY2VzcygpOwotCi0gICAgbV93ZWJJREJDb25uZWN0aW9u cy5jbGVhcigpOwogI2VuZGlmCiAgICAgCiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV4aWxpYXJ5UHJvY2Vzc1Byb3h5LmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1eGlsaWFyeVByb2Nlc3NQcm94eS5jcHAKaW5k ZXggZjUwZjdmYjRjNTJhOGZmMDBhOTQwNTUwNWM5MGU0MzRkY2M2N2I1My4uZjk4MzlkZThkNTYz Y2I3ODQ5N2JkM2E5MzE5YWE4NDQzNTQyM2Q2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQXV4aWxpYXJ5UHJvY2Vzc1Byb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BdXhpbGlhcnlQcm9jZXNzUHJveHkuY3BwCkBAIC04Niw3ICs4Niw3IEBAIHZvaWQg QXV4aWxpYXJ5UHJvY2Vzc1Byb3h5Ojpjb25uZWN0KCkKICAgICBBU1NFUlQoIW1fcHJvY2Vzc0xh dW5jaGVyKTsKICAgICBQcm9jZXNzTGF1bmNoZXI6OkxhdW5jaE9wdGlvbnMgbGF1bmNoT3B0aW9u czsKICAgICBnZXRMYXVuY2hPcHRpb25zKGxhdW5jaE9wdGlvbnMpOwotICAgIG1fcHJvY2Vzc0xh dW5jaGVyID0gUHJvY2Vzc0xhdW5jaGVyOjpjcmVhdGUodGhpcywgbGF1bmNoT3B0aW9ucyk7Cisg ICAgbV9wcm9jZXNzTGF1bmNoZXIgPSBQcm9jZXNzTGF1bmNoZXI6OmNyZWF0ZSh0aGlzLCBXVEZN b3ZlKGxhdW5jaE9wdGlvbnMpKTsKIH0KIAogdm9pZCBBdXhpbGlhcnlQcm9jZXNzUHJveHk6OnRl cm1pbmF0ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9Q cm9jZXNzTGF1bmNoZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvUHJv Y2Vzc0xhdW5jaGVyLmNwcAppbmRleCBmODY0Y2E5NWQ4MzhkNTEyYzc1NzIyMTI3ZmFlYjQzYTM5 MDJiOTNkLi43MzlkZDA1YjIyYmUzMGNhNDdiZWIxZDFjMmM0MTI5NWQ5YjhkZjM1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9Qcm9jZXNzTGF1bmNoZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL1Byb2Nlc3NMYXVuY2hlci5j cHAKQEAgLTMyLDkgKzMyLDkgQEAKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLVByb2Nlc3NMYXVu Y2hlcjo6UHJvY2Vzc0xhdW5jaGVyKENsaWVudCogY2xpZW50LCBjb25zdCBMYXVuY2hPcHRpb25z JiBsYXVuY2hPcHRpb25zKQorUHJvY2Vzc0xhdW5jaGVyOjpQcm9jZXNzTGF1bmNoZXIoQ2xpZW50 KiBjbGllbnQsIExhdW5jaE9wdGlvbnMmJiBsYXVuY2hPcHRpb25zKQogICAgIDogbV9jbGllbnQo Y2xpZW50KQotICAgICwgbV9sYXVuY2hPcHRpb25zKGxhdW5jaE9wdGlvbnMpCisgICAgLCBtX2xh dW5jaE9wdGlvbnMoV1RGTW92ZShsYXVuY2hPcHRpb25zKSkKICAgICAsIG1fcHJvY2Vzc0lkZW50 aWZpZXIoMCkKIHsKICAgICBtX2lzTGF1bmNoaW5nID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL1Byb2Nlc3NMYXVuY2hlci5oIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvUHJvY2Vzc0xhdW5jaGVyLmgKaW5kZXggNjRiMWEzMTJi ZmVmYzBhODYwZTNjZjQyNjBiZDcyYmYyMmE1MWNkYi4uYzc3ODdkM2I5MTg2MGFjNDJkYjI4NDY5 MDNmNTA3ZTg4MDlkZTAyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1 bmNoZXIvUHJvY2Vzc0xhdW5jaGVyLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1 bmNoZXIvUHJvY2Vzc0xhdW5jaGVyLmgKQEAgLTgzLDkgKzgzLDkgQEAgcHVibGljOgogI2VuZGlm CiAgICAgfTsKIAotICAgIHN0YXRpYyBSZWY8UHJvY2Vzc0xhdW5jaGVyPiBjcmVhdGUoQ2xpZW50 KiBjbGllbnQsIGNvbnN0IExhdW5jaE9wdGlvbnMmIGxhdW5jaE9wdGlvbnMpCisgICAgc3RhdGlj IFJlZjxQcm9jZXNzTGF1bmNoZXI+IGNyZWF0ZShDbGllbnQqIGNsaWVudCwgTGF1bmNoT3B0aW9u cyYmIGxhdW5jaE9wdGlvbnMpCiAgICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBQ cm9jZXNzTGF1bmNoZXIoY2xpZW50LCBsYXVuY2hPcHRpb25zKSk7CisgICAgICAgIHJldHVybiBh ZG9wdFJlZigqbmV3IFByb2Nlc3NMYXVuY2hlcihjbGllbnQsIFdURk1vdmUobGF1bmNoT3B0aW9u cykpKTsKICAgICB9CiAKICAgICBib29sIGlzTGF1bmNoaW5nKCkgY29uc3QgeyByZXR1cm4gbV9p c0xhdW5jaGluZzsgfQpAQCAtOTUsNyArOTUsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBpbnZhbGlk YXRlKCk7CiAKIHByaXZhdGU6Ci0gICAgUHJvY2Vzc0xhdW5jaGVyKENsaWVudCosIGNvbnN0IExh dW5jaE9wdGlvbnMmIGxhdW5jaE9wdGlvbnMpOworICAgIFByb2Nlc3NMYXVuY2hlcihDbGllbnQq LCBMYXVuY2hPcHRpb25zJiYpOwogCiAgICAgdm9pZCBsYXVuY2hQcm9jZXNzKCk7CiAgICAgdm9p ZCBkaWRGaW5pc2hMYXVuY2hpbmdQcm9jZXNzKFByb2Nlc3NJRCwgSVBDOjpDb25uZWN0aW9uOjpJ ZGVudGlmaWVyKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5z L1dlYlBsdWdpbkluZm9Qcm92aWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1 Z2lucy9XZWJQbHVnaW5JbmZvUHJvdmlkZXIuY3BwCmluZGV4IDc2ODQwNjQyZWVmNWE0MTJiYTRj YTM4MDZkMDEzZTQzNDgwMzQ5YmQuLjZjMWZkYjE4OGRiNTk0MTRkZjNlZGUyMmYzYzVmZGEyNDFl M2U2MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1dlYlBs dWdpbkluZm9Qcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdp bnMvV2ViUGx1Z2luSW5mb1Byb3ZpZGVyLmNwcApAQCAtNzgsNyArNzgsNyBAQCB2b2lkIFdlYlBs dWdpbkluZm9Qcm92aWRlcjo6c2V0UGx1Z2luTG9hZENsaWVudFBvbGljeShXZWJDb3JlOjpQbHVn aW5Mb2FkQ2xpZW50UAogICAgICAgICB2ZXJzaW9uc1RvUG9saWNpZXMgPSBwb2xpY2llc0J5SWRl bnRpZmllci5nZXQoYnVuZGxlSWRlbnRpZmllclRvU2V0KTsKIAogICAgIHZlcnNpb25zVG9Qb2xp Y2llcy5zZXQodmVyc2lvblN0cmluZ1RvU2V0LCBjbGllbnRQb2xpY3kpOwotICAgIHBvbGljaWVz QnlJZGVudGlmaWVyLnNldChidW5kbGVJZGVudGlmaWVyVG9TZXQsIHZlcnNpb25zVG9Qb2xpY2ll cyk7CisgICAgcG9saWNpZXNCeUlkZW50aWZpZXIuc2V0KGJ1bmRsZUlkZW50aWZpZXJUb1NldCwg V1RGTW92ZSh2ZXJzaW9uc1RvUG9saWNpZXMpKTsKICAgICBtX2hvc3RzVG9QbHVnaW5JZGVudGlm aWVyRGF0YS5zZXQoaG9zdFRvU2V0LCBwb2xpY2llc0J5SWRlbnRpZmllcik7CiAKICAgICBjbGVh clBhZ2VzUGx1Z2luRGF0YSgpOwo=