200127 2019-07-25 09:24:57 -0700 results.webkit.org: Color should be the worst result, count should include all results 2019-07-26 09:08:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue dewei_zhu ryanhaddad tsavell webkit-bug-importer oldest_to_newest 1555805 0 jbedard 2019-07-25 09:24:57 -0700 Talking to bot watchers, it seems that the fact that the count included only the count of the worst failures as opposed to a count of all failures is a source of confusion. Make it so that the count of failures includes all failures, regardless of type. For example, a test run with 30 crashes, 4 timeouts and 13 ImageDiff failures would be assigned the color purple, but have a count of 47. The current behavior would cause such a run to be assigned the color purple and have a count of 30. 1555808 1 374893 jbedard 2019-07-25 09:28:57 -0700 Created attachment 374893 Patch 1555820 2 ryanhaddad 2019-07-25 09:53:23 -0700 Agreed, this makes more sense. 1555967 3 aakash_jain 2019-07-25 16:48:19 -0700 rs=me 1555982 4 374927 jbedard 2019-07-25 17:24:39 -0700 Created attachment 374927 Patch 1555989 5 374927 commit-queue 2019-07-25 18:03:46 -0700 Comment on attachment 374927 Patch Clearing flags on attachment: 374927 Committed r247850: <https://trac.webkit.org/changeset/247850> 1555990 6 commit-queue 2019-07-25 18:03:48 -0700 All reviewed patches have been landed. Closing bug. 1555991 7 webkit-bug-importer 2019-07-25 18:04:16 -0700 <rdar://problem/53568693> 1556099 8 jbedard 2019-07-26 08:22:22 -0700 Reopening to attach new patch. 1556100 9 374962 jbedard 2019-07-26 08:22:23 -0700 Created attachment 374962 Patch 1556120 10 374962 commit-queue 2019-07-26 09:08:21 -0700 Comment on attachment 374962 Patch Clearing flags on attachment: 374962 Committed r247863: <https://trac.webkit.org/changeset/247863> 1556121 11 commit-queue 2019-07-26 09:08:23 -0700 All reviewed patches have been landed. Closing bug. 374893 2019-07-25 09:28:57 -0700 2019-07-25 17:24:38 -0700 Patch bug-200127-20190725092856.patch text/plain 2080 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NzgyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA3LTI1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IENvbG9yIHNob3VsZCBiZSB0aGUgd29y c3QgcmVzdWx0LCBjb3VudCBzaG91bGQgaW5jbHVkZSBhbGwgcmVzdWx0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMTI3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1bHRz ZGJweS92aWV3L3N0YXRpYy9qcy90aW1lbGluZS5qczoKKyAgICAgICAgKERvdC5wcm90b3R5cGUu dG9TdHJpbmcpOiBEbyBub3QgZGlmZmVyZW50aWF0ZSB0aGUgY291bnQgYmFzZWQgb24gdGhlIHBy ZXZhaWxpbmcgZmFpbHVyZSB0eXBlLgorCiAyMDE5LTA3LTI1ICBSb3NzIEtpcnNsaW5nICA8cm9z cy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBbRVNOZXh0XSBJbXBsZW1lbnQgbnVsbGlz aCBjb2FsZXNjaW5nCkluZGV4OiBUb29scy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0 YXRpYy9qcy90aW1lbGluZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9yZXN1bHRzZGJweS9yZXN1 bHRzZGJweS92aWV3L3N0YXRpYy9qcy90aW1lbGluZS5qcwkocmV2aXNpb24gMjQ3ODIzKQorKysg VG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvdGltZWxpbmUuanMJ KHdvcmtpbmcgY29weSkKQEAgLTE5NCwyMiArMTk0LDE3IEBAIGNsYXNzIERvdCB7CiAgICAgICAg ICAgICByZXR1cm4gcmVuZGVyKCdkb3Qgc3VjY2VzcycpOwogCiAgICAgICAgIGxldCBrZXkgPSAn ZmFpbGVkJzsKLSAgICAgICAgbGV0IHZhbHVlID0gdGhpcy5mYWlsZWQgLSB0aGlzLnRpbWVvdXQ7 Ci0gICAgICAgIGlmICh0aGlzLnRpbWVvdXQpIHsKKyAgICAgICAgaWYgKHRoaXMudGltZW91dCkK ICAgICAgICAgICAgIGtleSA9ICd0aW1lb3V0JzsKLSAgICAgICAgICAgIHZhbHVlID0gdGhpcy50 aW1lb3V0IC0gdGhpcy5jcmFzaDsKLSAgICAgICAgfQotICAgICAgICBpZiAodGhpcy5jcmFzaCkg eworICAgICAgICBpZiAodGhpcy5jcmFzaCkKICAgICAgICAgICAgIGtleSA9ICdjcmFzaCc7Ci0g ICAgICAgICAgICB2YWx1ZSA9IHRoaXMudGltZW91dDsKLSAgICAgICAgfQogCiAgICAgICAgIGlm ICghdGhpcy5jb21iaW5lZCkKLSAgICAgICAgICAgIHJldHVybiByZW5kZXIoYGRvdCAke2tleX1g LCBgPGRpdiBjbGFzcz0idGFnIiBzdHlsZT0iY29sb3I6dmFyKC0tYm9sZEludmVyc2VDb2xvciki PiR7dmFsdWV9PC9kaXY+YCk7CisgICAgICAgICAgICByZXR1cm4gcmVuZGVyKGBkb3QgJHtrZXl9 YCwgYDxkaXYgY2xhc3M9InRhZyIgc3R5bGU9ImNvbG9yOnZhcigtLWJvbGRJbnZlcnNlQ29sb3Ip Ij4ke3RoaXMuZmFpbGVkfTwvZGl2PmApOwogCiAgICAgICAgIHJldHVybiByZW5kZXIoYGRvdCAk e2tleX1gLCBgPGRpdiBjbGFzcz0idGFnIiBzdHlsZT0iY29sb3I6dmFyKC0tYm9sZEludmVyc2VD b2xvcikiPgogICAgICAgICAgICAgICAgICR7ZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgICAgICAg ICAgIGxldCBwZXJjZW50ID0gTWF0aC5jZWlsKHZhbHVlIC8gc2VsZi5jb3VudCAqIDEwMCAtIC41 KTsKKyAgICAgICAgICAgICAgICAgICAgbGV0IHBlcmNlbnQgPSBNYXRoLmNlaWwodGhpcy5mYWls ZWQgLyBzZWxmLmNvdW50ICogMTAwIC0gLjUpOwogICAgICAgICAgICAgICAgICAgICBpZiAocGVy Y2VudCA+IDApCiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gcGVyY2VudDsKICAgICAg ICAgICAgICAgICAgICAgcmV0dXJuICc8MSc7Cg== 374927 2019-07-25 17:24:39 -0700 2019-07-26 08:22:20 -0700 Patch bug-200127-20190725172439.patch text/plain 2115 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Nzg0NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA3LTI1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICByZXN1bHRzLndlYmtpdC5vcmc6IENvbG9yIHNob3VsZCBiZSB0aGUgd29y c3QgcmVzdWx0LCBjb3VudCBzaG91bGQgaW5jbHVkZSBhbGwgcmVzdWx0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMTI3CisKKyAgICAgICAgUnVi YmVyLXN0YW1wZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiByZXN1bHRzZGJweS9yZXN1 bHRzZGJweS92aWV3L3N0YXRpYy9qcy90aW1lbGluZS5qczoKKyAgICAgICAgKERvdC5wcm90b3R5 cGUudG9TdHJpbmcpOiBEbyBub3QgZGlmZmVyZW50aWF0ZSB0aGUgY291bnQgYmFzZWQgb24gdGhl IHByZXZhaWxpbmcgZmFpbHVyZSB0eXBlLgorCiAyMDE5LTA3LTI1ICBaaGlmZWkgRmFuZyAgPHpo aWZlaV9mYW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBbVGltZWxpbmVdOiBNYWtlIHRpbWVsaW5l IGhlYWRlciB3aWR0aCBhdXRvbWF0aWMsIGluc3RlYWQgb2YgZml4ZWQgd2lkdGgKSW5kZXg6IFRv b2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL3RpbWVsaW5lLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pz L3RpbWVsaW5lLmpzCShyZXZpc2lvbiAyNDc4NDUpCisrKyBUb29scy9yZXN1bHRzZGJweS9yZXN1 bHRzZGJweS92aWV3L3N0YXRpYy9qcy90aW1lbGluZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMTk0 LDIyICsxOTQsMTcgQEAgY2xhc3MgRG90IHsKICAgICAgICAgICAgIHJldHVybiByZW5kZXIoJ2Rv dCBzdWNjZXNzJyk7CiAKICAgICAgICAgbGV0IGtleSA9ICdmYWlsZWQnOwotICAgICAgICBsZXQg dmFsdWUgPSB0aGlzLmZhaWxlZCAtIHRoaXMudGltZW91dDsKLSAgICAgICAgaWYgKHRoaXMudGlt ZW91dCkgeworICAgICAgICBpZiAodGhpcy50aW1lb3V0KQogICAgICAgICAgICAga2V5ID0gJ3Rp bWVvdXQnOwotICAgICAgICAgICAgdmFsdWUgPSB0aGlzLnRpbWVvdXQgLSB0aGlzLmNyYXNoOwot ICAgICAgICB9Ci0gICAgICAgIGlmICh0aGlzLmNyYXNoKSB7CisgICAgICAgIGlmICh0aGlzLmNy YXNoKQogICAgICAgICAgICAga2V5ID0gJ2NyYXNoJzsKLSAgICAgICAgICAgIHZhbHVlID0gdGhp cy50aW1lb3V0OwotICAgICAgICB9CiAKICAgICAgICAgaWYgKCF0aGlzLmNvbWJpbmVkKQotICAg ICAgICAgICAgcmV0dXJuIHJlbmRlcihgZG90ICR7a2V5fWAsIGA8ZGl2IGNsYXNzPSJ0YWciIHN0 eWxlPSJjb2xvcjp2YXIoLS1ib2xkSW52ZXJzZUNvbG9yKSI+JHt2YWx1ZX08L2Rpdj5gKTsKKyAg ICAgICAgICAgIHJldHVybiByZW5kZXIoYGRvdCAke2tleX1gLCBgPGRpdiBjbGFzcz0idGFnIiBz dHlsZT0iY29sb3I6dmFyKC0tYm9sZEludmVyc2VDb2xvcikiPiR7dGhpcy5mYWlsZWR9PC9kaXY+ YCk7CiAKICAgICAgICAgcmV0dXJuIHJlbmRlcihgZG90ICR7a2V5fWAsIGA8ZGl2IGNsYXNzPSJ0 YWciIHN0eWxlPSJjb2xvcjp2YXIoLS1ib2xkSW52ZXJzZUNvbG9yKSI+CiAgICAgICAgICAgICAg ICAgJHtmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgICAgICAgbGV0IHBlcmNlbnQgPSBNYXRo LmNlaWwodmFsdWUgLyBzZWxmLmNvdW50ICogMTAwIC0gLjUpOworICAgICAgICAgICAgICAgICAg ICBsZXQgcGVyY2VudCA9IE1hdGguY2VpbCh0aGlzLmZhaWxlZCAvIHNlbGYuY291bnQgKiAxMDAg LSAuNSk7CiAgICAgICAgICAgICAgICAgICAgIGlmIChwZXJjZW50ID4gMCkKICAgICAgICAgICAg ICAgICAgICAgICAgIHJldHVybiBwZXJjZW50OwogICAgICAgICAgICAgICAgICAgICByZXR1cm4g JzwxJzsK 374962 2019-07-26 08:22:23 -0700 2019-07-26 09:08:21 -0700 Patch bug-200127-20190726082222.patch text/plain 1454 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Nzg2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA3LTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGb2xsb3ctdXAgZml4OiByZXN1bHRzLndlYmtpdC5vcmc6IENvbG9yIHNo b3VsZCBiZSB0aGUgd29yc3QgcmVzdWx0LCBjb3VudCBzaG91bGQgaW5jbHVkZSBhbGwgcmVzdWx0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMTI3 CisKKyAgICAgICAgVW5yZXZpZXdlZCBmb2xsb3ctdXAgZml4LgorCisgICAgICAgICogcmVzdWx0 c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvdGltZWxpbmUuanM6CisgICAgICAgIChE b3QudG9TdHJpbmcpOiBVc2Ugc2VsZiBpbnN0ZWFkIG9mIHRoaXMgaW4gcmVuZGVyIGNhbGxiYWNr LgorCiAyMDE5LTA3LTI0ICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViUGFnZVByb3h5OjpyZWNlaXZlZFBvbGljeURlY2lzaW9uIHNob3VsZCBjaGVjayBu YXZpZ2F0aW9uIElEIGJlZm9yZSBjbGVhciBwZW5kaW5nQVBJUmVxdWVzdApJbmRleDogVG9vbHMv cmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvdGltZWxpbmUuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvdGlt ZWxpbmUuanMJKHJldmlzaW9uIDI0Nzg1MikKKysrIFRvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNk YnB5L3ZpZXcvc3RhdGljL2pzL3RpbWVsaW5lLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yMDQsNyAr MjA0LDcgQEAgY2xhc3MgRG90IHsKIAogICAgICAgICByZXR1cm4gcmVuZGVyKGBkb3QgJHtrZXl9 YCwgYDxkaXYgY2xhc3M9InRhZyIgc3R5bGU9ImNvbG9yOnZhcigtLWJvbGRJbnZlcnNlQ29sb3Ip Ij4KICAgICAgICAgICAgICAgICAke2Z1bmN0aW9uKCkgewotICAgICAgICAgICAgICAgICAgICBs ZXQgcGVyY2VudCA9IE1hdGguY2VpbCh0aGlzLmZhaWxlZCAvIHNlbGYuY291bnQgKiAxMDAgLSAu NSk7CisgICAgICAgICAgICAgICAgICAgIGxldCBwZXJjZW50ID0gTWF0aC5jZWlsKHNlbGYuZmFp bGVkIC8gc2VsZi5jb3VudCAqIDEwMCAtIC41KTsKICAgICAgICAgICAgICAgICAgICAgaWYgKHBl cmNlbnQgPiAwKQogICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHBlcmNlbnQ7CiAgICAg ICAgICAgICAgICAgICAgIHJldHVybiAnPDEnOwo=