200123 2019-07-25 04:00:19 -0700 [GTK] Indistinguishable overloaded callback function inspectorViewDestroyed if RemoteWebInspectorProxyGtk.cpp and WebInspectorProxyGtk.cpp are in a unified build bundle 2019-07-25 18:44:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii fujii bugs-noreply cgarcia oldest_to_newest 1555756 0 fujii 2019-07-25 04:00:19 -0700 [GTK] Indistinguishable overloaded callback function inspectorViewDestroyed if RemoteWebInspectorProxyGtk.cpp and WebInspectorProxyGtk.cpp are in a unified build bundle If UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp and UIProcess/gtk/WebInspectorProxyGtk.cpp are in a same unified build bundle, the following compilation error occurs. > In file included from ../DependenciesGTK/Root/include/glib-2.0/gobject/gobject.h:28, > from ../DependenciesGTK/Root/include/glib-2.0/gobject/gbinding.h:29, > from ../DependenciesGTK/Root/include/glib-2.0/glib-object.h:23, > from ../DependenciesGTK/Root/include/glib-2.0/gio/gioenums.h:28, > from ../DependenciesGTK/Root/include/glib-2.0/gio/giotypes.h:28, > from ../DependenciesGTK/Root/include/glib-2.0/gio/gio.h:26, > from ../DependenciesGTK/Root/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28, > from ../DependenciesGTK/Root/include/gtk-3.0/gdk/gdk.h:32, > from ../DependenciesGTK/Root/include/gtk-3.0/gtk/gtk.h:30, > from ../../Source/WebKit/UIProcess/gtk/GestureController.cpp:30, > from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-26.cpp:1: > ../../Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp: In member function ‘WebKit::WebPageProxy* WebKit::WebInspectorProxy::platformCreateFrontendPage()’: > ../../Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp:157:50: error: overloaded function with no contextual type information > g_signal_connect(m_inspectorView, "destroy", G_CALLBACK(inspectorViewDestroyed), this); > ^~~~~~~~~~ > ../../Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp: In member function ‘void WebKit::WebInspectorProxy::platformCloseFrontendPageAndWindow()’: > ../../Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp:279:109: error: overloaded function with no contextual type information > g_signal_handlers_disconnect_by_func(m_inspectorView, reinterpret_cast<void*>(inspectorViewDestroyed), this); > ^ > ../../Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp: In member function ‘void WebKit::WebInspectorProxy::platformDetach()’: > ../../Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp:423:109: error: overloaded function with no contextual type information > g_signal_handlers_disconnect_by_func(m_inspectorView, reinterpret_cast<void*>(inspectorViewDestroyed), this); > ^ > In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-26.cpp:9: > ../../Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp: At global scope: > ../../Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp:53:13: warning: ‘void WebKit::inspectorViewDestroyed(GtkWidget*, gpointer)’ defined but not used [-Wunused-function] > static void inspectorViewDestroyed(GtkWidget*, gpointer userData) > ^~~~~~~~~~~~~~~~~~~~~~ 1555758 1 374886 fujii 2019-07-25 04:02:07 -0700 Created attachment 374886 Patch 1555996 2 374886 fujii 2019-07-25 18:44:03 -0700 Comment on attachment 374886 Patch Clearing flags on attachment: 374886 Committed r247852: <https://trac.webkit.org/changeset/247852> 1555997 3 fujii 2019-07-25 18:44:06 -0700 All reviewed patches have been landed. Closing bug. 374886 2019-07-25 04:02:07 -0700 2019-07-25 18:44:03 -0700 Patch bug-200123-20190725200203.patch text/plain 2464 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3ODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFhZjU1ZmRmZDg4M2QyNWQ4 NWU4YWE4NTRhZDUxZTZmNjJjYjVmODUuLjczMTg1YWI4YWNhODA3ZjZiZjEyZjZjNTczYjVjMmMw MTg3YzY1ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDctMjUgIEZ1amlpIEhp cm9ub3JpICA8ZnVqaWkuaGlyb25vcmlAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIEluZGlz dGluZ3Vpc2hhYmxlIG92ZXJsb2FkZWQgY2FsbGJhY2sgZnVuY3Rpb24gaW5zcGVjdG9yVmlld0Rl c3Ryb3llZCBpZiBSZW1vdGVXZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAgYW5kIFdlYkluc3BlY3Rv clByb3h5R3RrLmNwcCBhcmUgaW4gYSB1bmlmaWVkIGJ1aWxkIGJ1bmRsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMTIzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1JlbW90 ZVdlYkluc3BlY3RvclByb3h5R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6cmVtb3RlSW5zcGVj dG9yVmlld0Rlc3Ryb3llZCk6IEFkZGVkLgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVXZWJJbnNw ZWN0b3JQcm94eTo6cGxhdGZvcm1DcmVhdGVGcm9udGVuZFBhZ2VBbmRXaW5kb3cpOgorICAgICAg ICAoV2ViS2l0OjppbnNwZWN0b3JWaWV3RGVzdHJveWVkKTogRGVsZXRlZC4KKyAgICAgICAgUmVu YW1lZCBpbnNwZWN0b3JWaWV3RGVzdHJveWVkIHRvIHJlbW90ZUluc3BlY3RvclZpZXdEZXN0cm95 ZWQuCisKIDIwMTktMDctMjQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBVbmFibGUgdG8gdGFwL2RvdWJsZSB0YXAgdG8gb3BlbiBmaWxlcy9mb2xkZXJzIGluIEdv b2dsZSBEcml2ZSBpbiBTYWZhcmkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2d0ay9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9ndGsvUmVtb3RlV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCmluZGV4IDc5NjY1NWNlZjE3 MjUxMDI0ZmI2OTE2MjMxNTNiNmZiNzIyMjk4YTIuLjRjZThhOWUxMGI5NjhkN2ZjOGE5YThiOTdh MmIzMTM1YzcwNzMyMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9S ZW1vdGVXZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvZ3RrL1JlbW90ZVdlYkluc3BlY3RvclByb3h5R3RrLmNwcApAQCAtNDQsNyArNDQsNyBAQCB2 b2lkIFJlbW90ZVdlYkluc3BlY3RvclByb3h5Ojp1cGRhdGVXaW5kb3dUaXRsZShjb25zdCBDU3Ry aW5nJiB0YXJnZXROYW1lKQogICAgIHdlYmtpdEluc3BlY3RvcldpbmRvd1NldFN1YnRpdGxlKFdF QktJVF9JTlNQRUNUT1JfV0lORE9XKG1fd2luZG93KSwgIXRhcmdldE5hbWUuaXNOdWxsKCkgPyB0 YXJnZXROYW1lLmRhdGEoKSA6IG51bGxwdHIpOwogfQogCi1zdGF0aWMgdm9pZCBpbnNwZWN0b3JW aWV3RGVzdHJveWVkKFJlbW90ZVdlYkluc3BlY3RvclByb3h5KiBpbnNwZWN0b3JQcm94eSkKK3N0 YXRpYyB2b2lkIHJlbW90ZUluc3BlY3RvclZpZXdEZXN0cm95ZWQoUmVtb3RlV2ViSW5zcGVjdG9y UHJveHkqIGluc3BlY3RvclByb3h5KQogewogICAgIGluc3BlY3RvclByb3h5LT5jbG9zZUZyb21D cmFzaCgpOwogfQpAQCAtNjYsNyArNjYsNyBAQCBXZWJQYWdlUHJveHkqIFJlbW90ZVdlYkluc3Bl Y3RvclByb3h5OjpwbGF0Zm9ybUNyZWF0ZUZyb250ZW5kUGFnZUFuZFdpbmRvdygpCiAgICAgcGFn ZUNvbmZpZ3VyYXRpb24tPnNldFByZWZlcmVuY2VzKHByZWZlcmVuY2VzLnB0cigpKTsKICAgICBw YWdlQ29uZmlndXJhdGlvbi0+c2V0UGFnZUdyb3VwKHBhZ2VHcm91cC5wdHIoKSk7CiAgICAgbV93 ZWJWaWV3ID0gR1RLX1dJREdFVCh3ZWJraXRXZWJWaWV3QmFzZUNyZWF0ZSgqcGFnZUNvbmZpZ3Vy YXRpb24ucHRyKCkpKTsKLSAgICBnX3NpZ25hbF9jb25uZWN0X3N3YXBwZWQobV93ZWJWaWV3LCAi ZGVzdHJveSIsIEdfQ0FMTEJBQ0soaW5zcGVjdG9yVmlld0Rlc3Ryb3llZCksIHRoaXMpOworICAg IGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZChtX3dlYlZpZXcsICJkZXN0cm95IiwgR19DQUxMQkFD SyhyZW1vdGVJbnNwZWN0b3JWaWV3RGVzdHJveWVkKSwgdGhpcyk7CiAgICAgZ19vYmplY3RfYWRk X3dlYWtfcG9pbnRlcihHX09CSkVDVChtX3dlYlZpZXcpLCByZWludGVycHJldF9jYXN0PHZvaWQq Kj4oJm1fd2ViVmlldykpOwogCiAgICAgbV93aW5kb3cgPSB3ZWJraXRJbnNwZWN0b3JXaW5kb3dO ZXcobnVsbHB0cik7Cg==