200106 2019-07-24 19:30:40 -0700 REGRESSION (r243637): Some web fonts fail to load on Google docs 2022-11-24 21:08:36 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 248332 1 rniwa rniwa ews-watchlist ggaren jonlee mmaxfield oldest_to_newest 1555645 0 rniwa 2019-07-24 19:30:40 -0700 Add a site specific quirk to workaround the workaround Google docs added for Safari for pre-r243637 behavior. <rdar://problem/51227600> 1555653 1 374850 rniwa 2019-07-24 19:42:21 -0700 Created attachment 374850 Fixes the bug 1555656 2 ews-watchlist 2019-07-24 19:45:12 -0700 Attachment 374850 did not pass style-queue: ERROR: Source/WebCore/css/FontFace.cpp:159: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1555683 3 374850 rniwa 2019-07-24 20:45:37 -0700 Comment on attachment 374850 Fixes the bug Wait a minute, I don’t think this analysis is right. 1555700 4 374850 ggaren 2019-07-24 21:34:46 -0700 Comment on attachment 374850 Fixes the bug r=me 1555892 5 rniwa 2019-07-25 14:13:48 -0700 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 374850 [details] > Fixes the bug > > Wait a minute, I don’t think this analysis is right. Never mind. The analysis was correct. I've also confirmed that using Google Chrome UA would not break the website again so if Google fixes their website, it would continue to work. 1555895 6 374850 rniwa 2019-07-25 14:18:05 -0700 Comment on attachment 374850 Fixes the bug Clearing flags on attachment: 374850 Committed r247840: <https://trac.webkit.org/changeset/247840> 1555896 7 rniwa 2019-07-25 14:18:07 -0700 All reviewed patches have been landed. Closing bug. 374850 2019-07-24 19:42:21 -0700 2019-07-25 14:18:05 -0700 Fixes the bug bug-200106-20190724194220.patch text/plain 6640 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDM5NmNlNjA1NWI0Nzk2 MzU3ZDc5ZjVkZTIwOTI3YjFkZGY3MGEzZS4uNDE1NjhhMDM5MWJlNDNiNDUzNmNkOTNiMzg2MDhl N2JmNTdkYTRmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDE5LTA3LTI0ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDM2 MzcpOiBTb21lIHdlYiBmb250cyBmYWlsIHRvIGxvYWQgb24gR29vZ2xlIGRvY3MKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDEwNgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByaW9yIHRvIHIyNDM2Mzcs IFdlYktpdCB0aHJldyBhbiBleGNlcHRpb24gaWYgdGhlIGZvbnQgZmFtaWx5IG5hbWUgZGlkbid0 IHBhcnNlIGFzIGEgQ1NTIGlkZW50aWZpZXIgaW4gdGhlIHNldHRlcgorICAgICAgICBvZiBgZmFt aWx5YCBJREwgYXR0cmlidXRlIG9mIEZvbnRGYWNlIGludGVyZmFjZSBiZWNhdXNlIFdlYktpdCBp bXBsZW1lbnRlZCB0aGUgb2xkIHNwZWMgZmFpdGhmdWxseSB1bmxpa2UgQ2hyb21lCisgICAgICAg IGFuZCBGaXJlZm94IHdoaWNoIGJhc2ljYWxseSB0cmVhdGVkIGl0IGFzIGEgc3RyaW5nIGFuZCBk aWRuJ3QgdGhyb3cgYW55IGV4Y2VwdGlvbi4gWzFdCisKKyAgICAgICAgVG8gYWNjb3VudCBmb3Ig dGhpcyBicm93c2VyIGJlaGF2aW9yIGRpZmZlcmVuY2UsIEdvb2dsZSBkb2NzIGltcGxlbWVudGVk IGEgd29ya2Fyb3VuZCBmb3IgU2FmYXJpIHdoaWNoIGlzIHRvIHdyYXAKKyAgICAgICAgc29tZSBp ZGVudGlmaWVycyBpbiBmb250IGZhbWlseSBuYW1lcyB3aXRoIHF1b3RhdGlvbiBtYXJrczogYGRv Y3MtQW1hdGljIFNDYCBhcyBgJ2RvY3MtQW1hdGljIFNDJ2AgYW5kCisgICAgICAgIGBkb2NzLVBs YXlmYWlyIERpc3BsYXlgIGFzIGBkb2NzLSdQbGF5ZmFpciBEaXNwbGF5J2AuIFVuZm9ydHVuYXRl bHksIHRoaXMgaW4gdHVybiBjYXVzZXMgdGhlIGxhdGVzdCBTYWZhcmkgdG8KKyAgICAgICAgbm90 IG1hdGNoIHRoZXNlIGZvbnQgZmFjZSBmYW1pbHkgd2l0aCB0aG9zZSB0aGF0IGFwcGVhciBpbiBz dHlsZXNoZWV0IHNpbmNlIHdlIG5vIGxvbmdlciBwYXJzZSBpdCBhcyBhIENTUyBpZGVudGlmaWVy LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIHNpdGUgc3BlY2lmaWMgcXVpcmsgZm9yIEdv b2dsZSBkb2NzIHRvIHVuZG8gdGhpcyB3b3JrYXJvdW5kIGJ5IHN0cmlwcGluZyBhd2F5IHNpbmds ZSBxdW90YXRpb24gbWFya3MuCisKKyAgICAgICAgWzFdIFNlZSBodHRwczovL2dpdGh1Yi5jb20v dzNjL2Nzc3dnLWRyYWZ0cy9pc3N1ZXMvMzc3NiBmb3IgdGhlIGNvbnRleHQuCisKKyAgICAgICAg KiBjc3MvRm9udEZhY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udEZhY2U6OmNyZWF0ZSk6 CisgICAgICAgIChXZWJDb3JlOjpGb250RmFjZTo6c2V0RmFtaWx5KToKKyAgICAgICAgKiBjc3Mv Rm9udEZhY2UuaDoKKyAgICAgICAgKiBjc3MvRm9udEZhY2UuaWRsOgorICAgICAgICAqIHBhZ2Uv UXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlF1aXJrczo6c2hvdWxkU3RyaXBRdW90YXRp b25NYXJrSW5Gb250RmFjZVNldEZhbWlseSBjb25zdCk6CisgICAgICAgICogcGFnZS9RdWlya3Mu aDoKKwogMjAxOS0wNy0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAg ICAgICBXZWJLaXQgc2hvdWxkIHN0cmlwIGF3YXkgc3lzdGVtIGZvbnQgbmFtZXMgZnJvbSB0aGUg cGFzdGVkIGNvbnRlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Gb250RmFjZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvRm9udEZhY2UuY3BwCmluZGV4IDUxMjNiOGI2MzE1Njhi OGMxZDQxM2U0ZGZhOTQ2YWNiYzJlNTc2YWEuLjIxMjI0NWRlZGNhZmY5NTZhZDQ0MTA3YjllYjQ0 Y2I0MTMyOGFhZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9Gb250RmFjZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0ZvbnRGYWNlLmNwcApAQCAtMzgsNiArMzgsNyBAQAog I2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRm9udFZhcmlhbnRCdWlsZGVyLmgiCiAj aW5jbHVkZSAiSlNGb250RmFjZS5oIgorI2luY2x1ZGUgIlF1aXJrcy5oIgogI2luY2x1ZGUgIlN0 eWxlUHJvcGVydGllcy5oIgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0FycmF5QnVmZmVyLmg+ CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvQXJyYXlCdWZmZXJWaWV3Lmg+CkBAIC01OSw3ICs2 MCw3IEBAIEV4Y2VwdGlvbk9yPFJlZjxGb250RmFjZT4+IEZvbnRGYWNlOjpjcmVhdGUoRG9jdW1l bnQmIGRvY3VtZW50LCBjb25zdCBTdHJpbmcmIGZhCiAKICAgICBib29sIGRhdGFSZXF1aXJlc0Fz eW5jaHJvbm91c0xvYWRpbmcgPSB0cnVlOwogCi0gICAgYXV0byBzZXRGYW1pbHlSZXN1bHQgPSBy ZXN1bHQtPnNldEZhbWlseShmYW1pbHkpOworICAgIGF1dG8gc2V0RmFtaWx5UmVzdWx0ID0gcmVz dWx0LT5zZXRGYW1pbHkoZG9jdW1lbnQsIGZhbWlseSk7CiAgICAgaWYgKHNldEZhbWlseVJlc3Vs dC5oYXNFeGNlcHRpb24oKSkKICAgICAgICAgcmV0dXJuIHNldEZhbWlseVJlc3VsdC5yZWxlYXNl RXhjZXB0aW9uKCk7CiAKQEAgLTE0OCwxNSArMTQ5LDE5IEBAIFJlZlB0cjxDU1NWYWx1ZT4gRm9u dEZhY2U6OnBhcnNlU3RyaW5nKGNvbnN0IFN0cmluZyYgc3RyaW5nLCBDU1NQcm9wZXJ0eUlEIHBy b3BlCiAgICAgcmV0dXJuIENTU1BhcnNlcjo6cGFyc2VGb250RmFjZURlc2NyaXB0b3IocHJvcGVy dHlJRCwgc3RyaW5nLCBIVE1MU3RhbmRhcmRNb2RlKTsKIH0KIAotRXhjZXB0aW9uT3I8dm9pZD4g Rm9udEZhY2U6OnNldEZhbWlseShjb25zdCBTdHJpbmcmIGZhbWlseSkKK0V4Y2VwdGlvbk9yPHZv aWQ+IEZvbnRGYWNlOjpzZXRGYW1pbHkoRG9jdW1lbnQmIGRvY3VtZW50LCBjb25zdCBTdHJpbmcm IGZhbWlseSkKIHsKICAgICBpZiAoZmFtaWx5LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIEV4 Y2VwdGlvbiB7IFN5bnRheEVycm9yIH07CiAKKyAgICBTdHJpbmcgZmFtaWx5TmFtZVRvVXNlID0g ZmFtaWx5OworICAgIGlmIChmYW1pbHlOYW1lVG9Vc2UuY29udGFpbnMoJ1wnJykgJiYgZG9jdW1l bnQucXVpcmtzKCkuc2hvdWxkU3RyaXBRdW90YXRpb25NYXJrSW5Gb250RmFjZVNldEZhbWlseSgp KQorICAgICAgICBmYW1pbHlOYW1lVG9Vc2UgPSBmYW1pbHkucmVtb3ZlQ2hhcmFjdGVycyhbXShh dXRvIGNoYXJhY3RlcikgeyByZXR1cm4gY2hhcmFjdGVyID09ICdcJyc7IH0pOworCiAgICAgLy8g RklYTUU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTYzODEgRG9u J3QgdXNlIGEgbGlzdCBoZXJlLgogICAgIC8vIFNlZSBjb25zdW1lRm9udEZhbWlseURlc2NyaXB0 b3IoKSBpbiBDU1NQcm9wZXJ0eVBhcnNlci5jcHAgZm9yIHdoeSB3ZSdyZSB1c2luZyBpdC4KICAg ICBhdXRvIGxpc3QgPSBDU1NWYWx1ZUxpc3Q6OmNyZWF0ZUNvbW1hU2VwYXJhdGVkKCk7Ci0gICAg bGlzdC0+YXBwZW5kKENTU1ZhbHVlUG9vbDo6c2luZ2xldG9uKCkuY3JlYXRlRm9udEZhbWlseVZh bHVlKGZhbWlseSkpOworICAgIGxpc3QtPmFwcGVuZChDU1NWYWx1ZVBvb2w6OnNpbmdsZXRvbigp LmNyZWF0ZUZvbnRGYW1pbHlWYWx1ZShmYW1pbHlOYW1lVG9Vc2UpKTsKICAgICBib29sIHN1Y2Nl c3MgPSBtX2JhY2tpbmctPnNldEZhbWlsaWVzKGxpc3QpOwogICAgIGlmICghc3VjY2VzcykKICAg ICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IFN5bnRheEVycm9yIH07CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvRm9udEZhY2UuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9Gb250RmFjZS5o CmluZGV4IDNkOWEwZWMxYzlhZGFhYzgyMWI2NzQwMWI4Nzk2ZWE3Y2I2NzhhZjYuLmYwNWE3ZWYw ODZmOWMzNWFkMTgyZDA1MmViNmQxNzc0Yzc4MTM5MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9Gb250RmFjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9Gb250RmFjZS5oCkBA IC01NSw3ICs1NSw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPEZvbnRGYWNlPiBjcmVhdGUo Q1NTRm9udEZhY2UmKTsKICAgICB2aXJ0dWFsIH5Gb250RmFjZSgpOwogCi0gICAgRXhjZXB0aW9u T3I8dm9pZD4gc2V0RmFtaWx5KGNvbnN0IFN0cmluZyYpOworICAgIEV4Y2VwdGlvbk9yPHZvaWQ+ IHNldEZhbWlseShEb2N1bWVudCYsIGNvbnN0IFN0cmluZyYpOwogICAgIEV4Y2VwdGlvbk9yPHZv aWQ+IHNldFN0eWxlKGNvbnN0IFN0cmluZyYpOwogICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IHNldFdl aWdodChjb25zdCBTdHJpbmcmKTsKICAgICBFeGNlcHRpb25Pcjx2b2lkPiBzZXRTdHJldGNoKGNv bnN0IFN0cmluZyYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0ZvbnRGYWNlLmlk bCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9Gb250RmFjZS5pZGwKaW5kZXggOWFmNzIxNDc1ODc3ZDE2 NDFiZDE4OTM1MGFlNjg1YzhlNzUxNDZhOC4uMjAwMmQzMzhmMzA3MGVkOTNmMmIzMzg2ZmYzZjA4 Y2ZlMDBmNDJlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0ZvbnRGYWNlLmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvRm9udEZhY2UuaWRsCkBAIC00Nyw3ICs0Nyw3IEBAIGRp Y3Rpb25hcnkgRm9udEZhY2VEZXNjcmlwdG9ycyB7CiAgICAgQ29uc3RydWN0b3JNYXlUaHJvd0V4 Y2VwdGlvbiwKICAgICBDb25zdHJ1Y3RvcihET01TdHJpbmcgZmFtaWx5LCAoRE9NU3RyaW5nIG9y IEJpbmFyeURhdGEpIHNvdXJjZSwgb3B0aW9uYWwgRm9udEZhY2VEZXNjcmlwdG9ycyBkZXNjcmlw dG9ycykKIF0gaW50ZXJmYWNlIEZvbnRGYWNlIHsKLSAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIGZh bWlseTsKKyAgICBbU2V0dGVyQ2FsbFdpdGg9RG9jdW1lbnRdIGF0dHJpYnV0ZSBET01TdHJpbmcg ZmFtaWx5OwogICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgc3R5bGU7CiAgICAgYXR0cmlidXRlIERP TVN0cmluZyB3ZWlnaHQ7CiAgICAgYXR0cmlidXRlIERPTVN0cmluZyBzdHJldGNoOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9RdWlya3MuY3BwCmluZGV4IDk4MDQ2YjQ2YzZhZDhkMTg2OTZhYzY2NmU0N2EyZWJkNTU2OTJk NTYuLjRiMzFmZDhjMTVhMzc5YmVmOTRiYjUwMjYwMjJmZjRlYzAxNGZmOTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L1F1aXJrcy5jcHAKQEAgLTEzNSw2ICsxMzUsMTUgQEAgYm9vbCBRdWlya3M6Omhhc0Jyb2tlbkVu Y3J5cHRlZE1lZGlhQVBJU3VwcG9ydFF1aXJrKCkgY29uc3QKICAgICByZXR1cm4gbV9oYXNCcm9r ZW5FbmNyeXB0ZWRNZWRpYUFQSVN1cHBvcnRRdWlyay52YWx1ZSgpOwogfQogCitib29sIFF1aXJr czo6c2hvdWxkU3RyaXBRdW90YXRpb25NYXJrSW5Gb250RmFjZVNldEZhbWlseSgpIGNvbnN0Cit7 CisgICAgaWYgKCFuZWVkc1F1aXJrcygpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBh dXRvIGhvc3QgPSBtX2RvY3VtZW50LT50b3BEb2N1bWVudCgpLnVybCgpLmhvc3QoKTsKKyAgICBy ZXR1cm4gZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgImRvY3MuZ29vZ2xlLmNv bSIpOworfQorCiBib29sIFF1aXJrczo6aXNUb3VjaEJhclVwZGF0ZVN1cHJlc3NlZEZvckhpZGRl bkNvbnRlbnRFZGl0YWJsZSgpIGNvbnN0CiB7CiAjaWYgUExBVEZPUk0oTUFDKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVp cmtzLmgKaW5kZXggNGMyMDA3MGFjMGI1ZTM1YWVmNGRlYmUxMmI4ODFlMmMxMDQ3YjdkNi4uMWRj NTI3Zjc0YTA1MDQ5N2FlMTk1YTUyYzMyNzJiNmFiMzMwMWVhMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9RdWlya3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5o CkBAIC00OCw2ICs0OCw3IEBAIHB1YmxpYzoKICAgICBib29sIG5lZWRzUGVyRG9jdW1lbnRBdXRv cGxheUJlaGF2aW9yKCkgY29uc3Q7CiAgICAgYm9vbCBzaG91bGRBdXRvcGxheUZvckFyYml0cmFy eVVzZXJHZXN0dXJlKCkgY29uc3Q7CiAgICAgYm9vbCBoYXNCcm9rZW5FbmNyeXB0ZWRNZWRpYUFQ SVN1cHBvcnRRdWlyaygpIGNvbnN0OworICAgIGJvb2wgc2hvdWxkU3RyaXBRdW90YXRpb25NYXJr SW5Gb250RmFjZVNldEZhbWlseSgpIGNvbnN0OwogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAg ICAgYm9vbCBzaG91bGREaXNwYXRjaFNpbXVsYXRlZE1vdXNlRXZlbnRzKCkgY29uc3Q7CiAgICAg Ym9vbCBzaG91bGREaXNwYXRjaGVkU2ltdWxhdGVkTW91c2VFdmVudHNBc3N1bWVEZWZhdWx0UHJl dmVudGVkKEV2ZW50VGFyZ2V0KikgY29uc3Q7Cg==