200101 2019-07-24 17:05:03 -0700 Remove some unused code. 2019-07-24 17:14:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1555580 0 mark.lam 2019-07-24 17:05:03 -0700 MarkedBlock::Handle::zap() and SlotVisitor::appendToMutatorMarkStack() is no longer called from anywhere. 1555581 1 374836 mark.lam 2019-07-24 17:06:49 -0700 Created attachment 374836 proposed patch. 1555582 2 374836 ysuzuki 2019-07-24 17:08:26 -0700 Comment on attachment 374836 proposed patch. r=me 1555583 3 mark.lam 2019-07-24 17:11:27 -0700 Thanks for the review. Landed in r247801: <http://trac.webkit.org/r247801>. 1555584 4 webkit-bug-importer 2019-07-24 17:14:23 -0700 <rdar://problem/53520407> 374836 2019-07-24 17:06:49 -0700 2019-07-24 17:08:26 -0700 proposed patch. bug-200101.patch text/plain 3974 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ3ODAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE5LTA3LTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgc29tZSB1bnVzZWQgY29kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMDEwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaGVhcC9NYXJrZWRCbG9jay5jcHA6CisgICAgICAgIChKU0M6Ok1h cmtlZEJsb2NrOjpIYW5kbGU6OnphcCk6IERlbGV0ZWQuCisgICAgICAgICogaGVhcC9NYXJrZWRC bG9jay5oOgorICAgICAgICAqIGhlYXAvU2xvdFZpc2l0b3IuY3BwOgorICAgICAgICAoSlNDOjpT bG90VmlzaXRvcjo6YXBwZW5kVG9NdXRhdG9yTWFya1N0YWNrKTogRGVsZXRlZC4KKyAgICAgICAg KiBoZWFwL1Nsb3RWaXNpdG9yLmg6CisKIDIwMTktMDctMjQgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIHBlcmZvcm1KSVRNZW1jcHkgc2hvdWxkIGJlIFBBQ2VkIHdp dGggYSBub24temVybyBkaXZlcnNpZmllciB3aGVuIHBhc3NlZCBhbmQgY2FsbGVkIHZpYSBhIHBv aW50ZXIuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suY3Bw CShyZXZpc2lvbiAyNDc3OTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRC bG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0 IChDKSAyMDExLTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJp Z2h0IChDKSAyMDExLTIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAq IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg b3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQg dGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0yMDUsMTUgKzIwNSw2IEBAIHZvaWQgTWFya2Vk QmxvY2s6OkhhbmRsZTo6cmVzdW1lQWxsb2NhdGkKICAgICBzd2VlcCgmZnJlZUxpc3QpOwogfQog Ci12b2lkIE1hcmtlZEJsb2NrOjpIYW5kbGU6OnphcChjb25zdCBGcmVlTGlzdCYgZnJlZUxpc3Qp Ci17Ci0gICAgZnJlZUxpc3QuZm9yRWFjaCgKLSAgICAgICAgWyZdIChIZWFwQ2VsbCogY2VsbCkg ewotICAgICAgICAgICAgaWYgKG1fYXR0cmlidXRlcy5kZXN0cnVjdGlvbiA9PSBOZWVkc0Rlc3Ry dWN0aW9uKQotICAgICAgICAgICAgICAgIGNlbGwtPnphcCgpOwotICAgICAgICB9KTsKLX0KLQog dm9pZCBNYXJrZWRCbG9jazo6YWJvdXRUb01hcmtTbG93KEhlYXBWZXJzaW9uIG1hcmtpbmdWZXJz aW9uKQogewogICAgIEFTU0VSVCh2bSgpLT5oZWFwLm9iamVjdFNwYWNlKCkuaXNNYXJraW5nKCkp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2VkQmxvY2suaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5oCShyZXZpc2lv biAyNDc3OTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRCbG9jay5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogLyoKICAqICBDb3B5cmlnaHQgKEMpIDE5OTkt MjAwMCBIYXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3JnKQogICogIENvcHlyaWdodCAoQykgMjAw MSBQZXRlciBLZWxseSAocG1rQHBvc3QuY29tKQotICogIENvcHlyaWdodCAoQykgMjAwMy0yMDE4 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMDMt MjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogIFRoaXMgbGlicmFy eSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBt b2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGlj CkBAIC0xNDYsOCArMTQ2LDYgQEAgcHVibGljOgogICAgICAgICAKICAgICAgICAgdm9pZCB1bnN3 ZWVwV2l0aE5vTmV3bHlBbGxvY2F0ZWQoKTsKICAgICAgICAgCi0gICAgICAgIHZvaWQgemFwKGNv bnN0IEZyZWVMaXN0Jik7Ci0gICAgICAgIAogICAgICAgICB2b2lkIHNocmluaygpOwogICAgICAg ICAgICAgCiAgICAgICAgIHZvaWQgdmlzaXRXZWFrU2V0KFNsb3RWaXNpdG9yJik7CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TbG90VmlzaXRvci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU2xvdFZpc2l0b3IuY3BwCShyZXZpc2lvbiAyNDc3 OTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9TbG90VmlzaXRvci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI5NiwxMSArMjk2LDYgQEAgQUxXQVlTX0lOTElORSB2b2lkIFNsb3RWaXNp dG9yOjphcHBlbmRUbwogICAgIG1fY29sbGVjdG9yU3RhY2suYXBwZW5kKGNlbGwpOwogfQogCi12 b2lkIFNsb3RWaXNpdG9yOjphcHBlbmRUb011dGF0b3JNYXJrU3RhY2soY29uc3QgSlNDZWxsKiBj ZWxsKQotewotICAgIG1fbXV0YXRvclN0YWNrLmFwcGVuZChjZWxsKTsKLX0KLQogdm9pZCBTbG90 VmlzaXRvcjo6bWFya0F1eGlsaWFyeShjb25zdCB2b2lkKiBiYXNlKQogewogICAgIEhlYXBDZWxs KiBjZWxsID0gYml0d2lzZV9jYXN0PEhlYXBDZWxsKj4oYmFzZSk7CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaGVhcC9TbG90VmlzaXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL1Nsb3RWaXNpdG9yLmgJKHJldmlzaW9uIDI0Nzc5OCkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1Nsb3RWaXNpdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTEs NSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDExLTIwMTggQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDExLTIwMTkgQXBwbGUgSW5jLiBB bGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBh cmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0y MTEsOCArMjExLDYgQEAgcHJpdmF0ZToKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBDb250YWluZXJU eXBlPgogICAgIHZvaWQgYXBwZW5kVG9NYXJrU3RhY2soQ29udGFpbmVyVHlwZSYsIEpTQ2VsbCop OwogICAgIAotICAgIHZvaWQgYXBwZW5kVG9NdXRhdG9yTWFya1N0YWNrKGNvbnN0IEpTQ2VsbCop OwotICAgIAogICAgIHZvaWQgbm90ZUxpdmVBdXhpbGlhcnlDZWxsKEhlYXBDZWxsKik7CiAgICAg CiAgICAgdm9pZCB2aXNpdENoaWxkcmVuKGNvbnN0IEpTQ2VsbCopOwo=