200100 2019-07-24 16:22:17 -0700 performJITMemcpy should be PACed with a non-zero diversifier when passed and called via a pointer. 2019-07-24 16:51:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1555553 0 mark.lam 2019-07-24 16:22:17 -0700 <rdar://problem/53474939> 1555559 1 374831 mark.lam 2019-07-24 16:34:06 -0700 Created attachment 374831 proposed patch. 1555564 2 374831 ysuzuki 2019-07-24 16:39:17 -0700 Comment on attachment 374831 proposed patch. r=me 1555577 3 mark.lam 2019-07-24 16:51:54 -0700 Thanks for the review. Landed in r247799: <http://trac.webkit.org/r247799>. 374831 2019-07-24 16:34:06 -0700 2019-07-24 16:39:17 -0700 proposed patch. bug-200100.patch text/plain 6997 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ3Nzk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBA CisyMDE5LTA3LTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBw ZXJmb3JtSklUTWVtY3B5IHNob3VsZCBiZSBQQUNlZCB3aXRoIGEgbm9uLXplcm8gZGl2ZXJzaWZp ZXIgd2hlbiBwYXNzZWQgYW5kIGNhbGxlZCB2aWEgYSBwb2ludGVyLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMTAwCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81MzQ3NDkzOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGFzc2VtYmxlci9BUk02NEFzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpB Uk02NEFzc2VtYmxlcjo6Q29weUZ1bmN0aW9uOjpDb3B5RnVuY3Rpb24pOgorICAgICAgICAoSlND OjpBUk02NEFzc2VtYmxlcjo6Q29weUZ1bmN0aW9uOjpvcGVyYXRvcigpKToKKyAgICAgICAgLSBJ IGNob29zZSB0byB1c2UgcHRyYXV0aF9hdXRoX2Z1bmN0aW9uKCkgaGVyZSBpbnN0ZWFkIG9mIHJl dGFnQ29kZVB0cigpIGJlY2F1c2UKKyAgICAgICAgICByZXRhZ0NvZGVQdHIoKSB3b3VsZCBhdXRo LCBhc3NlcnQsIGFuZCByZS1wYWMgdGhlIHBvaW50ZXIuICBUaGlzIGlzIG5lZWRlZCBpbgorICAg ICAgICAgIGdlbmVyYWwgYmVjYXVzZSByZXRhZ0NvZGVQdHIoKSBkb2Vzbid0IGtub3cgdGhhdCB5 b3Ugd2lsbCBjb25zdW1lIHRoZSBwb2ludGVyCisgICAgICAgICAgaW1tZWRpYXRlbHkgKGFuZCB0 aGVyZWZvcmUgY3Jhc2ggaW1taW5lbnRseSBpZiBhIGZhaWxlZCBhdXRoIGlzIGVuY291bnRlcmVk KS4KKyAgICAgICAgICBTaW5jZSB3ZSBrbm93IGhlcmUgdGhhdCB3ZSB3aWxsIGNhbGwgd2l0aCB0 aGUgYXV0aCdlZCBwb2ludGVyIGltbWVkaWF0ZWx5LCB3ZQorICAgICAgICAgIGNhbiBza2lwIHRo ZSBhc3NlcnQuCisKKyAgICAgICAgICBUaGlzIGFsc28gaGFzIHRoZSBiZW5lZml0IG9mIGxldHRp bmcgQ2xhbmcgZG8gYSBwZWVwaG9sZSBvcHRpbWl6YXRpb24gdG8gZW1pdAorICAgICAgICAgIGEg YmxyYWIgaW5zdHJ1Y3Rpb24gd2l0aCB0aGUgaW50ZW5kZWQgZGl2ZXJzaWZpZXIsIGluc3RlYWQg b2YgZW1pdHRpbmcgbXVsdGlwbGUKKyAgICAgICAgICBpbnN0cnVjdGlvbnMgdG8gYXV0aCB0aGUg cG9pbnRlciBpbnRvIGEgQyBmdW5jdGlvbiwgYW5kIHRoZW4gdXNpbmcgYSBibHJhYXogdG8KKyAg ICAgICAgICBkbyBhIEMgZnVuY3Rpb24gY2FsbC4KKworICAgICAgICAoSlNDOjpBUk02NEFzc2Vt Ymxlcjo6bGlua0p1bXBPckNhbGwpOgorICAgICAgICAoSlNDOjpBUk02NEFzc2VtYmxlcjo6bGlu a0NvbXBhcmVBbmRCcmFuY2gpOgorICAgICAgICAoSlNDOjpBUk02NEFzc2VtYmxlcjo6bGlua0Nv bmRpdGlvbmFsQnJhbmNoKToKKyAgICAgICAgKEpTQzo6QVJNNjRBc3NlbWJsZXI6OmxpbmtUZXN0 QW5kQnJhbmNoKToKKyAgICAgICAgKiBhc3NlbWJsZXIvTGlua0J1ZmZlci5jcHA6CisgICAgICAg IChKU0M6OkxpbmtCdWZmZXI6OmNvcHlDb21wYWN0QW5kTGlua0NvZGUpOgorICAgICAgICAqIHJ1 bnRpbWUvSlNDUHRyVGFnLmg6CisKIDIwMTktMDctMjQgIERldmluIFJvdXNzbyAgPGRyb3Vzc29A YXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHByaW50IHRoZSB0YXJnZXQgb2Yg YGNvbnNvbGUuc2NyZWVuc2hvdGAgbGFzdCBzbyB0aGUgdGFyZ2V0IGlzIHRoZSBjbG9zZXN0IGl0 ZW0gdG8gdGhlIGltYWdlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FS TTY0QXNzZW1ibGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9BUk02NEFzc2VtYmxlci5oCShyZXZpc2lvbiAyNDc3ODQpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL0FSTTY0QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEs NSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDEyLTIwMTggQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEyLTIwMTkgQXBwbGUgSW5jLiBB bGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBh cmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0y OTEwLDcgKzI5MTAsMjcgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gbV9qdW1wc1RvTGluazsK ICAgICB9CiAKKyNpZiBDUFUoQVJNNjRFKQorICAgIGNsYXNzIENvcHlGdW5jdGlvbiB7CisgICAg ICAgIHR5cGVkZWYgdm9pZCogKCpGdW5jKSh2b2lkKiwgY29uc3Qgdm9pZCosIHNpemVfdCk7Cisg ICAgcHVibGljOgorICAgICAgICBDb3B5RnVuY3Rpb24oRnVuYyBmdW5jKQorICAgICAgICAgICAg OiBtX2Z1bmMoZnVuYykKKyAgICAgICAgeworICAgICAgICAgICAgYXNzZXJ0SXNOdWxsT3JUYWdn ZWRXaXRoKGZ1bmMsIENvcHlGdW5jdGlvblB0clRhZyk7CisgICAgICAgIH0KKworICAgICAgICB2 b2lkKiBvcGVyYXRvcigpKHZvaWQqIGRzdCwgY29uc3Qgdm9pZCogc3JjLCBzaXplX3Qgc2l6ZSkK KyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJuIHB0cmF1dGhfYXV0aF9mdW5jdGlvbihtX2Z1 bmMsIHB0cmF1dGhfa2V5X3Byb2Nlc3NfZGVwZW5kZW50X2NvZGUsIENvcHlGdW5jdGlvblB0clRh ZykoZHN0LCBzcmMsIHNpemUpOworICAgICAgICB9CisKKyAgICBwcml2YXRlOgorICAgICAgICBG dW5jIG1fZnVuYzsKKyAgICB9OworI2Vsc2UKICAgICB0eXBlZGVmIHZvaWQqICgqQ29weUZ1bmN0 aW9uKSh2b2lkKiwgY29uc3Qgdm9pZCosIHNpemVfdCk7CisjZW5kaWYKIAogICAgIHN0YXRpYyB2 b2lkIEFMV0FZU19JTkxJTkUgbGluayhMaW5rUmVjb3JkJiByZWNvcmQsIHVpbnQ4X3QqIGZyb20s IGNvbnN0IHVpbnQ4X3QqIGZyb21JbnN0cnVjdGlvbjgsIHVpbnQ4X3QqIHRvLCBDb3B5RnVuY3Rp b24gY29weSkKICAgICB7CkBAIC0yOTc3LDcgKzI5OTcsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgfQog CiAgICAgdGVtcGxhdGU8Ym9vbCBpc0NhbGw+Ci0gICAgc3RhdGljIHZvaWQgbGlua0p1bXBPckNh bGwoaW50KiBmcm9tLCBjb25zdCBpbnQqIGZyb21JbnN0cnVjdGlvbiwgdm9pZCogdG8sIENvcHlG dW5jdGlvbiBjb3B5ID0gcGVyZm9ybUpJVE1lbWNweSkKKyAgICBzdGF0aWMgdm9pZCBsaW5rSnVt cE9yQ2FsbChpbnQqIGZyb20sIGNvbnN0IGludCogZnJvbUluc3RydWN0aW9uLCB2b2lkKiB0bywg Q29weUZ1bmN0aW9uIGNvcHkgPSB0YWdDRnVuY3Rpb25QdHI8Q29weUZ1bmN0aW9uUHRyVGFnPihw ZXJmb3JtSklUTWVtY3B5KSkKICAgICB7CiAgICAgICAgIGJvb2wgbGluazsKICAgICAgICAgaW50 IGltbTI2OwpAQCAtMjk5OCw3ICszMDE4LDcgQEAgcHJvdGVjdGVkOgogICAgIH0KIAogICAgIHRl bXBsYXRlPGJvb2wgaXNEaXJlY3Q+Ci0gICAgc3RhdGljIHZvaWQgbGlua0NvbXBhcmVBbmRCcmFu Y2goQ29uZGl0aW9uIGNvbmRpdGlvbiwgYm9vbCBpczY0Qml0LCBSZWdpc3RlcklEIHJ0LCBpbnQq IGZyb20sIGNvbnN0IGludCogZnJvbUluc3RydWN0aW9uLCB2b2lkKiB0bywgQ29weUZ1bmN0aW9u IGNvcHkgPSBwZXJmb3JtSklUTWVtY3B5KQorICAgIHN0YXRpYyB2b2lkIGxpbmtDb21wYXJlQW5k QnJhbmNoKENvbmRpdGlvbiBjb25kaXRpb24sIGJvb2wgaXM2NEJpdCwgUmVnaXN0ZXJJRCBydCwg aW50KiBmcm9tLCBjb25zdCBpbnQqIGZyb21JbnN0cnVjdGlvbiwgdm9pZCogdG8sIENvcHlGdW5j dGlvbiBjb3B5ID0gdGFnQ0Z1bmN0aW9uUHRyPENvcHlGdW5jdGlvblB0clRhZz4ocGVyZm9ybUpJ VE1lbWNweSkpCiAgICAgewogICAgICAgICBBU1NFUlQoIShyZWludGVycHJldF9jYXN0PGludHB0 cl90Pihmcm9tKSAmIDMpKTsKICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRfY2FzdDxpbnRw dHJfdD4odG8pICYgMykpOwpAQCAtMzAyNiw3ICszMDQ2LDcgQEAgcHJvdGVjdGVkOgogICAgIH0K IAogICAgIHRlbXBsYXRlPGJvb2wgaXNEaXJlY3Q+Ci0gICAgc3RhdGljIHZvaWQgbGlua0NvbmRp dGlvbmFsQnJhbmNoKENvbmRpdGlvbiBjb25kaXRpb24sIGludCogZnJvbSwgY29uc3QgaW50KiBm cm9tSW5zdHJ1Y3Rpb24sIHZvaWQqIHRvLCBDb3B5RnVuY3Rpb24gY29weSA9IHBlcmZvcm1KSVRN ZW1jcHkpCisgICAgc3RhdGljIHZvaWQgbGlua0NvbmRpdGlvbmFsQnJhbmNoKENvbmRpdGlvbiBj b25kaXRpb24sIGludCogZnJvbSwgY29uc3QgaW50KiBmcm9tSW5zdHJ1Y3Rpb24sIHZvaWQqIHRv LCBDb3B5RnVuY3Rpb24gY29weSA9IHRhZ0NGdW5jdGlvblB0cjxDb3B5RnVuY3Rpb25QdHJUYWc+ KHBlcmZvcm1KSVRNZW1jcHkpKQogICAgIHsKICAgICAgICAgQVNTRVJUKCEocmVpbnRlcnByZXRf Y2FzdDxpbnRwdHJfdD4oZnJvbSkgJiAzKSk7CiAgICAgICAgIEFTU0VSVCghKHJlaW50ZXJwcmV0 X2Nhc3Q8aW50cHRyX3Q+KHRvKSAmIDMpKTsKQEAgLTMwNTQsNyArMzA3NCw3IEBAIHByb3RlY3Rl ZDoKICAgICB9CiAKICAgICB0ZW1wbGF0ZTxib29sIGlzRGlyZWN0PgotICAgIHN0YXRpYyB2b2lk IGxpbmtUZXN0QW5kQnJhbmNoKENvbmRpdGlvbiBjb25kaXRpb24sIHVuc2lnbmVkIGJpdE51bWJl ciwgUmVnaXN0ZXJJRCBydCwgaW50KiBmcm9tLCBjb25zdCBpbnQqIGZyb21JbnN0cnVjdGlvbiwg dm9pZCogdG8sIENvcHlGdW5jdGlvbiBjb3B5ID0gcGVyZm9ybUpJVE1lbWNweSkKKyAgICBzdGF0 aWMgdm9pZCBsaW5rVGVzdEFuZEJyYW5jaChDb25kaXRpb24gY29uZGl0aW9uLCB1bnNpZ25lZCBi aXROdW1iZXIsIFJlZ2lzdGVySUQgcnQsIGludCogZnJvbSwgY29uc3QgaW50KiBmcm9tSW5zdHJ1 Y3Rpb24sIHZvaWQqIHRvLCBDb3B5RnVuY3Rpb24gY29weSA9IHRhZ0NGdW5jdGlvblB0cjxDb3B5 RnVuY3Rpb25QdHJUYWc+KHBlcmZvcm1KSVRNZW1jcHkpKQogICAgIHsKICAgICAgICAgQVNTRVJU KCEocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oZnJvbSkgJiAzKSk7CiAgICAgICAgIEFTU0VS VCghKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRvKSAmIDMpKTsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTGlua0J1ZmZlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9MaW5rQnVmZmVyLmNwcAkocmV2aXNpb24gMjQ3 Nzg0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9MaW5rQnVmZmVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjI4LDEzICsyMjgsMTIgQEAgdm9pZCBMaW5rQnVmZmVyOjpjb3B5 Q29tcGFjdEFuZExpbmtDb2RlKAogCiAgICAgcmVjb3JkTGlua09mZnNldHMobV9hc3NlbWJsZXJT dG9yYWdlLCByZWFkUHRyLCBpbml0aWFsU2l6ZSwgcmVhZFB0ciAtIHdyaXRlUHRyKTsKICAgICAg ICAgCi0gICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGp1bXBDb3VudDsgKytpKSB7CiAjaWYg Q1BVKEFSTTY0RSkgJiYgRU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKQotICAgICAgICBhdXRv IG1lbWNweUZ1bmN0aW9uID0gbWVtY3B5OworICAgIGF1dG8gbWVtY3B5RnVuY3Rpb24gPSB0YWdD RnVuY3Rpb25QdHI8Q29weUZ1bmN0aW9uUHRyVGFnPihtZW1jcHkpOwogI2Vsc2UKLSAgICAgICAg YXV0byBtZW1jcHlGdW5jdGlvbiA9IHBlcmZvcm1KSVRNZW1jcHk7CisgICAgYXV0byBtZW1jcHlG dW5jdGlvbiA9IHRhZ0NGdW5jdGlvblB0cjxDb3B5RnVuY3Rpb25QdHJUYWc+KHBlcmZvcm1KSVRN ZW1jcHkpOwogI2VuZGlmCi0KKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwganVtcENvdW50 OyArK2kpIHsKICAgICAgICAgdWludDhfdCogbG9jYXRpb24gPSBjb2RlT3V0RGF0YSArIGp1bXBz VG9MaW5rW2ldLmZyb20oKTsKICAgICAgICAgdWludDhfdCogdGFyZ2V0ID0gY29kZU91dERhdGEg KyBqdW1wc1RvTGlua1tpXS50bygpIC0gZXhlY3V0YWJsZU9mZnNldEZvcihqdW1wc1RvTGlua1tp XS50bygpKTsKICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6OmxpbmsoanVtcHNUb0xpbmtbaV0sIG91 dERhdGEgKyBqdW1wc1RvTGlua1tpXS5mcm9tKCksIGxvY2F0aW9uLCB0YXJnZXQsIG1lbWNweUZ1 bmN0aW9uKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ1B0clRhZy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ1B0clRhZy5o CShyZXZpc2lvbiAyNDc3ODQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NQ dHJUYWcuaAkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUsNyBAQCB1c2luZyBQdHJUYWcgPSBX VEY6OlB0clRhZzsKICAgICB2KEIzQ0NhbGxQdHJUYWcpIFwKICAgICB2KEIzQ29tcGlsYXRpb25Q dHJUYWcpIFwKICAgICB2KEJ5dGVjb2RlUHRyVGFnKSBcCisgICAgdihDb3B5RnVuY3Rpb25QdHJU YWcpIFwKICAgICB2KERpc2Fzc2VtYmx5UHRyVGFnKSBcCiAgICAgdihFeGNlcHRpb25IYW5kbGVy UHRyVGFnKSBcCiAgICAgdihFeGVjdXRhYmxlTWVtb3J5UHRyVGFnKSBcCg==