20008 2008-07-11 04:55:46 -0700 -webkit-transform should have good initial value 2008-07-18 15:11:29 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dino simon.fraser simon.fraser oldest_to_newest 85773 0 dino 2008-07-11 04:55:46 -0700 See http://build.webkit.org/results/trunk-mac-ppc-release/13642/fast/css/computed-style-without-renderer-actual.txt (ignore that the test says it is failing in that report) -webkit-transform doesn't have a nice value when a parent of display none. 86141 1 simon.fraser 2008-07-16 20:53:19 -0700 It should return "none" in this case I think (as should an untransformed element). 86143 2 22329 simon.fraser 2008-07-16 21:19:53 -0700 Created attachment 22329 Patch This patch also fixes getComputedStyle() to return 'none' for elements with no tranform (previously, it would return an identity matrix). 86264 3 22349 dino 2008-07-17 12:47:18 -0700 Created attachment 22349 Updated patch (includes test changes) 86358 4 22349 hyatt 2008-07-18 12:17:23 -0700 Comment on attachment 22349 Updated patch (includes test changes) Remove the braces from + if (!renderer || renderer->style()->transform().isEmpty()) { + return CSSPrimitiveValue::createIdentifier(CSSValueNone); + } r=me 86389 5 simon.fraser 2008-07-18 15:11:29 -0700 Fixed in r35239. 22329 2008-07-16 21:19:53 -0700 2008-07-18 12:16:19 -0700 Patch patch_20008.txt text/plain 1545 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTRmMzRkMy4uOGNjNmJjYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAwOC0wNy0xNiAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBnZXRDb21wdXRlZFN0eWxlKCkgZm9yIC13ZWJraXQtdHJhbnNm b3JtIHNob3VsZCByZXR1cm4gCisgICAgICAgICdub25lJyBmb3IgZWxlbWVudHMgd2l0aCBubyBy ZW5kZXJlciwgb3IgdGhvc2Ugd2l0aCBubworICAgICAgICB0cmFuc2Zvcm0uCisgICAgICAgIAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMDgKKyAg ICAgICAgCisgICAgICAgIAorICAgICAgICAqIGNzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRp b24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29tcHV0ZWRUcmFuc2Zvcm0pOgorCisyMDA4LTA3 LTE2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmUgSHlhdHQKIAogICAgICAgICBBbmltYXRpb25Db250cm9sbGVyIG5lZWRz IHRvIGFkanVzdCB6LWluZGV4IGluIHRoZSBibGVuZGVkCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nz cy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwIGIvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0 ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAppbmRleCAxMzY1Mjk1Li5mZDdiYWEyIDEwMDY0NAotLS0g YS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCisrKyBiL1dlYkNv cmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKQEAgLTM4NywxMSArMzg3LDEy IEBAIHN0YXRpYyBJbnRSZWN0IHNpemluZ0JveChSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogICAg IHJldHVybiByZW5kZXJlci0+c3R5bGUoKS0+Ym94U2l6aW5nKCkgPT0gQ09OVEVOVF9CT1ggPyBy ZW5kZXJlci0+Y29udGVudEJveCgpIDogcmVuZGVyZXItPmJvcmRlckJveCgpOwogfQogCi1zdGF0 aWMgUGFzc1JlZlB0cjxDU1NWYWx1ZUxpc3Q+IGNvbXB1dGVkVHJhbnNmb3JtKFJlbmRlck9iamVj dCogcmVuZGVyZXIpCitzdGF0aWMgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gY29tcHV0ZWRUcmFuc2Zv cm0oUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKIHsKLSAgICBpZiAoIXJlbmRlcmVyKQotICAgICAg ICByZXR1cm4gMDsKLQorICAgIGlmICghcmVuZGVyZXIgfHwgcmVuZGVyZXItPnN0eWxlKCktPnRy YW5zZm9ybSgpLmlzRW1wdHkoKSkgeworICAgICAgICByZXR1cm4gQ1NTUHJpbWl0aXZlVmFsdWU6 OmNyZWF0ZUlkZW50aWZpZXIoQ1NTVmFsdWVOb25lKTsKKyAgICB9CisgICAgCiAgICAgSW50UmVj dCBib3ggPSBzaXppbmdCb3gocmVuZGVyZXIpOwogCiAgICAgQWZmaW5lVHJhbnNmb3JtIHRyYW5z Zm9ybTsK 22349 2008-07-17 12:47:18 -0700 2008-07-18 12:17:23 -0700 Updated patch (includes test changes) smfr.patch text/plain 2882 dino ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYTI1YzljLi5mMWVhYWI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDct MTcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZ2V0Q29tcHV0ZWRTdHlsZSgpIGZv ciAtd2Via2l0LXRyYW5zZm9ybSBzaG91bGQgcmV0dXJuIAorICAgICAgICAnbm9uZScgZm9yIGVs ZW1lbnRzIHdpdGggbm8gcmVuZGVyZXIsIG9yIHRob3NlIHdpdGggbm8KKyAgICAgICAgdHJhbnNm b3JtLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDAwOAorCisgICAgICAgICogZmFzdC9jc3MvY29tcHV0ZWQtc3R5bGUtd2l0aG91dC1yZW5kZXJl ci1leHBlY3RlZC50eHQ6CisKIDIwMDgtMDctMTYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSHlhdHQuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9jb21wdXRlZC1zdHlsZS13aXRob3V0LXJlbmRlcmVyLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2NvbXB1dGVkLXN0eWxlLXdpdGhvdXQtcmVu ZGVyZXItZXhwZWN0ZWQudHh0CmluZGV4IDczMWJlOTkuLmI3NWNhZjcgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL2Zhc3QvY3NzL2NvbXB1dGVkLXN0eWxlLXdpdGhvdXQtcmVuZGVyZXItZXhwZWN0 ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2NvbXB1dGVkLXN0eWxlLXdpdGhvdXQt cmVuZGVyZXItZXhwZWN0ZWQudHh0CkBAIC0xMzQsNyArMTM0LDcgQEAgQ29tcHV0ZWQgc3R5bGUg b2YgYW4gZWxlbWVudCB3aG9zZSBwYXJlbnQncyAnZGlzcGxheScgdmFsdWUgaXMgJ25vbmUnOgog ICAgIC13ZWJraXQtdGV4dC1zZWN1cml0eTogbm9uZQogICAgIC13ZWJraXQtdGV4dC1zdHJva2Ut Y29sb3I6IHJnYigwLCAwLCAwKQogICAgIC13ZWJraXQtdGV4dC1zdHJva2Utd2lkdGg6IDBweAot ICAgIC13ZWJraXQtdHJhbnNmb3JtOiAKKyAgICAtd2Via2l0LXRyYW5zZm9ybTogbm9uZQogICAg IC13ZWJraXQtdHJhbnNmb3JtLW9yaWdpbi14OiA1MCUKICAgICAtd2Via2l0LXRyYW5zZm9ybS1v cmlnaW4teTogNTAlCiAgICAgLXdlYmtpdC11c2VyLWRyYWc6IGF1dG8KZGlmZiAtLWdpdCBhL1dl YkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDFkOWRjYy4uNDAyYTUz NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxOCBAQAorMjAwOC0wNy0xNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBnZXRDb21wdXRlZFN0eWxlKCkgZm9yIC13ZWJraXQtdHJhbnNmb3JtIHNob3VsZCByZXR1 cm4gCisgICAgICAgICdub25lJyBmb3IgZWxlbWVudHMgd2l0aCBubyByZW5kZXJlciwgb3IgdGhv c2Ugd2l0aCBubworICAgICAgICB0cmFuc2Zvcm0uCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDA4CisKKyAgICAgICAgVGVzdGNhc2U6IExheW91 dFRlc3RzL2Zhc3QvY3NzL2NvbXB1dGVkLXN0eWxlLXdpdGhvdXQtcmVuZGVyZXIKKworICAgICAg ICAqIGNzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Y29tcHV0ZWRUcmFuc2Zvcm0pOgorCiAyMDA4LTA3LTE3ICBEYXZpZCBIeWF0dCAgPGh5YXR0 QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHN1cmUgdGhlIGNoZWNrIHRvIHNlZSBpZiBhIGZy YW1lL2lmcmFtZSBpcyBiZWluZyByZW5kZXJlZCBpbnNpZGUgYSB0cmFuc3BhcmVuY3kgbGF5ZXIg aXMKZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5j cHAgYi9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCmluZGV4IDEz NjUyOTUuLmZkN2JhYTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVE ZWNsYXJhdGlvbi5jcHAKKysrIGIvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0 aW9uLmNwcApAQCAtMzg3LDExICszODcsMTIgQEAgc3RhdGljIEludFJlY3Qgc2l6aW5nQm94KFJl bmRlck9iamVjdCogcmVuZGVyZXIpCiAgICAgcmV0dXJuIHJlbmRlcmVyLT5zdHlsZSgpLT5ib3hT aXppbmcoKSA9PSBDT05URU5UX0JPWCA/IHJlbmRlcmVyLT5jb250ZW50Qm94KCkgOiByZW5kZXJl ci0+Ym9yZGVyQm94KCk7CiB9CiAKLXN0YXRpYyBQYXNzUmVmUHRyPENTU1ZhbHVlTGlzdD4gY29t cHV0ZWRUcmFuc2Zvcm0oUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKK3N0YXRpYyBQYXNzUmVmUHRy PENTU1ZhbHVlPiBjb21wdXRlZFRyYW5zZm9ybShSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogewot ICAgIGlmICghcmVuZGVyZXIpCi0gICAgICAgIHJldHVybiAwOwotCisgICAgaWYgKCFyZW5kZXJl ciB8fCByZW5kZXJlci0+c3R5bGUoKS0+dHJhbnNmb3JtKCkuaXNFbXB0eSgpKSB7CisgICAgICAg IHJldHVybiBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlSWRlbnRpZmllcihDU1NWYWx1ZU5vbmUp OworICAgIH0KKyAgICAKICAgICBJbnRSZWN0IGJveCA9IHNpemluZ0JveChyZW5kZXJlcik7CiAK ICAgICBBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtOwo=