200074 2019-07-24 00:09:10 -0700 [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined" 2019-07-24 19:05:16 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=131177 https://bugs.webkit.org/show_bug.cgi?id=140049 P2 Normal --- 1 fujii fujii clopez don.olmstead mcatanzaro ross.kirsling oldest_to_newest 1555324 0 fujii 2019-07-24 00:09:10 -0700 [CMake] CMAKE_SHARED_LINKER_FLAGS drops "-Wl,--no-undefined" Although WebKitCompilerFlags.cmake adds "-Wl,--no-undefined" CMAKE_SHARED_LINKER_FLAGS, I found it isn't effective (Bug 199625 Comment 24). OptionsCommon.cmake has a typo. > set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=lld -Wl,--disable-new-dtags") CMAKE_EXE_LINKER_FLAGS should be CMAKE_SHARED_LINKER_FLAGS. 1555327 1 fujii 2019-07-24 00:26:21 -0700 While working on this, I see an existing issue: > Tools/DumpRenderTree/TestNetscapePlugIn/CMakeFiles/TestNetscapePlugIn.dir/PluginTest.cpp.o:PluginTest.cpp:function PluginTest::indicateTestFailure(): error: undefined reference to 'WTF::sleep(WTF::Seconds)' 1555329 2 374767 fujii 2019-07-24 00:35:04 -0700 Created attachment 374767 Patch 1555330 3 fujii 2019-07-24 00:43:44 -0700 These code was added in Bug 131177 and Bug 140049. 1555628 4 374767 fujii 2019-07-24 19:05:12 -0700 Comment on attachment 374767 Patch Clearing flags on attachment: 374767 Committed r247810: <https://trac.webkit.org/changeset/247810> 1555629 5 fujii 2019-07-24 19:05:16 -0700 All reviewed patches have been landed. Closing bug. 374767 2019-07-24 00:35:04 -0700 2019-07-24 19:05:12 -0700 Patch bug-200074-20190724163503.patch text/plain 4704 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDliZGMzNmRkMDI3OWYzMGI5YWRkOGE4MWZmN2NhOTA1OTBiNzczYTAuLmE1NzRlZjhjMjIyYmEw NzIwZDIyYTFmZDVkNWM4MTUzYTRkY2Y3MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC02OSw5ICs2OSw5IEBAIENNQUtFX0RFUEVOREVOVF9PUFRJT04oVVNFX0xEX0xMRCAiVXNlIExM RCBsaW5rZXIiIE9OCiBpZiAoVVNFX0xEX0xMRCkKICAgICBleGVjdXRlX3Byb2Nlc3MoQ09NTUFO RCAke0NNQUtFX0NfQ09NUElMRVJ9IC1mdXNlLWxkPWxsZCAtV2wsLS12ZXJzaW9uIEVSUk9SX1FV SUVUIE9VVFBVVF9WQVJJQUJMRSBMRF9WRVJTSU9OKQogICAgIGlmICgiJHtMRF9WRVJTSU9OfSIg TUFUQ0hFUyAiTExEIikKLSAgICAgICAgc2V0KENNQUtFX0VYRV9MSU5LRVJfRkxBR1MgIiR7Q01B S0VfRVhFX0xJTktFUl9GTEFHU30gLWZ1c2UtbGQ9bGxkIC1XbCwtLWRpc2FibGUtbmV3LWR0YWdz IikKLSAgICAgICAgc2V0KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfRVhFX0xJ TktFUl9GTEFHU30gLWZ1c2UtbGQ9bGxkIC1XbCwtLWRpc2FibGUtbmV3LWR0YWdzIikKLSAgICAg ICAgc2V0KENNQUtFX01PRFVMRV9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfTU9EVUxFX0xJTktFUl9G TEFHU30gLWZ1c2UtbGQ9bGxkIC1XbCwtLWRpc2FibGUtbmV3LWR0YWdzIikKKyAgICAgICAgc3Ry aW5nKEFQUEVORCBDTUFLRV9FWEVfTElOS0VSX0ZMQUdTICIgLWZ1c2UtbGQ9bGxkIC1XbCwtLWRp c2FibGUtbmV3LWR0YWdzIikKKyAgICAgICAgc3RyaW5nKEFQUEVORCBDTUFLRV9TSEFSRURfTElO S0VSX0ZMQUdTICIgLWZ1c2UtbGQ9bGxkIC1XbCwtLWRpc2FibGUtbmV3LWR0YWdzIikKKyAgICAg ICAgc3RyaW5nKEFQUEVORCBDTUFLRV9NT0RVTEVfTElOS0VSX0ZMQUdTICIgLWZ1c2UtbGQ9bGxk IC1XbCwtLWRpc2FibGUtbmV3LWR0YWdzIikKICAgICBlbHNlICgpCiAgICAgICAgIHNldChVU0Vf TERfTExEIE9GRikKICAgICBlbmRpZiAoKQpAQCAtODMsOSArODMsOSBAQCBDTUFLRV9ERVBFTkRF TlRfT1BUSU9OKFVTRV9MRF9HT0xEICJVc2UgR05VIGdvbGQgbGlua2VyIiBPTgogaWYgKFVTRV9M RF9HT0xEKQogICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5EICR7Q01BS0VfQ19DT01QSUxFUn0g LWZ1c2UtbGQ9Z29sZCAtV2wsLS12ZXJzaW9uIEVSUk9SX1FVSUVUIE9VVFBVVF9WQVJJQUJMRSBM RF9WRVJTSU9OKQogICAgIGlmICgiJHtMRF9WRVJTSU9OfSIgTUFUQ0hFUyAiR05VIGdvbGQiKQot ICAgICAgICBzZXQoQ01BS0VfRVhFX0xJTktFUl9GTEFHUyAiJHtDTUFLRV9FWEVfTElOS0VSX0ZM QUdTfSAtZnVzZS1sZD1nb2xkIC1XbCwtLWRpc2FibGUtbmV3LWR0YWdzIikKLSAgICAgICAgc2V0 KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfRVhFX0xJTktFUl9GTEFHU30gLWZ1 c2UtbGQ9Z29sZCAtV2wsLS1kaXNhYmxlLW5ldy1kdGFncyIpCi0gICAgICAgIHNldChDTUFLRV9N T0RVTEVfTElOS0VSX0ZMQUdTICIke0NNQUtFX01PRFVMRV9MSU5LRVJfRkxBR1N9IC1mdXNlLWxk PWdvbGQgLVdsLC0tZGlzYWJsZS1uZXctZHRhZ3MiKQorICAgICAgICBzdHJpbmcoQVBQRU5EIENN QUtFX0VYRV9MSU5LRVJfRkxBR1MgIiAtZnVzZS1sZD1nb2xkIC1XbCwtLWRpc2FibGUtbmV3LWR0 YWdzIikKKyAgICAgICAgc3RyaW5nKEFQUEVORCBDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTICIg LWZ1c2UtbGQ9Z29sZCAtV2wsLS1kaXNhYmxlLW5ldy1kdGFncyIpCisgICAgICAgIHN0cmluZyhB UFBFTkQgQ01BS0VfTU9EVUxFX0xJTktFUl9GTEFHUyAiIC1mdXNlLWxkPWdvbGQgLVdsLC0tZGlz YWJsZS1uZXctZHRhZ3MiKQogICAgIGVsc2UgKCkKICAgICAgICAgbWVzc2FnZShXQVJOSU5HICJH TlUgZ29sZCBsaW5rZXIgaXNuJ3QgYXZhaWxhYmxlLCB1c2luZyB0aGUgZGVmYXVsdCBzeXN0ZW0g bGlua2VyLiIpCiAgICAgICAgIHNldChVU0VfTERfR09MRCBPRkYpCmRpZmYgLS1naXQgYS9Ub29s cy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWVkOWJhZDE2Zjg2N2Q3NGRhZGZi NTNiZjlmMjMwM2ZjYmEyYmM4YS4uZDI3NzY1YmJiNTMyMjc1MjE5NmE5M2NhODRlZWFjNzBiNWUx MWZmMiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDE5LTA3LTI0ICBGdWppaSBIaXJvbm9yaSAgPGZ1amlpLmhpcm9u b3JpQGdtYWlsLmNvbT4KKworICAgICAgICBbQ01ha2VdIENNQUtFX1NIQVJFRF9MSU5LRVJfRkxB R1MgZHJvcHMgIi1XbCwtLW5vLXVuZGVmaW5lZCIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDA3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIHdhcyBhIGxhdGVudCBpc3N1ZS4gUGx1Z2luVGVz dDo6aW5kaWNhdGVUZXN0RmFpbHVyZSB3YXMKKyAgICAgICAgdXNpbmcgV1RGOjpzbGVlcCB3aXRo b3V0IGxpbmtpbmcgV1RGLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBl UGx1Z0luL0NNYWtlTGlzdHMudHh0OgorICAgICAgICBBZGRlZCBXZWJLaXQ6OldURiB0byBXZWJL aXRUZXN0TmV0c2NhcGVQbHVnSW5fTElCUkFSSUVTLgorCiAyMDE5LTA3LTIzICBGdWppaSBIaXJv bm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFt3ZWJraXRwZXJsXSBw cmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9wYXJzZXJfdW5pdHRlc3RzLnBsIGlzIGZhaWxpbmcg b24gV2luZG93cyBQZXJsCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0 c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50eHQgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0 c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50eHQKaW5kZXggODQyYmI0NTIxNGZkMDJkZmRmZGVlM2U1 ZWNkZTQzMzFlZWQwMmZkMC4uMGYyNmI3Y2I0YjI0Mzk5N2IzZmY4ZDQ2NzM0NGM4MTdhYjI5YTJl YyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL0NN YWtlTGlzdHMudHh0CisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJ bi9DTWFrZUxpc3RzLnR4dApAQCAtMzYsMTIgKzM2LDE2IEBAIHNldChXZWJLaXRUZXN0TmV0c2Nh cGVQbHVnSW5fSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICR7V1RGX0RJUn0KICkKIAorc2V0KFdl YktpdFRlc3ROZXRzY2FwZVBsdWdJbl9MSUJSQVJJRVMKKyAgICBXZWJLaXQ6OldURgorKQorCiBp ZiAoTU9aX1gxMSkKICAgICBzZXQoV2ViS2l0VGVzdE5ldHNjYXBlUGx1Z0luX1NZU1RFTV9JTkNM VURFX0RJUkVDVE9SSUVTCiAgICAgICAgICR7WDExX0lOQ0xVREVfRElSfQogICAgICkKIAotICAg IHNldChXZWJLaXRUZXN0TmV0c2NhcGVQbHVnSW5fTElCUkFSSUVTCisgICAgbGlzdChBUFBFTkQg V2ViS2l0VGVzdE5ldHNjYXBlUGx1Z0luX0xJQlJBUklFUwogICAgICAgICAke1gxMV9MSUJSQVJJ RVN9CiAgICAgKQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNTdm YzdlMzAwN2Y4MWE3YWFhOTczMmRlZjYzODdkOTZlODFhOTQyNi4uNDQ1ODdkZGEzMWNiMzMyNjdk NzdkYWZlYzY4OGU0MTM0NjA5YjcxOCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA3LTI0ICBGdWppaSBIaXJvbm9yaSAgPGZ1amlp Lmhpcm9ub3JpQGdtYWlsLmNvbT4KKworICAgICAgICBbQ01ha2VdIENNQUtFX1NIQVJFRF9MSU5L RVJfRkxBR1MgZHJvcHMgIi1XbCwtLW5vLXVuZGVmaW5lZCIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwMDA3NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsdGhvdWdoIFdlYktpdENvbXBpbGVyRmxhZ3Mu Y21ha2UgYWRkcyAiLVdsLC0tbm8tdW5kZWZpbmVkIiB0bworICAgICAgICBDTUFLRV9TSEFSRURf TElOS0VSX0ZMQUdTLCBpdCB3YXNuJ3QgZWZmZWN0aXZlIGJlY2F1c2UKKyAgICAgICAgT3B0aW9u c0NvbW1vbi5jbWFrZSBpbmFkdmVydGVudGx5IG92ZXJyaWRlIHRoZSB2YWx1ZSB3aXRoCisgICAg ICAgIENNQUtFX0VYRV9MSU5LRVJfRkxBR1MgYXM6CisKKyAgICAgICAgPiBzZXQoQ01BS0VfU0hB UkVEX0xJTktFUl9GTEFHUyAiJHtDTUFLRV9FWEVfTElOS0VSX0ZMQUdTfSAuLi4iKQorCisgICAg ICAgICogU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2U6IFVzZSBzdHJpbmcoQVBQRU5E KSB0byBtb2RpZnkKKyAgICAgICAgQ01BS0VfKl9MSU5LRVJfRkxBR1MgdmFyaWFibGVzIHRvIGF2 b2lkIHR5cG9zLgorCiAyMDE5LTA3LTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc0dUSy5jbWFr ZSBhbmQgTkVXUyBmb3IgMi4yNS4zIHJlbGVhc2UK