20007 2008-07-11 04:44:37 -0700 Signature of WebView::select-all differs from TextView::select-all 2017-03-11 10:46:45 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux ASSIGNED Gtk P2 Normal --- 1 christian christian bugs-noreply oldest_to_newest 85772 0 christian 2008-07-11 04:44:37 -0700 WebKitWebView has an action signal "select-all" that when called selects everything in the current page. The signature is this: void select-all (WebKitWebView* web_view, gpointer user_data) By comparison, GtkTextView has the same signal, but with a different signature: void select-all (GtkTextView* text_view, gboolean select, gpointer user_data) If the boolean "select" is TRUE, everything is selected, which is what WebView currently does. But if it is FALSE, everything is unselected. It is actually possible to call "select-all" without a boolean on a TextView but the behaviour is the reverse of what WebView does. I think we should really fix the signature of WebView to match TextView. I think it's not probable that it breaks anything because I don't think that one usually connects a callback to that signal. 100043 1 25445 christian 2008-11-24 13:35:34 -0800 Created attachment 25445 Adjust select-all as suggested This adjusts select-all as suggested. Unless anyone actually connected to the signal everything will work fine, at least in the C API. I don't really know about bindings, maybe someone more experienced in that area can confirm that. 100357 2 25445 eric 2008-11-25 18:02:14 -0800 Comment on attachment 25445 Adjust select-all as suggested Alp is our gtk reviewer, no? 100385 3 25445 christian 2008-11-26 00:46:37 -0800 Comment on attachment 25445 Adjust select-all as suggested (In reply to comment #2) > (From update of attachment 25445 [review]) > Alp is our gtk reviewer, no? Alp isn't the sole Gtk reviewer, granted he tends to assume that position for the most part. Either way, let's take it off the queue for the moment, a discussion on IRC made clear that it isn't undisputed. 25445 2008-11-24 13:35:34 -0800 2010-06-10 16:20:17 -0700 Adjust select-all as suggested select-all.diff text/plain 1970 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggZWU0ZDg0MS4uOWNiOTVmZCAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTcyOCwxMCArNzI4LDEzIEBAIHN0YXRp YyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfcmVhbF9jb25zb2xlX21lc3NhZ2UoV2ViS2l0V2Vi Vmlldyogd2ViVmlldywgY29uCiAgICAgcmV0dXJuIFRSVUU7CiB9CiAKLXN0YXRpYyB2b2lkIHdl YmtpdF93ZWJfdmlld19yZWFsX3NlbGVjdF9hbGwoV2ViS2l0V2ViVmlldyogd2ViVmlldykKK3N0 YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19yZWFsX3NlbGVjdF9hbGwoV2ViS2l0V2ViVmlldyog d2ViVmlldywgZ2Jvb2xlYW4gc2VsZWN0KQogewogICAgIEZyYW1lKiBmcmFtZSA9IGNvcmUod2Vi VmlldyktPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKTsKLSAgICBmcmFt ZS0+ZWRpdG9yKCktPmNvbW1hbmQoIlNlbGVjdEFsbCIpLmV4ZWN1dGUoKTsKKyAgICBpZiAoc2Vs ZWN0KQorICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPmNvbW1hbmQoIlNlbGVjdEFsbCIpLmV4ZWN1 dGUoKTsKKyAgICBlbHNlCisgICAgICAgIGZyYW1lLT5lZGl0b3IoKS0+Y29tbWFuZCgiVW5zZWxl Y3QiKS5leGVjdXRlKCk7CiB9CiAKIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19yZWFsX2N1 dF9jbGlwYm9hcmQoV2ViS2l0V2ViVmlldyogd2ViVmlldykKQEAgLTEwOTIsMTQgKzEwOTUsMTgg QEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQoV2ViS2l0V2ViVmlld0Ns YXNzKiB3ZWJWaWV3Q2xhc3MpCiAgICAgICogc2VsZWN0IHRoZSBjb21wbGV0ZSBjb250ZW50cyBv ZiB0aGUgdGV4dCB2aWV3LgogICAgICAqCiAgICAgICogVGhlIGRlZmF1bHQgYmluZGluZ3MgZm9y IHRoaXMgc2lnbmFsIGlzIEN0cmwtYS4KKyAgICAgKgorICAgICAqIFBhc3NpbmcgJVRSVUUgZm9y IEBzZWxlY3QgbWVhbnMgdGhhdCBldmVyeXRoaW5nIHdpbGwgYmUKKyAgICAgKiBzZWxlY3RlZCB3 aGlsZSAlRkFMU0UgdW5zZWxlY3RzIGV2ZXJ5dGhpbmcuCiAgICAgICovCiAgICAgd2Via2l0X3dl Yl92aWV3X3NpZ25hbHNbU0VMRUNUX0FMTF0gPSBnX3NpZ25hbF9uZXcoInNlbGVjdC1hbGwiLAog ICAgICAgICAgICAgR19UWVBFX0ZST01fQ0xBU1Mod2ViVmlld0NsYXNzKSwKICAgICAgICAgICAg IChHU2lnbmFsRmxhZ3MpKEdfU0lHTkFMX1JVTl9MQVNUIHwgR19TSUdOQUxfQUNUSU9OKSwKICAg ICAgICAgICAgIEdfU1RSVUNUX09GRlNFVChXZWJLaXRXZWJWaWV3Q2xhc3MsIHNlbGVjdF9hbGwp LAogICAgICAgICAgICAgTlVMTCwgTlVMTCwKLSAgICAgICAgICAgIGdfY2Nsb3N1cmVfbWFyc2hh bF9WT0lEX19WT0lELAotICAgICAgICAgICAgR19UWVBFX05PTkUsIDApOworICAgICAgICAgICAg Z19jY2xvc3VyZV9tYXJzaGFsX1ZPSURfX0JPT0xFQU4sCisgICAgICAgICAgICBHX1RZUEVfTk9O RSwgMSwKKyAgICAgICAgICAgIEdfVFlQRV9CT09MRUFOKTsKIAogICAgIC8qKgogICAgICAqIFdl YktpdFdlYlZpZXc6OmN1dC1jbGlwYm9hcmQ6CkBAIC0yMDUyLDcgKzIwNTksNyBAQCB2b2lkIHdl YmtpdF93ZWJfdmlld19zZWxlY3RfYWxsKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiB7CiAgICAg Z19yZXR1cm5faWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVcod2ViVmlldykpOwogCi0gICAgZ19z aWduYWxfZW1pdCh3ZWJWaWV3LCB3ZWJraXRfd2ViX3ZpZXdfc2lnbmFsc1tTRUxFQ1RfQUxMXSwg MCk7CisgICAgZ19zaWduYWxfZW1pdCh3ZWJWaWV3LCB3ZWJraXRfd2ViX3ZpZXdfc2lnbmFsc1tT RUxFQ1RfQUxMXSwgMCwgVFJVRSk7CiB9CiAKIC8qKgo=