200067 2019-07-23 17:43:33 -0700 Use 12 digits to show a git commit. 2019-07-24 10:10:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dewei_zhu dewei_zhu dewei_zhu jbedard rniwa oldest_to_newest 1555252 0 dewei_zhu 2019-07-23 17:43:33 -0700 Use 12 digits to show a git commit. 1555254 1 374744 dewei_zhu 2019-07-23 17:46:28 -0700 Created attachment 374744 Patch 1555255 2 dewei_zhu 2019-07-23 17:47:07 -0700 rdar://47048358 1555358 3 jbedard 2019-07-24 08:11:41 -0700 I did the math for this a few months back, 8 is way to small and a collision is quite likely given 10's of thousands of commits. If I recall, 12 digits supports what is, in effect, around 100 years worth of WebKit commits at the current rate. 1555390 4 dewei_zhu 2019-07-24 10:10:53 -0700 Landed in r247770 374744 2019-07-23 17:46:28 -0700 2019-07-23 21:10:56 -0700 Patch bug-200067-20190723174628.patch text/plain 2133 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NzYxCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA1NTE5YzMzZjE1N2JmNWMwNGU1NjkzNDQ3YjU4YzZhNWQ3YmY1ODVkLi4yMWFlODJhMTU5 YjYwYjk4NzQ0YWUzOTQ3ZmI0MTU5ODQ4MmY1ZjQwIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOS0wNy0yMyAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgMTIgZGlnaXRzIHRvIHNob3cgYSBnaXQgY29tbWl0 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMDY3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIDEy IGRpZ2l0cyB0byBzaG93IGEgZ2l0IGNvbW1pdCB0byByZWFzb25hYmx5IGRlc2NyZWFzZSBjb21t aXQgcHJlZml4IGNvbGxpc2lvbiBwcm9iYWJpbGl0eQorICAgICAgICBmb3IgcmVwb3NpdG9yeSB3 aXRoIGxhcmdlIGFtb3VudCBvZiBjb21taXRzLgorCisgICAgICAgICogcHVibGljL3YzL21vZGVs cy9jb21taXQtbG9nLmpzOiBJbmNyZWFzZSBkaWdpdHMgZnJvbSA4IHRvIDEyIGZvciBnaXQgU0hB LgorICAgICAgICAoQ29tbWl0TG9nLnByb3RvdHlwZS5sYWJlbCk6CisgICAgICAgIChDb21taXRM b2cucHJvdG90eXBlLmRpZmYpOgorCiAyMDE5LTA3LTAzICBEZXdlaSBaaHUgIDxkZXdlaV96aHVA YXBwbGUuY29tPgogCiAgICAgICAgIFRlc3QgZnJlc2huZXNzIHBhZ2Ugc2hvdWxkIGV4cG9zZSBy ZXZpc2lvbiBpbmZvcm1hdGlvbiBmb3IgbGF0ZXN0IGJ1aWxkIG9uIHRvb2x0aXAuCmRpZmYgLS1n aXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL21vZGVscy9jb21taXQtbG9n LmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9tb2RlbHMvY29tbWl0LWxv Zy5qcwppbmRleCBkYTUxZjVmOTBjY2UwYjljZjIyNDkzMTY1NTBmN2QxNzM4NThkYTMwLi5lNmQ0 ZDQ0YWJiNTU0MTM0NmUyZjRhOWQ0NDAwOWY3OWE3ODI5MDBiIDEwMDY0NAotLS0gYS9XZWJzaXRl cy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL21vZGVscy9jb21taXQtbG9nLmpzCisrKyBiL1dl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9kZWxzL2NvbW1pdC1sb2cuanMKQEAg LTU0LDcgKzU0LDcgQEAgY2xhc3MgQ29tbWl0TG9nIGV4dGVuZHMgRGF0YU1vZGVsT2JqZWN0IHsK ICAgICAgICAgaWYgKHBhcnNlSW50KHJldmlzaW9uKSA9PSByZXZpc2lvbikgLy8gZS5nLiByMTIz NDUKICAgICAgICAgICAgIHJldHVybiAncicgKyByZXZpc2lvbjsKICAgICAgICAgaWYgKHJldmlz aW9uLmxlbmd0aCA9PSA0MCkgLy8gZS5nLiBnaXQgaGFzaAotICAgICAgICAgICAgcmV0dXJuIHJl dmlzaW9uLnN1YnN0cmluZygwLCA4KTsKKyAgICAgICAgICAgIHJldHVybiByZXZpc2lvbi5zdWJz dHJpbmcoMCwgMTIpOwogICAgICAgICByZXR1cm4gcmV2aXNpb247CiAgICAgfQogICAgIHRpdGxl KCkgeyByZXR1cm4gdGhpcy5fcmVwb3NpdG9yeS5uYW1lKCkgKyAnIGF0ICcgKyB0aGlzLmxhYmVs KCk7IH0KQEAgLTc0LDcgKzc0LDcgQEAgY2xhc3MgQ29tbWl0TG9nIGV4dGVuZHMgRGF0YU1vZGVs T2JqZWN0IHsKICAgICAgICAgaWYgKHBhcnNlSW50KGZyb20pID09IGZyb20pLy8gZS5nLiByMTIz NDUuCiAgICAgICAgICAgICBsYWJlbCA9IGByJHtmcm9tfS1yJHt0aGlzLnJldmlzaW9uKCl9YDsK ICAgICAgICAgZWxzZSBpZiAodG8ubGVuZ3RoID09IDQwKSAvLyBlLmcuIGdpdCBoYXNoCi0gICAg ICAgICAgICBsYWJlbCA9IGAke2Zyb20uc3Vic3RyaW5nKDAsIDgpfS4uJHt0by5zdWJzdHJpbmco MCwgOCl9YDsKKyAgICAgICAgICAgIGxhYmVsID0gYCR7ZnJvbS5zdWJzdHJpbmcoMCwgMTIpfS4u JHt0by5zdWJzdHJpbmcoMCwgMTIpfWA7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGxhYmVs ID0gYCR7ZnJvbX0gLSAke3RvfWA7CiAK