200059 2019-07-23 16:34:30 -0700 [Timeline]: Make timeline header width automatic, instead of fixed width 2019-07-25 11:17:23 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zhifei_fang webkit-unassigned commit-queue jbedard ryanhaddad tsavell webkit-bug-importer zhifei_fang oldest_to_newest 1555209 0 zhifei_fang 2019-07-23 16:34:30 -0700 <rdar://problem/53470453> 1555212 1 374733 zhifei_fang 2019-07-23 16:44:54 -0700 Created attachment 374733 Patch 1555394 2 jbedard 2019-07-24 10:15:48 -0700 Not sure this actually does what we expect it to, because of <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers to still scroll? Because the do still scroll with this change. 1555395 3 zhifei_fang 2019-07-24 10:21:02 -0700 (In reply to Jonathan Bedard from comment #2) > Not sure this actually does what we expect it to, because of > <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers > to still scroll? Because the do still scroll with this change. The header will not be scrolled anymore, it will use the longest text as its width, then the timeline will use up what the remains. 1555482 4 jbedard 2019-07-24 13:34:59 -0700 (In reply to Zhifei Fang from comment #3) > (In reply to Jonathan Bedard from comment #2) > > Not sure this actually does what we expect it to, because of > > <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers > > to still scroll? Because the do still scroll with this change. > > The header will not be scrolled anymore, it will use the longest text as its > width, then the timeline will use up what the remains. Do some more testing locally, because at the moment, it definitely doesn't do that at the moment. 1555511 5 zhifei_fang 2019-07-24 14:40:35 -0700 (In reply to Jonathan Bedard from comment #4) > (In reply to Zhifei Fang from comment #3) > > (In reply to Jonathan Bedard from comment #2) > > > Not sure this actually does what we expect it to, because of > > > <https://bugs.webkit.org/show_bug.cgi?id=199955>. Do we expect the headers > > > to still scroll? Because the do still scroll with this change. > > > > The header will not be scrolled anymore, it will use the longest text as its > > width, then the timeline will use up what the remains. > > Do some more testing locally, because at the moment, it definitely doesn't > do that at the moment. I found I haven't deployed it, will try again. 1555523 6 374815 zhifei_fang 2019-07-24 14:59:39 -0700 Created attachment 374815 Patch 1555524 7 zhifei_fang 2019-07-24 15:00:37 -0700 (In reply to Zhifei Fang from comment #6) > Created attachment 374815 [details] > Patch Deployed, I found I also need to delete those customized styles. 1555793 8 jbedard 2019-07-25 08:44:00 -0700 Before we land, I'd like to run the change by bot watchers to make sure they like the difference. 1555795 9 tsavell 2019-07-25 08:56:04 -0700 The fixed width of the names feels solid to me and is definitely more readable. 1555796 10 jbedard 2019-07-25 08:56:41 -0700 (In reply to Truitt Savell from comment #9) > The fixed width of the names feels solid to me and is definitely more > readable. Ok! r+ed then! 1555851 11 374815 commit-queue 2019-07-25 11:16:40 -0700 Comment on attachment 374815 Patch Clearing flags on attachment: 374815 Committed r247830: <https://trac.webkit.org/changeset/247830> 1555852 12 commit-queue 2019-07-25 11:16:42 -0700 All reviewed patches have been landed. Closing bug. 1555853 13 webkit-bug-importer 2019-07-25 11:17:23 -0700 <rdar://problem/53550660> 374733 2019-07-23 16:44:54 -0700 2019-07-24 14:59:37 -0700 Patch bug-200059-20190723164453.patch text/plain 1752 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NzU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWRjOWQxMTdkYjhiZjU2NjI3ZmZiMWQ2MWNlMzliZTJi NjE0NTgxZi4uZDc5ZDRlMDU3NGQ4OWYxYWJiYmViNDJlYjBiMzY1YTg5YTgyMTBjNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTA3LTIzICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKwor ICAgICAgICBbVGltZWxpbmVdOiBNYWtlIHRpbWVsaW5lIGhlYWRlciB3aWR0aCBhdXRvbWF0aWMs IGluc3RlYWQgb2YgZml4ZWQgd2lkdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMDA1OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTM0NzA0NTM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZXN1 bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2Nzcy93ZWJraXQuY3NzOgor ICAgICAgICAoLnRpbWVsaW5lPi5jb250ZW50KToKKyAgICAgICAgKC50aW1lbGluZT4uaGVhZGVy KToKKwogMjAxOS0wNy0yMyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIE1vdmUgamF2YVNjcmlwdENvbmZpZ3VyYXRpb25EaXJlY3RvcnkgU1BJ IGZyb20gX1dLUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uIHRvIFdLUHJvY2Vzc1Bvb2xQcml2YXRl IHRvIG1ha2UgaXQgcnVudGltZSBzd2l0Y2hhYmxlCmRpZmYgLS1naXQgYS9Ub29scy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2Nzcy93ZWJraXQuY3NzIGIvVG9v bHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvbGlicmFyeS9jc3Mvd2Via2l0 LmNzcwppbmRleCBkYjU1MjcxMTdhZjNjYzgwZjQ4ZjQ0YWQ2ZTAwYTljNmZmOWFmZjljLi5kNjFl YjUzN2ZkZWNmNzUyMzUzNTA2NDY0ZWE5NjYwOGJiNzVjNTM1IDEwMDY0NAotLS0gYS9Ub29scy9y ZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2Nzcy93ZWJraXQuY3Nz CisrKyBiL1Rvb2xzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkv Y3NzL3dlYmtpdC5jc3MKQEAgLTE3NTAsMTcgKzE3NTAsMTUgQEAgcHJlIHsKIC50aW1lbGluZT4u Y29udGVudCB7CiAgIG92ZXJmbG93LXg6IGF1dG87CiAgIG92ZXJmbG93LXk6IGhpZGRlbjsKLSAg d2lkdGg6IGNhbGMoMTAwJSAtIDE0MHB4KTsKICAgcGFkZGluZzogMDsKICAgbWFyZ2luOiAwOwog ICB2ZXJ0aWNhbC1hbGlnbjogbWlkZGxlOwotICAvKmRpc3BsYXk6IGZsZXg7Ki87CisgIGZsZXg6 IGF1dG87CiB9CiAKIC50aW1lbGluZT4uaGVhZGVyIHsKICAgbWFyZ2luOiAwOwogICB0ZXh0LWFs aWduOiByaWdodDsKLSAgd2lkdGg6IDE0MHB4OwogICBib3JkZXI6IG5vbmU7CiAgIHZlcnRpY2Fs LWFsaWduOiBtaWRkbGU7CiAgIGRpc3BsYXk6IGJsb2NrOwpAQCAtMTc2OCw2ICsxNzY2LDcgQEAg cHJlIHsKICAgb3ZlcmZsb3c6IGF1dG87CiAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKICAgYm9yZGVy LWxlZnQ6IDFweCBzb2xpZCB2YXIoLS1ib3JkZXJDb2xvcklubGluZUVsZW1lbnQpOworICBmbGV4 OiBub25lOwogfQogCiAudGltZWxpbmU+LmhlYWRlciAuc2VyaWVzIHsK 374815 2019-07-24 14:59:39 -0700 2019-07-25 11:16:40 -0700 Patch bug-200059-20190724145938.patch text/plain 2530 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3Nzg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjhhOWJjNWVkZGFmYzk1ZDNkYzNhMzQzMTdiYmNmM2M0 ODBhNThhYi4uMjMyMmVmNzgyOTZkZTNjM2FjMjVmMGZmZDBhYTYzZmMwMzJmNjJhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTA3LTI0ICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKwor ICAgICAgICBbVGltZWxpbmVdOiBNYWtlIHRpbWVsaW5lIGhlYWRlciB3aWR0aCBhdXRvbWF0aWMs IGluc3RlYWQgb2YgZml4ZWQgd2lkdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwMDA1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvY3Nz L3RpbWVsaW5lLmNzczoKKyAgICAgICAgKC5kb3QuY3Jhc2gpOgorICAgICAgICAoLnRpbWVsaW5l Pi5oZWFkZXIpOiBEZWxldGVkLgorICAgICAgICAqIHJlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3Zp ZXcvc3RhdGljL2xpYnJhcnkvY3NzL3dlYmtpdC5jc3M6CisgICAgICAgICgudGltZWxpbmU+LmNv bnRlbnQpOgorICAgICAgICAoLnRpbWVsaW5lPi5oZWFkZXIpOgorCiAyMDE5LTA3LTI0ICBaaGlm ZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBydW4tamF2YXNjcmlw dGNvcmUtdGVzdHMgd29uJ3QgcmVwb3J0IHRlc3QgcmVzdWx0cyBmb3IgdGVzdG1hc20sIHRlc3Rh aXIsIHRlc3RiMywgdGVzdGRmZyBhbmQgdGVzdCBhcGkKZGlmZiAtLWdpdCBhL1Rvb2xzL3Jlc3Vs dHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2Nzcy90aW1lbGluZS5jc3MgYi9Ub29scy9y ZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9jc3MvdGltZWxpbmUuY3NzCmluZGV4 IDVjMzNlZDNjNzQyNDExYzAwOWZjY2VmZGNjNjNhYWE4MThlODJhYzIuLmFiZDliZWYxZWFlNTRh YmVlYWMyY2M4ZjNiNzA1MjUyOGFmNzBjMTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3Jlc3VsdHNkYnB5 L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2Nzcy90aW1lbGluZS5jc3MKKysrIGIvVG9vbHMvcmVz dWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvY3NzL3RpbWVsaW5lLmNzcwpAQCAtMjIs NyArMjIsNyBAQAogICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lO RyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCiAgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElG IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCi0gCisKIC5k b3QudGltZW91dCB7CiAgICAgYmFja2dyb3VuZC1jb2xvcjogdmFyKC0tb3JhbmdlTGlnaHQpOwog fQpAQCAtMzAsNyArMzAsMyBAQAogLmRvdC5jcmFzaCB7CiAgICAgYmFja2dyb3VuZC1jb2xvcjog dmFyKC0tcHVycGxlTGlnaHQpOwogfQotCi0udGltZWxpbmU+LmhlYWRlciB7Ci0gICAgd2lkdGg6 IDIwMHB4OwotfQpkaWZmIC0tZ2l0IGEvVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmll dy9zdGF0aWMvbGlicmFyeS9jc3Mvd2Via2l0LmNzcyBiL1Rvb2xzL3Jlc3VsdHNkYnB5L3Jlc3Vs dHNkYnB5L3ZpZXcvc3RhdGljL2xpYnJhcnkvY3NzL3dlYmtpdC5jc3MKaW5kZXggZGI1NTI3MTE3 YWYzY2M4MGY0OGY0NGFkNmUwMGE5YzZmZjlhZmY5Yy4uZDYxZWI1MzdmZGVjZjc1MjM1MzUwNjQ2 NGVhOTY2MDhiYjc1YzUzNSAxMDA2NDQKLS0tIGEvVG9vbHMvcmVzdWx0c2RicHkvcmVzdWx0c2Ri cHkvdmlldy9zdGF0aWMvbGlicmFyeS9jc3Mvd2Via2l0LmNzcworKysgYi9Ub29scy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9saWJyYXJ5L2Nzcy93ZWJraXQuY3NzCkBAIC0x NzUwLDE3ICsxNzUwLDE1IEBAIHByZSB7CiAudGltZWxpbmU+LmNvbnRlbnQgewogICBvdmVyZmxv dy14OiBhdXRvOwogICBvdmVyZmxvdy15OiBoaWRkZW47Ci0gIHdpZHRoOiBjYWxjKDEwMCUgLSAx NDBweCk7CiAgIHBhZGRpbmc6IDA7CiAgIG1hcmdpbjogMDsKICAgdmVydGljYWwtYWxpZ246IG1p ZGRsZTsKLSAgLypkaXNwbGF5OiBmbGV4OyovOworICBmbGV4OiBhdXRvOwogfQogCiAudGltZWxp bmU+LmhlYWRlciB7CiAgIG1hcmdpbjogMDsKICAgdGV4dC1hbGlnbjogcmlnaHQ7Ci0gIHdpZHRo OiAxNDBweDsKICAgYm9yZGVyOiBub25lOwogICB2ZXJ0aWNhbC1hbGlnbjogbWlkZGxlOwogICBk aXNwbGF5OiBibG9jazsKQEAgLTE3NjgsNiArMTc2Niw3IEBAIHByZSB7CiAgIG92ZXJmbG93OiBh dXRvOwogICBwb3NpdGlvbjogcmVsYXRpdmU7CiAgIGJvcmRlci1sZWZ0OiAxcHggc29saWQgdmFy KC0tYm9yZGVyQ29sb3JJbmxpbmVFbGVtZW50KTsKKyAgZmxleDogbm9uZTsKIH0KIAogLnRpbWVs aW5lPi5oZWFkZXIgLnNlcmllcyB7Cg==