200055 2019-07-23 16:05:35 -0700 ImageDecoderDirect2D::hotSpot() should return WTF::nullopt instead of default constructed value 2019-07-23 17:06:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 annulen annulen achristensen bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1555189 0 annulen 2019-07-23 16:05:35 -0700 ImageDecoderDirect2D::hotSpot() should return WTF::nullopt instead of default constructed value 1555190 1 374726 annulen 2019-07-23 16:06:54 -0700 Created attachment 374726 Patch 1555207 2 bfulgham 2019-07-23 16:31:36 -0700 (In reply to Konstantin Tokarev from comment #0) > ImageDecoderDirect2D::hotSpot() should return WTF::nullopt instead of > default constructed value I'm so excited someone else is looking at this code!!!!! :-) 1555215 3 374726 bfulgham 2019-07-23 16:47:58 -0700 Comment on attachment 374726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374726&action=review r=me > Source/WebCore/platform/graphics/win/ImageDecoderDirect2D.cpp:128 > + return WTF::nullopt; Doh! Good catch. 1555227 4 374726 commit-queue 2019-07-23 17:04:54 -0700 Comment on attachment 374726 Patch Clearing flags on attachment: 374726 Committed r247758: <https://trac.webkit.org/changeset/247758> 1555228 5 commit-queue 2019-07-23 17:04:55 -0700 All reviewed patches have been landed. Closing bug. 1555229 6 webkit-bug-importer 2019-07-23 17:06:05 -0700 <rdar://problem/53472189> 374726 2019-07-23 16:06:54 -0700 2019-07-23 17:04:54 -0700 Patch bug-200055-20190724020652.patch text/plain 1488 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ3NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQwMjJlZjkxMGYwNTMx MGE2MmIwZmM5YWM3MTRlYThlMTUxMGI3Ni4uMmU0MWZjODBmOGQ5MjA3M2FiZjk0OWZhNTgyZDFk NGRmZTZiY2IwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA3LTIzICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBJbWFnZURlY29k ZXJEaXJlY3QyRDo6aG90U3BvdCgpIHNob3VsZCByZXR1cm4gV1RGOjpudWxsb3B0IGluc3RlYWQg b2YgZGVmYXVsdCBjb25zdHJ1Y3RlZCB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjAwMDU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vSW1hZ2VEZWNvZGVy RGlyZWN0MkQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VEZWNvZGVyRGlyZWN0MkQ6Omhv dFNwb3QgY29uc3QpOgorCiAyMDE5LTA3LTIzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgW2lPU10gVGFwcGluZyB0aGUgc2VhcmNoIGZpZWxkIG9uIGEgc2VhcmNo IHJlc3VsdHMgcGFnZSBvbiB6aWxsb3cuY29tIHNob3dzIGFuZCBpbW1lZGlhdGVseSBkaXNtaXNz ZXMgdGhlIGtleWJvYXJkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy93aW4vSW1hZ2VEZWNvZGVyRGlyZWN0MkQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvd2luL0ltYWdlRGVjb2RlckRpcmVjdDJELmNwcAppbmRleCAzMDk2NDMzZmU1 ZTVhYTVhNWQ5YTkyY2MwM2RhOTFjM2FhNWJkMGU0Li4zMGI2ZjlmODE2NTNkMDc1MjEwNjA4ZjA1 YmQ3NWQ1NDA5NDQzODBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy93aW4vSW1hZ2VEZWNvZGVyRGlyZWN0MkQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3dpbi9JbWFnZURlY29kZXJEaXJlY3QyRC5jcHAKQEAgLTEyNSw3ICsx MjUsNyBAQCBSZXBldGl0aW9uQ291bnQgSW1hZ2VEZWNvZGVyRGlyZWN0MkQ6OnJlcGV0aXRpb25D b3VudCgpIGNvbnN0CiAKIE9wdGlvbmFsPEludFBvaW50PiBJbWFnZURlY29kZXJEaXJlY3QyRDo6 aG90U3BvdCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIEludFBvaW50KCk7CisgICAgcmV0dXJuIFdU Rjo6bnVsbG9wdDsKIH0KIAogSW50U2l6ZSBJbWFnZURlY29kZXJEaXJlY3QyRDo6ZnJhbWVTaXpl QXRJbmRleChzaXplX3QgaW5kZXgsIFN1YnNhbXBsaW5nTGV2ZWwgc3Vic2FtcGxpbmdMZXZlbCkg Y29uc3QK