200051 2019-07-23 15:23:40 -0700 Web Inspector: REGRESSION: Overlay: highlighting a ::before/::after shows the node info of the parent instead 2019-07-24 17:54:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1555164 0 hi 2019-07-23 15:23:40 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. find a ::before/::after in the DOM tree of the Elements tab 3. hover over the ::before/::after => the node info "box" that is shown on the page has details about the parent node, instead of the ::before/::after 1555178 1 374721 hi 2019-07-23 15:42:45 -0700 Created attachment 374721 Patch 1555179 2 374721 hi 2019-07-23 15:43:25 -0700 Comment on attachment 374721 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=374721&action=review > Source/WebCore/inspector/InspectorOverlay.cpp:288 > + Frame* containingFrame = node.document().frame(); This was previously checked by `WebCore::effectiveElementForNode`, but since that's no longer called, we should check it here. 1555578 3 374721 joepeck 2019-07-24 16:55:50 -0700 Comment on attachment 374721 Patch r=me 1555602 4 374721 commit-queue 2019-07-24 17:52:16 -0700 Comment on attachment 374721 Patch Clearing flags on attachment: 374721 Committed r247805: <https://trac.webkit.org/changeset/247805> 1555603 5 commit-queue 2019-07-24 17:52:17 -0700 All reviewed patches have been landed. Closing bug. 1555607 6 webkit-bug-importer 2019-07-24 17:54:19 -0700 <rdar://problem/53521776> 374721 2019-07-23 15:42:45 -0700 2019-07-24 17:52:16 -0700 Patch bug-200051-20190723154245.patch text/plain 4394 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MzI4M2FkYjJmMDZhMzBlNWI4YTQ0ZmIxNmU2NjViZmZlMTljODgwLi5l OGQ0ZTU0ZDZlMDA0ZWI1ZmI2MTI3OGRlODZlMDliYWU5MmUwODE4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTktMDctMjMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT046IE92ZXJsYXk6IGhpZ2hsaWdo dGluZyBhIDo6YmVmb3JlLzo6YWZ0ZXIgc2hvd3MgdGhlIG5vZGUgaW5mbyBvZiB0aGUgcGFyZW50 IGluc3RlYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwMDA1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdoZW4gaGlnaGxpZ2h0aW5nIGEgcHNldWRvLWVsZW1lbnQsIG9ubHkgdXNlIHRoZSBwYXJlbnQg bm9kZSBmb3Igc2VsZWN0b3IgaW5mb3JtYXRpb24uIEFsbAorICAgICAgICByZW5kZXJpbmcgZGF0 YSBzaG91bGQgc3RpbGwgY29tZSBmcm9tIHRoZSBwc2V1ZG8tZWxlbWVudCBpdHNlbGYuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpkcmF3U2hhcGVIaWdobGlnaHQpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yT3Zlcmxh eTo6ZHJhd0VsZW1lbnRUaXRsZSk6CisKIDIwMTktMDctMjMgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTG9uZyBwcmVzcyBoaW50IG9mIEFpclBvZHMg YnV5IGJ1dHRvbnMgYXJlIHRhbGwgYW5kIG5hcnJvdyBkdXJpbmcgYW5pbWF0aW9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKaW5kZXggMDljYmY2NTY0 MTgxZWVkNWIzN2M5ZmQ0M2FkNjRhMTY0MGFjYWRkMy4uNGVjNTI2MjcxMDBmMTRlNDFiZTcyZmEw YTg1ZmZlOGUzY2ExNGMzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3Rvck92ZXJsYXkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JPdmVybGF5LmNwcApAQCAtMjc3LDExICsyNzcsNyBAQCBzdGF0aWMgdm9pZCBkcmF3RnJhZ21l bnRIaWdobGlnaHQoR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBOb2RlJiBub2RlLCBjb25zdCBI aQogCiBzdGF0aWMgdm9pZCBkcmF3U2hhcGVIaWdobGlnaHQoR3JhcGhpY3NDb250ZXh0JiBjb250 ZXh0LCBOb2RlJiBub2RlLCBIaWdobGlnaHQ6OkJvdW5kcyYgYm91bmRzKQogewotICAgIEVsZW1l bnQqIGVsZW1lbnQgPSBlZmZlY3RpdmVFbGVtZW50Rm9yTm9kZShub2RlKTsKLSAgICBpZiAoIWVs ZW1lbnQpCi0gICAgICAgIHJldHVybjsKLQotICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBl bGVtZW50LT5yZW5kZXJlcigpOworICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBub2RlLnJl bmRlcmVyKCk7CiAgICAgaWYgKCFyZW5kZXJlciB8fCAhaXM8UmVuZGVyQm94PihyZW5kZXJlcikp CiAgICAgICAgIHJldHVybjsKIApAQCAtMjg5LDEyICsyODUsMTUgQEAgc3RhdGljIHZvaWQgZHJh d1NoYXBlSGlnaGxpZ2h0KEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgTm9kZSYgbm9kZSwgSGln aGxpZ2h0OjoKICAgICBpZiAoIXNoYXBlT3V0c2lkZUluZm8pCiAgICAgICAgIHJldHVybjsKIAot ICAgIGNvbnN0IENvbG9yIHNoYXBlSGlnaGxpZ2h0Q29sb3IoOTYsIDgyLCAxMjcsIDIwNCk7Cisg ICAgRnJhbWUqIGNvbnRhaW5pbmdGcmFtZSA9IG5vZGUuZG9jdW1lbnQoKS5mcmFtZSgpOworICAg IGlmICghY29udGFpbmluZ0ZyYW1lKQorICAgICAgICByZXR1cm47CiAKLSAgICBGcmFtZSogY29u dGFpbmluZ0ZyYW1lID0gZWxlbWVudC0+ZG9jdW1lbnQoKS5mcmFtZSgpOwogICAgIEZyYW1lVmll dyogY29udGFpbmluZ1ZpZXcgPSBjb250YWluaW5nRnJhbWUtPnZpZXcoKTsKICAgICBGcmFtZVZp ZXcqIG1haW5WaWV3ID0gY29udGFpbmluZ0ZyYW1lLT5wYWdlKCktPm1haW5GcmFtZSgpLnZpZXco KTsKIAorICAgIGNvbnN0IENvbG9yIHNoYXBlSGlnaGxpZ2h0Q29sb3IoOTYsIDgyLCAxMjcsIDIw NCk7CisKICAgICBTaGFwZTo6RGlzcGxheVBhdGhzIHBhdGhzOwogICAgIHNoYXBlT3V0c2lkZUlu Zm8tPmNvbXB1dGVkU2hhcGUoKS5idWlsZERpc3BsYXlQYXRocyhwYXRocyk7CiAKQEAgLTg0Myw3 ICs4NDIsNyBAQCB2b2lkIEluc3BlY3Rvck92ZXJsYXk6OmRyYXdFbGVtZW50VGl0bGUoR3JhcGhp Y3NDb250ZXh0JiBjb250ZXh0LCBOb2RlJiBub2RlLCBjbwogICAgIGlmICghZWxlbWVudCkKICAg ICAgICAgcmV0dXJuOwogCi0gICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IGVsZW1lbnQtPnJl bmRlcmVyKCk7CisgICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IG5vZGUucmVuZGVyZXIoKTsK ICAgICBpZiAoIXJlbmRlcmVyKQogICAgICAgICByZXR1cm47CiAKQEAgLTg3MSw5ICs4NzAsOSBA QCB2b2lkIEluc3BlY3Rvck92ZXJsYXk6OmRyYXdFbGVtZW50VGl0bGUoR3JhcGhpY3NDb250ZXh0 JiBjb250ZXh0LCBOb2RlJiBub2RlLCBjbwogICAgIH0KIAogICAgIFN0cmluZyBlbGVtZW50UHNl dWRvVHlwZTsKLSAgICBpZiAoZWxlbWVudC0+aXNCZWZvcmVQc2V1ZG9FbGVtZW50KCkpCisgICAg aWYgKG5vZGUuaXNCZWZvcmVQc2V1ZG9FbGVtZW50KCkpCiAgICAgICAgIGVsZW1lbnRQc2V1ZG9U eXBlID0gIjo6YmVmb3JlIl9zOwotICAgIGVsc2UgaWYgKGVsZW1lbnQtPmlzQWZ0ZXJQc2V1ZG9F bGVtZW50KCkpCisgICAgZWxzZSBpZiAobm9kZS5pc0FmdGVyUHNldWRvRWxlbWVudCgpKQogICAg ICAgICBlbGVtZW50UHNldWRvVHlwZSA9ICI6OmFmdGVyIl9zOwogCiAgICAgU3RyaW5nIGVsZW1l bnRXaWR0aDsKQEAgLTg4Myw3ICs4ODIsNyBAQCB2b2lkIEluc3BlY3Rvck92ZXJsYXk6OmRyYXdF bGVtZW50VGl0bGUoR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBOb2RlJiBub2RlLCBjbwogICAg ICAgICBlbGVtZW50V2lkdGggPSBTdHJpbmc6Om51bWJlcihhZGp1c3RGb3JBYnNvbHV0ZVpvb20o cm91bmRUb0ludChtb2RlbE9iamVjdC0+b2Zmc2V0V2lkdGgoKSksICptb2RlbE9iamVjdCkpOwog ICAgICAgICBlbGVtZW50SGVpZ2h0ID0gU3RyaW5nOjpudW1iZXIoYWRqdXN0Rm9yQWJzb2x1dGVa b29tKHJvdW5kVG9JbnQobW9kZWxPYmplY3QtPm9mZnNldEhlaWdodCgpKSwgKm1vZGVsT2JqZWN0 KSk7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgRnJhbWVWaWV3KiBjb250YWluaW5nVmlldyA9IGVs ZW1lbnQtPmRvY3VtZW50KCkuZnJhbWUoKS0+dmlldygpOworICAgICAgICBGcmFtZVZpZXcqIGNv bnRhaW5pbmdWaWV3ID0gbm9kZS5kb2N1bWVudCgpLmZyYW1lKCktPnZpZXcoKTsKICAgICAgICAg SW50UmVjdCBib3VuZGluZ0JveCA9IHNuYXBwZWRJbnRSZWN0KGNvbnRhaW5pbmdWaWV3LT5jb250 ZW50c1RvUm9vdFZpZXcocmVuZGVyZXItPmFic29sdXRlQm91bmRpbmdCb3hSZWN0KCkpKTsKICAg ICAgICAgZWxlbWVudFdpZHRoID0gU3RyaW5nOjpudW1iZXIoYm91bmRpbmdCb3gud2lkdGgoKSk7 CiAgICAgICAgIGVsZW1lbnRIZWlnaHQgPSBTdHJpbmc6Om51bWJlcihib3VuZGluZ0JveC5oZWln aHQoKSk7CkBAIC04OTQsOCArODkzLDggQEAgdm9pZCBJbnNwZWN0b3JPdmVybGF5OjpkcmF3RWxl bWVudFRpdGxlKEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgTm9kZSYgbm9kZSwgY28KICAgICAg ICAgV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6ZW5hYmxlQWNjZXNzaWJpbGl0eSgpOwogCiAgICAg U3RyaW5nIGVsZW1lbnRSb2xlOwotICAgIGlmIChBWE9iamVjdENhY2hlKiBheE9iamVjdENhY2hl ID0gZWxlbWVudC0+ZG9jdW1lbnQoKS5heE9iamVjdENhY2hlKCkpIHsKLSAgICAgICAgaWYgKEFj Y2Vzc2liaWxpdHlPYmplY3QqIGF4T2JqZWN0ID0gYXhPYmplY3RDYWNoZS0+Z2V0T3JDcmVhdGUo ZWxlbWVudCkpCisgICAgaWYgKEFYT2JqZWN0Q2FjaGUqIGF4T2JqZWN0Q2FjaGUgPSBub2RlLmRv Y3VtZW50KCkuYXhPYmplY3RDYWNoZSgpKSB7CisgICAgICAgIGlmIChBY2Nlc3NpYmlsaXR5T2Jq ZWN0KiBheE9iamVjdCA9IGF4T2JqZWN0Q2FjaGUtPmdldE9yQ3JlYXRlKCZub2RlKSkKICAgICAg ICAgICAgIGVsZW1lbnRSb2xlID0gYXhPYmplY3QtPmNvbXB1dGVkUm9sZVN0cmluZygpOwogICAg IH0KIAo=